issue commentargoproj/argo-workflows

Sprig can return default values and no error if no evaluation is possible

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

simster7

comment created time in an hour

issue commentargoproj/argo-workflows

Argo dag failFast option not working Argo version: 2.12.3

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

swathi59

comment created time in an hour

issue commentargoproj/argo-workflows

Linter failing on TemplateRef for WorkflowTemplate

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bmaggi

comment created time in an hour

issue commentargoproj/argo-cd

Unable to use helm CLI against helm releases that have been deployed by ArgoCD

+1

bdelagesap

comment created time in 3 hours

pull request commentargoproj/argo-workflows

fix: Set empty start time for nodes in retrying workflows as they have not started yet

Codecov Report

Merging #5927 (428232e) into master (304ab52) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5927      +/-   ##
==========================================
- Coverage   47.39%   47.36%   -0.04%     
==========================================
  Files         247      247              
  Lines       15596    15596              
==========================================
- Hits         7392     7387       -5     
- Misses       7272     7276       +4     
- Partials      932      933       +1

Impacted Files	Coverage Δ
workflow/util/util.go	`44.12% <100.00%> (ø)`
cmd/argo/commands/get.go	`56.63% <0.00%> (-1.30%)`	:arrow_down:
workflow/controller/operator.go	`70.26% <0.00%> (-0.28%)`	:arrow_down:
cmd/argoexec/commands/emissary.go	`50.00% <0.00%> (+1.56%)`	:arrow_up:
workflow/metrics/server.go	`16.66% <0.00%> (+4.16%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 304ab52...428232e. Read the comment docs.

terrytangyuan

comment created time in 3 hours

PR opened argoproj/argo-workflows

fix: Set empty start time for nodes in retrying workflows as they have not started yet

This was overlooked in https://github.com/argoproj/argo-workflows/pull/5801. The start time should be empty instead of current time since the nodes have not started yet. Otherwise it's problematic for all nodes to start at the same time.

Signed-off-by: terrytangyuan [email protected]

Checklist:

[x] My organization is added to USERS.md.

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

+4 -4

1 commit in terrytangyuan/argo/tree/fix-node-time argoproj/argo-workflows/tree/master

0 comment

2 changed files

pr created time in 3 hours

Pull request review commentargoproj/argo-workflows

feat: add disableSubmodules for git artifacts

 func (g *ArtifactDriver) Load(inputArtifact *wfv1.Artifact, path string) error { 		return err 	} 	defer closer()++	var recurseSubmodules = git.DefaultSubmoduleRecursionDepth+	if inputArtifact.Git.DisableSubmodules {+		log.Info("Setting recurse submodules to NoRecurseSubmodules")

Perhaps more meaningful/readable log here, e.g. "Recursive cloning of submodules is disabled".

zachaller

comment created time in 4 hours

PR opened argoproj-labs/applicationset

fix: handle conversion to string in git generator

Use fmt.Sprintf instead of type assertion for converting the incoming parameter to string.

Fixes: #192

Signed-off-by: Chetan Banavikalmutt [email protected]

+4 -2

1 commit in chetan-rns/applicationset/tree/fix-string-conversion argoproj-labs/applicationset/tree/master

0 comment

2 changed files

pr created time in 6 hours

issue commentargoproj/argo-cd

App stuck in loop while deleting endpoints / services

This is still not resolved.

Paragon1970

comment created time in 6 hours

Pull request review commentistio-ecosystem/admiral

Admiral apis

 func (opts *RouteOpts) ReturnSuccessGET(w http.ResponseWriter, r *http.Request)  func (opts *RouteOpts) GetClusters(w http.ResponseWriter, r *http.Request) { +	clusterList := []string{}++	// loop through secret controller's c.cs.remoteClusters to access all clusters admiral is watching+	for clusterID := range opts.RemoteRegistry.SecretController.Cs.RemoteClusters {+		clusterList = append(clusterList, clusterID)+	}++	out, err := json.Marshal(clusterList)+	if err != nil {+		log.Printf("Failed to marshall response for GetClusters call")+		http.Error(w, "Failed to marshall response", http.StatusInternalServerError)+	} else {+		if len(clusterList) == 0 {+			message := "No cluster is monitored by admiral"+			log.Printf(message)+			w.WriteHeader(200)+			out, _ = json.Marshal(message)+			w.Write(out)+		} else {+			w.Header().Set("Content-Type", "application/json")+			w.WriteHeader(200)+			w.Write(out)+		}+	}+}++func (opts *RouteOpts) GetServiceEntriesByCluster(w http.ResponseWriter, r *http.Request) {+	defer r.Body.Close()++	params := mux.Vars(r)+	clusterName := strings.Trim(params["clustername"], " ")++	var response []v1alpha3.ServiceEntry++	if clusterName != "" {++		serviceEntriesByCluster, err := clusters.GetServiceEntriesByCluster(clusterName, opts.RemoteRegistry)++		if err != nil {+			log.Printf(err.Error())+			if strings.Contains(err.Error(), "Admiral is not monitoring cluster") {+				http.Error(w, err.Error(), http.StatusNotFound)+			} else {+				http.Error(w, err.Error(), http.StatusInternalServerError)+			}+		} else {+			if len(serviceEntriesByCluster) == 0 {+				log.Printf(fmt.Sprintf("No service entries configured for cluster - %s", clusterName))

Print some request context

vrushalijoshi

comment created time in 7 hours

Pull request review commentistio-ecosystem/admiral

Admiral apis

 func (opts *RouteOpts) ReturnSuccessGET(w http.ResponseWriter, r *http.Request)  func (opts *RouteOpts) GetClusters(w http.ResponseWriter, r *http.Request) { +	clusterList := []string{}++	// loop through secret controller's c.cs.remoteClusters to access all clusters admiral is watching+	for clusterID := range opts.RemoteRegistry.SecretController.Cs.RemoteClusters {+		clusterList = append(clusterList, clusterID)+	}++	out, err := json.Marshal(clusterList)+	if err != nil {+		log.Printf("Failed to marshall response for GetClusters call")+		http.Error(w, "Failed to marshall response", http.StatusInternalServerError)+	} else {+		if len(clusterList) == 0 {+			message := "No cluster is monitored by admiral"+			log.Printf(message)+			w.WriteHeader(200)+			out, _ = json.Marshal(message)+			w.Write(out)+		} else {+			w.Header().Set("Content-Type", "application/json")+			w.WriteHeader(200)+			w.Write(out)+		}+	}+}++func (opts *RouteOpts) GetServiceEntriesByCluster(w http.ResponseWriter, r *http.Request) {+	defer r.Body.Close()++	params := mux.Vars(r)+	clusterName := strings.Trim(params["clustername"], " ")++	var response []v1alpha3.ServiceEntry++	if clusterName != "" {++		serviceEntriesByCluster, err := clusters.GetServiceEntriesByCluster(clusterName, opts.RemoteRegistry)++		if err != nil {+			log.Printf(err.Error())

Print some request context, would be hard to understand what this error is for

vrushalijoshi

comment created time in 7 hours

pull request commentargoproj/argo-workflows

ci: Update changelog.yaml

Codecov Report

Merging #5926 (cb9e6be) into master (304ab52) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head cb9e6be differs from pull request most recent head 6a91450. Consider uploading reports for the commit 6a91450 to get more accurate results

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
- Coverage   47.39%   47.38%   -0.02%     
==========================================
  Files         247      247              
  Lines       15596    15596              
==========================================
- Hits         7392     7390       -2     
- Misses       7272     7275       +3     
+ Partials      932      931       -1

Impacted Files	Coverage Δ
cmd/argo/commands/get.go	`57.28% <0.00%> (-0.65%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 304ab52...6a91450. Read the comment docs.

alexec

comment created time in 7 hours

pull request commentargoproj/argo-workflows

fix(installation): Enable capacity to override namespace with Kustomize

Codecov Report

Merging #5907 (67d2549) into master (d009e6b) will decrease coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5907      +/-   ##
==========================================
- Coverage   47.39%   47.34%   -0.06%     
==========================================
  Files         247      247              
  Lines       15596    15596              
==========================================
- Hits         7392     7384       -8     
- Misses       7272     7284      +12     
+ Partials      932      928       -4

Impacted Files	Coverage Δ
server/workflow/workflow_server.go	`40.45% <0.00%> (-2.28%)`	:arrow_down:
cmd/argo/commands/get.go	`57.28% <0.00%> (-0.65%)`	:arrow_down:
workflow/metrics/server.go	`16.66% <0.00%> (+4.16%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d009e6b...67d2549. Read the comment docs.

Daverkex

comment created time in 7 hours

push eventargoproj/argo-workflows

Alex Collins

commit sha 6a914500c29e42810a4863f66939400f07ada45a

ci: update

view details

push time in 7 hours

PR opened argoproj/argo-workflows

Ci: Update changelog.yaml

Checklist:

[ ] My organization is added to USERS.md.

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

+1 -2

1 commit in argoproj/argo-workflows/tree/alexec-patch-1 argoproj/argo-workflows/tree/master

0 comment

1 changed file

pr created time in 7 hours

create barnchargoproj/argo-workflows

branch : alexec-patch-1

created branch time in 7 hours

pull request commentargoproj/argo-cd

docs: Remove duplicated IBM GitOps blog and update official URL (#6245)

Codecov Report

Merging #6246 (0bef335) into master (a1419c2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6246   +/-   ##
=======================================
  Coverage   41.21%   41.21%           
=======================================
  Files         147      147           
  Lines       19862    19862           
=======================================
  Hits         8186     8186           
  Misses      10556    10556           
  Partials     1120     1120

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1419c2...0bef335. Read the comment docs.

lbscorpio

comment created time in 8 hours

push eventargoproj/argo-cd

jannfis

commit sha 91bda954f80fabd7235fcb65786540fc48ccee40

Automated deployment: Sat May 15 15:28:08 UTC 2021 5aa29ce405b0f3fcf0f3415ad23c32abbdd21536

view details

push time in 8 hours

push eventargoproj/argo-cd

Yujun Zhang

commit sha 5aa29ce405b0f3fcf0f3415ad23c32abbdd21536

chore: fix typo in comment (#6224) Signed-off-by: Yujun Zhang <[email protected]>

view details

push time in 8 hours

PR merged argoproj/argo-cd

chore: fix typo in comment

+1 -1

1 commit in yujunz/argo-cd/tree/fix-typo argoproj/argo-cd/tree/master

1 comment

1 changed file

yujunz

pr closed time in 8 hours

pull request commentargoproj/argo-cd

fix: copy github app key from repocreds

This commit has been cherry-picked into 2.0 release branch.

/cc @alexmt

backjo

comment created time in 8 hours

pull request commentargoproj/argo-cd

fix: copy github app key from repocreds

This commit has been cherry-picked into 2.0 release branch.

/cc @alexmt

joebowbeer

comment created time in 8 hours

push eventargoproj/argo-cd

Jonah Back

commit sha 1c698f7113254bf40a86799ef8e82eceb53d8e45

fix: copy github app key from repocreds (#6140) Signed-off-by: Jonah Back <[email protected]>

view details

Joe Bowbeer

commit sha beb93704506fe6b63a56b17ab087cf9ec1d398fd

fix: copy github app key from repocreds (#6197) * fix: copy github app key from repocreds Fixes #6196 Signed-off-by: Joe Bowbeer <[email protected]> * Add GitHub App to unit test Signed-off-by: Joe Bowbeer <[email protected]>

view details

push time in 8 hours

PR opened argoproj/argo-cd

feat(api+cli): Add new flag to diff command to diff live app against application manifest (#4706)

This PR adds an action in the API to generate the resource manifests for a given application manifest. It also adds a flag to the diff command so live app can be compared to application manifest without changing state of the cluster.

Closes #4706 Probably helps for #6167

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
[x] The title of the PR states what changed and the related issues number (used for the release note).
[x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
[x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
[x] Does this PR require documentation updates?
[x] I've updated documentation as required by this PR.
[ ] Optional. My organization is added to USERS.md.
[x] I have signed off all my commits as required by DCO
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My build is green (troubleshooting builds).

+526 -223

2 commit in Okhoshi/argo-cd/tree/feat/diff-from-app-manifest argoproj/argo-cd/tree/master

0 comment

8 changed files

pr created time in 9 hours

PullRequestEvent

PR closed argoproj/argo-workflows

fix(installation): Enable capacity to override namespace with Kustomize

Checklist:

[x] My organization is added to USERS.md.* *This is a personal PR

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

Fix: #4345 Continue: #4807, #4919

References:

https://github.com/kubernetes-sigs/kustomize/issues/2717
https://github.com/kubernetes-sigs/kustomize/issues/136
https://github.com/kubernetes-sigs/kustomize/issues/1377

+3 -2

1 commit in Daverkex/argo-workflows/tree/override-namespace argoproj/argo-workflows/tree/master

0 comment

3 changed files

Daverkex

pr closed time in 9 hours

issue commentargoproj/argo-workflows

SSO "authorization" cookie seems to be set incorrectly, causing a "token not valid for running mode" error

I was able to upgrade to v3.1.0-rc3 and test this, unfortunately I still experienced the same issue even after opening it in a private browser.

Himself12794

comment created time in 11 hours

pull request commentargoproj/argo-workflows

Update releases.md

oh, cool :)

jerguslejko

comment created time in 13 hours

issue commentargoproj/argo-cd

README.md have a duplicate blog entry

I have raised PR 6246 for this issue, fyi, thanks.

lbscorpio

comment created time in 17 hours

PR opened argoproj/argo-cd

docs: Remove duplicated IBM GitOps blog and update official URL (#6245)

Signed-off-by: Bo Liu [email protected]

Closes #6245

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
[x] The title of the PR states what changed and the related issues number (used for the release note).
[x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
[ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
[x] Does this PR require documentation updates?
[x] I've updated documentation as required by this PR.
[x] Optional. My organization is added to USERS.md.
[x] I have signed off all my commits as required by DCO
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My build is green (troubleshooting builds).

+1 -2

1 commit in lbscorpio/argo-cd/tree/readme-blog-url argoproj/argo-cd/tree/master

0 comment

1 changed file

pr created time in 17 hours