profile
viewpoint
Ryan Uber ryanuber HashiCorp Oceanside, CA http://www.ryanuber.com/ Software at HashiCorp

armon/go-metrics 949

A Golang library for exporting performance and runtime metrics to external metrics systems (i.e. statsite, statsd)

armon/go-proxyproto 180

Golang package to handle HAProxy Proxy Protocol

armon/relay 124

Golang framework for simple message passing using an AMQP broker

ryanuber/columnize 122

Easy column formatted output for golang

ryanuber/go-glob 99

Basic string globs in golang

ryanuber/go-license 71

Software licensing standardization library for Golang

ryanuber/go-otp 12

Simple one-time pad crypto library for golang

evanphx/wal 9

A WAL primitive for Golang

ryanuber/go-filecache 6

Cache data in flat files in Golang

ryanuber/go-semver 5

Semantic versioning (semver.org) for golang

pull request commenthashicorp/go-retryablehttp

Added LeveledFormatLogger (Printf-like logger)

w.r.t logrus we did that to turn it into a LeveledLogger https://play.golang.org/p/yQ1io2eYJWK

many libraries have logr compatible interface, which would be yet another interface.

juanfresia

comment created time in 2 days

startedexcalidraw/excalidraw

started time in 2 days

startedoam-dev/kubevela

started time in 3 days

startedemptymonkey/shelljack

started time in 5 days

startedgaffe23/linux-inject

started time in 5 days

startedstrace/strace

started time in 5 days

startedchaos-mesh/bpfki

started time in 5 days

startedproot-me/proot

started time in 5 days

startedpingcap/failpoint

started time in 6 days

startedtrailofbits/krf

started time in 6 days

issue openedhashicorp/go-retryablehttp

`attemptNum` as part of `CheckRetry`

type CheckRetry func(ctx context.Context, resp *http.Response, attemptNum int, err error) (bool, error)

Came across a use case where this would've been a great help and was wondering if this was something discussed previously?

created time in 7 days

startedryanuber/ruby-aptly

started time in 7 days

startedtnarg/rules_cue

started time in 7 days

startedryanuber/columnize

started time in 8 days

startedrecharts/recharts

started time in 8 days

startedtidwall/ticketd

started time in 9 days

startedtidwall/sipp

started time in 9 days

startedtidwall/sipp

started time in 9 days

startedtidwall/websocket

started time in 9 days

startedtidwall/rhh

started time in 9 days

startedtidwall/wal

started time in 9 days

startedHaivision/srt

started time in 9 days

startedgoogle/bbr

started time in 9 days

startedmicrosoft/restler-fuzzer

started time in 11 days

startedryanuber/columnize

started time in 11 days

delete branch hashicorp/go-hclog

delete branch : dnephin/remove-extra-interface

delete time in 13 days

push eventhashicorp/go-hclog

Daniel Nephin

commit sha fda4b465cf5345cfb57d6bfd147262bb7402823e

testing for a bug with json formatter and caller location

view details

Daniel Nephin

commit sha 04b3a66eb7d121725bcaede3a14ccf3caa447dd3

Reduce implementation of interceptLogger Also fixes a bug where using json formatting with IncludeLocation and InterceptLogger or Sinks would report the wrong location.

view details

Daniel Nephin

commit sha a1090d183dc7250603bbeb26cdf2f4747fd40171

Test IncludeLocation with FromStandardLogger

view details

Daniel Nephin

commit sha 59fbd7b932707c4095dd978f0d545e0c6538ef80

Merge pull request #77 from hashicorp/dnephin/remove-extra-interface Reduce intercept logger and fix a bug with json format and caller location

view details

push time in 13 days

PR merged hashicorp/go-hclog

Reviewers
Reduce intercept logger and fix a bug with json format and caller location

Builds on #76

This PR reduces the implementation of all the Logger methods in interceptLogger to call a single helper method.

It also makes two improvements to the IncludeLocation option:

  1. remove the need to call runtime.Caller twice. This call is relatively expensive, and we were calling it twice for every log line. Instead of guessing at the offset we pass the offset along. The logger itself knows what offset to use.
  2. fix a bug when IncludeLocation was used with JSONFormat and InterceptLogger. We were also using a fixed offset of 4, but that would be wrong when called from an InterceptLogger or an intLogger used as a sink.
+79 -87

0 comment

5 changed files

dnephin

pr closed time in 13 days

issue commenthashicorp/go-hclog

File name and location is always "go-hclog@v0.15.0/stdlog.go:45"

Ah, I missed this was about StandardLogger/StandardWriter, not FromStandardLogger. That should be easy to address in #77

vsekhar

comment created time in 13 days

more