profile
viewpoint
Ryan Florence ryanflorence React Training Seattle, WA http://reacttraining.com @ReactTraining, React Router, @Reach. Whole crew is on tour in November, join us!

jaredpalmer/after.js 3715

Next.js-like framework for server-rendered React apps built with React Router 4

mjackson/expect 2311

Write better assertions

reactions/component 1063

Declarative version of React.Component

ryanflorence/async-props 562

Co-located data loading for React Router

locks/ember-localstorage-adapter 476

Name says it all.

adamziel/react-router-named-routes 98

Painless support for named routes for ReactRouter 1.0, 2.0, 3.0, 4.0, and 5.0

knowbody/react-router-docs 56

Rewrite of the React Router docs - work in progress

mjackson/unpkg-demos 51

Experiments in how to use unpkg

push eventreach/reach.tech

Ryan Florence

commit sha bb45f7cd1b4f13ec7dca6c0147dc967ab517aa1e

temporarily add router website until we really fix it

view details

push time in 20 hours

issue commentReactTraining/react-router

goodbye react-router

@gromov-io

Show solidarity to your community, disable documentation for 1 day because of the dead children in Syria and Ukraine

These sound like great ideas. Perhaps we'll do this quarterly.

gromov-io

comment created time in a month

issue commentVSCodeVim/Vim

When using vim extension, cursor navigation with keyboard doesn't trigger matching symbol highlights

The auto highlighting really messes with me, so I set "editor.occurrencesHighlight": false.

If I do Shift + 8 I can jump around to to each occurrence but they aren't highlighted. If I double click the things it still highlights.

Is this related? How do I get it to highlight on shift + 8 the same as double clicking?

rebornix

comment created time in a month

CommitCommentEvent

pull request commentreach/router

Fixes useNavigate inequality with props.navigate

Awesome work!

Looking at the code a bit all we need to do is get this somewhere:

https://github.com/reach/router/blob/master/src/index.js#L219

We already have the BaseContext, so instead of creating an all new context just for Navigate, we can just toss the nesting-aware navigate from line 219 at the <BaseContext.Provider> here:

https://github.com/reach/router/blob/master/src/index.js#L242

And then use the BaseContext in useNavigate instead of LocationContext.

Should significantly reduce lines changed. What do you think?

sudkumar

comment created time in 2 months

PR opened ReactTraining/history

allow numeric paths

This is useful since many APIs return numeric IDs and history.pushState(null, null, 123) works just fine.

// instead of
<Link to={String(record.id)}>{record.name}</Link>

// you can now
<Link to={record.id}>{record.name}</Link>
+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchReactTraining/history

branch : support-numeric-paths

created branch time in 2 months

issue openedbalajmarius/svg2jsx

Don't change filter ids, or any values

Hey! Was really looking forward to using this tool since I've got a huge SVG that I'm making interactive, but it didn't work for me because the attribute values get changed.

What's the reasoning behind changing the values of attributes? I have mine all named because I swap around different effects. Having <use filter="url(#big-shadow)" /> get changed to <url filter="url(#j)" /> is annoying ot have to go put back, far worse than editing the JSX attribute names myself.

Why change any of the values at all? I expected the entire scope of this tool to change all html svg attributes to the JSX versions, I don't expect it to mess with the actual values of those attributes.

created time in 3 months

startedbikeshaving/crank

started time in 3 months

startedLanceGin/GraphQL-Server-Demo

started time in 3 months

push eventReactTraining/react-router

Ryan Florence

commit sha 5d11e0f6def9e88e6bb8671f0645c0140bce6a3c

added @reach/router migration guide

view details

push time in 3 months

more