profile
viewpoint
Bob rralian Automattic Austin, TX Just a man with a man's courage.

Automattic/interpolate-components 13

A module to turn strings into structured React components without dangerouslySetInnerHTML().

rralian/StartupTemplate 6

Template for html5 projects on google app engine using webapp framework

rralian/bootstrap-sass 1

bootstrap-sass is bootstrap for Sass, ready to roll

rralian/http-server 1

a simple zero-configuration command-line http server

rralian/javascript-algorithms 1

Collection of algorithms in javascript to solve arbitrary, unlikely problems.

rralian/yepnope.js 1

A Feature-Test Based Loader For Your Polyfills!

rralian/aquaweb 0

Control Jandy Aqualink via a web interface

rralian/calypso-walkthrough 0

A where-we-are for calypso

rralian/ievms 0

Automated installation of the Microsoft IE App Compat virtual machines

Pull request review commentAutomattic/wp-calypso

Manage Purchase: Add notice to inform about available products for renewal

 export const getByPurchaseId = ( state, purchaseId ) => export const getSitePurchases = ( state, siteId ) => 	getPurchases( state ).filter( ( purchase ) => purchase.siteId === siteId ); +/**+ * Returns a list of Purchases associated with a Site that may be expiring soon+ * or have expired recently but is still renewable.+ *+ * @param {object} state      global state+ * @param {number} siteId     the site id+ * @returns {Array} the matching expiring purchases if there are some+ */+export const getRenewableSitePurchases = ( state, siteId ) =>+	getSitePurchases( state, siteId ).filter(+		( purchase ) =>+			( isExpiring( purchase ) || isExpired( purchase ) ) &&+			canExplicitRenew( purchase ) &&+			moment( purchase.expiryDate ).diff( Date.now(), 'days' ) < 90

Curious what others think, but my gut reaction is yes. That it's better to take the renewals together in a single transaction while the user is here, both for us and the user. We just want to avoid giving the user a false impression. Maybe if it's still active it says "renews in 3 days" instead of "expires in 3 days"?

dylanrevisited

comment created time in 2 months

more