profile
viewpoint
Anup reznord OLX Group Mumbai, India Software Developer

preactjs/preact 27403

⚛️ Fast 3kB React alternative with the same modern API. Components & Virtual DOM.

ForsakenHarmony/parket 429

A library to manage application state, heavily inspired by mobx-state-tree

preactjs/preact-www 263

:book: Preact documentation website.

franfaccin/iscte-go 1

A Pokemon Go based game done in React.

reznord/Algorithms 0

Implementations of various sorting algorithms.

reznord/babel 0

🐠 Babel is a compiler for writing next generation JavaScript.

reznord/babel-esm-plugin 0

Add this plugin to generate mirrored esm modules for your existing bundles

reznord/babel-macros 0

🎣 Enables zero-config, importable babel plugins

PullRequestReviewEvent

PR opened workerb-io/docs

Remove yarn.lock file
+0 -10740

0 comment

1 changed file

pr created time in 6 days

create barnchworkerb-io/docs

branch : remove-lock-file

created branch time in 6 days

startediamdustan/smoothscroll

started time in a month

PullRequestReviewEvent

push eventpreactjs/preact-cli

Jovi De Croock

commit sha 9e49926a31a8c595793af0e26cd962a2de1963a2

fix changesets (#1415)

view details

push time in a month

delete branch preactjs/preact-cli

delete branch : fix-changesets

delete time in a month

PR merged preactjs/preact-cli

Fix changesets

We were missing a package

+32 -36

1 comment

4 changed files

JoviDeCroock

pr closed time in a month

PullRequestReviewEvent

delete branch preactjs/preact-cli

delete branch : JoviDeCroock-patch-2

delete time in a month

push eventpreactjs/preact-cli

Jovi De Croock

commit sha e970a1d385a60a12d3dc9d24be022b03c153bace

Add missing changeset for prefresh patch (#1414) * Create famous-cars-vanish.md * Update famous-cars-vanish.md

view details

push time in a month

PR merged preactjs/preact-cli

Add missing changeset for prefresh patch

Add missing changeset

+5 -0

1 comment

1 changed file

JoviDeCroock

pr closed time in a month

PullRequestReviewEvent

push eventpreactjs/preact-cli

Ivan Tanev

commit sha 5d7a37f059f227ab6b7b3f2066e53c44317b9704

Fix mangled output by size-plugin when ssr is enabled (#1407)

view details

Anup

commit sha 469ce7807eb061a294e146d034db86b5604aaee9

Merge branch 'master' into JoviDeCroock-patch-1

view details

push time in a month

PullRequestReviewEvent

push eventpreactjs/preact-cli

Ivan Tanev

commit sha 5d7a37f059f227ab6b7b3f2066e53c44317b9704

Fix mangled output by size-plugin when ssr is enabled (#1407)

view details

push time in a month

PR merged preactjs/preact-cli

Fix mangled size-plugin output when SSR is enabled

What kind of change does this PR introduce? bugfix

Did you add tests for your changes? No

Summary

Currently, running npm run build on a fresh preact-cli project produces a mangled output for size-plugin, because it writes both the output of the SSR build and the client build to the same output file.

As a result, the output is completely unusable:

image

This fix introduces a separate size-plugin-ssr.json output for the SSR build. After that, we get proper tracking of the size changes for the SSR and client builds:

image

Does this PR introduce a breaking change?

The addition of a second output file for size-plugin should not be a breaking change.

Other information

➜  preact-test4 git:(master) ✗ preact info

Environment Info:
  System:
    OS: Linux 4.15 Ubuntu 16.04.7 LTS (Xenial Xerus)
    CPU: (16) x64 Intel(R) Core(TM) i9-9900KS CPU @ 4.00GHz
  Binaries:
    Node: 14.8.0 - ~/.nvm/versions/node/v14.8.0/bin/node
    Yarn: 1.21.1 - /usr/bin/yarn
    npm: 6.14.7 - ~/.nvm/versions/node/v14.8.0/bin/npm
  Browsers:
    Chrome: 85.0.4183.83
    Firefox: 80.0.1
  npmPackages:
    preact: ^10.1.0 => 10.4.8 
    preact-cli: ^3.0.0 => 3.0.1 
    preact-render-to-string: ^5.1.2 => 5.1.10 

+6 -2

4 comments

3 changed files

VanTanev

pr closed time in a month

pull request commentpreactjs/preact-cli

Fix mangled size-plugin output when SSR is enabled

It is fine, if we track the SSR bundle size as well :)

VanTanev

comment created time in a month

PullRequestReviewEvent

startedlukejacksonn/oceanwind

started time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
more