Hi @Idrimi, I don't think we've been introduced. Would you be able to join the Capacitor Contributors slack? I'd like to add you to our channel if that's alright.

I also have a few questions (we can chat in Slack):

• What's the purpose this repo? https://github.com/capacitor-community/capacitor-contacts-plugin
• Any plans for updating this plugin for Capacitor 3 (now in beta)?

No need to bump the version--the plugin maintainer(s) will do this as necessary.

@mrbatista Apologies for the lack of response on your PR. Would you be able to join the Capacitor Contributors slack?

https://github.com/capacitor-community/bluetooth-le/blob/d1c1c99e8edd8e35dc867af7ec316248836974c5/src/definitions.ts#L166

I think it's easier if you upgrade to the community version of fcm

capacitor-fcm is deprecated. to be able to use it you would have to downgrade capacitor

I updated capacitor to the latest version (2.4.6) from 1.1.1 for @capacitor/ios only. I left the rest at 1.1.1. In order to resolve some swift compiler errors in the latest Xcode.

I have released the app to the store and FCM to iOS devices does not seem to be working. It says in the FCM dashboard that 22 have been sent to iOS (should be around 1000) and none of my iOS devices have received them. It still works fine for Android.

I am using the package capacitor-fcm v0.0.7.

I know this has now been replaced with @capacitor-community/fcm as I have used that in another project. https://www.npmjs.com/package/@capacitor-community/fcm

Do I have to downgrade Capacitor or upgrade to the new fcm package or should capacitor-fcm still work with capacitor 2.4.6?

@rdlabo can you please revert that commit until a solution is found. If what is reported is true, the npm release is broken.

Describe the bug All the photos I take with my device (iPhone 8 iOS 13) end up as 1920x1080 images even though the device has a 12Mpx lens hence can produce photos up to 4032x3024.

To Reproduce Simply set capture options as follow : CameraPreviewPictureOptions = { quality: 100 } I've tried also to pass height and width parameters but they don't seem to be taken into account as the result is always the same.

Expected behavior I'm expecting to get the best photo my device can take, especially when setting quality to the max value.

Smartphone (please complete the following information):

• Device: iPhone 8
• OS: iOS 13.6

I have the same issue... disabled the splashscreen but no results, need to drag the window around to show the content. By the way, it only happens on windows.

Describe the bug We are having a big problem with this encoding here:

This is a request made from our application to the backend: getting a bug.

Every time we sent text with Turkish character from the application we get this bug; looking on how fixing this we meet this pull request which seems to solve the bug, but this pull request is not yet in the last plugin's version.

To Reproduce Steps to reproduce the behavior:

1. Create an object with some non ascii character to be the request body.
2. Send the request to the backend through the api.
3. Get the response from the server on the console log.

Expected behavior A true response from the backend.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: Lenovo Tab M10 (FHD)
• OS: Android 9
• Browser [e.g. stock browser, safari]
• Version 0.2.1

Additional context There is a possible solution already in this plugin's base code, but it is not in the last version.

This is already fixed on master in #41 so I'm closing this. A new npm version will be out later this week if everything goes well!

Describe the bug

The http headers are not send when set on web implementation

To Reproduce

This is just one example from one of my applications

    const result = await (Http as HttpPlugin).request({
      method: 'GET',
      url,
      // handle cors issues
      headers: {
        origin: 'x-requested-with',
      },
      params: {
        package: encodeURI(decodeURI(packageName)).replace('%252F', '%2F'),
        until: format(new Date(), 'YYYY-MM-DD'),
        from: fromDate,
      },
    });

Expected behavior

The we implementation of the plugin should set http headers and url params.

Closing this since the fix has already been merged to master. I'm preparing a 0.3.0 release for later this week on npm but if you need the fix now you can clone the repo and build the project with the following command. It builds a /dist folder

npm install
npm run build

It could indeed be useful 😄 I'll take a look at it!

Describe the bug Hello, I think there's a bug with the returned headers values on Android, there's a comma and a space added at the end of every values. This can be problematic when retrieving a token from the response header. I haven't tested on iOS so I don't know if it's a bug specific to Android.

Response headers in browser/Electron :

{
	content-length: "581"
	content-type: "text/html; charset=ISO-8859-1"
	date: "Tue, 27 Oct 2020 15:03:01 GMT"
	server: "Transmission"
	x-transmission-session-id: "xxxxxxxxxx"
}

Response headers in Android app :

[
	{},
	{"Content-Length":"581, "},
	{"Content-Type":"text/html; charset=ISO-8859-1, "},
	{"Date":"Tue, 27 Oct 2020 15:08:20 GMT, "},
	{"Server":"Transmission, "},
	{"X-Android-Received-Millis":"1603811299594, "},
	{"X-Android-Response-Source":"NETWORK 409, "},
	{"X-Android-Selected-Protocol":"http/1.1, "},
	{"X-Android-Sent-Millis":"1603811299593, "},
	{"X-Transmission-Session-Id":"xxxxxxxxxx, "}
]

To Reproduce

const ret = await Http.request({
    method: 'GET',
    url: 'https://example.com/my/api'
});
console.log(ret.headers);

Expected behavior There shouldn't be content added at the end of the values.

Screenshots Browser log:

Android Studio log:

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Google Chrome
• Version: 86.0.4240.111

Smartphone (please complete the following information):

• Device: Pixel 3
• OS: Android 11
• Browser: Android Webview (capacitor)
• Version: 2.4.2

Additional context I'm using SDK for Android 11 (API level 30) to build the app.

I believe this is a duplicate of #32. Closing this issue in favor of that one

Is this only an issue on Web? What about Android and iOS?

@thomasvidas We did last week. However, we had to roll it back because the implementation caused all kinds of issues with existing data.

Our latest plugin template changes also ship CommonJS now. It looks like the broader JavaScript community isn't quite ready for ESM-only yet. 😞

See the following for reference:

• https://github.com/ionic-team/create-capacitor-plugin/blob/main/assets/plugin-template/package.json.mustache#L5
• https://github.com/ionic-team/create-capacitor-plugin/blob/main/assets/plugin-template/rollup.config.js.mustache#L14-L19

@mraible has Okta added capacitor://localhost as a trusted origin yet? Either way, I'll take a look at the underlying issue with the capacitor:// scheme

@muuvmuuv sorry for the delayed response, I miss this. @thomasvidas that's right, this feature is lacking only for the web.

best!

Is it only for custom headers or is it for all headers?

Hello, could you provide a reproducible example project?

Describe the bug Params defined in the params options are not set

To Reproduce

This request will be translated into following url

    const response = await Capacitor.Plugins.Http.request({
      method: 'GET',
      url: 'https://api.rss2json.com/v1/api.json',
      params: {
        rss_url: environment.npmBlogEndpoint,
        api_key: environment.rss2jsonApiKey,
        count: '100'
      }
    });

// expected URL
https://api.rss2json.com/v1/api.json?rss_url=http://blog.npmjs.org/rss&api_key=vaamv0bymd6t8b2lorlzway3ph5wg6gpauwfuk7a&count=100

// Requested URL
https://api.rss2json.com/v1/api.json

Expected behavior The url params should been set correctly

The current plan is the release a 0.3.0 with this and other fixes released later this week. If you need it immediately, you can clone the repo and run the following to build the project in a /dist folder

npm install
npm run build

Closing this as the fix is already fixed in #46 and merged into master

I believe this fixes #53 as well, adding it to my list

I believe that Android and iOS already support this here (Android) and here (iOS) so its only missing on web if I'm reading the code correctly.

I'll add it to my list of things to review 👍

Closing due to no response. The headers should suffice. If that is not the case, you can re-open this issue