profile
viewpoint

mozilla-spidermonkey/spidermonkey-embedding-examples 39

Documentation and examples for people who want to embed the SpiderMonkey JavaScript engine.

ptomato/advanced-gtk-techniques 13

Tutorial for advanced GTK programmers

ptomato/Beams 12

Open-source laser beam profiling software designed for cheap webcams

ptomato/devdocs 7

MOVED! Please see https://gitlab.gnome.org/GNOME/devdocsgjs/

chimara/Chimara 4

Interactive Fiction GTK Widget

maelvls/vscode_autotools 3

Autotools syntax highlighting for vscode (adapted from Sublime Text)

push eventGNOME/gjs

Evan Welsh

commit sha 0ce106a6531f67b61bb8936dcc0ab25a7326da57

Bump GLib version requirement.

view details

push time in 4 hours

push eventGNOME/gjs

Florian Müllner

commit sha 1b68e2e9f3579340bb65eb36d1e9e65e548c660e

gobject: Handle CONSTRUCT_ONLY flag CONSTRUCT_ONLY properties are supposed to be only writable during construction, however this is currently only enforced on the C level. Add some minimal handling for GObjects defined in JS as well, by redefining the property as read-only when set from the underlying C code. We know that call happens only during construction, as g_object_set_property() and friends handle the flag themselves, and turning the JS property read-only will prevent changes from javascript (unless it is explicitly made writable again).

view details

Marco Trevisan (Treviño)

commit sha 83347839050c716c8443b3ec192c431d31724a8c

jsapi-util: Rewrite GjsAutoPointer to only use template data We introduced GjsAutoPointer as part of commit dab3c7d06, to avoid duplication of the same code everywhere, and that served us well to create multiple smart pointer types, however since we were relying on std::unique_ptr, all the times we created a pointer with a custom destructor, we were allocating 8bits more, and this can be sensitive when used around in wrappers. However, since we are already constructing the auto-pointers passing all these information as template (generating some custom code, for sure), we can just rely on the template parameters also for the destructor, and so ensuring that the struct size always matches the wrapped pointer, removing all the overhead. This will allow to use GjsAutoPointer's everywhere without increasing the size of the wrapped objects. As per this being all new (even though the API is mainly inspired to unique_ptr), adding various unit tests to ensure we behave correctly.

view details

Marco Trevisan (Treviño)

commit sha 84d1fc4669d8dffe7dc0f847e557e2c3f2f5f051

jsapi-util: Add back support for C++ objects and arrays to GjsAutoPointer As per moving away from std::unique_ptr we lost support for C++ native objects, even this may be optional (as we can just use stl containers for that), it's still nice to have. So add it back and include tests.

view details

Marco Trevisan (Treviño)

commit sha d251072b5fca199ac019f69d7de662d30f338587

jsapi-util: Add copy function to GjsAutoStrv (and test it)

view details

Marco Trevisan (Treviño)

commit sha 6f73ae9efb03d9f24d7ef8895d72c4580966e8d9

jsapi-util: Inherit constructors for GjsAutoBaseInfo and friends Use automatic c++ constructor inheritance, as it allows us to reuse all the constructors defined in the main base class, and so to support the GjsAutoTakeOwnership() "struct-flag", to add a ref. Take advantage of this in the real code.

view details

Marco Trevisan (Treviño)

commit sha 55fa159bcd58ddede392e5b295b1923038350743

jsapi-util: Add copy and equality operator to GjsAutoPointer Not being an unique_ptr anymore we've some more freedom (that will be way more when C++ will allow us to do more static checks), one of the good gain we've now, is that we can easily implement a copy and swap idiom to allow to pass the wrappers by value ensuring an internal copy. This will not work (unfortunately only with runtime checks! :-( ) if the wrapper doesn't provide a copy function, but this is still nice. Tests included.

view details

Marco Trevisan (Treviño)

commit sha c443c6592ed2f3c3cbec5de929d5276e2de9a6ae

jsapi-util: Use constexpr based checks on GjsAutoPointer functions We had FIXME's about this for some time now, but we had a quite nice way to check whether we're handling nullptr functions at compile time, so that we can produce safe code with less dynamic checks: - Previously we were trying to use `if constexpr (ref_func != nullptr)` - The error we were getting was because we were trying to compare a template value (that will be evaluated at link time) with a null pointer (that yes, is a constant value). - However, C++ provides us since the long C++11 times a nice tool that allows to generate a type out from any constant value and that we can do use it to do constexpr checks. - Thus for each template function parameter we can just compute its integral constant type, and ensure that it's not matching null. Under the hood this will generate such types for examples: for g_object_ref: std::integral_constant<GObject* (*)(GObject*), g_object_ref>; for nullptr: std::integral_constant<GObject* (*)(GObject*), 0> And those types are indeed different. Added few tests, although to test invalid types we should add some no-compilation tests.

view details

Marco Trevisan (Treviño)

commit sha 232aeed57253879a6b007fbe312093670198ade0

jsapi-util: Make SFINAE on constructor to work with clang++ As per C++ standard is perfectly legal for the compiler to check template definitions both during instantation (so looking at potential issues) and after their actual usage, so while g++ is more liberal on this and will not try to define functions which are disabled when allocating the template, clang++ will do it. So, in the case of using a void pointer to hold GjsAutoPointer it will complain when using void[] type. To avoid this, let's change the array constructor definition to use an implicit template value, while we still check it properly as part of the enable_if check, so that we'll eventually have the same result. Also fix other compilation issues due to clang being a bit more stricter.

view details

Marco Trevisan (Treviño)

commit sha f0ecb36c9cdc2b13ba5c94a70dc713cd5077895b

boxed: Use an unique_ptr to store the FieldMap There's no need to do manual memory management here, given that unique_ptr will not cost us anything but will handle it for free

view details

Marco Trevisan (Treviño)

commit sha 4800710ef355f3987e901642ad70968c23d22f60

jsapi-util: Add GjsSmartPointer template to create an auto-pointer dynamically

view details

Marco Trevisan (Treviño)

commit sha 868922992398a8f809b3505c995fe695e9a76cca

gi: Use more GjsAutoPointer's in wrapper classes Being now the autopointer as heavy as having a normal pointer, we can just use it more without being worried of the extra memory allocation, as it in fact has none.

view details

Marco Trevisan (Treviño)

commit sha 76563efb16f563cb337701da65b63cefa261aed7

gi: Use GjsSmartPointer to handle destruction of Wrapped objects With the introduction of GjsSmartPointer we can easily generate smart pointer types at build-time depending on template arguments and with the same size of a normal pointer, so use this for WrapperUtils. Don't change the default behavior for base class, so introduce a fake smart-pointer using a custom type that has no free function set, while use it to handle automatically some basic types we have (so far just GError and GObject will take advantage). However this opens the gates to a creation of custom specializations of BoxedInstance that we may use to create different compile-time codepaths avoiding various dynamic checks.

view details

Marco Trevisan (Treviño)

commit sha f7d36e7c6a2ce729ac3d375f7d5d94b7a6c908d4

jsapi-util: Add out operator to get the double pointer

view details

Marco Trevisan (Treviño)

commit sha be527e76f909d8372b6dd0e8baeec98539ee564d

arg: Use early-return in JS to GIArgument conversion function Instead of keeping error-prones errors around and return errors late, let's just try to return early on success and failures. In case we allocated memory we need to free, smart pointers ar our friends.

view details

Marco Trevisan (Treviño)

commit sha 91c18394c23a6dc4bee5595e4172f0befcafa002

jsapi-util: Add SmartPointer for G(S)List and use it It can make some code easier to read as well.

view details

Marco Trevisan (Treviño)

commit sha f4af2e52a27faa2b9cc1cdc0787d984736cba0ba

repo: Use an autopointer to free the versions list, don't leak on error

view details

Marco Trevisan (Treviño)

commit sha fc68688a3bead5f7f17157f979178017f11d26b4

arg: Use GjsSmartPointer to get the right auto pointer on array

view details

Marco Trevisan (Treviño)

commit sha 19c5038189a674301ac1ae17ad3a186edd09ce51

arg: Use smart pointers and early-return on functions

view details

Florian Müllner

commit sha 999e4f940f0d73a2e8ba5c8fd5e6c1ef1c599ca2

gi/object: Check property before access ... to avoid a harmless but annoying "access to undefined property" warning in case the property doesn't exist (namely the first time a non-introspected gtype is accessed).

view details

Florian Müllner

commit sha 8bdbc175513459521fbc9a9b2fd11657a71b8e31

gi/fundamental: Check property before access ... to avoid a harmless but annoying "access to undefined property" warning in case the property doesn't exist (namely the first time a non-introspected gtype is accessed).

view details

push time in 4 hours

delete branch tc39/proposals

delete branch : error-cause-updates

delete time in 4 hours

PR merged tc39/proposals

Reviewers
error-cause to stage-2.

Error cause is not on stage-2 as per November 2020 meeting.

+3 -3

0 comment

2 changed files

hemanth

pr closed time in 4 hours

push eventtc39/proposals

Hegadehalli Madhavarao, Hemanth

commit sha 2327f7af04c3117dcaa7ef4f91ef90362ed4097e

Error Cause to Stage 2, per 2020.11.19 TC39

view details

push time in 4 hours

push eventtc39/proposals

Hegadehalli Madhavarao, Hemanth

commit sha 2327f7af04c3117dcaa7ef4f91ef90362ed4097e

Error Cause to Stage 2, per 2020.11.19 TC39

view details

push time in 5 hours

push eventGNOME/gjs

Evan Welsh

commit sha 2b89239bf0612bfa5b1404fd1bdbb5d1981ca694

Add native registry for GI modules.

view details

Evan Welsh

commit sha 60541cbee76f90c368f68c8f86032c29a675bad1

Fix label formatting.

view details

push time in 5 hours

push eventGNOME/gjs

Evan Welsh

commit sha 3d3b8f6fa9ad68f33ec3847c236383bcad13fc79

Add native registry for GI modules.

view details

Evan Welsh

commit sha c2fb4717605cebdd2f15d31508df2147a7557859

Fix label formatting.

view details

push time in 5 hours

push eventGNOME/gjs

Florian Müllner

commit sha 1b68e2e9f3579340bb65eb36d1e9e65e548c660e

gobject: Handle CONSTRUCT_ONLY flag CONSTRUCT_ONLY properties are supposed to be only writable during construction, however this is currently only enforced on the C level. Add some minimal handling for GObjects defined in JS as well, by redefining the property as read-only when set from the underlying C code. We know that call happens only during construction, as g_object_set_property() and friends handle the flag themselves, and turning the JS property read-only will prevent changes from javascript (unless it is explicitly made writable again).

view details

Marco Trevisan (Treviño)

commit sha 83347839050c716c8443b3ec192c431d31724a8c

jsapi-util: Rewrite GjsAutoPointer to only use template data We introduced GjsAutoPointer as part of commit dab3c7d06, to avoid duplication of the same code everywhere, and that served us well to create multiple smart pointer types, however since we were relying on std::unique_ptr, all the times we created a pointer with a custom destructor, we were allocating 8bits more, and this can be sensitive when used around in wrappers. However, since we are already constructing the auto-pointers passing all these information as template (generating some custom code, for sure), we can just rely on the template parameters also for the destructor, and so ensuring that the struct size always matches the wrapped pointer, removing all the overhead. This will allow to use GjsAutoPointer's everywhere without increasing the size of the wrapped objects. As per this being all new (even though the API is mainly inspired to unique_ptr), adding various unit tests to ensure we behave correctly.

view details

Marco Trevisan (Treviño)

commit sha 84d1fc4669d8dffe7dc0f847e557e2c3f2f5f051

jsapi-util: Add back support for C++ objects and arrays to GjsAutoPointer As per moving away from std::unique_ptr we lost support for C++ native objects, even this may be optional (as we can just use stl containers for that), it's still nice to have. So add it back and include tests.

view details

Marco Trevisan (Treviño)

commit sha d251072b5fca199ac019f69d7de662d30f338587

jsapi-util: Add copy function to GjsAutoStrv (and test it)

view details

Marco Trevisan (Treviño)

commit sha 6f73ae9efb03d9f24d7ef8895d72c4580966e8d9

jsapi-util: Inherit constructors for GjsAutoBaseInfo and friends Use automatic c++ constructor inheritance, as it allows us to reuse all the constructors defined in the main base class, and so to support the GjsAutoTakeOwnership() "struct-flag", to add a ref. Take advantage of this in the real code.

view details

Marco Trevisan (Treviño)

commit sha 55fa159bcd58ddede392e5b295b1923038350743

jsapi-util: Add copy and equality operator to GjsAutoPointer Not being an unique_ptr anymore we've some more freedom (that will be way more when C++ will allow us to do more static checks), one of the good gain we've now, is that we can easily implement a copy and swap idiom to allow to pass the wrappers by value ensuring an internal copy. This will not work (unfortunately only with runtime checks! :-( ) if the wrapper doesn't provide a copy function, but this is still nice. Tests included.

view details

Marco Trevisan (Treviño)

commit sha c443c6592ed2f3c3cbec5de929d5276e2de9a6ae

jsapi-util: Use constexpr based checks on GjsAutoPointer functions We had FIXME's about this for some time now, but we had a quite nice way to check whether we're handling nullptr functions at compile time, so that we can produce safe code with less dynamic checks: - Previously we were trying to use `if constexpr (ref_func != nullptr)` - The error we were getting was because we were trying to compare a template value (that will be evaluated at link time) with a null pointer (that yes, is a constant value). - However, C++ provides us since the long C++11 times a nice tool that allows to generate a type out from any constant value and that we can do use it to do constexpr checks. - Thus for each template function parameter we can just compute its integral constant type, and ensure that it's not matching null. Under the hood this will generate such types for examples: for g_object_ref: std::integral_constant<GObject* (*)(GObject*), g_object_ref>; for nullptr: std::integral_constant<GObject* (*)(GObject*), 0> And those types are indeed different. Added few tests, although to test invalid types we should add some no-compilation tests.

view details

Marco Trevisan (Treviño)

commit sha 232aeed57253879a6b007fbe312093670198ade0

jsapi-util: Make SFINAE on constructor to work with clang++ As per C++ standard is perfectly legal for the compiler to check template definitions both during instantation (so looking at potential issues) and after their actual usage, so while g++ is more liberal on this and will not try to define functions which are disabled when allocating the template, clang++ will do it. So, in the case of using a void pointer to hold GjsAutoPointer it will complain when using void[] type. To avoid this, let's change the array constructor definition to use an implicit template value, while we still check it properly as part of the enable_if check, so that we'll eventually have the same result. Also fix other compilation issues due to clang being a bit more stricter.

view details

Marco Trevisan (Treviño)

commit sha f0ecb36c9cdc2b13ba5c94a70dc713cd5077895b

boxed: Use an unique_ptr to store the FieldMap There's no need to do manual memory management here, given that unique_ptr will not cost us anything but will handle it for free

view details

Marco Trevisan (Treviño)

commit sha 4800710ef355f3987e901642ad70968c23d22f60

jsapi-util: Add GjsSmartPointer template to create an auto-pointer dynamically

view details

Marco Trevisan (Treviño)

commit sha 868922992398a8f809b3505c995fe695e9a76cca

gi: Use more GjsAutoPointer's in wrapper classes Being now the autopointer as heavy as having a normal pointer, we can just use it more without being worried of the extra memory allocation, as it in fact has none.

view details

Marco Trevisan (Treviño)

commit sha 76563efb16f563cb337701da65b63cefa261aed7

gi: Use GjsSmartPointer to handle destruction of Wrapped objects With the introduction of GjsSmartPointer we can easily generate smart pointer types at build-time depending on template arguments and with the same size of a normal pointer, so use this for WrapperUtils. Don't change the default behavior for base class, so introduce a fake smart-pointer using a custom type that has no free function set, while use it to handle automatically some basic types we have (so far just GError and GObject will take advantage). However this opens the gates to a creation of custom specializations of BoxedInstance that we may use to create different compile-time codepaths avoiding various dynamic checks.

view details

Marco Trevisan (Treviño)

commit sha f7d36e7c6a2ce729ac3d375f7d5d94b7a6c908d4

jsapi-util: Add out operator to get the double pointer

view details

Marco Trevisan (Treviño)

commit sha be527e76f909d8372b6dd0e8baeec98539ee564d

arg: Use early-return in JS to GIArgument conversion function Instead of keeping error-prones errors around and return errors late, let's just try to return early on success and failures. In case we allocated memory we need to free, smart pointers ar our friends.

view details

Marco Trevisan (Treviño)

commit sha 91c18394c23a6dc4bee5595e4172f0befcafa002

jsapi-util: Add SmartPointer for G(S)List and use it It can make some code easier to read as well.

view details

Marco Trevisan (Treviño)

commit sha f4af2e52a27faa2b9cc1cdc0787d984736cba0ba

repo: Use an autopointer to free the versions list, don't leak on error

view details

Marco Trevisan (Treviño)

commit sha fc68688a3bead5f7f17157f979178017f11d26b4

arg: Use GjsSmartPointer to get the right auto pointer on array

view details

Marco Trevisan (Treviño)

commit sha 19c5038189a674301ac1ae17ad3a186edd09ce51

arg: Use smart pointers and early-return on functions

view details

Florian Müllner

commit sha 999e4f940f0d73a2e8ba5c8fd5e6c1ef1c599ca2

gi/object: Check property before access ... to avoid a harmless but annoying "access to undefined property" warning in case the property doesn't exist (namely the first time a non-introspected gtype is accessed).

view details

Florian Müllner

commit sha 8bdbc175513459521fbc9a9b2fd11657a71b8e31

gi/fundamental: Check property before access ... to avoid a harmless but annoying "access to undefined property" warning in case the property doesn't exist (namely the first time a non-introspected gtype is accessed).

view details

push time in 5 hours

push eventGNOME/gjs

Evan Welsh

commit sha d4daa0dad54bcce3073687b2f63c5320ae748fac

Implement WHATWG Encoding specification.

view details

push time in 5 hours

push eventGNOME/gjs

Philip Chimento

commit sha f73427e3cc458701b30c76efa4dc1f2fa697e50e

CI: Avoid cppcheck false positive Cppcheck checks for g_strchomp(g_strdup(...)) but doesn't realize that we are freeing the return value later by storing it in a smart pointer. Reverse the order of the calls to avoid the false positive.

view details

Philip Chimento

commit sha 4c02d479cca0d61656d371bd69bc6b3bf1932c5d

CI: Activate GNOME-specific rules in cppcheck Cppcheck ships a "library file" for the GNOME platform, enabling some extra checks when using GLib and GTK APIs.

view details

Philip Chimento

commit sha 95a48ca23c090d4058d3a0cc89f7e4cff39521a8

Merge branch 'cppcheck' into 'master' Use GNOME-specific rules with cppcheck See merge request GNOME/gjs!532

view details

Philip Chimento

commit sha f89e0586e004aa32607219e6d7f0d1d1fbbe8fb3

maint: Move expressions with side-effects out of assert statements A newer version of cppcheck catches this.

view details

Marco Trevisan (Treviño)

commit sha ac0b11a8a4efeccff47706f334717e0923db3122

function: Don't use alloca for CallState values Usage of alloca() is at least discouraged, especially in a project that it is supposed to work in multiple architectures and OSes, as its implementation is very hw/compiler dependent. Not only, when a function has many arguments we may end up in filling up the stack space, leading to unexpected behavior. It also prevents us from usage of C++ constructors and destructors in GjsFunctionCallState. As per this, remove g_newa() and rely on default C++ allocators, while use some utilities to compute the proper offsets.

view details

Marco Trevisan (Treviño)

commit sha a6c943273e9ba6775c3550e3c47a433edb563a7c

function: Allocate ffi_arg_pointers using an unique_ptr array As commit before, better not to use alloca(), while we've c++ handling the lifetime of our array.

view details

Philip Chimento

commit sha 7f7c1ed0a78b120ae46cf11a1a219a384f0159b2

maint: Replace use of g_newa() and g_alloca() We do use stack allocation with g_newa() for performance reasons in some places, but these are not hot paths, so there is no need to do it here. Cppcheck now warns about this, so just use GjsAutoPointer and g_new() instead.

view details

Philip Chimento

commit sha e3494eb6be742edf8f4e60c99d471e506eae5c46

dbus: Avoid null dereference in error message Caught by cppcheck.

view details

Philip Chimento

commit sha 85516f96edd3817899217c1f370069e7e07db7a6

util: Fix wrong format specifiers It seems that these two format specifiers were reversed. Caught by cppcheck.

view details

Philip Chimento

commit sha 092157e16f3a098c0b7c99ebdd7de6a3daaad0c9

module: Delete GjsScriptModule copy constructor and assignment operator These allocate memory, and we don't want to do that accidentally. Caught by cppcheck.

view details

Philip Chimento

commit sha 068206950388a6820e120752263347595e358015

tests: Use GObject weak pointer to track test object refcount The GObject.ref_count field is private, who knew! It is still accessible but apparently it messes up cppcheck, so we use GObject weak pointers instead to track the reference count of these objects, as demonstrated in https://stackoverflow.com/a/24459058/172999

view details

Philip Chimento

commit sha 2fde9dd46394cda25091065d234413af4e75494c

CI: Avoid cppcheck false positives Various changes to avoid false positives in cppcheck. The 'alternative int' specifier isn't known to cppcheck so always run the checks as if it is not defined. Cppcheck has trouble deducing the type of one 'auto' variable, so just replace it with its real type.

view details

Philip Chimento

commit sha 1074a575e55f5b85b1e2e35e7fe110248ad282ce

CI: Add cppcheck config file This is needed because we are about to upgrade to a newer version of cppcheck than the one on the DockerHub image. It ships a "library file" for the GNOME platform, enabling some extra checks when using GLib and GTK APIs. It also requires configuration of some of the macros that we use.

view details

Philip Chimento

commit sha a5de7e27d9e693de3df1bb63951b94d5090e2e38

CI: Replace jobs that pull from DockerHub with CI templates DockerHub is rate-limiting pulls that come from the same IP, which is a big problem for GNOME's GitLab CI runners. Use CI templates instead, to store images in this project's own container registry. Documentation: https://freedesktop.pages.freedesktop.org/ci-templates/templates.html

view details

Philip Chimento

commit sha cf05a5a750e7e7616e5eabf838ff2203a6fa50f4

CI: Replace cpplint image build and CI job with CI templates Since we are already building a light image with linters, add cpplint to it as well and remove the separate Dockerfile build.

view details

Philip Chimento

commit sha 7842fec51937fc8b48f7eea2c85172fde2661844

CI: Use Fedora project registry images instead of DockerHub Hopefully these are just drop-in replacements. We cannot rely on DockerHub anymore because they are rate-limiting pulls.

view details

Marco Trevisan (Treviño)

commit sha 4edf8cebdfe2c2f8fc8c811de17c209412bb94db

Dockerfile: Allow to pass the mozjs base to use for build-deps And use them for mozjs78 builds, as build-deps may change

view details

Philip Chimento

commit sha e5e202faadb484bbdb58b0a2be2f89f84697d27a

CI: Use images with buildah and runc preinstalled for image builds This saves some time when building the monthly images.

view details

Philip Chimento

commit sha 5aa26aba7d2c153ad831ffe6c409e470aed3205d

Merge branch 'bye-dockerhub' into 'master' Avoid pulling from DockerHub in CI See merge request GNOME/gjs!531

view details

Evan Welsh

commit sha 4a80fbe377398d8332ff75342d8140a25a7f9738

Implement WHATWG Encoding specification.

view details

push time in 5 hours

push eventGNOME/gjs

Evan Welsh

commit sha fe4043da236dc14c19f5e75cbcc40b8a57a21246

Implement WHATWG Encoding specification.

view details

push time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha c19f3309e80f9d78bd2e8d6cfee5ebc796dce2f5

Implement WHATWG Encoding specification.

view details

push time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha f75801d51069c33ca8b5d852fd9c42f78a429929

Implement WHATWG Encoding specification.

view details

push time in 6 hours

push eventtc39/proposals

Hegadehalli Madhavarao, Hemanth

commit sha a35f351ddd9a014282f1140b4be266705d13238a

Error Cause to Stage-2.

view details

push time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha 3fe5c4410c8ecf5616eb43779ce158e1d3270091

Implement WHATWG Encoding specification.

view details

push time in 6 hours

Pull request review commenttc39/proposals

error-cause to stage-2.

 # [ECMAScript](https://github.com/tc39/ecma262) proposals -* [Stage 1 Proposals](stage-1-proposals.md)-* [Stage 0 Proposals](stage-0-proposals.md)-* [Finished Proposals](finished-proposals.md)-* [Inactive Proposals](inactive-proposals.md)+- [Stage 1 Proposals](stage-1-proposals.md)

Looks like my editor tried to auto-format it.

I did say save without formatting.

hemanth

comment created time in 6 hours

PR opened tc39/proposals

Reviewers
error-cause to stage-2.

Error cause is not on stage-2 as per November 2020 meeting.

+122 -122

0 comment

2 changed files

pr created time in 6 hours

push eventtc39/proposals

Hegadehalli Madhavarao, Hemanth

commit sha 9b2cdbd898c1ce7339fa07cb4a71b6579210c3e5

error-cause to stage-2.

view details

push time in 6 hours

create barnchtc39/proposals

branch : error-cause-updates

created branch time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha 29262ad2d4957debc3e8ff2496dca1a470973581

Implement WHATWG Encoding specification.

view details

push time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha 3e9098146507d4c5eed0627d2944565b538c811b

Implement WHATWG Encoding specification.

view details

push time in 6 hours

push eventGNOME/gjs

Evan Welsh

commit sha cbda96b75fc0273a4c27c59b6bc2db3adde4c633

Implement WHATWG Encoding specification.

view details

push time in 7 hours

push eventtc39/proposal-temporal

ptomato

commit sha 624b183c30bf9b293b130ad427420483411122ec

Deploying to gh-pages from @ d75ef218455e6733765cbc3499336eda650704b2 🚀

view details

push time in 7 hours

delete branch tc39/agendas

delete branch : littledan-patch-1

delete time in 7 hours

PR merged tc39/agendas

Add Type.isType topic
+1 -0

2 comments

1 changed file

littledan

pr closed time in 7 hours

push eventtc39/agendas

Daniel Ehrenberg

commit sha 6ce3136a6751cfd9446355e76cee4c2f5e232d6e

2020.01: Add Type.isType topic

view details

push time in 7 hours

push eventtc39/agendas

Rob Palmer

commit sha f198df0c733a598b960c3152d7023e70ad8d7164

Reschedule Dec 2021

view details

Rob Palmer

commit sha 753aab4a7fb5aef04973c293a3250c10c99dee73

Merge pull request #903 from tc39/robpalme-patch-1 Reschedule Dec 2021

view details

Daniel Ehrenberg

commit sha 6ce3136a6751cfd9446355e76cee4c2f5e232d6e

2020.01: Add Type.isType topic

view details

push time in 7 hours

push eventGNOME/gjs

Philip Chimento

commit sha f89e0586e004aa32607219e6d7f0d1d1fbbe8fb3

maint: Move expressions with side-effects out of assert statements A newer version of cppcheck catches this.

view details

Marco Trevisan (Treviño)

commit sha ac0b11a8a4efeccff47706f334717e0923db3122

function: Don't use alloca for CallState values Usage of alloca() is at least discouraged, especially in a project that it is supposed to work in multiple architectures and OSes, as its implementation is very hw/compiler dependent. Not only, when a function has many arguments we may end up in filling up the stack space, leading to unexpected behavior. It also prevents us from usage of C++ constructors and destructors in GjsFunctionCallState. As per this, remove g_newa() and rely on default C++ allocators, while use some utilities to compute the proper offsets.

view details

Marco Trevisan (Treviño)

commit sha a6c943273e9ba6775c3550e3c47a433edb563a7c

function: Allocate ffi_arg_pointers using an unique_ptr array As commit before, better not to use alloca(), while we've c++ handling the lifetime of our array.

view details

Philip Chimento

commit sha 7f7c1ed0a78b120ae46cf11a1a219a384f0159b2

maint: Replace use of g_newa() and g_alloca() We do use stack allocation with g_newa() for performance reasons in some places, but these are not hot paths, so there is no need to do it here. Cppcheck now warns about this, so just use GjsAutoPointer and g_new() instead.

view details

Philip Chimento

commit sha e3494eb6be742edf8f4e60c99d471e506eae5c46

dbus: Avoid null dereference in error message Caught by cppcheck.

view details

Philip Chimento

commit sha 85516f96edd3817899217c1f370069e7e07db7a6

util: Fix wrong format specifiers It seems that these two format specifiers were reversed. Caught by cppcheck.

view details

Philip Chimento

commit sha 092157e16f3a098c0b7c99ebdd7de6a3daaad0c9

module: Delete GjsScriptModule copy constructor and assignment operator These allocate memory, and we don't want to do that accidentally. Caught by cppcheck.

view details

Philip Chimento

commit sha 068206950388a6820e120752263347595e358015

tests: Use GObject weak pointer to track test object refcount The GObject.ref_count field is private, who knew! It is still accessible but apparently it messes up cppcheck, so we use GObject weak pointers instead to track the reference count of these objects, as demonstrated in https://stackoverflow.com/a/24459058/172999

view details

Philip Chimento

commit sha 2fde9dd46394cda25091065d234413af4e75494c

CI: Avoid cppcheck false positives Various changes to avoid false positives in cppcheck. The 'alternative int' specifier isn't known to cppcheck so always run the checks as if it is not defined. Cppcheck has trouble deducing the type of one 'auto' variable, so just replace it with its real type.

view details

Philip Chimento

commit sha 1074a575e55f5b85b1e2e35e7fe110248ad282ce

CI: Add cppcheck config file This is needed because we are about to upgrade to a newer version of cppcheck than the one on the DockerHub image. It ships a "library file" for the GNOME platform, enabling some extra checks when using GLib and GTK APIs. It also requires configuration of some of the macros that we use.

view details

Philip Chimento

commit sha a5de7e27d9e693de3df1bb63951b94d5090e2e38

CI: Replace jobs that pull from DockerHub with CI templates DockerHub is rate-limiting pulls that come from the same IP, which is a big problem for GNOME's GitLab CI runners. Use CI templates instead, to store images in this project's own container registry. Documentation: https://freedesktop.pages.freedesktop.org/ci-templates/templates.html

view details

Philip Chimento

commit sha cf05a5a750e7e7616e5eabf838ff2203a6fa50f4

CI: Replace cpplint image build and CI job with CI templates Since we are already building a light image with linters, add cpplint to it as well and remove the separate Dockerfile build.

view details

Philip Chimento

commit sha 7842fec51937fc8b48f7eea2c85172fde2661844

CI: Use Fedora project registry images instead of DockerHub Hopefully these are just drop-in replacements. We cannot rely on DockerHub anymore because they are rate-limiting pulls.

view details

Marco Trevisan (Treviño)

commit sha 4edf8cebdfe2c2f8fc8c811de17c209412bb94db

Dockerfile: Allow to pass the mozjs base to use for build-deps And use them for mozjs78 builds, as build-deps may change

view details

Philip Chimento

commit sha e5e202faadb484bbdb58b0a2be2f89f84697d27a

CI: Use images with buildah and runc preinstalled for image builds This saves some time when building the monthly images.

view details

Philip Chimento

commit sha 5aa26aba7d2c153ad831ffe6c409e470aed3205d

Merge branch 'bye-dockerhub' into 'master' Avoid pulling from DockerHub in CI See merge request GNOME/gjs!531

view details

push time in 7 hours

pull request commenttc39/proposal-temporal

Clarify ZDT docs for `from` behavior of date/time fields

Codecov Report

Merging #1216 (5b1021a) into main (5930868) will decrease coverage by 1.39%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
- Coverage   93.55%   92.15%   -1.40%     
==========================================
  Files          19       17       -2     
  Lines        7961     9256    +1295     
  Branches     1264     1315      +51     
==========================================
+ Hits         7448     8530    +1082     
- Misses        506      716     +210     
- Partials        7       10       +3     
Flag Coverage Δ
test262 ?
tests 92.15% <ø> (+2.71%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/intrinsicclass.mjs
polyfill/lib/slots.mjs
polyfill/lib/shim.mjs
polyfill/lib/legacydate.mjs
lib/intl.mjs 99.74% <0.00%> (ø)
lib/plaintime.mjs 91.71% <0.00%> (ø)
lib/temporal.mjs 100.00% <0.00%> (ø)
lib/timezone.mjs 89.49% <0.00%> (ø)
lib/plaindate.mjs 87.08% <0.00%> (ø)
lib/plainmonthday.mjs 83.23% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a579788...58f8731. Read the comment docs.

justingrant

comment created time in 7 hours

more