 This is an example of a working app with [TwinSpark](https://kasta-ua.github.io/ This is a simple eCommerce site: product list with endless scroll, where you can add a product to cart and so on. +[![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)

This one is pretty neat. Heroku server reads a request origin to figure out what app should be deployed.

JAremko

comment created time in 6 days

Pull request review commentpiranha/ecomspark

Add Heroku deployment

             [ecomspark.app :as app]))  +(def default-port 5454)+ (mount/defstate httpd-  :start (do-           (println "Starting HTTPd on :5454...")-           (httpd/run-server app/app {:port 5454}))+  :start (let [port (or (some->> "PORT" System/getenv Integer/parseInt)

Heroku sets PORT variable.

JAremko

comment created time in 12 days

pull request commentpiranha/ecomspark

Lube the entry

GitHub stuck displaying old head... Thanks Microsoft :shipit:

JAremko

comment created time in 12 days

pull request commentpiranha/ecomspark

Lube the entry

GitHub stuck displaying old head... Thanks Microsoft :shipit:

JAremko

comment created time in 12 days

PR opened tonsky/rum

Help automatic externs inference with type hints

CLJS compiler was not able to infer these calls for produce externs. Produced e.g. following error with shadow-cljs release app --debug:

react-dom.production.min.js:199 TypeError: this.$setState$ is not a function
    at $ctor$jscomp$2$$.componentWillReceiveProps (core.cljs:77)
    at De (react-dom.production.min.js:134)
    at Of (react-dom.production.min.js:171)
    at Hg (react-dom.production.min.js:181)
    at Gh (react-dom.production.min.js:233)
    at Hh (react-dom.production.min.js:234)
    at cg (react-dom.production.min.js:250)
    at cc (react-dom.production.min.js:249)
    at Nh (react-dom.production.min.js:251)
    at $rum$core$render$$ (core.cljs:233)

Setting (set! *warn-on-infer* true) on rum.core namespace reported these issues (for example when running lein test). For example: WARNING: Cannot infer target type in expression (. this setState #object[cljs.tagged_literals.JSValue 0x5b042995 "cljs.tagged_literals.JSValue@5b042995"]) coming from UNSAFE_componentWillReceiveProps function.

+9 -9

1 commit in lupapiste/rum/tree/feature/type-hints-fix-infer-warnings tonsky/rum/tree/gh-pages

0 comment

1 changed file

pr created time in 13 days

issue commentpiranha/ecomspark

:div.product.column.col-3.col-xs-6.p-1

Ну можно написать [:div {:class "a b c d e"}], но мне кажется, что в целом в большом проекте всё равно оно не так будет делаться. :)

@piranha Знайти css-ера який буде не проти залізти в код і поміняти :div.product.column.col-3.col-xs-6.p-1 на :div.product.column.col-4.col-xs-6.p-1 напевно не так-то просто :grimacing: А взагалі, як ви з дизайнерами і т.п працюєте? hiccup/garden індоктринація? :shipit:

JAremko

comment created time in 15 days

startedpiranha/ecomspark

started time in 15 days

pull request commentpiranha/ecomspark

Lube the entry

Dockerfile.heroku needed cuz heroku builder doesn't have 4-5gigs of RAM to quench the thirst of GraalVM native builder.

JAremko

comment created time in 18 days

PR opened piranha/ecomspark

Lube the entry

Reduce entry friction by providing easy deployment options

@piranha The demo is up https://ecomspark.herokuapp.com/ (I'll transfer it if PR gets merged), you'll need Heroku account (demo runs on free instance so it can get "cold")

:cherries: Native image container for bonus tism points ((((:confused:))))

+174 -7

1 commit in JAremko/ecomspark/tree/master piranha/ecomspark/tree/master

0 comment

13 changed files

pr created time in 18 days

issue openedpiranha/ecomspark

Misleading timeout error

With Chrome in "slow 3G" mode sometimes you can get twinspark.js:845 TwinSpark error: Error retrieving backend response /?offset=<NUMBER> This request needs at least 1 elements, but 0 were returned I guess, when API times out it returns empty response. Something like error: request <REQUST> timed out would be preferable. Also in "request needs at least 1 elements" is it "response must contain at least 1 element" ?

created time in 19 days

issue commentpiranha/ecomspark

:div.product.column.col-3.col-xs-6.p-1

Если провести псевдонаучный анализ, то, с точки зрения псевдо эксперта по визуальному дизайн, элементы с высокой частотой под элементов (количество саб элементов на см квадратный экрана) привлекают к себе внимания. Точка . является разделителем, с точки зрения деванного лингвиста. Соединённые точками классы организуются в слово - слово с высокой частотой под слов. Это, с точки зрения библиотекаря-любителя, нарушает нормальный поток чтения документа.

JAremko

comment created time in 19 days

issue commentpiranha/ecomspark

:div.product.column.col-3.col-xs-6.p-1

Понятно что в коде демки должен быть сервер, верстка (так как фишка фреймворка в том что она как есть отдается) но нужны ли кишки css селекторов :thinking:

JAremko

comment created time in 19 days

issue commentpiranha/ecomspark

:div.product.column.col-3.col-xs-6.p-1

Что бы ответить на этот вопрос нужна камера с :eyes: тракером и :lab_coat: :rabbit: без профессиональной деформации.

JAremko

comment created time in 19 days

issue commentpiranha/ecomspark

:div.product.column.col-3.col-xs-6.p-1

@piranha ИМХО в демке должно быть как можно меньше шума.

JAremko

comment created time in 19 days