Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ thinking-sphinx (5.1.0 → 5.2.0) · Repo · Changelog

<details> <summary>Release Notes</summary> <h4><a href="https://github.com/pat/thinking-sphinx/releases/tag/v5.2.0">5.2.0</a></h4>

<blockquote><h2>Upgrading</h2> <p>No breaking or major changes.</p> <h2>New features</h2> <ul> <li>Confirmed support for Ruby 3.0.</li> <li>Orphaned records in real-time indices can now be cleaned up without running <code>rails ts:rebuild</code>. Disabled by default, can be enabled by setting <code>real_time_tidy</code> to true per environment in <code>config/thinking_sphinx.yml</code> (and will need <code>ts:rebuild</code> to restructure indices upon initial deploy). More details in <a href="https://bounce.depfu.com/github.com/pat/thinking-sphinx/pull/1192">#1192</a>.</li> </ul> <h2>Bug fixes</h2> <ul> <li>Avoid loading ActiveRecord during Rails initialisation so app configuration can still have an impact (<a href="https://bounce.depfu.com/github.com/jdelStrother">@jdelStrother</a> in <a href="https://bounce.depfu.com/github.com/pat/thinking-sphinx/pull/1194">#1194</a>).</li> <li>Remove <code>app/indices</code> (in both the Rails app and engines) from Rails' eager load paths, which was otherwise leading to indices being loaded more than once. (See <a href="https://bounce.depfu.com/github.com/pat/thinking-sphinx/issues/1191">#1191</a> and <a href="https://bounce.depfu.com/github.com/pat/thinking-sphinx/issues/1195">#1195</a>).</li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/rubygem/thinking-sphinx/feedback">Please let us know.</a></em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/pat/thinking-sphinx/compare/454b0260df150b4cdba32432e2e933e9de7b2006...0753d7e7b0d732605706b56bac57b2046b37d42e">See the full diff on Github</a>. The new version differs by 15 commits:</p> <ul> <li><a href="https://github.com/pat/thinking-sphinx/commit/0753d7e7b0d732605706b56bac57b2046b37d42e"><code>Merge branch 'release/v5.2.0' into master</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/1e9eb987736ea6342a4e545f0a8d9bdcb0db4181"><code>5.2.0</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/d715732dbc862c425e28e5dab55dfa55c595acc0"><code>Avoid all app/indices paths from eager loading.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/02bbb5071482cab8c91b956d2f6437b4cded3cce"><code>Remove indices from eager load paths.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/18ea60de259cc120459d3a7fd94cb9a75fea67aa"><code>Merge pull request #1194 from jdelStrother/rails-init</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/ea8bc34ef71615523ae4159e851fa514338c14a8"><code>Don't load ActiveRecord during rails initialization</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/d1f0940390b9687550ca47513b843ff50164c9f7"><code>Merge pull request #1192 from pat/realtime-cleaning</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/08086ff93d14fa5a6674132d1e29f9ee07ce682c"><code>If tidying, clear unchanged records.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/ba3fd0f048426b4c33239ae1de8efad7379d9b47"><code>Switch sphinx_updated_at default to use a proc.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/e12ef353d2f7853fdebee8b962f4281bdb6c74ed"><code>Add sphinx_updated_at if real_time_tidy is true.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/4e6eda0f6743d12ebca33e9a1b8766b43a9621de"><code>Switch to proper MRI 3.0.0 release in CI.</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/3ebd15fc84a4d12c81c4621e2c3311cef364e8be"><code>Update README with latest versions. [skip ci]</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/4a0b25c0ec9da4ffbda3fccc81e00b92530d4329"><code>Merge pull request #1187 from pat/ruby-3</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/6c3d69b36a1af9199cbb1836bdf0dd46b2f5ca20"><code>Test against Ruby 3.0</code></a></li> <li><a href="https://github.com/pat/thinking-sphinx/commit/777f1513901b809c0f8d3e86205c5e7110a51ed2"><code>Merge branch 'release/v5.1.0' into develop</code></a></li> </ul> </details>

↗️ concurrent-ruby (indirect, 1.1.8 → 1.1.9) · Repo · Changelog

<details> <summary>Release Notes</summary>

<h4>1.1.9 (from changelog)</h4> <blockquote><p>concurrent-ruby:</p> <ul> <li>(<a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/866">#866</a>) Child promise state not set to :pending immediately after #execute when parent has completed</li> <li>(<a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/905">#905</a>, <a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/issues/872">#872</a>) Fix RubyNonConcurrentPriorityQueue#delete method</li> <li>(2df0337d) Make sure locks are not shared on shared when objects are dup/cloned</li> <li>(<a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/issues/900">#900</a>, <a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/906">#906</a>, <a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/issues/796">#796</a>, <a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/847">#847</a>, <a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/911">#911</a>) Fix Concurrent::Set tread-safety issues on CRuby</li> <li>(<a href="https://bounce.depfu.com/github.com/ruby-concurrency/concurrent-ruby/pull/907">#907</a>) Add new ConcurrentMap backend for TruffleRuby</li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/rubygem/concurrent-ruby/feedback">Please let us know.</a></em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/ruby-concurrency/concurrent-ruby/compare/b47d29412b05a4a502fad66a2ac3699013178e89...52c08fca13cc3811673ea2f6fdb244a0e42e0ebe">See the full diff on Github</a>. The new version differs by 27 commits:</p> <ul> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/52c08fca13cc3811673ea2f6fdb244a0e42e0ebe"><code>Fix wrong class</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/f47e30049c820782d3311f6f7aeb9d652c43424f"><code>Fix testing on different Ruby versions</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/229a051f3f124e7dece4bb4d9364bd2d63c3d141"><code>Add missing sections</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/0fdf0e27a14d6ddee230cc3086dd56fc705e3ae5"><code>Update documentation</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/5f06b9bc337c5de05a0960b3f87a65e03f1cd4cd"><code>Update building instructions</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/d3892de929cfa554001ab4ed6844fd57fdf4887a"><code>bump version</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/08f60eebea9442ee8ae561670c65831ceaa023b7"><code>Update changelog</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/0ace3583f1b2ddc3245b66666db71a007a9cba2c"><code>Make sure locks are not shared on shared when objects are dup/cloned</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/b57b48306997b6741e4c582cb12f0f6bb7b2f78e"><code>Merge pull request #866 from pelly/master</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/663fe73bd4b26f47e9b995e4355cab4ceef1e5c5"><code>Merge pull request #905 from andrykonchin/fix-priority-queue</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/19e19267c08a584d10df2fcba559b73464fef096"><code>Merge pull request #911 from ruby-concurrency/pitr-ch/set</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/7e1dc828807685a3d13fc5008770166626f7d58f"><code>Avoid warning about uninitialized ivar</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/8fa5b953d05d9bdbbaff43c08abe05f4cfefd1e8"><code>fix formatting</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/dd2d8cf6fc5c85c904d2892de4d89eed311b995a"><code>Fix Set thread safety</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/382550c1ec453ed310cca61436288eb80eacf0d9"><code>Flattne the condition</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/aa83e25099bf17ebbc9b26788f8d2265c083e345"><code>Merge pull request #907 from Shopify/truffleruby-map-backend</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/4b0c1b2c207b1c49732410653774981f754b976c"><code>Use new TruffleRuby::ConcurrentMap backend for Concurrent::Map</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/9b4269e2c977cf68341dc261e49dc3acbf43dd3e"><code>Merge pull request #908 from wildmaples/github-actions-maybe</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/e056ef3903d2fcc4297fcbf0d91125a855dad8f6"><code>Add CI flow for tests on Github actions</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/cb2191f1f6bc47bfd1bff9cb5a4a0f5e6b126c8c"><code>Fix RubyNonConcurrentPriorityQueue#delete method</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/7b7900a9133a5c31e60fc55133559ae07c934d69"><code>Merge pull request #901 from olleolleolle/patch-2</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/44224ac16c27a3e5dab026197b1fb246395189df"><code>Merge pull request #904 from ksapozhnikov/fixed_map_documenation</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/d6f56cb58be136b69b962726aa8bdc7f2b2b079e"><code>Update doc</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/c5431eadeb067df94d20d3faaf0000f7844e99b2"><code>Fixed documentation for Concurrent::Map</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/1eb74e5339bb16e094f023bdd777315366131ea2"><code>CI: Use jruby-9.2.16.0</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/6ff17946d034095cf9ba2929df27f70b1f269cfb"><code>CI: Use latest JRuby 9.2.15.0</code></a></li> <li><a href="https://github.com/ruby-concurrency/concurrent-ruby/commit/c6af93d93e21a7b35a5c6fe7807a9924be129ea3"><code>CI: Update latest JRuby to 9.2.14.0</code></a></li> </ul> </details>

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.16.0 → 1.16.1) · Repo · Changelog

<details> <summary>Release Notes</summary> <h4><a href="https://github.com/rubocop/rubocop/releases/tag/v1.16.1">1.16.1</a></h4>

<blockquote><h3>Bug fixes</h3> <ul> <li> <a href="https://bounce.depfu.com/github.com/rubocop/rubocop/issues/9843">#9843</a>: Fix <code>Style/RedundantSelf</code> to allow conditional nodes to use <code>self</code> in the condition when a variable named is shadowed inside. (<a href="https://bounce.depfu.com/github.com/dvandersluis">@dvandersluis</a>)</li> <li> <a href="https://bounce.depfu.com/github.com/rubocop/rubocop/issues/9845">#9845</a>: Fix <code>Style/QuotedSymbols</code> for hash-rocket hashes. (<a href="https://bounce.depfu.com/github.com/dvandersluis">@dvandersluis</a>)</li> <li> <a href="https://bounce.depfu.com/github.com/rubocop/rubocop/pull/9849">#9849</a>: Fix a false negative for <code>Layout/HashAlignment</code> when setting <code>EnforcedStyle: with_fixed_indentation</code> of <code>Layout/ArgumentAlignment</code> and using misaligned keyword arguments. (<a href="https://bounce.depfu.com/github.com/koic">@koic</a>)</li> <li> <a href="https://bounce.depfu.com/github.com/rubocop/rubocop/pull/9854">#9854</a>: Allow braced numeric blocks in <code>omit_parentheses</code> style of <code>Style/MethodCallWithArgsParentheses</code>. (<a href="https://bounce.depfu.com/github.com/gsamokovarov">@gsamokovarov</a>)</li> <li> <a href="https://bounce.depfu.com/github.com/rubocop/rubocop/issues/9850">#9850</a>: Fix missing <code>AllowComments</code> option for <code>Lint/EmptyInPattern</code>. (<a href="https://bounce.depfu.com/github.com/koic">@koic</a>)</li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/rubygem/rubocop/feedback">Please let us know.</a></em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/68cd82ebebfb53dd31b331e52942fe3d0a9bdcc3...cc4b75a826d8c837696ded735e1a0d14ffdc38e9">See the full diff on Github</a>. The new version differs by 20 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/cc4b75a826d8c837696ded735e1a0d14ffdc38e9"><code>Cut 1.16.1</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4bbbc16851ac9046cc7bfd4a75c24bdd32cd9998"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ffdd3022e5df5479164916642f707b6a721f450f"><code>configuration: * seems to bind before ; escape it</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a8ba2f97a97b898f4d89f3432065d4e78ebdd926"><code>Merge pull request #9856 from MSP-Greg/mingw-ci</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/721cbf0dde0cf0d177f262ef499667e1d0e77008"><code>Merge pull request #9854 from gsamokovarov/omit-parentheses-braced-numblocks</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/3de2a7b4ab38687b56b6a89b0aec4059bff6bcba"><code>Allow braced numeric blocks in Style/MethodCallWithArgsParentheses</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/6ca1147c71d157481ceef7be31814b53d28a42f2"><code>Revert &quot;Merge pull request #9808 from koic/workaournd_for_mingw_build_error&quot;</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/73975f96546ffa4d7cdd50d2ecb4b64c8b268fab"><code>Remove redundant code forStyle/MultilineWhenThen</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/632e2f15a9684e4c6edf51213efea069e7b34013"><code>Merge pull request #9851 from koic/fix_missing_option_for_lint_empty_in_pattern</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ba141f5e29018ac053c1660d6b9219c3c4d402dc"><code>[Fix #9850] Fix missing option forLint/EmptyInPattern</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/2d4d6df6ab38d21b23b2facfddc74725a815a8c2"><code>Merge pull request #9849 from koic/fix_a_false_negative_for_layout_hash_alignment</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/2cc2f9810000f3d33d8718937c22e774397f3244"><code>Fix a false negative forLayout/HashAlignment</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/27cb14d2c7fc501cdf188ceb4c06d99cbcca4523"><code>Merge pull request #9847 from dvandersluis/issue/9843</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/e81366794a43875f545e90a1c134b07b441cd769"><code>[Fix #9843] FixStyle/RedundantSelfto allow conditional nodes to useselfin the condition when a variable named is shadowed inside.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4ab9286e9486c575ade2d43c98140c72d18cd6fd"><code>Merge pull request #9846 from dvandersluis/issue/9845</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b292109d7b64b4aef1919d7e49729f9c20b32f97"><code>[Fix #9845] FixStyle/QuotedSymbolsfor hash-rocket hashes.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/6a681fa69f40bc7e79ea8b06c704519284715619"><code>Merge pull request #9844 from n1zyy/corrent-is-incorrect</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/0684236d2139f81446b595823c40f570cc27b74d"><code>Fix trivial typo in rake_task.rb</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8aa36568986693266f2c7588c0d38860a5af5bfc"><code>Refine offense range forStyle/RedundantSelf`</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/eaccf7be86b5e4085dcc1bd72ce4b43c1055f996"><code>Switch back the docs version</code></a></li> </ul> </details>

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

Of course. I will try it and if there are issues I will open a separate issue here. I just wanted to make sure the case of engines (as it is supported) is not forgotten with this change.

I just thought of something.

I have a rails engine and it is located in /gems/my-engine/

There I have a model gems/my-engine/app/models/user.rb

Currently my indices are in

app/indices/user_index.rb

but I would like to move them to gems/my-engine/app/indices/user_index.rb

My point is - is it possible to have inidices in many folders, not only app/indices but also gems/my-engine/app/indices?

All good on my side.

The gitrepo has a typo - it should be thinking-sphinx and not thinking-sphinix.

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Bumps rubocop from 1.16.0 to 1.16.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rubocop/rubocop/releases">rubocop's releases</a>.</em></p> <blockquote> <h2>RuboCop 1.16.1</h2> <h3>Bug fixes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9843">#9843</a>: Fix <code>Style/RedundantSelf</code> to allow conditional nodes to use <code>self</code> in the condition when a variable named is shadowed inside. (<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9845">#9845</a>: Fix <code>Style/QuotedSymbols</code> for hash-rocket hashes. (<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/pull/9849">#9849</a>: Fix a false negative for <code>Layout/HashAlignment</code> when setting <code>EnforcedStyle: with_fixed_indentation</code> of <code>Layout/ArgumentAlignment</code> and using misaligned keyword arguments. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/pull/9854">#9854</a>: Allow braced numeric blocks in <code>omit_parentheses</code> style of <code>Style/MethodCallWithArgsParentheses</code>. (<a href="https://github.com/gsamokovarov"><code>@​gsamokovarov</code></a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9850">#9850</a>: Fix missing <code>AllowComments</code> option for <code>Lint/EmptyInPattern</code>. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">rubocop's changelog</a>.</em></p> <blockquote> <h2>1.16.1 (2021-06-09)</h2> <h3>Bug fixes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9843">#9843</a>: Fix <code>Style/RedundantSelf</code> to allow conditional nodes to use <code>self</code> in the condition when a variable named is shadowed inside. ([<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9845">#9845</a>: Fix <code>Style/QuotedSymbols</code> for hash-rocket hashes. ([<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/pull/9849">#9849</a>: Fix a false negative for <code>Layout/HashAlignment</code> when setting <code>EnforcedStyle: with_fixed_indentation</code> of <code>Layout/ArgumentAlignment</code> and using misaligned keyword arguments. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/pull/9854">#9854</a>: Allow braced numeric blocks in <code>omit_parentheses</code> style of <code>Style/MethodCallWithArgsParentheses</code>. ([<a href="https://github.com/gsamokovarov"><code>@​gsamokovarov</code></a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9850">#9850</a>: Fix missing <code>AllowComments</code> option for <code>Lint/EmptyInPattern</code>. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/cc4b75a826d8c837696ded735e1a0d14ffdc38e9"><code>cc4b75a</code></a> Cut 1.16.1</li> <li><a href="https://github.com/rubocop/rubocop/commit/4bbbc16851ac9046cc7bfd4a75c24bdd32cd9998"><code>4bbbc16</code></a> Update Changelog</li> <li><a href="https://github.com/rubocop/rubocop/commit/ffdd3022e5df5479164916642f707b6a721f450f"><code>ffdd302</code></a> configuration: * seems to bind before `; escape it</li> <li><a href="https://github.com/rubocop/rubocop/commit/a8ba2f97a97b898f4d89f3432065d4e78ebdd926"><code>a8ba2f9</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9856">#9856</a> from MSP-Greg/mingw-ci</li> <li><a href="https://github.com/rubocop/rubocop/commit/721cbf0dde0cf0d177f262ef499667e1d0e77008"><code>721cbf0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9854">#9854</a> from gsamokovarov/omit-parentheses-braced-numblocks</li> <li><a href="https://github.com/rubocop/rubocop/commit/3de2a7b4ab38687b56b6a89b0aec4059bff6bcba"><code>3de2a7b</code></a> Allow braced numeric blocks in Style/MethodCallWithArgsParentheses</li> <li><a href="https://github.com/rubocop/rubocop/commit/6ca1147c71d157481ceef7be31814b53d28a42f2"><code>6ca1147</code></a> Revert "Merge pull request <a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9808">#9808</a> from koic/workaournd_for_mingw_build_error"</li> <li><a href="https://github.com/rubocop/rubocop/commit/73975f96546ffa4d7cdd50d2ecb4b64c8b268fab"><code>73975f9</code></a> Remove redundant code for <code>Style/MultilineWhenThen</code></li> <li><a href="https://github.com/rubocop/rubocop/commit/632e2f15a9684e4c6edf51213efea069e7b34013"><code>632e2f1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9851">#9851</a> from koic/fix_missing_option_for_lint_empty_in_pattern</li> <li><a href="https://github.com/rubocop/rubocop/commit/ba141f5e29018ac053c1660d6b9219c3c4d402dc"><code>ba141f5</code></a> [Fix <a href="https://github-redirect.dependabot.com/rubocop/rubocop/issues/9850">#9850</a>] Fix missing option for <code>Lint/EmptyInPattern</code></li> <li>Additional commits viewable in <a href="https://github.com/rubocop/rubocop/compare/v1.16.0...v1.16.1">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Thanks @pat

$ bin/rspec spec/system/search_spec.rb 

/search
    search doesn't show content that has no image

Finished in 3.62 seconds (files took 0.9671 seconds to load)
1 example, 0 failures

Tests passed on my side. My current rails is 6.1 just to let you know.

@thebravoman Try modifying this method in lib/thinking_sphinx/configuration.rb

  def preload_index(file)
    return if ActiveSupport::Dependencies.loaded.include?(file.split(".rb").first)
    if ActiveRecord::VERSION::MAJOR <= 5
      ActiveSupport::Dependencies.require_or_load file
    else
      load file
    end
  end

I think I've got it working.

Should an index file be require'd by Rails before Sphinx loads it with preload_index()? Would that be a problem?

It loads the indexes twice when config.eager_load = true in config/environments/test.rb

are you using the old-style classic loader, or Zeitwork's new approach?

config/application.rb:    config.autoloader = :classic

how are your index files named? e.g. app/indices/article_index.rb containing the index for the Article model - or a different pattern? The model is app/models/course.rb

$ tree app/indices/
app/indices/
├── course_index.rb

Current book is An Elegant Puzzle by Will Larson (Amazon).

Aiming to read/discuss:

• Chapter 6: Sections 1, 2, 3, 4

MC: @matthewborden Notes: @mcgain

See you 12 pm Tuesday, June 8th @ https://blackmill.co/meet

Ping [email protected] if you want a calendar invite and access to the low-volume Slack beforehand.

6.1 Roles over Rocketships

What is the role of luck in your careers?

Elle says relationships help you make your own luck

Lachlan has never set a career goal, so everything’s luck

Adam says nepotism has guided his. He doesn’t feel exceptional

Richard says he thinks it’s 95% luck, 5% success

Lachlan points out privilege makes a difference

Matt brings up tenure

What are our experiences of tenure?

John has done cycles of 7 years, but done multiple roles in each job

He’s suspicious of people who’ve been somewhere less than a year, but also of people who have been at a place for more than 7 years, since he thinks people will lack flexibility

Lachlan says there’s a theory that when you start a job your actual impact is 0, but your eventual impact is huge. Over time the company gets all your knowledge, and you get no new learning from the company. When this happens, you should change teams to help reset some of that.

Matt is curious about the stable era of a company and people’s development during that period.

Elle has a problem with people who are only after titles, people don’t stay long enough in a place to develop the craft and mastery.

People change jobs to get more money and better titles, also to get diverse stock options.

Companies pay huge costs, onboarding, hiring etc. when they lose people, it makes Elle sad that companies don’t invest more in their current employees

Lachlan wonders if anyone applied the career narrative approach to their own careers?

How do you even explain that to people eloquently? - Matt

Lachlan says teams are immutable, when you change any element, it’s a whole new team. He saw this at his time at Microsoft, with several different bosses changing the way the team, and he, worked

6.2 Running a humane interview process

John has had panel interviews where people have conflicted, a bad sign. On the plus side, he’s had good feedback from the interviewers after the fact

There’s nothing worse than getting to the end of an interview process and finding out they’ve decided they were hiring for the wrong role

The book has a list of things that are important to keep in mind when interviewing. Stuff like “be kind to the candidate”

Lachlan thinks it’s a good list, obvious, but good. Stuff like role descriptions aren’t done often enough

I just love this list - Lachlan

Matt takes a general point of give your candidates time to prepare in an interview

Has anyone had a company express interest?

A couple of different perspectives. Lachlan has been headhunted, which is gratifying. Richard deliberately tries to take an interest in the candidate in an interview, his objective is to learn something new from the candidate

John asks if loose, tech interviews are better than govt style interviews with criteria published in advance to prep for

Matt asks if anyone has been trained to interview people?

Lachlan has trained other people to train people

Richard has had interviewer training, mainly in diversity topics, but also in order to get everyone on the same page with regard to what we’re actually interviewing for. He’s also trained people to take pairing interviews.

Lachlan brings up that the book doesn’t mention that all this process takes up a huge amount of time. Lot’s of unanswered questions around the amount of effort this takes.

John says there’s lots of legal issues with crappy processes, you need to be able to defend yourself if you get sued for this.

Elle adds that rubrics are super important to give candidates a level playing field.

The BeApplied interview process is pretty cool, they focus on mitigating bias

Elle judges companies on the hiring software they use

6.3 Cold Sourcing

Matt questions his cold sourcing advice. He tried it on LinkedIn and it only selected people in his circles. Pretty useless

General noises of agreement

Adam doesn’t have big company clout, so finds hiring really hard. He’s thinking of trying LinkedIn, in the past he’s mostly got people from meetups. Adam assumes he doesn’t see the good people is because there working in other companies.

Lachlan has done a lot of hiring over the years. He once found a super diverse company and tried to poach as many people as possible from it.

Bumps normalize-url from 4.5.0 to 4.5.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/sindresorhus/normalize-url/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps glob-parent from 5.1.1 to 5.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/releases">glob-parent's releases</a>.</em></p> <blockquote> <h2>v5.1.2</h2> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md">glob-parent's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">5.1.2</a> (2021-03-06)</h3> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> <h2><a href="https://www.github.com/gulpjs/glob-parent/compare/v5.1.2...v6.0.0">6.0.0</a> (2021-05-03)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">#34</a>)</li> <li>upgrade scaffold, dropping node <10 support</li> </ul> <h3>Bug Fixes</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">#34</a>) (<a href="https://www.github.com/gulpjs/glob-parent/commit/32f6d52663b7addac38d0dff570d8127edf03f47">32f6d52</a>), closes <a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/32">#32</a></li> </ul> <h3>Miscellaneous Chores</h3> <ul> <li>upgrade scaffold, dropping node <10 support (<a href="https://www.github.com/gulpjs/glob-parent/commit/e83d0c5a411947cf69eb58f36349db80439c606f">e83d0c5</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/gulpjs/glob-parent/commit/eb2c439de448c779b450472e591a2bc9e37e9668"><code>eb2c439</code></a> chore: update changelog</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/12bcb6c45c942e2d05fc1e6ff5402e72555b54b6"><code>12bcb6c</code></a> chore: release 5.1.2</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366"><code>f923116</code></a> fix: eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/0b014a7962789b2d8f2cf0b6311f40667aecd62c"><code>0b014a7</code></a> chore: add JSDoc returns information (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/33">#33</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/2b24ebd64b2a045aa167c825376335555da139fd"><code>2b24ebd</code></a> chore: generate initial changelog</li> <li>See full diff in <a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

I commented out a line in our code that calls ThinkingSphinx::Configuration.instance.indices thinking maybe it could be responsible. No luck. I'll keep working with it.

I also added a puts "ABC" in one of our indexes. It's being loaded twice. I'm going to check the configuration files and see if we're doing anything we shouldn't be in rails 6. Autoload maybe? Hrm.

Oh, and: how are your index files named? e.g. app/indices/article_index.rb containing the index for the Article model - or a different pattern?

Exactly that.