Resolves #9096

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md

1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure cargo test passes.
5. Ensure ./tools/format.js passes without changing files.
6. Ensure ./tools/lint.js passes. -->

It looks like cmd is misinterpreting the unicode escapes in the URL as environment variables.

% generated by deno install %
@deno.exe "run" "file:///Z:/home/liam/code/playground/Magn%C3%BAs/unicode_oh_no.ts" %*
%                                                         ^^^^ According to cmd, an env variable %

I'm seeing Jison failing to import with an Uncaught TypeError

This is on CentOS Linux release 7.5.1804 (Core); tested with and without --no-check. I built Deno from source just now, so this is the newest build. Is this a strictness issue in Deno?

/tmp > deno -V
deno 1.6.3 

/tmp > cat failure.js
import "https://jspm.dev/jison";

/tmp > deno run --reload failure.js
Download https://jspm.dev/jison
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:lex-parser!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/path
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/process
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/fs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]/package.json
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/[email protected]/nodelibs/fs
Download https://jspm.dev/npm:@jspm/[email protected]/_/de9a8dfb.js
Download https://jspm.dev/npm:@jspm/[email protected]/nodelibs/path
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]/_/bad471ea.js
Download https://jspm.dev/npm:amdefine!cjs
Download https://jspm.dev/npm:[email protected]!cjs
error: Uncaught TypeError: Cannot assign to read only property 'name' of function 'function () {
    return Array.prototype[e].apply((this || _global$1)._items, arguments);
  }'
  setMixin[e].name = e;
                   ^
    at https://jspm.dev/npm:[email protected]!cjs:198:20
    at Array.forEach (<anonymous>)
    at https://jspm.dev/npm:[email protected]!cjs:193:62

After a length discussion on community chat, it's clear that the ES spec does not allow bypassing the use strict check, and so Deno will not support such modules.

The only options to use such modules with Deno are:

1. File an Issue against the module (or Fork it) to use strict and re-release it, wait for propagation to JSPM, then import into Deno
2. Use a more "current" module with similar functionality

Closing the issue. Thank you for your time!

Nope, I was wrong. This is the correct behaviour when "use strict" is used (or when using ES modules, of course).

@recursionbane The library you're trying to import is not "use strict" compatible. JSPM does its best to distribute it as an ES module but it obviously can't transform everything correctly.

@nayeemrmn Thank you for the smaller repro. Do you want to open a new issue and close this one?

Smaller repro:

function a() {} a.name = "b"; console.log(a.name);

Expected (behaviour in browsers and Node):

a

Actual:

Uncaught TypeError: Cannot assign to read only property 'name' of function 'function a() {}'
    at <anonymous>:2:24

No idea what's causing this.

I'm seeing Jison failing to import with an Uncaught TypeError

This is on CentOS Linux release 7.5.1804 (Core); tested with and without --no-check. I built Deno from source just now, so this is the newest build. Is this a strictness issue in Deno?

/tmp > deno -V
deno 1.6.3 

/tmp > cat failure.js
import "https://jspm.dev/jison";

/tmp > deno run --reload failure.js
Download https://jspm.dev/jison
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:lex-parser!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/path
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/process
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/core@2/nodelibs/fs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]/package.json
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:@jspm/[email protected]/nodelibs/fs
Download https://jspm.dev/npm:@jspm/[email protected]/_/de9a8dfb.js
Download https://jspm.dev/npm:@jspm/[email protected]/nodelibs/path
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]!cjs
Download https://jspm.dev/npm:[email protected]/_/bad471ea.js
Download https://jspm.dev/npm:amdefine!cjs
Download https://jspm.dev/npm:[email protected]!cjs
error: Uncaught TypeError: Cannot assign to read only property 'name' of function 'function () {
    return Array.prototype[e].apply((this || _global$1)._items, arguments);
  }'
  setMixin[e].name = e;
                   ^
    at https://jspm.dev/npm:[email protected]!cjs:198:20
    at Array.forEach (<anonymous>)
    at https://jspm.dev/npm:[email protected]!cjs:193:62

In #9071 I added DocumentSpan and have noticed there are several cases where equivalent fields are hard-coded. This PR is to replace those fields for DocumentSpan.

I agree that this is a significant hurdle for use-cases that require CentOS 7. I appreciate @hayd for maintaining a Deno binary! It's easy to fall behind the official releases, though.

Is it possible to get an official Deno build for CentOS 7 as part of future releases?

We also need to update dlint in third_party.

Hi. I'm one of the authors of ICU4X which is a Rust implementation of ICU. We're quite young (with just 0.1 released), but we're working on 0.2 now which we hope to provide some basic ECMA-402 compatible functionality (DateTimeFormat, PlrualRules, Locale etc.)

We also have ecma_402 traits and some ICU4C wrappers in Rust that are used by the Fucshia team for now.

Would you consider cooperating with us instead of writing your own bindings?

Link: https://github.com/unicode-org/icu4x and https://crates.io/crates/rust_icu

@00ff0000red

Before I try setting up a repro, do think any of your code specifically targetted TS, as opposed to JS?

I don't think so, but I'm not really sure. The implementation code of the watcher doesn't contain TS specific stuff. So the issue might be caused by another code like module dependency resolution I guess. I will look into it as well.

Added a test, was working locally. Excited to see if it passes the tests here :3

Anyhow, I'm in a little need of assistance regarding adding the feature as unstable.

This example didn't use TLS on the connecting side at all, problem is that the listener crashed when the client unexpectedly closed during a TLS handshake.

Here's the client code:

Deno.connect({hostname, port});
setTimeout(() => Deno.close(), 1000);
``

This crashed the `for await` loop on the TLS listener.

The TLS methods don't have very good error messages. Check issue #6427, older TLS ciphers are not supported by the underlying Rust crate.

Originally reported and fixed in https://github.com/denoland/deno/issues/9008

@magurotuna Canary build same stuff happening again, but with JavaScript instead of TypeScript. Before I try setting up a repro, do think any of your code specifically targetted TS, as opposed to JS?

cc @kitsonk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md

1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure cargo test passes.
5. Ensure ./tools/format.py passes without changing files.
6. Ensure ./tools/lint.py passes. -->

Currently symbols are not properly handled in std/testing/asserts because of the way objects are iterated in equality function.

Example

import { assertEquals } from "https://deno.land/std/testing/asserts.ts"
const foo = Symbol("foo")
Deno.test("symbol1", () => assertEquals({[foo]:"bar"}, {[foo]:"bar"}))
Deno.test("symbol2", () => assertEquals({[foo]:"bar"}, {[Symbol("foo")]:"bar"}))

Expected

running 2 tests
test symbol1 ... ok (3ms)
test symbol2 ... FAILED (2ms)

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out (5ms)

Actual

running 2 tests
test symbol1 ... ok (2ms)
test symbol2 ... ok (1ms)

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (4ms)

In the second test, since symbols are not the same, it should throws.

Today I wanted to implement this library: https://deno.land/x/[email protected] But the problem is that, deno tries recompile whole project every time. After day of test I found that this library imports own deps.ts with own third party libraries for example: https://denopkg.com/chiefbiiko/[email protected]/mod.ts If we go under this address, we are redirected to: https://raw.githubusercontent.com/chiefbiiko/sha1/v1.0.3/mod.ts In $HOME/.cache/deps directory I see denopkg.com and raw.githubusercontent.com directories, so I don't know if this is a deno or denopkg problem.

Steps to reproduce:

1. Create test.ts file
2. Inside put:

import * as test from 'https://raw.githubusercontent.com/chiefbiiko/sha1/v1.0.3/mod.ts'

3. deno run test.ts

Yeah I've got plans to work on the test runner soon.

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md

1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure cargo test passes.
5. Ensure ./tools/format.js passes without changing files.
6. Ensure ./tools/lint.js passes. -->

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.