profile
viewpoint

mroch/ical_builder 8

An iCalendar generator in Ruby, modelled after Jim Weirich's Builder

mroch/bigmoney 6

Represents an amount of money in a particular currency. Backed by BigDecimal, so is safe from float rounding errors.

mroch/baby-connect 5

A library for interacting with Baby Connect

mroch/crestron-alexa-server 3

Simpl# Alexa server

mroch/attachment_fu 2

Treat an ActiveRecord model as a file attachment, storing its patch, size, content type, etc.

mroch/authpipe 2

Ruby library to respond to Courier authpipe authentication requests

mroch/campusbooks 2

A Ruby library for accessing the CampusBooks.com API

mroch/GzipSimplSharp 2

A Crestron Simpl# library to enable gzip decoding in SIMPL+

mroch/interlock 2

Evan Weaver's Rails plugin for maintainable and high-efficiency caching.

mroch/amazonian 1

Building out ASIN with the full Amazon Product Advertising API

pull request commentfacebook/flow

feat(docs): Update README.md

indeed, looks nice. thanks!

iamdarshshah

comment created time in 16 days

delete branch mroch/flow

delete branch : export-D20315043

delete time in a month

delete branch mroch/flow

delete branch : socket

delete time in a month

delete branch mroch/flow

delete branch : circle_mac

delete time in a month

delete branch mroch/flow

delete branch : export-D20313040

delete time in a month

delete branch mroch/flow

delete branch : circle_windows

delete time in a month

issue commentfacebook/flow

Add implementationProvider capability to lsp server

go-to-definition is powered by the definition provider. the implementation provider is a different thing, go-to-implementation. it's for jumping from an interface to classes that implement that interface. you're right that Flow doesn't support that yet.

but if you're trying to jump to the definition of an identifier or an object property or something, that is a different thing. if completion isn't working either then it sounds like something is wrong with the setup in general. what extension are you using? does it have a way of logging the LSP traffic?

thomasf

comment created time in a month

PR closed facebook/flow

[DOCS] remove suppress_comment option from docs CLA Signed

<!-- If this is a change to library defintions, please include links to relevant documentation. If this is a documentation change, please prefix the title with [DOCS].

If this is neither, ensure you opened a discussion issue and link it in the PR description. --> removed suppress_comment options from the option docs, as it is no longer supported from flow-bin v0.127.0

+0 -29

1 comment

1 changed file

Naturalclar

pr closed time in a month

pull request commentfacebook/flow

[DOCS] remove suppress_comment option from docs

Thanks for the PR! In https://github.com/facebook/flow/commit/42de9df5cf38d12b6fc51cb6a50f97b17e053828 we marked it as deprecated instead of removing it, for people still on old versions.

Naturalclar

comment created time in a month

issue commentfacebook/flow

Flow save-state incompatible between OS binaries

our Flow script could pull the appropriate saved state based on merge-base, create .flow.saved_state_file_changes as appropriate, and then launch the server with --saved-state-fetcher=local --lazy.

we should perhaps discuss this in a separate issue, but internally we use a custom build with an additional saved-state fetcher, so we do --saved-state-fetcher=fb (rather, saved_state.fetcher=fb in flowconfig). it gets the mergebase from mercurial, queries a DB to find the most recent saved state from CI (it's generated on a schedule, doing it on every merge is too expensive), downloads it, then asks mercurial for all the files changed since the saved state's commit. you'd replace this: https://github.com/facebook/flow/blob/1a8a22eaf2541febe77856a88f6ad69cde1367a1/src/stubs/saved_state_fb_fetcher.ml

n8downs

comment created time in a month

issue commentfacebook/flow

Flow save-state incompatible between OS binaries

this should be doable. the saved state file format is portable, but not stable. it's just serialized ocaml data structures, so it changes often between versions. the version mismatch you're running into is trying to ensure it's invalidated whenever the binary changes.

these versions are computed by hashing the binary, and obviously the Mac and Linux binaries are different. but since they come from the same commit, compatibility shouldn't be an issue. I think we could fix this by using the commit hash or version number for release builds, and continuing to use the binary's hash for dev builds.

cc @nmote

n8downs

comment created time in a month

pull request commentfacebook/flow

Make `offset` an optional argument for the sized Buffer read/writes

@isker: our policy for targeting node is very... not good. I'd like the node definitions to move to flow-typed so they can be versioned. it'd keep them from interfering if you're working on a web project. and it'd also be great for making PRs like this not have to wait for a flow release.

the main problem then is that you don't get out-of-the-box support for node, but given how inaccurate it is now, I think it's right to trade off a bit of (arguable) usability for correctness.

it's similar but a bit better defined for React... we try to target the latest public release of React, but that can be a problem if you don't keep them both up to date together. moving react to flow-typed has similar benefits.

isker

comment created time in a month

issue commentjanestreet/core

Multiple definitions of unix_initgroups & unix_nice

this looks like it was fixed in 0.13

alfa07

comment created time in 2 months

PR closed facebook/flow

Bump jquery from 3.2.0 to 3.5.0 in /website CLA Signed dependencies javascript

Bumps jquery from 3.2.0 to 3.5.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jquery/jquery/commit/7a0a850f3d41c0412609c1d32b1e602d4afe2f4e"><code>7a0a850</code></a> 3.5.0</li> <li><a href="https://github.com/jquery/jquery/commit/8570a08f6689223aa06ca8cc51d488c6d81d44f9"><code>8570a08</code></a> Release: Update AUTHORS.txt</li> <li><a href="https://github.com/jquery/jquery/commit/da3dd85b63c4e3a6a768132c2a83a1a6eec24840"><code>da3dd85</code></a> Ajax: Do not execute scripts for unsuccessful HTTP responses</li> <li><a href="https://github.com/jquery/jquery/commit/065143c2e93512eb0c82d1b344b71d06eb7cf01c"><code>065143c</code></a> Ajax: Overwrite s.contentType with content-type header value, if any</li> <li><a href="https://github.com/jquery/jquery/commit/1a4f10ddc37c34c6dc3a451ee451b5c6cf367399"><code>1a4f10d</code></a> Tests: Blacklist one focusin test in IE</li> <li><a href="https://github.com/jquery/jquery/commit/9e15d6b469556eccfa607c5ecf53b20c84529125"><code>9e15d6b</code></a> Event: Use only one focusin/out handler per matching window & document</li> <li><a href="https://github.com/jquery/jquery/commit/966a70909019aa09632c87c0002c522fa4a1e30e"><code>966a709</code></a> Manipulation: Skip the select wrapper for <option> outside of IE 9</li> <li><a href="https://github.com/jquery/jquery/commit/1d61fd9407e6fbe82fe55cb0b938307aa0791f77"><code>1d61fd9</code></a> Manipulation: Make jQuery.htmlPrefilter an identity function</li> <li><a href="https://github.com/jquery/jquery/commit/04bf577e2f961c9dde85ddadc77f71bc7bc671cc"><code>04bf577</code></a> Selector: Update Sizzle from 2.3.4 to 2.3.5</li> <li><a href="https://github.com/jquery/jquery/commit/7506c9ca62a2f3ef773e19385918c31e9d62d412"><code>7506c9c</code></a> Build: Resolve Travis config warnings</li> <li>Additional commits viewable in <a href="https://github.com/jquery/jquery/compare/3.2.0...3.5.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mgol">mgol</a>, a new releaser for jquery since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

2 changed files

dependabot[bot]

pr closed time in 2 months

issue closedfacebook/flow

Flow infers incorrectly types when enum is involved and there's an if-else.

<!-- Please fill out this entire template so that we can address your bug report as quickly as possible.

Any bug reports that don't contain instructions to reproduce the issue will be closed. -->

Flow version: 0.122.0

SetArray is a function of type (Array<enumType>) => void. Code snippet: (stringOrEnumValue) => { let newArray; if ( stringOrEnumValue === enumType.value1 || stringOrEnumValue === enumType.value2 ) { newArray = [stringOrEnumValue]; } else { newArray = [enumType.value1, enumType.value2]; } SetArray(newArray);

Expected behavior

In both cases newArray is Array<enumType>, so there shouldn't be a problem.

Actual behavior

Cannot call SetArray with newArray bound to the first parameter because string [1] is incompatible with enum [2].Flow(InferError)

<!-- Please reproduce your issue on flow.org/try so that we can debug it.

Not all issues are reproducible on try-flow because they may require multiple files or specific flowconfig settings. If your bug can only be reproduced under one of these constraints, please make a small github repo that contains a minimal way to reproduce your problem. -->

  • Link to Try-Flow or Github repo:

closed time in 2 months

shardel23

pull request commentfacebook/flow

Add exitCode to ChildProcess

Thanks @isker!

isker

comment created time in 2 months

PR opened facebook/watchman

Update links in state-enter docs

all the links on https://facebook.github.io/watchman/docs/state-enter/ are broken because of the trailing slash.

+4 -4

0 comment

1 changed file

pr created time in 2 months

create barnchmroch/watchman

branch : state-enter

created branch time in 2 months

fork mroch/watchman

Watches files and records, or triggers actions, when they change.

https://facebook.github.io/watchman/

fork in 2 months

issue closedfacebook/flow

Get rid of the location informations in the OCaml AST

<!-- Please fill out this entire template so that we can evaluate your proposal as quickly as possible. --> There is a way to get rid of the location annotation in the ocaml ast? This is the code I am trying

<!-- Explain why you need this change and why this cannot be addressed with Flow's current set of features. -->

let _ =
  let parser = Parser_flow.program in
  let parse_options =
    Some
      Parser_env.
    {
      enums = false;
      esproposal_class_instance_fields = false;
      esproposal_class_static_fields = false;
      esproposal_decorators = false;
      esproposal_export_star_as = false;
      esproposal_optional_chaining = false;
      esproposal_nullish_coalescing = false;
      types = false;
      use_strict = false;
    } in
  let code = "function factorial(n) {
                  if(n==0){return 1} else {n*factorial(n-1)}
              }
              factorial(5)" in
  let (ast, errors) = parser ~parse_options code ~fail:false  in
  ast

closed time in 2 months

Adamk93

issue commentfacebook/flow

Get rid of the location informations in the OCaml AST

can you elaborate on your use case? why don't you want the locations?

the AST is generic, so you could use Flow_polymorphic_ast_mapper to convert a (Loc.t, Loc.t) Flow.Program.t to a (unit, unit) Flow.Program.t. there's (currently) no way to prevent the parser from allocating the Locs in the first place.

something like this:

class loc_eraser =
  object (this)
    inherit [Loc.t, Loc.t, unit, unit] Flow_polymorphic_ast_mapper.mapper
    method on_loc_annot _ = ()
    method on_type_annot _ = ()
  end

let eraser = new loc_eraser in
let (ast : (unit, unit) Flow_ast.Program.t) = eraser#program ast in
Adamk93

comment created time in 2 months

issue commentfacebook/flow

update-suppressions subcommand missing?

ah, you're right. this is an internal command we use to deal with overlapping projects. for example, www.facebook.com and m.facebook.com are in the same codebase but have separate .flowconfigs, except there are some files that are included in both. ./tool remove-comments in www sometimes removes suppressions that are unused in www but still necessary in m, so update-suppressions keeps track of that.

it's still a work in progress that will eventually also replace add-comments --all (so, no UI).

I think we can deprecate remove-comments and release update-suppressions, though it's still pretty experimental. I wonder if it'd be useful to anyone to be worth the effort to generalize?

osmestad

comment created time in 2 months

issue commentfacebook/flow

Flow not working any more in Alpine Docker

we've never maintained official docker images nor musl support (which is used by Alpine instead of glibc IIRC?). can you provide some more details please?

peimansh

comment created time in 2 months

Pull request review commentfacebook/flow

Add exitCode to ChildProcess

 declare class child_process$ChildProcess extends events$EventEmitter {   connected: boolean;   killed: boolean;   pid: number;+  exitCode: number?;

i think the ? is a syntax error. exitCode: number | null instead

isker

comment created time in 2 months

create barnchmroch/linguist

branch : flow

created branch time in 3 months

fork mroch/linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!

fork in 3 months

push eventmroch/flow

Marshall Roch

commit sha 292314b39d8bde8651dc8eca75627330ca36108f

use file URIs in command names Summary: D20249614 added the root path to LSP command names. the tests failed on Windows because of normalization issues. even though this is essentially an opaque token, using a `file://` URI instead of a path makes it consistent, and all other parts of the LSP use file URIs. Reviewed By: vrama628 Differential Revision: D20260352 fbshipit-source-id: 3a2cabea5954a765ab54cad6cd7c1fb6cb5ed282

view details

Marshall Roch

commit sha 9e5ab2c68ee344a7bbc47ceece5ab88ab6564f0d

fix <PLACEHOLDER_PROJECT_URL> in tests on Macs Summary: on macs, the temp dir is in `/var/folders` which is a symlink to `/private/var/folders`. in our expected test output, we want to replace the project root URL with `<PLACEHOLDER_PROJECT_URL>`, but that doesn't work when it's sometimes `file:///var/folders/...` and other times `file:///private/var/folders/...`. so, we `realpath` the temp dir before using it to run the tests. Reviewed By: dsainati1 Differential Revision: D20283512 fbshipit-source-id: 604c1c82877b052919dcb13ab1935e7a4c966d14

view details

Daniel Sainati

commit sha 2c17f52c1cca1bf1fbe427b3ef101c659422ba03

v0.120.0 Reviewed By: mroch Differential Revision: D20283528 fbshipit-source-id: 4539ffdc19ece52e3838fb8003fc8436752e0e84

view details

Nat Mote

commit sha bd62395e7234d165bf08b14326028fef61959899

Rename Saved_state_fetcher.result Summary: It always throws me for a loop when I see a `result` type which shadows `Pervasives.result`. This diff renames `Saved_state_fetcher.result` to avoid that confusion. Reviewed By: gkz Differential Revision: D20231452 fbshipit-source-id: b2546dda4091f1d41a8a40fc4314c6213d8dc08f

view details

Pieter Vanderwerff

commit sha 3254a8479eb2b6a6cdcac10b987c5838693bf5cd

Merge pattern interation logic Reviewed By: panagosg7 Differential Revision: D20264298 fbshipit-source-id: f507352b3ca8dbb972bc9b2558143d2ecf7543c5

view details

Daniel Sainati

commit sha e9773c8355c7f9534fe594a75eea720399e5ac9a

v0.120.1 Reviewed By: dsainati1 Differential Revision: D20290152 fbshipit-source-id: 09806e5e77653a04ee14f79d10cbcded2518c9bd

view details

Hans Halverson

commit sha d04ead2c6d7ef7ea6b1a83cdf31828ed42a3d4ad

Intern comments in blocks Summary: Interns leading and trailing comments around blocks with the following form: ``` /* leading */ { const x = 1; } /* trailing */ ``` This change does not attach any inner comments, e.g. comments that trail all statements in the block: ``` { const x = 1; /* Trailing all statements */ } ``` This can be changed in the future when we settle how to handle these comments, but this diff sets up the basic structure for interning comments in blocks. Note that there are still issues with trailing comments leading for the next statement, but this is a general problem across all comment interning at the moment. Reviewed By: pieterv Differential Revision: D20201572 fbshipit-source-id: 4f2d7b0d6dcc0e14231625bf150bf228d833608a

view details

Hans Halverson

commit sha 8f931b8cc0c082435b5630362bd5be56b51f7452

Intern comments in variable declaration nodes Summary: Interns leading and trailing comments around variable declarations. Variable declarations can always have leading comments before the initial `var`/`let`/`const`, and also may have trailing comments after the closing semicolon. For example: ``` /* L decl */ var /* L id */ x /* T id */ = /* L num */ 1 /* T num */ ; /* T decl */ ``` However variable declarations as the init of a for loop cannot have trailing comments after the semicolon, as those comments should be interpreted as leading comments of the test. Variable declarations on the left hand side of for in or for of statements also cannot have trailing comments as comments directly before the `of`/`in` will be trailing for the var decl's pattern, and comments directly after the `of`/`in` will be leading for the right hand side. To correctly grab trailing comments when parsing I had to lift the creation of the `VariableDeclaration` out of utilities in the declaration parser, and instead move it to every call site, fetching trailing comments after the semicolon is consumed if appropriate. Note that there are still issues with trailing comments leading for the next statement, but this is a general problem across all comment interning at the moment. Reviewed By: pieterv Differential Revision: D20229729 fbshipit-source-id: 6bbe97b7642c96ea3adcb020cd5505ea199a55ad

view details

Daniel Sainati

commit sha e5262d703a20dc640d2a9ce718c4a689429db69f

[Errors] Don't replace a speculation error's location with its singular branch's location Summary: Previously, when formatting a speculation error for printing, if we only had a single branch to the error, we'd replace the overall error's location with that of the branch. This is a bad idea. Not only does it claim that the primary location's error is positioned elsewhere than it actually is, but when checking the new `positioning.js` test file, we'd generate the following error: ``` Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ tests/error_printing/positioning.js:8:18 number literal 3 [1] is incompatible with empty [2] in type argument T of the first argument. 8│ $fragmentRefs: $PropertyType<T, '$refType'>, 9│ }; 10│ 11│ type X = $NonMaybeType<{| [1] 12│ +$refType: 3, : [2] 18│ (<T: {+$refType: empty, ...}>(?T) => ?T) & 19│ (<TRef: 3, T: {+$refType: TRef, ...}>(T) => $FragmentRef<T>), 20│ >; 21│ 22│ type Props = { 23│ selectedValue: X, 24│ }; 25│ 26│ declare var x: $RelayProps<React$ElementConfig<(Props) => React.Node>, {}>; ``` One might expect, quite reasonably, that position `[1]` might be the primary location, or the `$PropertyType<T, '$refType'>` which is highlighted red on the CLI. In fact however, the primary location is on line 22, which only appears in the error by proximity to an included location. If the primary location were in a different file, it wouldn't appear in the error message at all. This is obviously terrible, so instead we don't replace the error's location with it's branch's, and thus correctly display the primary location. Reviewed By: panagosg7 Differential Revision: D20108047 fbshipit-source-id: 1044008fbf28746b8af424e3c85d73cedc71228c

view details

Daniel Sainati

commit sha ac1b7c45bf6a70e3a92eb7bab64476d7131bfb13

[Errors] when printing errors, the primary location should always be printed first Summary: Previously, the error printing logic distinguished between a primary location and a "root location", which was decided based on some arcane logic that has little to do with the actual location of the error. We need to ensure that the first location printed in an error is always the primary so users know where to add suppressions, so this changes error printing to always print the primary location first, and ignore the "root loc". Reviewed By: panagosg7 Differential Revision: D19827425 fbshipit-source-id: 45b2263f893c522fa96defd9c0028b539d7ea8f3

view details

Marshall Roch

commit sha 35f40523205c1a40e836119e938faca4c25b9788

don't mark unparsed .js.flow files as checked Summary: parsed `.js.flow` files are not automatically considered "checked", so don't consider unparsed `.js.flow` files as such either. as far as I can tell, this doesn't really make a difference since we only check parsed files, but I want to kill `Docblock.isDeclarationFile`. Reviewed By: samwgoldman Differential Revision: D20069817 fbshipit-source-id: ae9d654c0f6bd47fbc18eef5ee3deb1cb132328c

view details

Marshall Roch

commit sha cde20899624d8ac01722ccbb7a4398a089b3c43f

unit test for parse errors in .js.flow without @flow Summary: adds a test for our current behavior: | | parse | check | | .js w/ flow | √ | √ | | .js w/o flow | x | x | | .js.flow w/ flow | √ | √ | | .js.flow w/o flow | √ | x | Reviewed By: samwgoldman Differential Revision: D20069748 fbshipit-source-id: 0833661fd11c25ddc303b49eba0db7ae1a30888a

view details

Marshall Roch

commit sha 964750ad9baa0e93ef52a4df04cb36d01f39dfbe

stop parsing .flow files without @flow Summary: right now, we parse but don't check `.js.flow` files without `flow`. this is inconsistent, because we treat it as a "non flow" file, but still report parse errors. it can cause problems if you have an invalid non-@flow `.js` file and follow our recommended "build" strategy of `cp *.js *.js.flow`. | | parse | check | | .js w/ flow | √ | √ | | .js w/o flow | x | x | | .js.flow w/ flow | √ | √ | | .js.flow w/o flow | √ -> x | x | Reviewed By: samwgoldman Differential Revision: D18768614 fbshipit-source-id: 9c0ba773f3c667312e790d3f03ee9422bb27b996

view details

Marshall Roch

commit sha e2ce0976291f57d765850e0277e713103edce9c7

remove Docblock.isDeclarationFile Summary: it's unused now. it was also strange because it wasn't actually part of the docblock, it was determined by the filename. Reviewed By: gkz Differential Revision: D20070778 fbshipit-source-id: 58498bc200fd05dd6bbc2940c4bfa1562bfe176a

view details

Hans Halverson

commit sha 1ec8c0f01249a32b3fe2972d67d35da61ab5786c

Fix attachment of trailing comments on return statements Summary: Fixes attachment of trailing comments for `return`. - `return; /* comment */` is a comment trailing the return statement - `return /* comment1 */ exp /* comment2 */;` are leading/trailing the expression, not the return statement - `return /* comment */;` is a comment internal to the statement, which is ignored for now as internal attachment has not yet been implemented Reviewed By: mroch Differential Revision: D20231075 fbshipit-source-id: 06996f25fbd35cef3b00b2e3624c161b9ecb7279

view details

Nat Mote

commit sha 79cfa21f343ef79700060d8e1bc7bc2e4f22c46e

Add an error variant to `Saved_state_fetcher.fetch_result` Summary: Previously, this variant type did not distinguish between the case where we tried to find saved state and failed (e.g. local fetcher) and the case where we simply did not bother to look for saved state (e.g. the dummy fetcher). This leads to an inconsistency where a failure to find the saved state and a failure to read the saved state are handled in completely different ways. This is illustrated by the test added in D20252511. This diff adds the additional variant needed to distinguish between failing to find saved state and choosing not to look for saved state. For now, they are handled identically, but future diffs will change that. Reviewed By: mroch Differential Revision: D20236637 fbshipit-source-id: 5da544d66c3982af95ea568a09754d615a640ff0

view details

Nat Mote

commit sha e3b6b41edffc8f0fb53ef03682bf6ab132e47976

Add test for --saved-state-no-fallback flag Summary: This test illustrates the issue described in D20236637. We fail to distinguish between "could not find saved state" and "did not look for saved state," so even if the `--saved-state-no-fallback` flag is provided, Flow ignores it and initializes normally if saved state cannot be found. Reviewed By: mroch Differential Revision: D20252511 fbshipit-source-id: e6521e877be83bacc8b4e5078fc998a7fa59ebb2

view details

Nat Mote

commit sha dddbaeee3e40ec4275d10d59ba93deb2e7101e74

Return `Saved_state_error` if we encounter an error while finding the saved state Summary: Natural next step after D20236637 Reviewed By: mroch Differential Revision: D20254587 fbshipit-source-id: 15a7e284c4960a384d9d5c950984e52802611c4c

view details

Nat Mote

commit sha 9ae62d10dbab28ddc219e95e274a242d7364f9a5

Split out `saved_state` directory into multiple subdirectories Reviewed By: mroch Differential Revision: D20265351 fbshipit-source-id: 5faba0e55b4d021fed05d0f6dcaa2833967d107b

view details

Nat Mote

commit sha 08d58c98c02ac97f126fb0e1160c71bf83d8a7ea

Replace `include struct` pattern with `mli` files Summary: It looks like the intent of this pattern was to constrain the module to a particular interface. Fortunately we can accomplish the same thing by simply `include`ing the interface that we want in an `mli` file. Reviewed By: mroch Differential Revision: D20268104 fbshipit-source-id: 46ad40721b2738b4fee025c9b979f08dd7fec1d9

view details

push time in 3 months

push eventflowtype/flow-bin

Marshall Roch

commit sha 9207073822d7e129fe424af5c58a24f57bd72966

`make push` should not fail if the tag already exists

view details

push time in 3 months

Pull request review commentfacebook/flow

Add HeadersInit and signal to Fetch

 declare class WaveShaperNode extends AudioNode {  // this part of spec is not finished yet, apparently // https://stackoverflow.com/questions/35296664/can-fetch-get-object-as-headers-type HeadersInit = Headers | { [key: string]: string, ... };+type HeadersInit = Headers | string[][] | { [key: string]: string, ... };

changing this to Array<[string, string]> per

Screen Shot 2020-05-14 at 9 44 04 AM

goodmind

comment created time in 3 months

pull request commentfacebook/flow

Fix for recent version of OCaml, js_of_ocaml, lwt, core_kernel

thanks for this! we have a lot of different environments to get this to build in so it might take a bit of time to merge this, or I might have to land it in a couple pieces.

hhugo

comment created time in 3 months

more