profile
viewpoint
Mostafa Amer mosamer Careem Berlin, Germany

mosamer/Action 1

Abstracts actions to be performed in RxSwift.

mosamer/ALPickerView 1

Multiple row selection in UIPickerView

mosamer/Arabic-Converter-From-and-To-Arabic-Presentation-Forms-B 1

Objective C Class to convert from and to Arabic Presentation Forms B

mosamer/DYRateView 1

A custom iOS rate view control similar to the one used in Apple's App Store.

mosamer/EKStreamView 1

A scrolling view having many cells in different heights and in columns for iOS, just like Pinterest

mosamer/JCMSegmentPageController 1

Custom container view controller for iOS5 that functions similarly to a UITabBarController, but the way to switch tabs is through a UISegmentedControl on top

mosamer/AvatarUpdater 0

Yet another demo project

mosamer/calloutview 0

A lightweight callout view class for iOS mimicking UICalloutView.

mosamer/CHSlideController 0

A View controller that contains 1 static non moving ViewController and 1 swipeable ViewController that can cover the static one.

issue openedtuist/XcodeProj

Command PhaseScriptExecution failed with a nonzero exit code

Hi All,

I am getting Command PhaseScriptExecution failed with a nonzero exit code issue while trying to archive the application for build. I have tried keychain lock-unlock process and other possible solutions but nothing working in my case.

I am macOS big Sur 11.0.1 version but the issue was also there before this update.

Updated xcode also to 12.2 version

Please help

**uilding file list ... done App.framework/ App.framework/App App.framework/Info.plist App.framework/flutter_assets/ App.framework/flutter_assets/AssetManifest.json App.framework/flutter_assets/FontManifest.json App.framework/flutter_assets/NOTICES App.framework/flutter_assets/fonts/ App.framework/flutter_assets/fonts/MaterialIcons-Regular.otf App.framework/flutter_assets/images/ App.framework/flutter_assets/images/logoWhite.png App.framework/flutter_assets/packages/ App.framework/flutter_assets/packages/cupertino_icons/ App.framework/flutter_assets/packages/cupertino_icons/assets/ App.framework/flutter_assets/packages/cupertino_icons/assets/CupertinoIcons.ttf

sent 7128957 bytes received 238 bytes 14258390.00 bytes/sec total size is 7127228 speedup is 1.00 building file list ... done Flutter.framework/ Flutter.framework/Flutter Flutter.framework/Info.plist Flutter.framework/icudtl.dat Flutter.framework/_CodeSignature/ Flutter.framework/_CodeSignature/CodeResources

sent 435560819 bytes received 120 bytes 124445982.57 bytes/sec total size is 435507242 speedup is 1.00 /Users/apple/Library/Developer/Xcode/DerivedData/Runner-bxflrmmaoovbpmcxatshzlmgiqcv/Build/Intermediates.noindex/ArchiveIntermediates/Runner/InstallationBuildProductsLocation/Applications/Runner.app/Frameworks/App.framework/App: errSecInternalComponent Command PhaseScriptExecution failed with a nonzero exit code **

created time in 5 hours

pull request commentapple/swift-package-manager

[SR-12851] System-wide cache of SwiftPM dependencies

Determining if a git repository exists by checking if ".git" exists does't work when we don't do a checkout. Now we are using git rev-parse --is-inside-git-dir --is-inside-work-tree which works in both cases.

tgymnich

comment created time in 9 hours

PR opened apple/swift-package-manager

Update the CLanguageStandard and CXXLanguageStandard enums

Generate the enum cases by preprocessing the LangStandards.def file.

Motivation:

Follow-up to: apple/swift-package-manager#2716

Modifications:

  • Add enum cases for C17/C18, C2x, and C++20.
  • Deprecate enum cases for C++1z.
  • Remove enum cases for C++2a (which aren't in release/5.3 yet).
  • Update the raw string value for C94 (bug fix).

Result:

  • New documentation comments.
  • New cases for the latest C/C++ language standards.
  • The order of existing cases is preserved.
+90 -30

0 comment

1 changed file

pr created time in 9 hours

issue openedRxSwiftCommunity/RxSwiftExt

Support mapToMany for Single

Name and description

Support mapMany for Single

Motivation for inclusion

It is very annoying to convert to Observable to be able to use mapMany and then to convert it to single.

Example of use

mySingle.mapMany(...)

In place of

mySingle.asObservable()
               .mapMany(...)
               .asSingle()

created time in 16 hours

issue closedRxSwiftCommunity/RxSwiftExt

mapToVoid

Name and description

Add mapToVoid to map any observable type to void.

Motivation for inclusion

I am tired to see map { _ in } in the code

Example of use

myObserver.mapToVoid() in place of myObserver.map { _ in }

Code

public extension ObservableType { 
    func mapToVoid() -> Observable<Void> {
        return map { _ in }
    }
}

closed time in 16 hours

asam139

issue commentRxSwiftCommunity/RxSwiftExt

mapToVoid

Ok, you've convinced me 🤣, I will add to my own extensions.

asam139

comment created time in 16 hours

pull request commentapple/swift-package-manager

[PackageEditor] Mechanical editing functionality for package manifests

@swift-ci please smoke test

owenv

comment created time in a day

push eventRxSwiftCommunity/rxswiftcommunity.github.io

Ash Furrow (Via Travis)

commit sha fc8de76622b7b71ed513b102ef79469a667e4026

Site updated to c6b898d

view details

push time in a day

pull request commentRxSwiftCommunity/RxSwiftExt

Add FlatScan(First/Latest) operators

Looks like Github automatically closed #257 when renaming master branch to main, so I'm reopening it here 😉

jegnux

comment created time in 2 days

PR opened RxSwiftCommunity/RxSwiftExt

Reviewers
Add FlatScan(First/Latest) operators

Hi community!

Here's a new Rx operator I made for a specific use case, but I've seen myself using it for more use cases so I guess it was a good candidate for this repository.

Basically, flatScan is a scan operator that returns an Observable<T> instead of just T and flatten the result. It's declined in flatScanFirst and flatScanLatest versions that works the same as their flatMap counterparts.

The most useful use case is when working with paginated content when you want to make a new API request with an "offset" and append your new results to current local results. Something like that:

loadMoreTrigger
    .withLatestFrom(searchQuery)
    .flatScan(SearchResults()) { previous, query in
        searchResults(
            for: query,
            start: previous.elements.count,
            count: 20
        )
        .map(previous.merging)
    }

I know I should have discussed this operator in an issue first but the code was already existing in my project but without unit tests (😱) and working on a PR directly encouraged me to write unit tests for it. If you feel like this operator doesn't fit in this repository I wouldn't mind closing this PR. At least I'll be able to add the tests to my project 😇

PS: In the second commit I fixed swift lint issues unrelated to the flatScan operator. Feel free to focus your review on the first commit 7332d10 😉

+525 -91

0 comment

29 changed files

pr created time in 2 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

Ash Furrow (Via Travis)

commit sha a69c401aee01ea78fa22eb3d0841ea480f811c11

Site updated to c6b898d

view details

push time in 2 days

PR opened apple/swift-package-manager

Reviewers
Fix build on Windows: add dependencies in CMake script

Motivation:

A build error sometimes occurs when building SwiftPM with CMake, because the dependencies on Basics target are missing for some other targets. The error might happen or not, depending on the order in which CMake builds the targets.

Modifications:

This change adds the missing dependencies.

Result:

The CMake build succeeds after this change.

+15 -3

0 comment

12 changed files

pr created time in 2 days

PR opened danger/swift

Remove deprecated action API
+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchdanger/swift

branch : f-meloni-patch-6

created branch time in 2 days

push eventdanger/swift

Franco Meloni

commit sha d4c755eabf7af26ff69bff23eb62e6bd6684b51f

Version 3.7.0

view details

Franco Meloni

commit sha 2aadbd9d1f3ecec9e3bfc46cada0e12e85dabe70

Unhide dependencies

view details

push time in 2 days

created tagdanger/swift

tag3.7.0

⚠️ Stop saying "you forgot to …" in code review

created time in 2 days

created tagapple/swift-package-manager

tagswift-DEVELOPMENT-SNAPSHOT-2020-11-21-a

The Package Manager for the Swift Programming Language

created time in 3 days

pull request commenttuist/XcodeProj

[Fix] JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Codecov Report

Merging #593 (de55326) into main (82bf5ef) will decrease coverage by 0.02%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   84.24%   84.21%   -0.03%     
==========================================
  Files         154      154              
  Lines        8663     8668       +5     
==========================================
+ Hits         7298     7300       +2     
- Misses       1365     1368       +3     
Impacted Files Coverage Δ
.../Extensions/KeyedDecodingContainer+Additions.swift 80.95% <57.14%> (-12.80%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82bf5ef...6adefa8. Read the comment docs.

tjwio

comment created time in 3 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

Ash Furrow (Via Travis)

commit sha 893ac221ae25e4fdb4322995ddd9f7c9c0166c8a

Site updated to c6b898d

view details

push time in 3 days

PR opened tuist/XcodeProj

[Fix] JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Resolves https://github.com/tuist/xcodeproj/issues/592

Short description 📝

This PR should fix decoding defaultConfigurationIsVisible (and other booleans) of multiple types of encoding (ie. plist encoded which encodes to a proper boolean or a normal pbxproj which encodes into a string).

Solution 📦

Try decoding it as a string like before, then an int, then a boolean and finally return nil if it cannot. Notice each try is marked with try? so it doesn't actually throw in case there is a type mismatch.

Implementation 👩‍💻👨‍💻

  • [X] Fix decoder process for booleans
  • [X] Test out in both pbxproj formats
+7 -2

0 comment

1 changed file

pr created time in 3 days

issue openedtuist/XcodeProj

JSON decoder not properly decoding `defaultConfigurationIsVisible` in some projects

Context 🕵️‍♀️

Some of our projects generated via BUCK have a plist encoding so the property looks like:

<key>defaultConfigurationIsVisible</key>
<false/>

instead of something like:

defaultConfigurationIsVisible = 0;

This causes the JSON encoder to encode the property as a boolean instead of a string, so the JSON decoder fails to decode that boolean properly since it thinks it's a string

What 🌱

This error is thrown when trying to decode defaultConfigurationIsVisible

error: typeMismatch(Swift.String, Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "defaultConfigurationIsVisible", intValue: nil)], debugDescription: "Expected to decode String but found a number instead.", underlyingError: nil))

Proposal 🎉

Opening pr (will update soon)

created time in 3 days

pull request commentapple/swift-package-manager

[NFC] Use extended delimiters for regex strings

@swift-ci please smoke test

WowbaggersLiquidLunch

comment created time in 3 days

push eventdanger/swift

Franco Meloni

commit sha 18f083c9a390a96ea5a6a6aad01849a67468555a

Use Swift 5.3 on Linux 5.3 machine

view details

Franco Meloni

commit sha db760765b07e49e90d74cbfbb9c6b627dc577c58

Try 5.3.1

view details

Franco Meloni

commit sha a511bd0d62c5a5e53d6b6f323a332e0ce3442e7e

Merge branch 'master' of github.com:danger/swift into f-meloni-patch-5

view details

Franco Meloni

commit sha 33147b4e2285474e54312381840fc8b0fb267dda

Merge pull request #389 from danger/f-meloni-patch-5 Use Swift 5.3 on Linux 5.3 machine

view details

push time in 3 days

PR merged danger/swift

Use Swift 5.3 on Linux 5.3 machine
+2 -2

0 comment

1 changed file

f-meloni

pr closed time in 3 days

Pull request review commentapple/swift-package-manager

[NFC] Use extended delimiters for regex strings

 public struct ToolsVersion: Equatable, Hashable, Codable {     /// Regex pattern to parse tools version. The format is SemVer 2.0 with an     /// addition that specifying the patch version is optional.     static let toolsVersionRegex = try! NSRegularExpression(pattern: "^" +-        "(\\d+)\\.(\\d+)(?:\\.(\\d+))?" ++        #"(\d+)\.(\d+)(?:\.(\d+))?"# +         "(" +-            "\\-[A-Za-z\\d]+(?:\\.[A-Za-z\\d]+)*" ++            #"\-[A-Za-z\d]+(?:\.[A-Za-z\d]+)*"# +         ")?" +         "(" +-            "\\+[A-Za-z\\d]+(?:\\.[A-Za-z\\d]+)*" ++            #"\+[A-Za-z\d]+(?:\.[A-Za-z\d]+)*"# +         ")?$", options: [])

This is a good point. I originally thought about using a multi-line literal, but didn't do it because I forgot about using .allowCommentsAndWhitespace to retain the "scoping". Thanks for reminding me about it!

I changed the pattern to using a multi-line literal in commit 1e24af8a3d30409afcc5a1aac6050ed7b955f1da, with a bit of stylistic differences.

WowbaggersLiquidLunch

comment created time in 3 days

push eventdanger/swift

Lihsuan CHEN

commit sha f6507296ceee06037642b85897a2e8ea6a51c619

Add groupId property for group milestones.

view details

Lihsuan CHEN

commit sha 33a243d8bc857158f3ba3be683acece7a94adb69

Update CHANGELOG.

view details

Lihsuan CHEN

commit sha 0f613e67814aca4cee6655cd9b919b5e216aa534

Add additional test for `Milestone` model, add quick documentation and update the CHANGELOG to indicate a breaking change.

view details

Lihsuan CHEN

commit sha 1c7a3e07557239e4da4a18b15bc142e258cde2c1

Add PR information.

view details

Lihsuan CHEN

commit sha beb687959413f6c5b4ab04533c8ca35d7fb21285

Fix for the danger recommandations.

view details

Lihsuan CHEN

commit sha 1e9d865e9bbfd6e099b0d276c1e1c3b51495f981

Make tests throws

view details

Lihsuan CHEN

commit sha f8c5cbe626a860e99148e88c6bafa7c11f4e0858

Combine project_id and group_id to ParentIdentifier. Adjust the related tests.

view details

Lihsuan CHEN

commit sha 3c8b9280c32ca7fd29e5b8b43d5e357ec2f17fa7

Update CHANGELOG.

view details

Lihsuan CHEN

commit sha ef7e00c0d63ab4e5379649ff3605f8c60a5f8cb4

Fix typo.

view details

Abel

commit sha 6a05d5cec48a730c27c38539a1c474943f34b96c

Made BitbucketClout.User accountId and nickname optional

view details

Abel

commit sha a6d996ab2f2c433dd6e4581299ab98cee26cfd50

Updated CHANGELOG

view details

Franco Meloni

commit sha a2b3fd6ef0d0657f0852dadaf135be571045b1fe

Merge branch 'master' into hotfix/group_milestone

view details

Franco Meloni

commit sha b46fed8495c26eeaa6b39590fe8a16114d92b732

Merge pull request #388 from abel3cl/bitbucket_cloud_user_without_account_id_and_nickname Fixing Bitbucket cloud optional user properties issue

view details

Franco Meloni

commit sha 21f6b5b4c23eab2c72ec9c1fcfb084c881293a9c

Merge pull request #385 from vc7/hotfix/group_milestone Introduce Group Milestone for GitLab and fix related parsing error.

view details

Franco Meloni

commit sha c9a55382cd83f15ce27c00cae17b448f07f3f7ad

Add fail text to XCFail

view details

Franco Meloni

commit sha 2479b2dfbe8714e3b0741d6ff9e4543c24baa3b5

Remove trailing comma

view details

Franco Meloni

commit sha 795e7e4c91c1d6c70c830bb5d40073427dc38616

Remove swiftlint warnings in DangerFileGeneratorTests

view details

Franco Meloni

commit sha ca9d1612ff89393ea00606b99cfed8d7bea969be

Exclude trailing comma swiftlint rule

view details

Franco Meloni

commit sha 2873bbc6038f02f47e675242d23c93dc8acff0a2

Fix BitBucketCloudTests.swift swiftlint warnings

view details

Franco Meloni

commit sha 377cfaf8adf491252fc4b1ab893e57562e38e523

Remove Swiftlint Warnings from GitHub tests

view details

push time in 4 days

pull request commentapple/swift-package-manager

Add package registry implementation

@neonichu @abertelrud @tomerd @yim-lee I just finished rebasing this branch to incorporate the changes from #3057 and #3040. Please take another look when you have a chance. Thanks!

mattt

comment created time in 4 days

pull request commentapple/swift-package-manager

Add package registry implementation

@swift-ci please smoke test

mattt

comment created time in 4 days

Pull request review commentapple/swift-package-manager

[NFC] Use extended delimiters for regex strings

 public struct ToolsVersion: Equatable, Hashable, Codable {     /// Regex pattern to parse tools version. The format is SemVer 2.0 with an     /// addition that specifying the patch version is optional.     static let toolsVersionRegex = try! NSRegularExpression(pattern: "^" +-        "(\\d+)\\.(\\d+)(?:\\.(\\d+))?" ++        #"(\d+)\.(\d+)(?:\.(\d+))?"# +         "(" +-            "\\-[A-Za-z\\d]+(?:\\.[A-Za-z\\d]+)*" ++            #"\-[A-Za-z\d]+(?:\.[A-Za-z\d]+)*"# +         ")?" +         "(" +-            "\\+[A-Za-z\\d]+(?:\\.[A-Za-z\\d]+)*" ++            #"\+[A-Za-z\d]+(?:\.[A-Za-z\d]+)*"# +         ")?$", options: [])

If we're going through the exercise of rewriting this, any reason not use a multi-line, raw string literal with the . allowCommentsAndWhitespace option?

static let toolsVersionRegex = try! NSRegularExpression(pattern: #
^(\d+)\.(\d+)(?:\.(\d+))?
(
  \-[A-Za-z\d]+(?:\.[A-Za-z\d]+)*
)?
(
  \+[A-Za-z\d]+(?:\.[A-Za-z\d]+)*
)?$
"""#, options: [.allowCommentsAndWhitespace])
WowbaggersLiquidLunch

comment created time in 4 days

pull request commentapple/swift-package-manager

[NFC] Use extended delimiters for regex strings

@swift-ci please smoke test

WowbaggersLiquidLunch

comment created time in 4 days

more