profile
viewpoint
Marco Franssen marcofranssen @philips-software Geleen, Netherlands https://www.marcofranssen.nl Coding architect | Blockchain | IOT | Docker | Kubernetes | Machine Learning | Microservices | Event sourcing | CQRS

marcofranssen/packer.io-webserver-example 5

Full example for these blogposts http://marcofranssen.nl/packer-io-machine-building-and-provisioning-part-1/ & http://marcofranssen.nl/packer-io-machine-building-and-provisioning-part-2/

marcofranssen/gothermostat 4

Interact with you nest Thermostat

marcofranssen/ncqrs 3

Ncqrs Framework - The CQRS Framework for .NET

marcofranssen/Kinect 2

Kinect Application Framework including some demo apps

marcofranssen/gekko 1

A bitcoin trading bot written in node - https://gekko.wizb.it/

marcofranssen/gocryptotrader 1

A cryptocurrency trading bot and framework supporting multiple exchanges written in Golang.

marcofranssen/grunt-dotnet-mspec 1

Grunt plugin to run Machine.Specification tests

marcofranssen/aws-auth 0

Shell functions to handle secrets stored in pass, LastPass or Keychain for AWS

marcofranssen/babel 0

🐠 Babel is a compiler for writing next generation JavaScript.

marcofranssen/cointop 0

The fastest and most interactive terminal based UI application for tracking cryptocurrencies

push eventphilips-labs/garo

Marco Franssen

commit sha 39be7d6b194fdb277b87fa8e3350bae682e994ef

Add vscode recommended extensions

view details

push time in 3 days

PR opened philips-labs/garo

Reviewers
Feature/docs

In this PR I have added an overall DRAFT architectural overview describing a goal we can work towards. This should also help others to be able to contribute to the implementation.

+554 -1

0 comment

11 changed files

pr created time in 3 days

push eventphilips-labs/garo

Marco Franssen

commit sha da2a99623e0049b83467c1fa93c745ec09444f8f

Add diagrams visualizing the intended architecture

view details

Marco Franssen

commit sha b413ef07c7961e1ac3812a4935e400aca24c0bee

Write DRAFT overall target architecture document

view details

Marco Franssen

commit sha ea51f7f74663e2ba855303ce5a9b2e4fe212c2cd

Add vscode recommended extensions

view details

push time in 3 days

create barnchphilips-labs/garo

branch : feature/docs

created branch time in 3 days

issue commentgoogle/go-github

Why are all the responses using pointers

Thanks for explaining.

marcofranssen

comment created time in 3 days

issue commentgoogle/go-github

Why are all the responses using pointers

I get the nil checking, what I don't understand is why to apply this on string and []*SomeStruct. In those cases I think they should be removed. For integers it is debatable as well I think as also there, why would I want to check for nil in those cases?

I Would do something like this. That simplifies codebase and consumption of it a lot.

type SomeType struct {
     MyOtherObject *OtherType
     Amount               Int64
     Text                      string
     Collection           []CollectionItem
}

An empty string can then be treated the same as nil and 0 can also be treated similar. No more nil checks there. And I think in the case of slices it doesn't add value as well. Either there is an element in the slice or it is not. Why would you want to have nil elements in the slice?

Only the case were another struct like MyOtherObject is used I could think of user a pointer.

Am I completely missing out on something?

marcofranssen

comment created time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 10adf697140d3bdd2857b482b7e8d77d758c89ff

Fix fetching single workflow to work for any given repo

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 10adf697140d3bdd2857b482b7e8d77d758c89ff

Fix fetching single workflow to work for any given repo

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 10adf697140d3bdd2857b482b7e8d77d758c89ff

Fix fetching single workflow to work for any given repo

view details

Marco Franssen

commit sha b16876347df0d408b2c3f05890d2fb3760c3ec5a

Allow to run workflow using repository dispatch

view details

Marco Franssen

commit sha 05515a91ba6369167f7795643502be80c9099d22

Add Dispatch repository request

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha e453287926cc16ddc70ae3cf7ac01a7388848504

Add Dispatch repository request

view details

Marco Franssen

commit sha c52dc0daaef63762838856a4b95a89b49a461f25

Fix fetching single workflow to work for any given repo

view details

push time in 4 days

push eventphilips-labs/garo

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 1d6db1670d09d4e7020d8e32641599877f735298

Allow to run workflow using repository dispatch

view details

push time in 4 days

create barnchphilips-labs/garo

branch : feature/trigger-workflow-manual

created branch time in 4 days

delete branch philips-labs/garo

delete branch : feature/filter-repos

delete time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 5435d9cabfdf40320be4b3ede78d8ae0c5bada7c

Upgrade google/go-github from v17 to v29 to include some of the actions apis

view details

Marco Franssen

commit sha 84782207c1a733262dfddf80df70fdd8de94f10a

Use named variables for clarity in usage

view details

Marco Franssen

commit sha 897b72b71c5b2a3e59184bffb2be3941dc83fa12

Utilize the get/list workflows APIs from go-github v29

view details

Marco Franssen

commit sha 59e6d5052a9b8b4cb3313f3161b054f8b445b06a

Merge pull request #6 from philips-labs/feature/actions-workflow Feature/actions workflow

view details

Marco Franssen

commit sha 19be5ddca2159dbee065ba0c660d8925f18b4ace

Implement repository filtering

view details

Marco Franssen

commit sha faebc8f50979398e97d2da9aa2a1ec70d3b5a5bf

Refactor filters to some predefined ones

view details

Marco Franssen

commit sha 01c3b74b92bd5616b947dea8db06c93ebdfd8773

Document how to run tests in VSCode

view details

push time in 4 days

PR merged philips-labs/garo

Feature/filter repos

Adds some filtering capability on repositories to reduce the amount of printed repositories for testing purposes.

+110 -13

1 comment

10 changed files

marcofranssen

pr closed time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 19be5ddca2159dbee065ba0c660d8925f18b4ace

Implement repository filtering

view details

Marco Franssen

commit sha faebc8f50979398e97d2da9aa2a1ec70d3b5a5bf

Refactor filters to some predefined ones

view details

Marco Franssen

commit sha 01c3b74b92bd5616b947dea8db06c93ebdfd8773

Document how to run tests in VSCode

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 01c3b74b92bd5616b947dea8db06c93ebdfd8773

Document how to run tests in VSCode

view details

push time in 4 days

delete branch philips-labs/garo

delete branch : feature/actions-workflow

delete time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 59e6d5052a9b8b4cb3313f3161b054f8b445b06a

Merge pull request #6 from philips-labs/feature/actions-workflow Feature/actions workflow

view details

Marco Franssen

commit sha 19be5ddca2159dbee065ba0c660d8925f18b4ace

Implement repository filtering

view details

Marco Franssen

commit sha faebc8f50979398e97d2da9aa2a1ec70d3b5a5bf

Refactor filters to some predefined ones

view details

Marco Franssen

commit sha 26d17f1b8dafd3446b0ffb7db4104b6e3a74ea1c

Document how to run tests in VSCode

view details

push time in 4 days

PR opened philips-labs/garo

Feature/filter repos

Adds some filtering capability on repositories to reduce the amount of printed repositories for testing purposes.

+99 -2

0 comment

8 changed files

pr created time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 28c20c847f44831844f906c48149389feca9f072

Refactor filters to some predefined ones

view details

Marco Franssen

commit sha b635d228cfce77c5e694829b235f93614d3189e1

Document how to run tests in VSCode

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 5435d9cabfdf40320be4b3ede78d8ae0c5bada7c

Upgrade google/go-github from v17 to v29 to include some of the actions apis

view details

Marco Franssen

commit sha 84782207c1a733262dfddf80df70fdd8de94f10a

Use named variables for clarity in usage

view details

Marco Franssen

commit sha 897b72b71c5b2a3e59184bffb2be3941dc83fa12

Utilize the get/list workflows APIs from go-github v29

view details

Marco Franssen

commit sha 59e6d5052a9b8b4cb3313f3161b054f8b445b06a

Merge pull request #6 from philips-labs/feature/actions-workflow Feature/actions workflow

view details

push time in 4 days

PR merged philips-labs/garo

Reviewers
Feature/actions workflow

Consume workflow APIs by upgrading go-github to v29.

This resolves #2

+114 -13

1 comment

10 changed files

marcofranssen

pr closed time in 4 days

issue closedphilips-labs/garo

Implement the actions/workflows endpoints

Add a file github/actions_workflows.go to implement these Apis.

https://developer.github.com/v3/actions/workflows/

closed time in 4 days

marcofranssen

push eventphilips-labs/garo

Marco Franssen

commit sha b4791b313517f01f52b149decceed5555fe6ea57

Utilize the actions APIs when running garo

view details

Marco Franssen

commit sha 47c2739f6801401720e2b11a420394f17f713599

Add vscode debug and formatting settings

view details

Marco Franssen

commit sha f11633a1eaf96d98373b8f0c540a2878eee166cd

Update the token-registration endpoint which now changed and caused 404 response

view details

Marco Franssen

commit sha 3effc7a774ab0b1fd8a403f219ebb8213b463fa2

Restructure Actions decoration to be more aligned with the to be official lib support

view details

Andy Lo-A-Foe

commit sha 1d9ccdac4b8baf962a8a91205a4b23a6048d52ed

Merge pull request #3 from philips-labs/feature/refactor-actions-extension-structure Restructure Actions decoration to be more aligned with the to be offi…

view details

Marco Franssen

commit sha 66cc8e7d563b682fd85b0eb5a105901edc0150e1

Add github actions including codecoverage

view details

Marco Franssen

commit sha 8c7f5b9b53f5b491d0121f0cbe9bd574a0740927

Add CI status badge and codecov badge

view details

push time in 4 days

delete branch philips-labs/garo

delete branch : feature/ci-plus-coverage

delete time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 66cc8e7d563b682fd85b0eb5a105901edc0150e1

Add github actions including codecoverage

view details

Marco Franssen

commit sha 8c7f5b9b53f5b491d0121f0cbe9bd574a0740927

Add CI status badge and codecov badge

view details

Marco Franssen

commit sha 5435d9cabfdf40320be4b3ede78d8ae0c5bada7c

Upgrade google/go-github from v17 to v29 to include some of the actions apis

view details

Marco Franssen

commit sha 84782207c1a733262dfddf80df70fdd8de94f10a

Use named variables for clarity in usage

view details

Marco Franssen

commit sha 897b72b71c5b2a3e59184bffb2be3941dc83fa12

Utilize the get/list workflows APIs from go-github v29

view details

Marco Franssen

commit sha 6c2663fa98abe9dfb63ee9db5e655a26f31aa2cb

Implement repository filtering

view details

Marco Franssen

commit sha c3bc836ea27a5d2663d7f640701a19252ede41a9

Document how to run tests in VSCode

view details

Marco Franssen

commit sha 35b222313bf19b5c8f70deee1e8029ae5c058c17

Refactor filters to some predefined ones

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 66cc8e7d563b682fd85b0eb5a105901edc0150e1

Add github actions including codecoverage

view details

Marco Franssen

commit sha 8c7f5b9b53f5b491d0121f0cbe9bd574a0740927

Add CI status badge and codecov badge

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 66cc8e7d563b682fd85b0eb5a105901edc0150e1

Add github actions including codecoverage

view details

Marco Franssen

commit sha 8c7f5b9b53f5b491d0121f0cbe9bd574a0740927

Add CI status badge and codecov badge

view details

Marco Franssen

commit sha 5435d9cabfdf40320be4b3ede78d8ae0c5bada7c

Upgrade google/go-github from v17 to v29 to include some of the actions apis

view details

Marco Franssen

commit sha 84782207c1a733262dfddf80df70fdd8de94f10a

Use named variables for clarity in usage

view details

Marco Franssen

commit sha 897b72b71c5b2a3e59184bffb2be3941dc83fa12

Utilize the get/list workflows APIs from go-github v29

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 66cc8e7d563b682fd85b0eb5a105901edc0150e1

Add github actions including codecoverage

view details

Marco Franssen

commit sha 8c7f5b9b53f5b491d0121f0cbe9bd574a0740927

Add CI status badge and codecov badge

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 3f0cbeb02d8d7bbbb834789fb79d3d6ccb19d4ae

Add github actions including codecoverage

view details

Marco Franssen

commit sha 0fc8dc718715aed73ea5391f2bf826516aa172fe

Add CI status badge and codecov badge

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 74f1d6cf95e4ff166c513977d533ecbad4207600

Add CI status badge and codecov badge

view details

push time in 4 days

issue openedgoogle/go-github

Why are all the responses using pointers

I noticed most responses are using slices of pointers. IMHO it would be better to not use pointers in the slices.

Also I don't think we should use pointers for strings in the JSON.

It will reduce the amount of required null checks, simplify working with the strings. Furthermore a slice is already kind of using pointers.

Is there any reason for this?

Would a PR removing the pointers in those locations be accepted?

created time in 4 days

issue commentgoogle/go-github

Go Module invalid version issue on master branch

That did the trick.

marcofranssen

comment created time in 4 days

issue closedgoogle/go-github

Go Module invalid version issue on master branch

$ go get -u github.com/google/go-github@master
go get github.com/google/go-github@master: github.com/google/go-github@v0.0.0-20200210131958-2e3e74fa920e: invalid version: go.mod has post-v0 module path "github.com/google/go-github/v29" at revision 2e3e74fa920e

closed time in 4 days

marcofranssen

create barnchphilips-labs/garo

branch : feature/ci-plus-coverage

created branch time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha 092c18c672be2e4ffa7e1c4c5adad90a4714f046

Refactor filters to some predefined ones

view details

push time in 4 days

push eventphilips-labs/garo

Marco Franssen

commit sha f6faaeaa64ebd354f4ea2e64f73283c753c2a34c

Document how to run tests in VSCode

view details

push time in 4 days

create barnchphilips-labs/garo

branch : feature/filter-repos

created branch time in 4 days

push eventmarcofranssen/opensource-portal

dependabot[bot]

commit sha 0e7ad7c52980afeb3c4bbf723ff687d5f6d9c9ef

Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.3.1...3.4.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jeff Wilcox

commit sha 3bfa623f1f308d7948559347a680281543507641

Merge pull request #106 from marcofranssen/feature/npm-build Add 'npm run-script build' mentioned in the README.md

view details

Jeff Wilcox

commit sha 480683910335f93f7f55bc6e71d0e32275e5b4a8

Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha f33757bb9131704d5d8e3f1e5d18e5b70ed6b538

Merge pull request #109 from microsoft/revert-106-feature/npm-build Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha a31386045cc885059c54e240782d1dc99dd30bfc

Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha adeac441f5b51e7dc5d0c576ef6f3670d02f9125

Merge pull request #110 from microsoft/revert-109-revert-106-feature/npm-build Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha dc987d65420d92ab3b20df0b20d1baf7bac630e6

Merge pull request #104 from microsoft/dependabot/npm_and_yarn/default-assets-package/jquery-3.4.0 Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package

view details

Marco Franssen

commit sha b880614d4c00a307fafba6b52ff03c39d66f2e09

Change Dockerfile to use CMD instead of ENTRYPOINT This allows you to enter the container using an interactive shell for the sake of debugging any issues causing the container to crash. docker run --rm -it opensource-portal sh

view details

Marco Franssen

commit sha 501bca489980a7a2bb510706b2313e3e5af70a15

Define ENV variables in single Docker layer and move up for caching benefits

view details

Marco Franssen

commit sha 8461a7fc9d8fb9035f93e2722068877a3c4dd6d6

Build the portal in /build folder in Dockerfile and remove need for rsync

view details

Marco Franssen

commit sha 48a35626d0ff7e94100a02bedd3e6b1eb5180f8a

Configure WORKDIR more early and COPY with correct owner

view details

Marco Franssen

commit sha f64c9448d2a10d5142f76501c0a8f4cd7b9c9291

Add default-assets-package to Docker image

view details

Marco Franssen

commit sha 7cd2c6c0e83abc13cfb0fa0795f5792a9fc42771

Add documentation on how to troubleshoot Docker image

view details

Marco Franssen

commit sha 2aefe03a99ca3fb46c352f7af4c9a9eea6a94123

Add docker-compose file including Redis and Postgres dependencies

view details

Marco Franssen

commit sha ef6b001cdc63a6cf0a14e932f8da067a0b8f5334

Draft keycloak docker-compose setup

view details

push time in 4 days

push eventmarcofranssen/opensource-portal

dependabot[bot]

commit sha 0e7ad7c52980afeb3c4bbf723ff687d5f6d9c9ef

Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.3.1...3.4.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jeff Wilcox

commit sha 3bfa623f1f308d7948559347a680281543507641

Merge pull request #106 from marcofranssen/feature/npm-build Add 'npm run-script build' mentioned in the README.md

view details

Jeff Wilcox

commit sha 480683910335f93f7f55bc6e71d0e32275e5b4a8

Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha f33757bb9131704d5d8e3f1e5d18e5b70ed6b538

Merge pull request #109 from microsoft/revert-106-feature/npm-build Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha a31386045cc885059c54e240782d1dc99dd30bfc

Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha adeac441f5b51e7dc5d0c576ef6f3670d02f9125

Merge pull request #110 from microsoft/revert-109-revert-106-feature/npm-build Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha dc987d65420d92ab3b20df0b20d1baf7bac630e6

Merge pull request #104 from microsoft/dependabot/npm_and_yarn/default-assets-package/jquery-3.4.0 Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package

view details

Marco Franssen

commit sha b880614d4c00a307fafba6b52ff03c39d66f2e09

Change Dockerfile to use CMD instead of ENTRYPOINT This allows you to enter the container using an interactive shell for the sake of debugging any issues causing the container to crash. docker run --rm -it opensource-portal sh

view details

Marco Franssen

commit sha 501bca489980a7a2bb510706b2313e3e5af70a15

Define ENV variables in single Docker layer and move up for caching benefits

view details

Marco Franssen

commit sha 8461a7fc9d8fb9035f93e2722068877a3c4dd6d6

Build the portal in /build folder in Dockerfile and remove need for rsync

view details

Marco Franssen

commit sha 48a35626d0ff7e94100a02bedd3e6b1eb5180f8a

Configure WORKDIR more early and COPY with correct owner

view details

Marco Franssen

commit sha f64c9448d2a10d5142f76501c0a8f4cd7b9c9291

Add default-assets-package to Docker image

view details

Marco Franssen

commit sha 7cd2c6c0e83abc13cfb0fa0795f5792a9fc42771

Add documentation on how to troubleshoot Docker image

view details

Marco Franssen

commit sha 2aefe03a99ca3fb46c352f7af4c9a9eea6a94123

Add docker-compose file including Redis and Postgres dependencies

view details

push time in 4 days

Pull request review commentmicrosoft/opensource-portal

Feature/improve dockerfile

 FROM node:10-alpine AS build ARG NPM_TOKEN  # Make Git available for NPM and rsync in the build image-RUN apk add --update git rsync && \-  rm -rf /tmp/* /var/cache/apk/*+RUN apk add --update git && rm -rf /var/cache/apk/* -COPY . /tmp/+WORKDIR /build+COPY . .  # Only if needed, copy .npmrc files into the container-# COPY Dockerfile.npmrc /tmp/.npmrc-# COPY .npmrc /tmp/.npmrc+# COPY Dockerfile.npmrc /build/.npmrc+# COPY .npmrc /build/.npmrc -RUN cd /tmp && npm install --production --verbose-RUN rsync -azhqi /tmp/node_modules/ /tmp/production_node_modules+RUN npm install --production --verbose && mv node_modules production_node_modules  # Dev dependencies-RUN cd /tmp && npm install --verbose-RUN rm -rf /tmp/.npmrc+RUN npm install --verbose && rm -rf .npmrc  # TypeScript build-RUN cd /tmp && npm run-script build+RUN npm run-script build++RUN cd default-assets-package && npm install && npm run build  FROM node:10-alpine AS run-ENV APPDIR=/usr/src/repos -RUN mkdir -p "${APPDIR}"+ENV IS_DOCKER=1 \+    DEBUG=oss-initialize \+    NPM_CONFIG_LOGLEVEL=warn \+    PORT=3000 -# Production Node.js modules-COPY --from=build /tmp/production_node_modules "${APPDIR}/node_modules"--# Assets that people not using painless config may need-COPY --from=build /tmp/data "${APPDIR}/data"--# Copy built assets, app, config map-COPY --from=build /tmp/dist "${APPDIR}"-COPY --from=build /tmp/config "${APPDIR}/config"-COPY --from=build /tmp/views "${APPDIR}/views"-COPY --from=build /tmp/package.json "${APPDIR}/package.json"-COPY --from=build /tmp/jobs/reports/exemptRepositories.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/organizationDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/repositoryDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/teamDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/views "${APPDIR}/jobs/reports/views"+EXPOSE ${PORT}  WORKDIR /usr/src/repos -# COPY package.json "${APPDIR}"-# COPY views "${APPDIR}/views"-# COPY dist "${APPDIR}"-# COPY public "${APPDIR}/public"+RUN addgroup oss && adduser -D -G oss oss && chown -R oss:oss . -ENV IS_DOCKER=1-ENV DEBUG=oss-initialize+# Production Node.js modules+COPY --from=build --chown=oss:oss /build/production_node_modules ./node_modules -ENV NPM_CONFIG_LOGLEVEL=warn+# Assets that people not using painless config may need+COPY --from=build --chown=oss:oss /build/data ./data -ENV PORT 3000-EXPOSE 3000+# Copy built assets, app, config map+COPY --from=build --chown=oss:oss /build/dist ./

Moved things most likely to change to the bottom so other layes can benefit from cache.

This helps both the build and pull of images.

marcofranssen

comment created time in 4 days

Pull request review commentmicrosoft/opensource-portal

Feature/improve dockerfile

 FROM node:10-alpine AS build ARG NPM_TOKEN  # Make Git available for NPM and rsync in the build image-RUN apk add --update git rsync && \-  rm -rf /tmp/* /var/cache/apk/*+RUN apk add --update git && rm -rf /var/cache/apk/* -COPY . /tmp/+WORKDIR /build+COPY . .  # Only if needed, copy .npmrc files into the container-# COPY Dockerfile.npmrc /tmp/.npmrc-# COPY .npmrc /tmp/.npmrc+# COPY Dockerfile.npmrc /build/.npmrc+# COPY .npmrc /build/.npmrc -RUN cd /tmp && npm install --production --verbose-RUN rsync -azhqi /tmp/node_modules/ /tmp/production_node_modules+RUN npm install --production --verbose && mv node_modules production_node_modules  # Dev dependencies-RUN cd /tmp && npm install --verbose-RUN rm -rf /tmp/.npmrc+RUN npm install --verbose && rm -rf .npmrc  # TypeScript build-RUN cd /tmp && npm run-script build+RUN npm run-script build++RUN cd default-assets-package && npm install && npm run build  FROM node:10-alpine AS run-ENV APPDIR=/usr/src/repos -RUN mkdir -p "${APPDIR}"+ENV IS_DOCKER=1 \+    DEBUG=oss-initialize \+    NPM_CONFIG_LOGLEVEL=warn \+    PORT=3000 -# Production Node.js modules-COPY --from=build /tmp/production_node_modules "${APPDIR}/node_modules"--# Assets that people not using painless config may need-COPY --from=build /tmp/data "${APPDIR}/data"--# Copy built assets, app, config map-COPY --from=build /tmp/dist "${APPDIR}"-COPY --from=build /tmp/config "${APPDIR}/config"-COPY --from=build /tmp/views "${APPDIR}/views"-COPY --from=build /tmp/package.json "${APPDIR}/package.json"-COPY --from=build /tmp/jobs/reports/exemptRepositories.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/organizationDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/repositoryDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/teamDefinitions.json "${APPDIR}/jobs/reports/"-COPY --from=build /tmp/jobs/reports/views "${APPDIR}/jobs/reports/views"+EXPOSE ${PORT}  WORKDIR /usr/src/repos -# COPY package.json "${APPDIR}"-# COPY views "${APPDIR}/views"-# COPY dist "${APPDIR}"-# COPY public "${APPDIR}/public"+RUN addgroup oss && adduser -D -G oss oss && chown -R oss:oss . -ENV IS_DOCKER=1-ENV DEBUG=oss-initialize+# Production Node.js modules+COPY --from=build --chown=oss:oss /build/production_node_modules ./node_modules -ENV NPM_CONFIG_LOGLEVEL=warn+# Assets that people not using painless config may need+COPY --from=build --chown=oss:oss /build/data ./data -ENV PORT 3000-EXPOSE 3000+# Copy built assets, app, config map+COPY --from=build --chown=oss:oss /build/dist ./+COPY --from=build --chown=oss:oss /build/default-assets-package ../default-assets-package+COPY --from=build --chown=oss:oss /build/config ./config+COPY --from=build --chown=oss:oss /build/views ./views+COPY --from=build --chown=oss:oss /build/package.json ./package.json+COPY --from=build --chown=oss:oss /build/jobs/reports/exemptRepositories.json \+    /build/jobs/reports/organizationDefinitions.json \+    /build/jobs/reports/repositoryDefinitions.json \+    /build/jobs/reports/teamDefinitions.json \+    ./jobs/reports/+COPY --from=build --chown=oss:oss /build/jobs/reports/views ./jobs/reports/views++# COPY package.json ./+# COPY views ./views+# COPY dist ./+# COPY public ./public -RUN addgroup oss && adduser -D -G oss oss \- && chown -R oss:oss "${APPDIR}" USER oss -ENTRYPOINT ["npm", "run-script", "start-in-container"]+CMD ["npm", "run-script", "start-in-container"]

This allows the container to also be started interacively with a shell for debugging purposes

marcofranssen

comment created time in 4 days

push eventmarcofranssen/opensource-portal

dependabot[bot]

commit sha 0e7ad7c52980afeb3c4bbf723ff687d5f6d9c9ef

Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.3.1...3.4.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jeff Wilcox

commit sha 3bfa623f1f308d7948559347a680281543507641

Merge pull request #106 from marcofranssen/feature/npm-build Add 'npm run-script build' mentioned in the README.md

view details

Jeff Wilcox

commit sha 480683910335f93f7f55bc6e71d0e32275e5b4a8

Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha f33757bb9131704d5d8e3f1e5d18e5b70ed6b538

Merge pull request #109 from microsoft/revert-106-feature/npm-build Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha a31386045cc885059c54e240782d1dc99dd30bfc

Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha adeac441f5b51e7dc5d0c576ef6f3670d02f9125

Merge pull request #110 from microsoft/revert-109-revert-106-feature/npm-build Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha dc987d65420d92ab3b20df0b20d1baf7bac630e6

Merge pull request #104 from microsoft/dependabot/npm_and_yarn/default-assets-package/jquery-3.4.0 Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package

view details

Marco Franssen

commit sha b880614d4c00a307fafba6b52ff03c39d66f2e09

Change Dockerfile to use CMD instead of ENTRYPOINT This allows you to enter the container using an interactive shell for the sake of debugging any issues causing the container to crash. docker run --rm -it opensource-portal sh

view details

Marco Franssen

commit sha 501bca489980a7a2bb510706b2313e3e5af70a15

Define ENV variables in single Docker layer and move up for caching benefits

view details

Marco Franssen

commit sha 8461a7fc9d8fb9035f93e2722068877a3c4dd6d6

Build the portal in /build folder in Dockerfile and remove need for rsync

view details

Marco Franssen

commit sha 48a35626d0ff7e94100a02bedd3e6b1eb5180f8a

Configure WORKDIR more early and COPY with correct owner

view details

Marco Franssen

commit sha f64c9448d2a10d5142f76501c0a8f4cd7b9c9291

Add default-assets-package to Docker image

view details

Marco Franssen

commit sha 7cd2c6c0e83abc13cfb0fa0795f5792a9fc42771

Add documentation on how to troubleshoot Docker image

view details

push time in 4 days

push eventmarcofranssen/opensource-portal

dependabot[bot]

commit sha 0e7ad7c52980afeb3c4bbf723ff687d5f6d9c9ef

Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.3.1...3.4.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Marco Franssen

commit sha fde016181d3e0dca7803fde7b661032dca365619

Add 'npm run-script build' mentioned in the README.md

view details

Jeff Wilcox

commit sha 3bfa623f1f308d7948559347a680281543507641

Merge pull request #106 from marcofranssen/feature/npm-build Add 'npm run-script build' mentioned in the README.md

view details

Jeff Wilcox

commit sha 480683910335f93f7f55bc6e71d0e32275e5b4a8

Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha f33757bb9131704d5d8e3f1e5d18e5b70ed6b538

Merge pull request #109 from microsoft/revert-106-feature/npm-build Revert "Add 'npm run-script build' mentioned in the README.md"

view details

Jeff Wilcox

commit sha a31386045cc885059c54e240782d1dc99dd30bfc

Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha adeac441f5b51e7dc5d0c576ef6f3670d02f9125

Merge pull request #110 from microsoft/revert-109-revert-106-feature/npm-build Revert "Revert "Add 'npm run-script build' mentioned in the README.md""

view details

Jeff Wilcox

commit sha dc987d65420d92ab3b20df0b20d1baf7bac630e6

Merge pull request #104 from microsoft/dependabot/npm_and_yarn/default-assets-package/jquery-3.4.0 Bump jquery from 3.3.1 to 3.4.0 in /default-assets-package

view details

push time in 4 days

issue openedgoogle/go-github

Go Module invalid version issue on master branch

$ go get -u github.com/google/go-github@master
go get github.com/google/go-github@master: github.com/google/go-github@v0.0.0-20200210131958-2e3e74fa920e: invalid version: go.mod has post-v0 module path "github.com/google/go-github/v29" at revision 2e3e74fa920e

created time in 5 days

push eventmarcofranssen/medical-delivery-drone

Marco Franssen

commit sha 1746899e373280a36383471003b165724710ea4d

Add capability to write the video raw data to a file

view details

push time in 6 days

push eventphilips-labs/medical-delivery-drone

Jeroen Knoops

commit sha 388041ffa9d2db928b66a604b1f28c1138a0f7cd

Update README.md

view details

Marco Franssen

commit sha c44347d5ff144ec8bc7694e34780ac57065f7a1b

Add editorconfig for harmonized formatting

view details

Marco Franssen

commit sha a1d2148eaa6d2cc61c04ff1eb7eadc837bee666c

Add Makefile to automate some tasks

view details

Marco Franssen

commit sha 85eb0c760f814ad262cea3c5692c85ba18258d5a

Refactor code for drone and video rendering to separate package

view details

Marco Franssen

commit sha 795f4a30524b0790c3af4e9e9f344115d63c53cf

Add PS4 controller

view details

Marco Franssen

commit sha 8f992f7caca5c9683fe48eeedb2f8c497634b20f

Add documenation on how to build with Makefile

view details

push time in 6 days

push eventmarcofranssen/medical-delivery-drone

Jeroen Knoops

commit sha 388041ffa9d2db928b66a604b1f28c1138a0f7cd

Update README.md

view details

Marco Franssen

commit sha c44347d5ff144ec8bc7694e34780ac57065f7a1b

Add editorconfig for harmonized formatting

view details

Marco Franssen

commit sha a1d2148eaa6d2cc61c04ff1eb7eadc837bee666c

Add Makefile to automate some tasks

view details

Marco Franssen

commit sha 85eb0c760f814ad262cea3c5692c85ba18258d5a

Refactor code for drone and video rendering to separate package

view details

Marco Franssen

commit sha 795f4a30524b0790c3af4e9e9f344115d63c53cf

Add PS4 controller

view details

Marco Franssen

commit sha 8f992f7caca5c9683fe48eeedb2f8c497634b20f

Add documenation on how to build with Makefile

view details

push time in 6 days

push eventmarcofranssen/medical-delivery-drone

Marco Franssen

commit sha c44347d5ff144ec8bc7694e34780ac57065f7a1b

Add editorconfig for harmonized formatting

view details

Marco Franssen

commit sha a1d2148eaa6d2cc61c04ff1eb7eadc837bee666c

Add Makefile to automate some tasks

view details

Marco Franssen

commit sha 85eb0c760f814ad262cea3c5692c85ba18258d5a

Refactor code for drone and video rendering to separate package

view details

Marco Franssen

commit sha 795f4a30524b0790c3af4e9e9f344115d63c53cf

Add PS4 controller

view details

Marco Franssen

commit sha 8f992f7caca5c9683fe48eeedb2f8c497634b20f

Add documenation on how to build with Makefile

view details

push time in 6 days

delete branch marcofranssen/medical-delivery-drone

delete branch : feature/ps4-controller

delete time in 6 days

push eventphilips-labs/medical-delivery-drone

Marco Franssen

commit sha c44347d5ff144ec8bc7694e34780ac57065f7a1b

Add editorconfig for harmonized formatting

view details

Marco Franssen

commit sha a1d2148eaa6d2cc61c04ff1eb7eadc837bee666c

Add Makefile to automate some tasks

view details

Marco Franssen

commit sha 85eb0c760f814ad262cea3c5692c85ba18258d5a

Refactor code for drone and video rendering to separate package

view details

Marco Franssen

commit sha 795f4a30524b0790c3af4e9e9f344115d63c53cf

Add PS4 controller

view details

Marco Franssen

commit sha 8f992f7caca5c9683fe48eeedb2f8c497634b20f

Add documenation on how to build with Makefile

view details

push time in 6 days

PR merged philips-labs/medical-delivery-drone

video streaming and ps4 controller
  1. Cleaned the codebase
  2. Fixed the videostream
  3. Added PS4 controller to fly the drone
+602 -82

0 comment

12 changed files

marcofranssen

pr closed time in 6 days

push eventmarcofranssen/medical-delivery-drone

Marco Franssen

commit sha da65e121eba42e133232e467cd02d58a5b259c85

Add PS4 controller

view details

Marco Franssen

commit sha a414cde49c5f3a247ceb18ea070809675361383a

Add documenation on how to build with Makefile

view details

push time in 6 days

create barnchphilips-labs/medical-delivery-drone

branch : develop

created branch time in 6 days

startedtcardonne/docker-github-runner

started time in 6 days

pull request commentgoogle/go-github

Implement support for actions workflow jobs

@joshuabezaleel

probably you need to do

go get github.com/google/go-github@thebranch-containing-the-code

or you should add a replace in your go.mod

replace github.com/google/go-github => ./the-path-to-your-checkout-of-the-repo-branch
joshuabezaleel

comment created time in 6 days

pull request commenttheupdateframework/notary

Feature/go modules

@justincormack I have added a steps to reproduce

https://github.com/theupdateframework/notary/issues/1533#issuecomment-584522088

marcofranssen

comment created time in 6 days

issue commenttheupdateframework/notary

Notary 0.6.1 pulled via go.mod has a bug as well the upcoming 0.6.2 release

How to reproduce:

go mod init github.com/somenotary/integration

service_test.go

package main

import (
	"context"
	"net/http/httptest"
	"testing"

	"github.com/theupdateframework/notary"
	"github.com/theupdateframework/notary/cryptoservice"
	"github.com/theupdateframework/notary/server"
	"github.com/theupdateframework/notary/server/storage"
	"github.com/theupdateframework/notary/trustmanager"
)

func fullTestServer(t *testing.T) *httptest.Server {
	// Set up server
	ctx := context.WithValue(context.Background(), notary.CtxKeyMetaStore, storage.NewMemStorage())

	// Do not pass one of the const KeyAlgorithms here as the value! Passing a
	// string is in itself good test that we are handling it correctly as we
	// will be receiving a string from the configuration.
	ctx = context.WithValue(ctx, notary.CtxKeyKeyAlgo, "ecdsa")

	// Eat the logs instead of spewing them out
	// var b bytes.Buffer
	// l := logrus.New()
	// l.Out = &b
	// ctx = ctxu.WithLogger(ctx, logrus.NewEntry(l))

	cryptoService := cryptoservice.NewCryptoService(trustmanager.NewKeyMemoryStore(passphraseRetriever))
	server := httptest.NewServer(server.RootHandler(ctx, nil, cryptoService, nil, nil, nil))
	config.RemoteServer.URL = ts.URL

	return server
}

func TestFullTestServer(t *testing.T) {
	ts := fullTestServer(t)
	// my custom code utilizing the TestServer for unittesting
}

Now run the test:

$ go test ./...
# github.com/theupdateframework/notary/utils
../../../go/pkg/mod/github.com/theupdateframework/notary@v0.6.1/utils/http.go:112:24: not enough arguments in call to challenge.SetHeaders
        have (http.ResponseWriter)
        want (*http.Request, http.ResponseWriter)
FAIL    github.com/philips-internal/actions-runner-orchestrator [build failed]
FAIL

Now try the same by upgrading to latest master branch as a dependency

$ go get github.com/theupdateframework/notary@master
go: finding github.com/theupdateframework/notary master
$ go test ./...
# github.com/theupdateframework/notary/server
../../../go/pkg/mod/github.com/theupdateframework/notary@v0.6.2-0.20200114084303-f255ae779066/server/server.go:127:9: undefined: prometheus.InstrumentHandlerWithOpts
../../../go/pkg/mod/github.com/theupdateframework/notary@v0.6.2-0.20200114084303-f255ae779066/server/server.go:235:44: undefined: prometheus.Handler
FAIL    github.com/philips-internal/actions-runner-orchestrator [build failed]
FAIL

This last error is also the case when using the version using Go modules from this PR #1523

@justincormack is this more clear?

marcofranssen

comment created time in 6 days

issue openedgoogle/go-github

Add support for the actions self hosted runners api

Would be good if the github actions selfhosted runner apis would be supported in the library

https://developer.github.com/v3/actions/self_hosted_runners/

This might also be picked up in this issue #1399

created time in 7 days

create barnchmarcofranssen/opensource-portal

branch : feature/docker-keycloak-oidc

created branch time in 7 days

pull request commenttheupdateframework/notary

Feature/go modules

@HuKeping @justincormack @thaJeztah I found one bug with the dependencies when consuming notary as a lib in another project. I think in my original PR I resolved that by manually downgrading the vendored lib if I remember correctly. #1533

Shall I try to fix the issue on this PR? Or shall I add another PR on top of this one trying to resolve it? Would be good if this can be merged as I would love to add a few more contributions on top of this.

marcofranssen

comment created time in 7 days

push eventmarcofranssen/medical-delivery-drone

Marco Franssen

commit sha a414cde49c5f3a247ceb18ea070809675361383a

Add documenation on how to build with Makefile

view details

push time in 8 days

PR opened philips-labs/medical-delivery-drone

video streaming and ps4 controller
  1. Cleaned the codebase
  2. Fixed the videostream
  3. Added PS4 controller to fly the drone
+600 -82

0 comment

11 changed files

pr created time in 8 days

create barnchmarcofranssen/medical-delivery-drone

branch : feature/ps4-controller

created branch time in 8 days

create barnchmarcofranssen/medical-delivery-drone

branch : develop

created branch time in 9 days

startedCharterhouse/PowerOfBlockchain

started time in 10 days

push eventmarcofranssen/opensource-portal

Marco Franssen

commit sha 3ed3dc005ad903c0eae7568aba482d7ce2a24669

Add docker-compose file including Redis and Postgres dependencies

view details

push time in 10 days

PR opened microsoft/opensource-portal

Feature/docker compose

This builds further on top of the PR #107

It is a first step into creating a local environment that can be run by just doing

cp .secrets.env.example
cp env-orgs.json.example env-orgs.json
# update the configuration values in both the files
docker-compose up
+164 -42

0 comment

9 changed files

pr created time in 10 days

create barnchmarcofranssen/opensource-portal

branch : feature/docker-compose

created branch time in 10 days

push eventmarcofranssen/opensource-portal

Marco Franssen

commit sha 64247c2954c6ede71993eb8bf326f7bd6c90bd18

Add documentation on how to troubleshoot Docker image

view details

push time in 10 days

PR opened microsoft/opensource-portal

Feature/improve dockerfile

This PR improves caching of the layers in the Dockerfile and it reduces some layers.

Furthermore it also adds the default-assets to the container and takes care of putting into place the env.json and env-orgs.json

This PR does not contain documentation on what to put in the env.json and env-orgs.json as that is also not yet fully clear to me.

It does resolve many of the bootup errors I got while troubleshooting, so this will allow others to more easily contribute by having a Docker image that puts all files properly in place.

This PR also contains the commit from the other PR #106

+65 -42

0 comment

4 changed files

pr created time in 10 days

create barnchmarcofranssen/opensource-portal

branch : feature/improve-dockerfile

created branch time in 10 days

push eventmarcofranssen/opensource-portal

Marco Franssen

commit sha fde016181d3e0dca7803fde7b661032dca365619

Add 'npm run-script build' mentioned in the README.md

view details

push time in 10 days

create barnchmarcofranssen/opensource-portal

branch : feature/npm-build

created branch time in 10 days

issue openedmicrosoft/opensource-portal

Package json does not contain the `npm run-script build` script

In the readme is mentioned to use npm run-script build. This is missing in the package.json.

Would be great if that could be added.

created time in 10 days

issue commenttheupdateframework/notary

Notary 0.6.1 pulled via go.mod has a bug as well the upcoming 0.6.2 release

I have also tried to use the #1523 branch by using a replace statement in the Go.mod

This is having the same issue as the master branch, which was about to be expected as the dependencies are exactly the same.

I expect this to be easily resolveable if we can upgrade some modules using go.mod

marcofranssen

comment created time in 11 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha e02e12dd9511e2310c269d791ace699ac9f044ac

Update notary submodule

view details

Marco Franssen

commit sha b5b3af5d73e83716a59dbe67b47e64ab677c1fef

Implement Add Delegation in notary service

view details

Marco Franssen

commit sha 6305e8078cf2fed3a4f0f491fcafdde4b87e3d04

Add endpoints for adding and deleting delegations

view details

Marco Franssen

commit sha 2f3b4a00b941c3dc9901c8a96cb43e59c2d8aa66

Add tests for GuardHasGUN

view details

Marco Franssen

commit sha 05a155e00dea7fb2f19cf6a562c8539a8104750b

Document the delegation endpoints for adding and deleting

view details

Marco Franssen

commit sha 33db7649815dede745e7764844f86cba233d8eb1

Reuse the same password retriever created when initializing the Service

view details

Marco Franssen

commit sha 467501af1702b8c9270f2ec43fef6b3a7e0a8bb1

Implement test for adding delegation key without autopublish

view details

Thales Sousa

commit sha 1a41518e408519b65ff21bd9f9fa9096d2c31919

Implement add delegation API

view details

push time in 11 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha e02e12dd9511e2310c269d791ace699ac9f044ac

Update notary submodule

view details

push time in 11 days

push eventphilips-labs/notary

Marco Franssen

commit sha 7d38d26cd34856655452cf3acc010c91924a6819

Apply 'go mod init github.com/theupdateframework/notary'

view details

Marco Franssen

commit sha 98a5d2cecb7d0c2011c0da38eadc6e69475652e6

Apply 'go mod download'

view details

Marco Franssen

commit sha b8a8e90f31818b69fc3cc78f89c89f957b9a5e8c

Apply 'go mod vendor' (adds indirect dependencies)

view details

Marco Franssen

commit sha 1da673b542e53a09946c809e87dc226700b6d022

Update docker images to use Go Modules and 1.12.15

view details

Marco Franssen

commit sha 4d9d7ac01561913f48ed755ca27956ab81adbd60

Update documentation for module compatibility

view details

Marco Franssen

commit sha 527a24dc22ef5ae2a6f46f1b6a92924707a442e9

Add vendor validation script to ensure deps are properly vendored after upgrade

view details

Marco Franssen

commit sha 73ce46a125c4bc79d1efba68a3606dcbb751fcdb

Include vendor check in circleci workflow

view details

Marco Franssen

commit sha 6f7e2df243e4969f1ac7b0aa18b910f3fac4587d

Add documentation on how to upgrade

view details

Marco Franssen

commit sha 38c931cdf4b5ea00489f8da7da3de33a7092c80a

Align golang-cross docker image version

view details

Marco Franssen

commit sha df3c9856d2d51b5626ecf3ba29c95a35970b9345

Make the validate-vendor.sh script solely to work with go mod

view details

Marco Franssen

commit sha a3e24e9b44857e01ae14004b2eda05d8a7e02f40

Set default go flag to use -mod=vendor for cli commands

view details

Marco Franssen

commit sha 6c96e3b1a6b4c084168055f60f9f4119f5c243a4

Apply 'go mod tidy && go mod vendor'

view details

Marco Franssen

commit sha 322b3bca92b18674e3cba39bc8bb3e4abd5d4d2a

Add Docker/notary sandbox docker-compose setup

view details

Marco Franssen

commit sha 3e103e20e297ef25332f19a74b9f599a627e5275

Expose registry port in docker-compose sandbox

view details

Marco Franssen

commit sha 86f0eeb6b303b2233cec795ac9c4a115c2485da3

Use shared volume for /go/pkg/mod in docker-compose sandbox

view details

push time in 11 days

push eventmarcofranssen/notary

Marco Franssen

commit sha 7d38d26cd34856655452cf3acc010c91924a6819

Apply 'go mod init github.com/theupdateframework/notary'

view details

Marco Franssen

commit sha 98a5d2cecb7d0c2011c0da38eadc6e69475652e6

Apply 'go mod download'

view details

Marco Franssen

commit sha b8a8e90f31818b69fc3cc78f89c89f957b9a5e8c

Apply 'go mod vendor' (adds indirect dependencies)

view details

Marco Franssen

commit sha 1da673b542e53a09946c809e87dc226700b6d022

Update docker images to use Go Modules and 1.12.15

view details

Marco Franssen

commit sha 4d9d7ac01561913f48ed755ca27956ab81adbd60

Update documentation for module compatibility

view details

Marco Franssen

commit sha 527a24dc22ef5ae2a6f46f1b6a92924707a442e9

Add vendor validation script to ensure deps are properly vendored after upgrade

view details

Marco Franssen

commit sha 73ce46a125c4bc79d1efba68a3606dcbb751fcdb

Include vendor check in circleci workflow

view details

Marco Franssen

commit sha 6f7e2df243e4969f1ac7b0aa18b910f3fac4587d

Add documentation on how to upgrade

view details

Marco Franssen

commit sha 38c931cdf4b5ea00489f8da7da3de33a7092c80a

Align golang-cross docker image version

view details

Marco Franssen

commit sha df3c9856d2d51b5626ecf3ba29c95a35970b9345

Make the validate-vendor.sh script solely to work with go mod

view details

Marco Franssen

commit sha a3e24e9b44857e01ae14004b2eda05d8a7e02f40

Set default go flag to use -mod=vendor for cli commands

view details

Marco Franssen

commit sha 6c96e3b1a6b4c084168055f60f9f4119f5c243a4

Apply 'go mod tidy && go mod vendor'

view details

Marco Franssen

commit sha 322b3bca92b18674e3cba39bc8bb3e4abd5d4d2a

Add Docker/notary sandbox docker-compose setup

view details

Marco Franssen

commit sha 3e103e20e297ef25332f19a74b9f599a627e5275

Expose registry port in docker-compose sandbox

view details

Marco Franssen

commit sha 86f0eeb6b303b2233cec795ac9c4a115c2485da3

Use shared volume for /go/pkg/mod in docker-compose sandbox

view details

push time in 11 days

issue openedtcardonne/docker-github-runner

What License applies to this repository?

Hi,

What License does apply to this repository? Would you be able to add the LICENSE file to make this clear for others?

created time in 11 days

push eventphilips-labs/notary

Marco Franssen

commit sha 7d38d26cd34856655452cf3acc010c91924a6819

Apply 'go mod init github.com/theupdateframework/notary'

view details

Marco Franssen

commit sha 98a5d2cecb7d0c2011c0da38eadc6e69475652e6

Apply 'go mod download'

view details

Marco Franssen

commit sha b8a8e90f31818b69fc3cc78f89c89f957b9a5e8c

Apply 'go mod vendor' (adds indirect dependencies)

view details

Marco Franssen

commit sha 1da673b542e53a09946c809e87dc226700b6d022

Update docker images to use Go Modules and 1.12.15

view details

Marco Franssen

commit sha 4d9d7ac01561913f48ed755ca27956ab81adbd60

Update documentation for module compatibility

view details

Marco Franssen

commit sha 527a24dc22ef5ae2a6f46f1b6a92924707a442e9

Add vendor validation script to ensure deps are properly vendored after upgrade

view details

Marco Franssen

commit sha 73ce46a125c4bc79d1efba68a3606dcbb751fcdb

Include vendor check in circleci workflow

view details

Marco Franssen

commit sha 6f7e2df243e4969f1ac7b0aa18b910f3fac4587d

Add documentation on how to upgrade

view details

Marco Franssen

commit sha 38c931cdf4b5ea00489f8da7da3de33a7092c80a

Align golang-cross docker image version

view details

Marco Franssen

commit sha df3c9856d2d51b5626ecf3ba29c95a35970b9345

Make the validate-vendor.sh script solely to work with go mod

view details

Marco Franssen

commit sha a3e24e9b44857e01ae14004b2eda05d8a7e02f40

Set default go flag to use -mod=vendor for cli commands

view details

Marco Franssen

commit sha 6c96e3b1a6b4c084168055f60f9f4119f5c243a4

Apply 'go mod tidy && go mod vendor'

view details

push time in 11 days

issue openedtheupdateframework/notary

Notary 0.6.1 pulled via go.mod has a bug

Following error is shown when trying to run some test utilizing this util.

/Users/marco/go/pkg/mod/github.com/theupdateframework/notary@v0.6.1/utils/http.go:112:24: not enough arguments in call to challenge.SetHeaders
	have (http.ResponseWriter)
	want (*http.Request, http.ResponseWriter)

The fix is already on master, so probably needs a hotfix on the 06.1 release as this blocks people installing the latest release via Go modules.

https://github.com/theupdateframework/notary/blob/master/utils/http.go#L112

created time in 11 days

issue commentactions/checkout

Checkout with submodules?

@webknjaz thanks, will give that a try as well. I finally managed to fix it by replacing the ssh with https address as explained in the README.md of this repo. Overlooked that at first.

DethRaid

comment created time in 11 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha f3b514ab2a14376931180f0740f44288b00741fe

Cleanup go.sum by removing and running 'go mod tidy'

view details

Marco Franssen

commit sha 9edac07d3b621730c612abc1464a0f1ebde689fe

Implement Add Delegation in notary service

view details

Marco Franssen

commit sha 54d1b450b6f81e4b336b88e7f226774c5c6d8969

Add endpoints for adding and deleting delegations

view details

Marco Franssen

commit sha 9a2a1a2b2ba89f69a6f8cb9550b7e1d8c43a7a63

Add tests for GuardHasGUN

view details

Marco Franssen

commit sha 8b100ec8c231eeb7e844e477071feb93187eef2c

Document the delegation endpoints for adding and deleting

view details

Marco Franssen

commit sha c91db5ed72d08cc18e5b7a21b7b0c79908ed8522

Reuse the same password retriever created when initializing the Service

view details

Marco Franssen

commit sha 876a08323ac4e0fe848ac88a65e03a2fbf1fef41

Implement test for adding delegation key without autopublish

view details

Thales Sousa

commit sha 2763afdc2377c58ad5b401f3d0d51399ab61437f

Implement add delegation API

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha f3b514ab2a14376931180f0740f44288b00741fe

Cleanup go.sum by removing and running 'go mod tidy'

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Thales Sousa

commit sha afbae8f13250d65d924c406bf916bcff9e91d5d4

Implement add delegation API

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha da3506103ffb84fac50d0a793f067ea2a44f5f01

Add reset-sandbox task to makefile to simplify running tests

view details

Marco Franssen

commit sha bd97783b6c68968deb97f251f017b0aa969363f1

Make more reusable role filter

view details

Marco Franssen

commit sha 6d209157808bd482c177a74292f8d80436a47068

Implement Add Delegation in notary service

view details

Marco Franssen

commit sha d8fb3dfe8cbdcf7ccc07a7612c72873bd327a91c

Add endpoints for adding and deleting delegations

view details

Marco Franssen

commit sha 55b18225d1a3d2f43d13ef805b433f2afe774ede

Add tests for GuardHasGUN

view details

Marco Franssen

commit sha 80be5e8f3668ec1ee41dd60cacebc952494bdbb0

Document the delegation endpoints for adding and deleting

view details

Marco Franssen

commit sha 18382ac63b446d9ad0c4e97fb76254ae1a97221d

Reuse the same password retriever created when initializing the Service

view details

Marco Franssen

commit sha dd10f96310e53f884e610d4f028b0611561cf8d6

Implement test for adding delegation key without autopublish

view details

Thales Sousa

commit sha 7c10868dc0bc3987f08c9850af7152cc2cf2248f

Implement add delegation API

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha bd97783b6c68968deb97f251f017b0aa969363f1

Make more reusable role filter

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha da3506103ffb84fac50d0a793f067ea2a44f5f01

Add reset-sandbox task to makefile to simplify running tests

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha 2056009dac3754286a51496da8eb72a0d84098a1

Implement test for adding delegation key without autopublish

view details

push time in 12 days

push eventphilips-labs/dct-notary-admin

Marco Franssen

commit sha 3c4305775ffc77ab8fc5dbf17259fd4c735538ca

Add build-sandbox doc to README

view details

Marco Franssen

commit sha 40ecaf7656f47c7cb4e393aed4ab68c552122c09

Move the hyperlink definitions all to the bottom of README.md

view details

Marco Franssen

commit sha 309e8e72938986b768cec20d135f1637f3935ae3

Fix 'make build-sandbox'

view details

Marco Franssen

commit sha 123f7f4de23f65edc066586d1d06bb47a3f10418

Add reset-sandbox task to makefile to simplify running tests

view details

Marco Franssen

commit sha 65866a3ca91220adf744348e30136b367be4092e

Implement Add Delegation in notary service

view details

Marco Franssen

commit sha e658331d6378aa6b581e5b356533c47513544bf3

Add endpoints for adding and deleting delegations

view details

Marco Franssen

commit sha 9aa0156abbe85aea985c404ad258681b84f83acc

Add tests for GuardHasGUN

view details

Marco Franssen

commit sha 46a632dd7ae8d3afd05cc403850bb352323eaae9

Document the delegation endpoints for adding and deleting

view details

Marco Franssen

commit sha 952d0c18f70ce3a1f159e41fa5efe9b6994672ba

Reuse the same password retriever created when initializing the Service

view details

push time in 13 days

more