Base commit: 5cb2debbea57603990f36200daab5fb981603b47

Base commit: 5cb2debbea57603990f36200daab5fb981603b47

Description

I am trying to start up a react native ios app from terminal with: npx react-native run-ios --configuration Debug --scheme Development

I then get the error: ** BUILD FAILED ** The following build commands failed: CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler MergeSwiftModule normal x86_64 /Users/Library/Developer/Xcode/DerivedData/frnjcdnxmbqgcnhkwpisddivymns/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/lottie-react-native.build/Objects-normal/x86_64/lottie_react_native.swiftmodule (2 failures)

I expect the Xcode simulator to startup and run the ios app but the build fails.

npm: '6.14.11', ares: '1.16.1', brotli: '1.0.9', cldr: '37.0', icu: '67.1', llhttp: '2.1.3', modules: '83', napi: '7', nghttp2: '1.41.0', node: '14.16.0', openssl: '1.1.1j', tz: '2020a', unicode: '13.0', uv: '1.40.0', v8: '8.4.371.19-node.18', zlib: '1.2.11'

lottie-ios: '3.1.8', lottie-react-native: '3.5.0'

react-native: '0.64.2'

Xcode: '12.5'

Macbook pro 2019 2.3Ghz 8-Core Intel Core i9 macOS Big Sur v11.4

<!-- 0 failure: 0 warning: 3 messages

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Messages</th> </tr> </thead> <tbody><tr> <td>:book:</td> <td>

:clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

<details>CATEGORY may be:

• General
• iOS
• Android
• JavaScript
• Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

• Added, for new features.
• Changed, for changes in existing functionality.
• Deprecated, for soon-to-be removed features.
• Removed, for now removed features.
• Fixed, for any bug fixes.
• Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.</details></i> </td> </tr>

<tr> <td>:book:</td> <td>:clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i></td> </tr>

<tr> <td>:book:</td> <td>:clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i></td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 0fb292f2ba8aac11dd835d119121444d5ba51913 </p>

This pull request was exported from Phabricator. Differential Revision: D29124724

Summary: Changelog:[General][Removed] - Remove Picker iOS code

Reviewed By: p-sun

Differential Revision: D29124724

Are you using react-native-elements or some other dependency that might be overwriting your attempts to change the status bar? This is what happened to me. After updating from "react-native-elements": "^2.0.4" to "react-native-elements": "^3.4.2" I experienced this. I was able to fix it by setting the props like so inside of the react-native-elements header I was using:

statusBarProps={{ backgroundColor: 'rgb(17, 0, 233)' }}

@mweststrate Gotcha, so do we have an idiomatic way to make an instance with observables atteibute immutable of some sort?

Observable properties are setter / getter pairs, not simple value fields, so this is working as expected.

On Thu, 24 Jun 2021, 22:26 An Phi, ***@***.***> wrote:

I have frozen a non-plain object with Object.freeze, fields being decorated with observable are still modifiable.

I have looked around for similar issues, but I don't seem to find one that fits my description exactly, also most of those issues are rather old so this might be a problem that is introduced more recently.

Intended outcome:

I would expect the field to be non-modifiable, or an error is thrown when I attempt to change the value of the frozen field.

Actual outcome:

The observable field of the frozen object is modifiable.

How to reproduce the issue:

Please refer to this for code repro: https://github.com/akphi/issue-repo/tree/mobx-observable-ref-freeze

I have the following code:

import { makeObservable, observable, action } from "mobx"; class Person { name = ''; age = 1;

constructor() { makeObservable(this, { name: observable, setName: action, }); }

setName(val: string) { this.name = val; }} export const App = (props: {}) => { const person = new Person(); person.setName('initial'); console.log("person", person, person.name); // this will print initial for the name Object.freeze(person); person.setName('something'); // person.age = 3; // this will throw an error if uncommented console.log("person", person, person.name); // this will print something for the name return <div>{person.name}</div>;};

As you can see, person.name is still modifiable after calling Object.freeze(person). On the other hand, if we modify the non-observable field person.age, error will be thrown.

Versions

@***.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mobxjs/mobx/issues/3008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBF6PEVAVEADF7T5ZHTTUOPI3ANCNFSM47IVSW3Q .

Hi, I also got the same error. Did you solve the problem? Could you kindly share if you had done that!

@ekram21 I upgraded watchman, yarn install, and npx pod-install and I am still getting the same error. Am I missing something?

I'm rendering multiple maps as such:

[a, b, c].map(mapObj => <ReactMapGL onClick={e => console.log(e)} />

and found that when I click on one of the rendered maps, the click event gets called 3 times, as many as the maps rendered in the loop, instead of just firing from the element that I actually clicked on. I think this is a bug and makes working with multiple maps quite tricky. Logging the click events shows 3 different event targets, one for each different map container.

the onMouseDownevent behaves correctly by only firing from the map that is actually being clicked, which makes me think that the onClick listener might not be behaving correctly

Thanks for reporting. This is fixed by [email protected]. You may need to remove your lock file to upgrade the dependency.

I have frozen a non-plain object with Object.freeze, fields being decorated with observable are still modifiable.

I have looked around for similar issues, but I don't seem to find one that fits my description exactly, also most of those issues are rather old so this might be a problem that is introduced more recently.

Intended outcome:

I would expect the field to be non-modifiable, or an error is thrown when I attempt to change the value of the frozen field.

Actual outcome:

The observable field of the frozen object is modifiable.

How to reproduce the issue:

Please refer to this for code repro: https://github.com/akphi/issue-repo/tree/mobx-observable-ref-freeze

I have the following code:

import { makeObservable, observable, action } from "mobx";

class Person {
  name = '';
  age = 1;

  constructor() {
    makeObservable(this, {
      name: observable,
      setName: action,
    });
  }

  setName(val: string) {
    this.name = val;
  }
}

export const App = (props: {}) => {
  const person = new Person();
  person.setName('initial');
  console.log("person", person, person.name); // this will print `initial` for the name
  Object.freeze(person);
  person.setName('something');
  // person.age = 3; // this will throw an error if uncommented
  console.log("person", person, person.name); // this will print `something` for the name
  return <div>{person.name}</div>;
};

As you can see, person.name is still modifiable after calling Object.freeze(person). On the other hand, if we modify the non-observable field person.age, error will be thrown.

Versions

[email protected]

been able to find a solution, for me the issue was mainly caused by the inconsistent behaviour of date.toLocaleDateString function on Android. https://stackoverflow.com/a/51400372 the easiest solution I could find is to replace toLocaleDateString everywhere in the app with a custom made version.

const toLocaleDateString = date =>${date.getDate()}/${date.getMonth() < 9 ? 0${date.getMonth() + 1} : date.getMonth() + 1}/${date.getFullYear()};

I have the same issue with play store with RN 0.63.1

Reopening this as we're getting closer to a React 18 release. Progress can be followed in #3005.

At this moment, as far as initial test projects point out, mobx-react(-lite) plays fine with React 18 in Strict mode. No warnings, errors and features like startTransaction seem to work correctly.

At this moment we don't offer MobX specific concurrent features yet. Some tearing could (theoretically) still happen. And MobX might put React in de-opt mode (theoretically) in cases as well.

That being said, there are no known problems at this moment that would block mobx-react(-lite) from upgrading or using specific React features.

That conclusion is based on some pretty flimsy research, but at least it is some status update :). No known limitations or blockers for a React 18 upgrade at this moment.

Can flopper be opt in and not too invasive in project code? Too much problems for nothing.