Coverage remained the same at 34.984% when pulling 6f54a89cb64d484064771c8ac0d8976855968b97 on Nikatik:patch-1 into e462f0a584bcf58547247d532e10fc1994c2ab1e on processone:master.

Hi @Nikatik, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

scram-sha512 did not work, because serverkey is longer then that array. All passwords was unhashed.

There's a problem. When I'm playing media, like music or whatever, I can't adjust the volume via the button. I uninstalled KissLauncher and it works well, so I guess it's because of the launcher. While using KissLauncher, I can adjust it. But, I have to do it on the settings app. It's a little frustrating. Please fix this, thank you.

thanks!

This adds modulus (remainder) division to the calculator.

<!--

Thanks for taking the time to make KISS better by contributing code!

Before you open the pull request, please make sure that:

• Your pull request title is clear enough -- ideally, reading the title should be enough to understand the content
• Your description explains what you're trying to do (ideally referencing some existing issues)
• If you made any tradeoffs, please mention them and explain why you think they were necessary
• Include screenshots of your changes
• If you add something slightly complex, feel free to create a new documentation page, users will thank you for that!

You might also want to have a look at the "Before contributing..." section ;)

Once again, thanks for your help! Feel free to remove all this text and start typing...

-->

• fix off by one error: positions are already valid indices
• we need to add one to get a valid count here to miss no view on update

<!--

Thanks for taking the time to make KISS better by contributing code!

Before you open the pull request, please make sure that:

• Your pull request title is clear enough -- ideally, reading the title should be enough to understand the content
• Your description explains what you're trying to do (ideally referencing some existing issues)
• If you made any tradeoffs, please mention them and explain why you think they were necessary
• Include screenshots of your changes
• If you add something slightly complex, feel free to create a new documentation page, users will thank you for that!

You might also want to have a look at the "Before contributing..." section ;)

Once again, thanks for your help! Feel free to remove all this text and start typing...

-->

Describe the bug A notification with setOngoing(false) inside a NotificationChannel with setShowBadge(false) makes the App icon have a badge. It seems the NotificationChannel setShowBadge(false) is not looked at at all in the logic to determine, whether to put a badge or not.

Expected behavior It should not have a badge. This works correctly in the stock launcher.

i think so too! Will close for now

• notification dots now respects profiles
• notification dots now uses user and package for identification
• fixes #1604

<!--

Thanks for taking the time to make KISS better by contributing code!

Before you open the pull request, please make sure that:

• Your pull request title is clear enough -- ideally, reading the title should be enough to understand the content
• Your description explains what you're trying to do (ideally referencing some existing issues)
• If you made any tradeoffs, please mention them and explain why you think they were necessary
• Include screenshots of your changes
• If you add something slightly complex, feel free to create a new documentation page, users will thank you for that!

You might also want to have a look at the "Before contributing..." section ;)

Once again, thanks for your help! Feel free to remove all this text and start typing...

-->

I am using the latest version of KISS on F-Droid. I have enabled notification dots but, when I have two versions of the same app, one in the main profile and one in the work profile, if one has a notification, KISS shows a dot on both apps.

Example:

• Whatsapp1 is on the main profile;
• Whatsapp2 is on the work profile;

I receive a message to my Whatsapp1. Both my whatsapp1 and my whatsapp2 icons will have the notification dot, when only the whatsapp1 icon should have.

Environment

• ejabberd version: 21.1.0
• Erlang version: 10.5
• OS: Linux (Ubuntu)
• Installed from: docker ejabberd/ecs

Errors from error.log/crash.log

2021-04-19 15:17:26.752692+00:00 [error] <0.1384.0>@mod_http_api:handle/4:258 REST API Error: send_message([{<<"type">>,<<"normal">>},
                              {<<"from">>,<<"user1@localhost">>},
                              {<<"to">>,
                               <<"user2@localhost">>},
                              {<<"subject">>,<<"Hello">>},
                              {<<"body">>,<<"world">>}]) -> error:{try_clause,
                                                                   {message,
                                                                    <<"4977454225270036420">>,
                                                                    normal,
                                                                    <<>>,
                                                                    {jid,
                                                                     <<"user1">>,
                                                                     <<"localhost">>,
                                                                     <<>>,
                                                                     <<"user1">>,
                                                                     <<"localhost">>,
                                                                     <<>>},
                                                                    {jid,
                                                                     <<"user2">>,
                                                                     <<"localhost">>,
                                                                     <<>>,
                                                                     <<"user2">>,
                                                                     <<"localhost">>,
                                                                     <<>>},
                                                                    [{text,
                                                                      <<>>,
                                                                      <<"Hello">>}],
                                                                    [{text,
                                                                      <<>>,
                                                                      <<"world">>}],
                                                                    undefined,
                                                                    [],#{}}} [{mod_admin_extra,
                                                                               send_message,
                                                                               5,
                                                                               [{file,
                                                                                 "src/mod_admin_extra.erl"},
                                                                                {line,
                                                                                 1485}]},
                                                                              {mod_http_api,
                                                                               handle2,
                                                                               4,
                                                                               [{file,
                                                                                 "src/mod_http_api.erl"},
                                                                                {line,
                                                                                 268}]},
                                                                              {mod_http_api,
                                                                               handle,
                                                                               4,
                                                                               [{file,
                                                                                 "src/mod_http_api.erl"},
                                                                                {line,
                                                                                 229}]},
                                                                              {mod_http_api,
                                                                               perform_call,
                                                                               4,
                                                                               [{file,
                                                                                 "src/mod_http_api.erl"},
                                                                                {line,
                                                                                 189}]},
                                                                              {mod_http_api,
                                                                               process,
                                                                               2,
                                                                               [{file,
                                                                                 "src/mod_http_api.erl"},
                                                                                {line,
                                                                                 142}]},
                                                                              {ejabberd_http,
                                                                               process,
                                                                               2,
                                                                               [{file,
                                                                                 "src/ejabberd_http.erl"},
                                                                                {line,
                                                                                 373}]},
                                                                              {ejabberd_http,
                                                                               process_request,
                                                                               1,
                                                                               [{file,
                                                                                 "src/ejabberd_http.erl"},
                                                                                {line,
                                                                                 496}]},
                                                                              {ejabberd_http,
                                                                               process_header,
                                                                               2,
                                                                               [{file,
                                                                                 "src/ejabberd_http.erl"},
                                                                                {line,
                                                                                 293}]}]

Bug description

I'm trying to send message from user1@localhost to user2@localhost through REST API, but I have a 500 "internal_error" response (all other API endpoints are working well and as expected). Above error message found in error.log (the same is in ejabberd.log).

This is failing with all message types (normal, chat, ...), and user1@localhost & user2@localhost are registered.

Thank you for your help!

1. Open chat with a contact (someone who has an avatar published)
2. Have the contact remove their own avatar
3. Observe their avatar in Dino

Expect: Dino should revert to the default (ie colored square with a letter).

Actual: No change observed.

Dino version: 0.2.0~git86.20210412.328c3cf

Per XEP-0084 3.5 Publisher Disables Avatar Publishing receiving the following indicates that a contact has removed their avatar:

<message id='bAQ4v0lrHFlpSZFB' type='headline' from='[email protected]'>
  <event xmlns='http://jabber.org/protocol/pubsub#event'>
    <items node='urn:xmpp:avatar:metadata'>
      <item id='5daf833b-b81b-4896-9e5c-689dd73627b6'>
        <metadata xmlns='urn:xmpp:avatar:metadata'/>
      </item>
    </items>
  </event>
</message>

With servers supporting more of XEP-0060 on users PEP services, it may also be good to handle purge if it isn't too much trouble:

<message id='w46wOynPy-IFRdfm' type='headline' from='[email protected]'>
  <event xmlns='http://jabber.org/protocol/pubsub#event'>
    <purge node='urn:xmpp:avatar:metadata'/>
  </event>
</message>

Or even the nuclear option...

@woj-tek Thank you Hello,I did not found where I can create the room,so I have no room address.I can just create the room address written in database directly or other place?

Which address did you provide to join/create the room? It shouldn't make a difference.

I just tried and it worked without an issue.