profile
viewpoint
Oliver Kopp koppor Germany https://orcid.org/0000-0001-6962-4290 Core developer of @JabRef and @adr. The code and views expressed are not necessarily the views of my employer.

ad-m/github-push-action 413

GitHub actions to push back to repository eg. updated code

JabRef/JabRef-Browser-Extension 60

Browser extension for JabRef to allow importing of new items directly from the browser.

dante-ev/docker-texlive 28

Full TeX Live

dotCtor/jQuery.msgBox 24

A smart message window plugin for jQuery.

java-diff-utils/java-diff-utils-jycr 23

A library for computing diffs, applying patches, generation side-by-side view in Java

flesler/XMLWriter 13

XML generator for Javascript, based on .NET's XMLTextWriter.

adr/e-adr 12

Architectural Decisions Records embedded in Java code

JabRef/scimappr 12

Scientific Mind Mapping

adr/serepo 6

Software Engineering Repository

adr/eadlsync 3

Synchronization tool to synchronize embedded architectural decisions in Java with a SE-Repo

push eventcontextswitcher/contextswitcher

Oliver Kopp

commit sha 9dd3d11752a791bcc4f8ea6ce23e4ddc5f03ceb0

Update README.md

view details

push time in a day

Pull request review commentSE761Team4/jabref

[WIP]Feature/jabmap webview inside jabref

+package org.jabref.gui.maintable;++import javafx.scene.control.SplitPane;+import javafx.scene.layout.Pane;+import javafx.scene.web.WebEngine;+import javafx.scene.web.WebView;+import org.jabref.gui.JabRefFrame;+import org.jabref.gui.StateManager;+import org.jabref.gui.actions.SimpleCommand;++public class OpenJabMapAction extends SimpleCommand {+    private final JabRefFrame jabRefFrame;+    private final StateManager stateManager;+    private final SplitPane splitPane ;+    private Pane jabMapPane;++    public OpenJabMapAction(JabRefFrame jabRefFrame, StateManager stateManager, SplitPane splitPane) {+        this.jabRefFrame = jabRefFrame;+        this.stateManager = stateManager;++        this.splitPane = splitPane;+        jabMapPane = new Pane();++        initJabMapPane();++        //for the first run /empty+    }++    private void initJabMapPane(){++        WebView browser = new WebView();++        WebEngine webEngine = browser.getEngine();+        webEngine.load("http://google.com");  //gwl for next step, please modify here to show jabmap index.html+        browser.setPrefSize(1400, 800);+        jabMapPane.getChildren().add(browser);+    }++    @Override+    public void execute() {+

Please no empty line at the beginning of a method

WilbertGui

comment created time in a day

Pull request review commentSE761Team4/jabref

[WIP]Feature/jabmap webview inside jabref

+package org.jabref.gui.maintable;++import javafx.scene.control.SplitPane;+import javafx.scene.layout.Pane;+import javafx.scene.web.WebEngine;+import javafx.scene.web.WebView;+import org.jabref.gui.JabRefFrame;+import org.jabref.gui.StateManager;+import org.jabref.gui.actions.SimpleCommand;++public class OpenJabMapAction extends SimpleCommand {+    private final JabRefFrame jabRefFrame;+    private final StateManager stateManager;+    private final SplitPane splitPane ;+    private Pane jabMapPane;++    public OpenJabMapAction(JabRefFrame jabRefFrame, StateManager stateManager, SplitPane splitPane) {+        this.jabRefFrame = jabRefFrame;+        this.stateManager = stateManager;++        this.splitPane = splitPane;+        jabMapPane = new Pane();++        initJabMapPane();++        //for the first run /empty+    }++    private void initJabMapPane(){++        WebView browser = new WebView();++        WebEngine webEngine = browser.getEngine();+        webEngine.load("http://google.com");  //gwl for next step, please modify here to show jabmap index.html

Please put comments above the statement

WilbertGui

comment created time in a day

Pull request review commentSE761Team4/jabref

[WIP]Feature/jabmap webview inside jabref

 package org.jabref.gui; -import java.net.Authenticator;- import javafx.application.Application; import javafx.application.Platform; import javafx.scene.control.Alert; import javafx.stage.Stage;-+import org.apache.commons.cli.ParseException;

https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace - otherwise, the imports are restorted.

WilbertGui

comment created time in a day

Pull request review commentSE761Team4/jabref

[WIP]Feature/jabmap webview inside jabref

 import javafx.scene.control.skin.TabPaneSkin; import javafx.scene.input.KeyEvent; import javafx.scene.input.TransferMode;-import javafx.scene.layout.BorderPane;

Please configrure IntelliJ as outlined in https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace

WilbertGui

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

+package org.jabref.model.entry;

Please add test cases

rowanh22

comment created time in a day

Pull request review commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

+package org.jabref.model.jabmap;++import java.util.ArrayList;+import java.util.List;++/**+ * This class is a data model for a complete mind map+ */+public class MindMap {++    private List<MindMapNode> nodes;+    private List<MindMapEdge> edges;++    public MindMap() {+        nodes = new ArrayList<>();+        edges = new ArrayList<>();+    }++    public MindMap(MindMapNode node) {+        nodes = new ArrayList<>();

For readability, I would move all field initializers to the constructor.

Better: Write a builder

You could try to use Lombok's builder: https://projectlombok.org/features/Builder (currently not in use in JabRef. Not sure, whether the other maintainers will accept it)

rowanh22

comment created time in a day

Pull request review commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

+package org.jabref.model.entry;++import com.google.gson.TypeAdapter;+import com.google.gson.stream.JsonReader;+import com.google.gson.stream.JsonWriter;+import org.jabref.logic.TypedBibEntry;+import org.jabref.model.database.BibDatabaseMode;+import org.jabref.model.entry.field.Field;+import org.jabref.model.entry.field.InternalField;+import java.io.IOException;+import java.util.*;

Please follow the setup-guide and adjust the intellij configuration --> optimize imports.

rowanh22

comment created time in a day

Pull request review commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

+package org.jabref.model.jabmap;

Please add test cases

rowanh22

comment created time in a day

Pull request review commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

+package org.jabref.logic.jabmap;++import org.jabref.gui.JabRefFrame;+import org.jabref.model.entry.BibEntry;++import java.util.List;++public class MindMapWriter {+    private static MindMapWriter _instance = null;++    private JabRefFrame jabRefFrame;++    private MindMapWriter() {+    }++    public MindMapWriter(JabRefFrame jabRefFrame) {

Logc should not access UI. Bad thing: The whole flow needs to be rethought. -- Reason: JabRef's aim is to work with local variables and not using global ones. jabRefFrame is sort of a global variable.

rowanh22

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentSE761Team4/jabref

Added loading bibtex -> mindmap and endpoint for getting current map

I have to comment with some secreenshots from JabRef's guides:

grafik

grafik

I know, it's much information - not sure, how I can structure it better. Possibly, I have to work on a checker to also check commit messages.

I really like the page https://chris.beams.io/posts/git-commit/

Why I do write it?

  1. Use the imperative mood in the subject line

😇

rowanh22

comment created time in a day

Pull request review commentJabRef/jabref

fixed 'copy key and link'

 Note that this project **does not** adhere to [Semantic Versioning](http://semve - We fixed an issue where the `.sav` file was not deleted upon exiting JabRef. [#6109](https://github.com/JabRef/jabref/issues/6109) - We fixed a linked identifier icon inconsistency. [#6705](https://github.com/JabRef/jabref/issues/6705) - We fixed the wrong behavior that font size changes are not reflected in dialogs. [#6039](https://github.com/JabRef/jabref/issues/6039)+- We fixed the failure to Copy citation key and link. [#5835](https://github.com/JabRef/jabref/issues/5835) - We fixed an issue where the sort order of the entry table was reset after a restart of JabRef. [#6898](https://github.com/JabRef/jabref/pull/6898) - We fixed an issue where no longer a warning was displayed when inserting references into LibreOffice with an invalid "ReferenceParagraphFormat". [#6907](https://github.com/JabRef/jabref/pull/60907).  ### Removed -## [5.1] – 2020-08-30

Please do not delete CHANGELOG headers

PremKolar

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

startedclearlydefined/spdx

started time in 2 days

startedclearlydefined/curated-data

started time in 2 days

issue closedJabRef/jabref

Integrate journal abbreviations into JabRef

Currently, the repository https://github.com/JabRef/reference-abbreviations contains several abbreviation lists. They should be maintained in JabRef itself and should be loaded automatically on startup.

  • [ ] check performance
  • [ ] check whether the files are disjunct
  • [ ] check that the abbreviations are correct
  • [ ] merge https://github.com/JabRef/reference-abbreviations into JabRef's code

closed time in 2 days

koppor

issue commentJabRef/jabref

Integrate journal abbreviations into JabRef

Implemented in https://github.com/JabRef/jabref/pull/5749.

koppor

comment created time in 2 days

issue commentkoppor/jabref

New cleanup for em dash

Help page for working on fetchers: https://devdocs.jabref.org/advanced-reading/fetchers

koppor

comment created time in 2 days

issue closedkoppor/jabref

The link file dialog does not popup anymore when dropping onto the file field

The following dialog is only shown when dropping to the preview or to the main table:

grafik

grafik

Possible when porting the dialog to JavaFX - see https://github.com/JabRef/jabref/pull/3200#issuecomment-327450362

closed time in 2 days

koppor

issue commentkoppor/jabref

The link file dialog does not popup anymore when dropping onto the file field

This is possibly obsolete with: https://github.com/JabRef/jabref/issues/121#issuecomment-368215205

koppor

comment created time in 2 days

pull request commentJabRef/jabref

Fix Drag and Drop on empty database

Related: https://github.com/JabRef/jabref/issues/121#issuecomment-368215205

MootezSaaD

comment created time in 2 days

push eventJabRef/jabref

MLEP

commit sha 545478f9999421df2e3a18c774ed6faa135f6081

Docs: ADR: correcting paths (#6919)

view details

push time in 2 days

PR merged JabRef/jabref

Docs: ADR: correcting paths
+19 -19

1 comment

1 changed file

mlep

pr closed time in 2 days

pull request commentJabRef/jabref

Docs: ADR: correcting paths

I just let it go. Not sure, why relative paths are not working any more.

mlep

comment created time in 2 days

issue closedkoppor/jabref

Normalize Author Names should be able to treat multiple ,

Florian Maier, Andreas Wohlfrom, Falko Koetter, Sabrina Merkel-Malkowskiy and Daniel Zech

should be normalized to

Maier, Florian and Wohlfrom, Andreas and Koetter, Falko and Merkel-Malkowskiy, Sabrina and Zech, Daniel

Currently, it is normalized to

Florian Maier, Andreas Wohlfrom, Falko Koetter Sabrina Merkel-Malkowskiy and Zech, Daniel

I know, we had huge discussions about that. I need to dig into that and understand why THREE commas and ONE AND are not interpreted as case where the first names are ill formatted.

Source of the names: copy and paste of a paper

grafik

Source of the PDF: https://www.thinkmind.org/index.php?view=article&articleid=energy_2016_2_30_30051

closed time in 2 days

koppor

issue commentkoppor/jabref

Normalize Author Names should be able to treat multiple ,

Frozen, because only required if we parse names manually.

koppor

comment created time in 2 days

startedKDE/cirkuit

started time in 2 days

startedfhackenberger/ktikz

started time in 2 days

issue openedJabRef/JabRef4Word

JabRef4Word - this C# code is obsolete

See https://github.com/JabRef/jabref/issues/6904#issuecomment-692854957 for details

created time in 3 days

push eventlatextemplates/scientific-thesis-template

github-actions[bot]

commit sha d18f92d6af3bad7a3101f5761d65749c33bf35da

Deploy to GitHub pages

view details

push time in 3 days

startedpschichtel/JavaCAN

started time in 4 days

GollumEvent
GollumEvent

issue commentJabRef/jabref

Microsoft Word Integration simliar to LibreOffice

Initial code: https://github.com/JabRef/JabRef4Word - this is based on Docear4Word.

Siedlerchr

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentJabRef/jabref

fixed 'copy key and link'

 public void setHtmlContent(String html) {         setPrimaryClipboardContent(content);     } +    //@overload

Please remove the comment

PremKolar

comment created time in 4 days

Pull request review commentJabRef/jabref

fixed 'copy key and link'

 private void copyKeyAndLink() {             String url = entry.getField(StandardField.URL).orElse("");             keyAndLink.append(url.isEmpty() ? key : String.format("<a href=\"%s\">%s</a>", url, key));             keyAndLink.append(OS.NEWLINE);+            fallbackString.append(url.isEmpty() ? key : String.format("%s - %s", key, url));+            fallbackString.append(OS.NEWLINE);         } -        clipBoardManager.setHtmlContent(keyAndLink.toString());+        clipBoardManager.setHtmlContent(keyAndLink.toString(),fallbackString.toString());

Please fix checkstyle

        clipBoardManager.setHtmlContent(keyAndLink.toString(), fallbackString.toString());
PremKolar

comment created time in 4 days

PullRequestReviewEvent

push eventJabRef/jabref

Christoph

commit sha babad7801a9810dd4a85209ec38c1fbf31164474

Catch correct exception in LO inserter (#6907)

view details

push time in 4 days

delete branch JabRef/jabref

delete branch : fixwrongException

delete time in 4 days

PR merged JabRef/jabref

Catch correct exception in LO inserter status: ready-for-review

Discovered that bug while reproducing #6903

<!-- Describe the changes you have made here: what, why, ... Link issues that are fixed, e.g. "Fixes #333". If you fixed a koppor issue, link it, e.g. "Fixes https://github.com/koppor/jabref/issues/47". The title of the PR must not reference an issue, because GitHub does not support autolinking there. -->

<!--

  • Go through the list below. If a task has been completed, mark it done by using [x].

  • Please don't remove any items, just leave them unchecked if they are not applicable. -->

  • [x] Change in CHANGELOG.md described (if applicable)

  • [ ] Tests created for changes (if applicable)

  • [x] Manually tested changed features in running JabRef (always required)

  • [ ] Screenshots added in PR description (for UI changes)

  • [ ] Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

+3 -2

0 comment

2 changed files

Siedlerchr

pr closed time in 4 days

push eventJabRef/jabref

Oliver Kopp

commit sha d40135b188316cb1f5bc1c141ec0925c6fd969e9

Update CHANGELOG.md

view details

push time in 4 days

issue closedJabRef/jabref

Cannot run JabRef from Source

Hello together,

I wanted to run JabRef from source following the documentation: https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.

Everything builds correctly with gradle except that if I'm trying to run it, I get an error. The error looks like following:

2020-07-13 19_59_58-JabRef – JabRefMain java  JabRef main  IntelliJ IDEA

I've no clue why this happens, does anyone have similar issues?

Thanks in advance!

closed time in 4 days

DaniloMurer

issue commentJabRef/jabref

Cannot run JabRef from Source

We think the issue is solved. If not, please comment.

DaniloMurer

comment created time in 4 days

issue commentJabRef/jabref

Alt-F3 does not open keyword group view

I will try to install XFCE here and try to use the hotkey

rs-aesi

comment created time in 4 days

issue commentJabRef/jabref

Two versions of Jabref 5.1. while "listen to remote operation on port" 6500 is checked

@bernhard-kleine May I ask for an update?

bernhard-kleine

comment created time in 4 days

issue commentJabRef/jabref

Custom entry type cannot be added to bibliography

@DrFelder May I ask for an update?

DrFelder

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentJabRef/jabref

DOI matching in duplicate check

 public DOI(String doi) {         Matcher matcher = EXACT_DOI_PATT.matcher(trimmedDoi);         if (matcher.find()) {             // match only group \1-            this.doi = matcher.group(1);+            this.doi = matcher.group(1).replaceAll("[^\\w,/,:,-,.,-]|[_]", "");
            this.doi = matcher.group(1).replaceAll("[^\\w/:-.-_]", "");

Variable name: ILLEGAL_DOI_CHARACTERS --> Pattern.compile?

(devcall)

Siedlerchr

comment created time in 4 days

pull request commentJabRef/jabref

Rename menus citation style in preview style

DevCall:

  1. Renaming OK
  2. "build-in style" (not "JabRef style", because people can customize it) --> "customized preview style"

grafik

grafik

mlep

comment created time in 4 days

startedWitiko/markdown

started time in 4 days

startedjackc/pgx

started time in 4 days

push eventJabRef/user-documentation

Oliver Kopp

commit sha fb87f95dfd1f429ec98e9008c66ac7939eb2781c

Change link to IEEExplore

view details

push time in 5 days

push eventJabRef/user-documentation

Oliver Kopp

commit sha 2226084639892141cf824f8c305e6c204df5b151

Fix some links

view details

push time in 5 days

issue commentlatextemplates/LNCS

Switch to svproc.cls

@amandeep0429 Please refine your problem.

I tried to repodruce:

Download ftp://ftp.springernature.com/cs-proceeding/svproc/templates/ProcSci_TeX.zip (from mirror http://www.logdynamics.de/fileadmin/Upload/Dokumente/LDIC_2020/ProcSci_TeX.zip)

pdflatex:

$ pdflatex author.tex
This is pdfTeX, Version 3.14159265-2.6-1.40.21 (MiKTeX 20.7)
entering extended mode
(author.tex
LaTeX2e <2020-02-02> patch level 5
L3 programming layer <2020-08-07>

! LaTeX Error: File `svproc.cls' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: cls)

Enter file name:
! Emergency stop.
<read *>

l.14

!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on author.log.

Inspect the zip archive. In ../styles, there is svproc.cls. I copied that .cls file to the directory template. Now, pdflatex works

koppor

comment created time in 5 days

push eventJabRef/jstyles.jabref.org

randomchars42

commit sha d87e49d8bada595f98324822088fe928fda2a900

add style to index, add phdthesis and mastersthesis

view details

Oliver Kopp

commit sha cecf28ea95122a7aecdea222952a2fe8c4817670

Merge pull request #16 from randomchars42/master add style to index, add phdthesis and mastersthesis

view details

push time in 5 days

PR merged JabRef/jstyles.jabref.org

add style to index, add phdthesis and mastersthesis

added mastersthesis and phdthesis updated readme

+10 -2

1 comment

3 changed files

randomchars42

pr closed time in 5 days

startedabhivaikar/howtheytest

started time in 6 days

issue openedgitpod-io/gitpod

Touch scrolling also for Explorer and Markdown Preview on ChromeOS

Describe the bug

I'm trying to integrate GitPod in a Java project (https://github.com/koppor/jabref/pull/446).

I am on following environment:

Chrome OS Version: 85.0.4183.84 (Offizieller Build) (64-Bit)
Chrome: Version 85.0.4183.84 (Offizieller Build) (64-Bit)

I have opened gitpod.io in a tab.

I put the finger down in the Java editor and move the finger down. The text scrolls up. When doing the same gesture in the "EXPLORER" or the Markdown preview, nothing happens.

Steps to reproduce

  1. Start your Chromebook (or ChromiumOS in an emulatur - not tested)
  2. Open arbitrary GitPod.io project with many files (so that a scrollbar appears)
  3. Try to scroll in the "EXPLORER"

Expected behavior

Scrolling works

Additional information

--

Example repository

https://github.com/koppor/jabref/tree/gitpod-setup

created time in 8 days

issue openedkoppor/jabref

Update journallilst.mv only when abbr.jabref.org changes

Refs https://github.com/koppor/jabref/issues/470

created time in 8 days

issue closedkoppor/jabref

Full gradle build is made when running something

It seems that even trivial changes trigger a full recompilation. The gradle output suggests that it is due to org.apache.logging.log4j.plugins.processor.PluginProcessor. Also the run task takes quite some time.

Could be caused by https://github.com/JabRef/jabref/pull/6749

  • Refs https://github.com/JabRef/jabref/pull/6794

closed time in 8 days

koppor

issue commentkoppor/jabref

Full gradle build is made when running something

Should be fixed in latest master. With the drawback, that the .mv file with 1,5MB is updated each 14 days.

koppor

comment created time in 8 days

push eventkoppor/jabref

systemoperator

commit sha becc1c4589003873e65f02e86c2ea5b820e2dc72

Reimport -> Reload (#6874)

view details

MLEP

commit sha c0b139a946dd4a332c63850ae4fe3f49b11e37ac

Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876) * SAO/NASA Astrophysics Data System -> SAO/NASA ADS (1/2) In drop-down menu for fetching by ID of the window "Select entry type", "SAO/NASA Astrophysics Data System" is quite long. Replacement by SAO/NASA ADS (people knowing it will recognized it). Remark: second PR coming to complement this one * Finishing, for the test (2/2) * Update Changelog

view details

Oliver Kopp

commit sha 05b9d938a22529b06231e1262b6b09faec96f12e

Add mlep's other email adress

view details

Oliver Kopp

commit sha e89a0e49c5f710418b4c4714ce4667d8ad2c7f25

Add MD031 to lint ignore list

view details

MLEP

commit sha b640a66c50d6341756f7e2c93a8dd7632c8ac3b0

Dev Doc: Moving around ADR (end?) (#6873)

view details

Siedlerchr

commit sha b6d1906bfa397f2861ecb07f19c46ef2ebaafd84

lint changelog

view details

dependabot[bot]

commit sha e6c3a44e544f187e21ffa596905691527ddf0807

Bump mockito-core from 3.5.7 to 3.5.10 (#6886) Bumps [mockito-core](https://github.com/mockito/mockito) from 3.5.7 to 3.5.10. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](https://github.com/mockito/mockito/compare/v3.5.7...v3.5.10) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 49815cdc415984707d8f369c177388a9505a2ca2

Bump pdfbox from 2.0.20 to 2.0.21 (#6885) Bumps pdfbox from 2.0.20 to 2.0.21. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha aa14db98bff27c29e71fe018c425e2b450a292ba

Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884) Bumps com.github.ben-manes.versions from 0.29.0 to 0.30.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 89ef03eabaaffa6e6a78a0930a2f6e8c856eef1f

Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882) Bumps org.beryx.jlink from 2.21.3 to 2.21.4. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 0d0a70d73bd3d42aae29ee9a06e622a545ee2970

Bump fontbox from 2.0.20 to 2.0.21 (#6883) Bumps fontbox from 2.0.20 to 2.0.21. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 1305d06fe2ceb4e3f278c8235ff8f2b588562129

Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881) Bumps lucene-queryparser from 8.6.1 to 8.6.2. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

MLEP

commit sha 70c43207e8fa07b863259dbc1b23b57c4336aca6

Dev-doc: ADR list (#6887) * ADR: duplicate number: renumberrin * Completing ADR list in doc

view details

Tobias Diez

commit sha 6dec1747d8a1c89f6c62fc1d1939d88411f17eba

Complete rebranding of `bibtexkey` as `citationkey` (#6875)

view details

MLEP

commit sha 46e9fe22d528dcde41f3440655f569e2d7adb0ce

Window "Manage field names & content": make title consistent with menu (+ localization) (#6895) * Manage field names & content: make window title as menu title (+ localization) * Window "Manage field names and content": same title as the menu (+ localization) * Adding PR number to changelog * Update CHANGELOG.md Co-authored-by: Christoph <cschwentker@gmail.com>

view details

Christoph

commit sha 1d2ecffa1b07d930c0ff936e2574d102aaf7255d

Fix sort order in main table not stored (#6898) * Fix sort order in main table not stored Compare propertys correctly with equals * add issue to changelog

view details

push time in 8 days

push eventkoppor/jabref

Oliver Kopp

commit sha 3f9a508a80c2145aecdca9bc43346216f57d60d5

Also release a binary in the "master-release" branch (which is to test releases)

view details

Oliver Kopp

commit sha fd08f8d7248682256d517d81fdf7fc246ca85d49

Update JDK14 from 34 to Build 36 (2020/2/6) - Release Candidate Source: https://jdk.java.net/14/

view details

Oliver Kopp

commit sha 8111707f7edac23bbe54f3abc7bc0acb1ba37809

Refine list of external libraries

view details

Galileo Sartor

commit sha 21c6e5e680c1d0ff4d0e278c2dc89a4f86bbb68d

snap: fix for native-messaging-host permissions (#6062) * snap: fix for native-messaging-host permissions add hook for chrome/chromium * snap: fix no newline * Add snap browser integration to changelog

view details

Galileo Sartor

commit sha 8fdfcfa7760ed56c00fc561663443dfa34003cd9

Use github action to publish snap

view details

Tobias Diez

commit sha 8660e290a9e36103dcc30b81cedc37815c17eeaa

Remove ci prefix for releases

view details

Oliver Kopp

commit sha 2978deea1f713055921ee047cd9d0657db204627

Remove suffix "-ci.1" from version information stored in BuildInfo

view details

Oliver Kopp

commit sha 3d9eccce7e757ac56a4db15cd5cf0a5fa1da69e2

Revert "Remove ci prefix for releases" This reverts commit 8660e290a9e36103dcc30b81cedc37815c17eeaa.

view details

Oliver Kopp

commit sha 6a4df6f09b915f8f66ccb05d52f2bf3b317eac31

Refine external-libraries.txt

view details

Oliver Kopp

commit sha 2a1367438e015ce1094fca812295d7dc800c9713

Release v5.0

view details

Oliver Kopp

commit sha 6a4fa61f0e15a5b5498f50b4b1633c45fe4237fc

Add empty line to deployment.yml to trigger build

view details

Oliver Kopp

commit sha d8e4c11872619ab4e5dc1375e9a2cef57b5f1700

Update GitVersion action from v0.3 to v0.9.1 (#6061)

view details

Oliver Kopp

commit sha 1a7a4df515ee53d39d2c12921d214de67a0c3f6a

Build snap only for master branch

view details

Oliver Kopp

commit sha 29ed8fe0f9ad2c4a8dff5c19fb45e103c89cf24f

Merge remote-tracking branch 'origin/snapcraft-publish-action' into master-release

view details

Oliver Kopp

commit sha ecf822e1dee8a18dd248a3f1c99220a9ed665417

Try to build snapcraft image also on master-release

view details

Oliver Kopp

commit sha 1d6887e371cb53e00686aec5f743c117e3c9aadb

Add debug output for snap file location

view details

Oliver Kopp

commit sha cd707467ab5ffb7d5c0097661af54551027d7097

Remove obsolete step

view details

github actions

commit sha 4bdedcb2fe96ee24b23184195cd79bcfe4f610ad

Merge commit 'dbd48659bba98c38d48b902641cfda93aa211a61'

view details

github actions

commit sha dbd48659bba98c38d48b902641cfda93aa211a61

Squashed 'src/main/resources/csl-locales/' changes from 2b94bf9fac..d0ee4d13c9 d0ee4d13c9 Update CONTRIBUTING.md git-subtree-dir: src/main/resources/csl-locales git-subtree-split: d0ee4d13c942648c2c88629aeb01f03a17fac72c

view details

Oliver Kopp

commit sha d27867f7352b95ad613dad7397f6e446f8398477

Move snap publishing to own workflow

view details

push time in 8 days

push eventkoppor/jabref

Oliver Kopp

commit sha 129ca0492c5086efba7d61ab838cf8c6f0dd3707

Update to Java 14

view details

push time in 8 days

issue commenttexdoc/diplomarbeit-mit-latex

changelog

Finde diese Art von Commit-Nachrichten gut.

Allerdings könnten sie "Anfänger" abschrecken. Würde das nicht erzwingen. Lieber etwas Mehraufwand auf unserer Seite. Nichtsdestoweniger finde ich https://github.com/git-chglog/git-chglog als Tool (auf den ersten Blick) ganz gut.

wp-seth

comment created time in 8 days

issue openedbanyan/github-story-points

Add privacy statement

Is it possible to add a privacy statement?

Example privacy statement: https://github.com/sindresorhus/privacy-policy/blob/master/chrome-extensions.md

created time in 8 days

issue commentbanyan/github-story-points

Count story points in cards

That would be a great feature!

jc064522

comment created time in 8 days

delete branch texdoc/diplomarbeit-mit-latex

delete branch : add-github-workflow

delete time in 8 days

create barnchtexdoc/diplomarbeit-mit-latex

branch : add-github-workflow

created branch time in 8 days

delete branch texdoc/diplomarbeit-mit-latex

delete branch : add-github-workflow

delete time in 8 days

push eventtexdoc/diplomarbeit-mit-latex

Oliver Kopp

commit sha 5a62e3fd259da834af2db0908589f195c02584de

Add initial build workflow

view details

Oliver Kopp

commit sha 0861e3adef0a54d171a5e0d6facf5c87ba3c6fbc

Merge pull request #6 from texdoc/add-github-workflow Add initial build workflow

view details

push time in 8 days

pull request commenttexdoc/diplomarbeit-mit-latex

Add initial build workflow

I merge to keep things going. Build issues can be fixed in another follow-up pr

koppor

comment created time in 8 days

issue commentSE761Team4/jabref

[8pt] Add (basic) REST-interface to JabRef

This refs https://github.com/jbibtex/jbibtex/pull/18#issuecomment-359752506 (could have been an alternative. We do not want to rely to an external library for writing BibTeX ^^).

koppor

comment created time in 8 days

Pull request review commentSE761Team4/jabref

[WIP] Rhar768/feature/23 rest interface

+package org.jabref.rest.resources;++import com.google.gson.Gson;+import com.google.gson.GsonBuilder;+import com.google.gson.JsonSerializer;+import com.google.gson.reflect.TypeToken;+import org.jabref.logic.jabmap.MindMapManager;+import org.jabref.model.entry.BibEntry;+import org.jabref.model.entry.BibEntrySerializer;+import org.jabref.model.entry.field.Field;++import javax.ws.rs.GET;+import javax.ws.rs.Path;+import javax.ws.rs.Produces;+import javax.ws.rs.core.MediaType;+import java.lang.reflect.Type;+import java.util.ArrayList;+import java.util.List;++@Path("/root")+public class RootResource {++    @GET+    @Path("entries")

Please foresee the possibilitiy to work on multiple libraries (libraries/current)

    @Path("libraries/current/entries")
rowanh22

comment created time in 8 days

Pull request review commentSE761Team4/jabref

[WIP] Rhar768/feature/23 rest interface

+package org.jabref.model.entry;++import com.google.gson.JsonElement;+import com.google.gson.JsonObject;+import com.google.gson.JsonSerializationContext;+import com.google.gson.JsonSerializer;+import org.jabref.model.entry.field.Field;+import org.jabref.model.entry.field.InternalField;++import java.lang.reflect.Type;+import java.util.*;++public class BibEntrySerializer implements JsonSerializer<BibEntry> {+    @Override+    public JsonElement serialize(BibEntry entry, Type typeOfSrc, JsonSerializationContext context) {+        JsonObject obj = new JsonObject();++        obj.addProperty("type", entry.getType().getName());+        obj.addProperty("cite_key", entry.getCiteKeyOptional().orElse(""));

Difficult decision here. Alternatives are null or to omit the field. It is OK for me to use the emptry string. Seems to be the JavaScript way.

rowanh22

comment created time in 8 days

Pull request review commentSE761Team4/jabref

[WIP] Rhar768/feature/23 rest interface

+package org.jabref.model.entry;++import com.google.gson.JsonElement;+import com.google.gson.JsonObject;+import com.google.gson.JsonSerializationContext;+import com.google.gson.JsonSerializer;+import org.jabref.model.entry.field.Field;+import org.jabref.model.entry.field.InternalField;++import java.lang.reflect.Type;+import java.util.*;++public class BibEntrySerializer implements JsonSerializer<BibEntry> {+    @Override+    public JsonElement serialize(BibEntry entry, Type typeOfSrc, JsonSerializationContext context) {+        JsonObject obj = new JsonObject();++        obj.addProperty("type", entry.getType().getName());

Please introduce a constant (public static final String JSON_TYPE)

General thing: We need to add two meta information to the JSON. We need to the bibtex content and the meta data type and key. They should not be mixed up. We need to consider that a user can add custom fields.

To be prepared for moree meta data, I would suggest a nested object

{
  "bibtex_metadata": {
    "type": "article",
    "key": "the-citation-key"
  }
}

In case a user adds bibtex_metadata as custom field in the entry editor, then the thing breaks.

Alternative: Do not add special handling for citationkey, because JabRef itself uses that field name.

Another thing:

Shouldn't one use typedEntry.getTypeForDisplay() for type writing (Source: org.jabref.logic.bibtex.BibEntryWriter#writeRequiredFieldsFirstRemainingFieldsSecond)

  TypedBibEntry typedEntry = new TypedBibEntry(entry, bibDatabaseMode);
  typedEntry.getTypeForDisplay();
rowanh22

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentSE761Team4/jabref

[WIP] Rhar768/feature/23 rest interface

+package org.jabref.rest.resources;++import com.google.gson.Gson;+import com.google.gson.GsonBuilder;+import com.google.gson.JsonSerializer;+import com.google.gson.reflect.TypeToken;+import org.jabref.logic.jabmap.MindMapManager;+import org.jabref.model.entry.BibEntry;+import org.jabref.model.entry.BibEntrySerializer;+import org.jabref.model.entry.field.Field;++import javax.ws.rs.GET;+import javax.ws.rs.Path;+import javax.ws.rs.Produces;+import javax.ws.rs.core.MediaType;+import java.lang.reflect.Type;+import java.util.ArrayList;+import java.util.List;++@Path("/root")

Is it possible to omit /root?

@Path("/")
rowanh22

comment created time in 8 days

Pull request review commentSE761Team4/jabref

[WIP] Rhar768/feature/23 rest interface

+package org.jabref.rest.resources;++import com.google.gson.Gson;+import com.google.gson.GsonBuilder;+import com.google.gson.JsonSerializer;+import com.google.gson.reflect.TypeToken;+import org.jabref.logic.jabmap.MindMapManager;+import org.jabref.model.entry.BibEntry;+import org.jabref.model.entry.BibEntrySerializer;+import org.jabref.model.entry.field.Field;++import javax.ws.rs.GET;+import javax.ws.rs.Path;+import javax.ws.rs.Produces;+import javax.ws.rs.core.MediaType;+import java.lang.reflect.Type;+import java.util.ArrayList;+import java.util.List;++@Path("/root")+public class RootResource {++    @GET+    @Path("entries")+    @Produces(MediaType.APPLICATION_JSON)+    public String getEntries() {+        List<BibEntry> entries = MindMapManager.instance().getBibEntries();

This code is a bit strange. I would go to the current opened library directly instead of routing the request throught he MindMapManager. (Since one does not need to be that specific here, the more general "object" is enough)

rowanh22

comment created time in 8 days

PullRequestReviewEvent

pull request commentJabRef/jabref

Rename bibtexkey

Why "Citation key"? Because BibLaTeX calls it like that:

grafik

calixtus

comment created time in 8 days

PR closed SE761Team4/jabref

Add initial http endpoint
+277 -242

2 comments

34 changed files

rowanh22

pr closed time in 8 days

pull request commentSE761Team4/jabref

Add initial http endpoint

Obosolete. Follow-up: https://github.com/SE761Team4/jabref/pull/59

rowanh22

comment created time in 8 days

push eventtexdoc/diplomarbeit-mit-latex

seth

commit sha 8ede352c0a2cbde1df52d73e3d8b186160b72c40

fix(bib): added missing publishers; updated entry

view details

seth

commit sha c47c3426a64e4987d3232b2259395de57557576d

fix: get rid of underfull/overfull boxes by using package tabularx and reformatting and reformulating

view details

seth

commit sha f2b1afc9f7e3cfb5c201c4f63012f65016a146f2

fix: updated koma; use scrhack to avoid warnings updated koma scrbook params package 'listings' uses old koma script, therefore added package scrhack

view details

seth

commit sha d0015263995c5a323f6bbfe46e44937e1e9012bf

fix: get rid of overfull boxes in TOC

view details

seth

commit sha dbb689675e66e4f15a8520baf5d2ac42d06d6995

feat: removed font package luximono seems to be too exotic

view details

seth

commit sha 35f624518ebac90aff795c49e7997dccc75ea0f0

chore: typos

view details

seth

commit sha 1f690c3b1b9c146da1218779e77bfd367eda4b73

docs: updated old download urls; readme; ...

view details

seth

commit sha 3fba11692178f541a4ca5ea0bf2296c855b39afb

style: less vertical whitespace

view details

seth

commit sha 35a7d9db7271b05975b6c5b6fb0fb7d0225d33e6

feat: modernized beginning chapters; updated links

view details

Oliver Kopp

commit sha f632442891de1b61ca59b0633a023ee19563ba3d

Merge branch 'master' into master

view details

Oliver Kopp

commit sha c882fbd2031843d1725064b4679b8bd41b43ad2e

Merge pull request #2 from wp-seth/master

view details

Oliver Kopp

commit sha fe76c7b4ba958baa09b06b1bf2706353aa040a16

Update README.md

view details

Oliver Kopp

commit sha 5a62e3fd259da834af2db0908589f195c02584de

Add initial build workflow

view details

push time in 8 days

delete branch dante-ev/docker-texlive

delete branch : add-luximono

delete time in 9 days

push eventdante-ev/docker-texlive

Oliver Kopp

commit sha 8488ace545d96290293980c7df8f795516fb5f3a

Add luximono

view details

push time in 9 days

push eventdante-ev/docker-texlive

Oliver Kopp

commit sha ba205de21a73224cdce062d65575e0ff3741e6d2

Add luximono

view details

push time in 9 days

create barnchdante-ev/docker-texlive

branch : add-luximono

created branch time in 9 days

startedreitzig/texlive-docker

started time in 9 days

push eventtexdoc/diplomarbeit-mit-latex

Oliver Kopp

commit sha e78a187003edab5e3b91ab9c3898d9b014d8c58f

Convert to utf-8 (and add build for template_diplomarbeit)

view details

push time in 9 days

issue openedtexdoc/diplomarbeit-mit-latex

Neue Lizenz

Der Original-Author hat zugestimmt, die Lizenz zu ändern.

Die GFDL zwingt alle Änderungen auch wieder öffentlich zu machen. Da das hier ein Template ist, muss auch die Masterarbeit (usw) im Quelltext wieder veröffentlicht werden.

Ich würde "CC0" vorschlagen, damit das LaTeX-Universum "ungestört" wachsen kann.

created time in 9 days

create barnchtexdoc/diplomarbeit-mit-latex

branch : add-github-workflow

created branch time in 9 days

more