This PR suggests to improve ls command.

Sample

Definitions are below; a little bit different from sample codes in #234, I added some modules and classes have the same methods.

class P
  def m() end
  def m2() end
end

class C < P
  def m1() end
  def m2() end
end

module M
  def m1() end
  def m3() end
end

module M2
  include M
  def m4() end
end

obj = C.new; obj.extend M2; def obj.m5() end;

Before

> ls obj
M#methods: m1  m3
M2#methods: m4
C.methods: m5
P#methods: m
C#methods: m1  m2

After

> ls obj
P#methods: m
C#methods: m2
M#methods: m1  m3
M2#methods: m4
C.methods: m5

Good day developers,

I have tested this and can say on macOS 11 it does not work. Does it work on your site?

When I test it with KeepassXC 2.6.6, the macOS Finder shows me that the creation time was not retained when saving the database.

Originally posted by @dsh4dtw in https://github.com/keepassxreboot/keepassxc/pull/6576#issuecomment-864475847

It would appear based on my testing that this is a Qt bug on macos. Everything is being called correctly but the creation time is not set. This applies to safe and unsafe saves.

I wonder if hs.application.applicationsForBundleID should be used instead to reduce the risk of Hammerspoon getting the wrong application (ie if you have a Safari window open with the VOX website, etc)?

Makes sense. As I understand hs.application.applicationsForBundleID it returns a table with applications with the given BundleID, so the only check that is needed is for a non-empty table. I.e. there is no need to call isRunning() on an app from the table to confirm?

@droidmonkey Good day developers,

I have tested this and can say on macOS 11 it does not work. Does it work on your site?

When I test it with KeepassXC 2.6.6, the macOS Finder shows me that the creation time was not retained when saving the database.

That is Firefox...

View Test Results

1 files      2 suites   57m 9s :stopwatch: 338 tests 332 :heavy_check_mark: 0 :zzz: 6 :x:

For more details on these failures, see this check.

Results for commit 6fb4bc23.

Codecov Report

Merging #2908 (6fb4bc2) into master (3713f70) will decrease coverage by 0.12%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
- Coverage   27.22%   27.09%   -0.13%     
==========================================
  Files         180      180              
  Lines       36148    36148              
==========================================
- Hits         9841     9795      -46     
- Misses      26307    26353      +46     

I noticed that too. Many connections to both Google and Amazon servers immediately after starting Firefox with the KeePassXC browser extension.

Fix for case when VOX isn't running and hence hs.application.find("VOX") returns nil. Fixes #2906.

Handle isRunning() throwing an error if VOX is not running. Fixes #2906.

I'm going to close this PR and put in a fresh clean up.

Changed the getCenter() function for Polygon & Polyline. Now it uses map.un-/project() of the latlngs instead of the pre-generated _rings with latLngToLayerPoint().

Also added the center functions to PolyUtil and LineUtil, because then the function can be used without creating a Polyline/-gon and adding it to the map:

Visible changes:

Polyline:

• if getCenter() is called on a low zoom level (0), then the returned point is not anymore the first latlng:
• getCenter() returns the same point no matter which zoom level (2 & 16)

Polygon:

• if getCenter() is called on a low zoom level (0), then the returned point is not anymore the first latlng:
• getCenter() returns the same point no matter which zoom level (8 & 16)

Thanks!

This PR updates the build status badge in the README to show the currently-used one.

View Test Results

1 files      2 suites   20m 38s :stopwatch: 338 tests 337 :heavy_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit bb7a6922.

Codecov Report

Merging #2907 (bb7a692) into master (3713f70) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head bb7a692 differs from pull request most recent head f25664b. Consider uploading reports for the commit f25664b to get more accurate results

@@           Coverage Diff           @@
##           master    #2907   +/-   ##
=======================================
  Coverage   27.22%   27.23%           
=======================================
  Files         180      180           
  Lines       36148    36148           
=======================================
+ Hits         9841     9844    +3     
+ Misses      26307    26304    -3     

The latest MSYS2 package mingw-w64-ucrt-x86_64-libxslt-1.1.34-4 is now in the official repository and it fixes the date/time issue on UCRT64.

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

Not seeing how I can set a label sorry.

(W431) shadowing upvalue 'app' on line 9

Handle isRunning() throwing an error if VOX is not running. Fixes #2906.

If I understood https://github.com/Leaflet/Leaflet/blob/master/CONTRIBUTING.md#improving-documentation right then editing .md files is sufficient

I dug into it a little more. Safari, Firefox, and Chrome all agree with the test. html5ever agrees with Gumbo and my reading of the spec. More details here. This could be a spec bug, so I filed an issue. It's more likely I'm just missing something subtle.

I also have this "probem". Last two characters of my password are uppercase and for some reason I always press Shift+Enter to submit the password. Then I have to retry without Shift. It wouldn't hurt to just allow submitting the form with Enter, ignoring key combinations.