profile
viewpoint
Keyan Zhang keyz @robinhood Menlo Park, CA http://keyan.io Engineering @robinhood. Prev: @facebook, @oculus, and @reactjs.

keyz/c311-get-started 13

An opinionated guide for setting up Racket and Emacs on a Mac

keyz/alfred-prettier 5

Run Prettier in Alfred

keyz/babel-plugin-transform-optimize-object-literal 4

Rewrites object and array literals with JSON.parse calls.

keyz/bn0 3

`bn0`: babel-node with pre-loaded nightly (stage-0) presets

keyz/advent-of-code-js 2

Advent of Code (in Modern JavaScript) http://adventofcode.com/

keyz/alfy 0

Create Alfred workflows with ease

keyz/animate.css 0

A cross-browser library of CSS animations. As easy to use as an easy thing.

keyz/ast-types 0

Esprima-compatible implementation of the Mozilla JS Parser API

keyz/astexplorer 0

A web tool to explore the ASTs generated by various parsers.

keyz/atom-simple-kill-ring 0

Emacs style ctrl-k, ctrl-y, and ctrl-w using a separate clipboard.

delete branch keyz/TypeScript

delete branch : master

delete time in 4 days

push eventkeyz/TypeScript

ExE Boss

commit sha 5e40f32f66355975575740f4913be34361acfdb1

fix(helpers): Use `hasOwnProperty.call`

view details

ExE Boss

commit sha e2ece0409f05708de91a1c5bf05bf60a172ea580

test(helpers): Update test baselines

view details

Armando Aguirre

commit sha 33333e86ebe6a37d87673bc59ab9311f0a21cd7c

Added toggleLineComment, toggleMultilineComment with jsx and tests

view details

Armando Aguirre

commit sha 97de811d4809dc1cb2fd5ccc5ec37b42fd73efe9

Fix multiline name

view details

Armando Aguirre

commit sha fc9753473e2f61ebd1cc7616d5343d7811dde4c5

Added jsx to singleLineComment

view details

Armando Aguirre

commit sha e5829881b52936ee8832d10d8deb3ef3cd5b95d8

Fixed toggleLineComment jsx cases

view details

Armando Aguirre

commit sha 937e3e88e122e3ffb62d686a2c0f34d42cbfb769

Added simplified result to ToggleComment

view details

Armando Aguirre

commit sha 090b38daa1a3ed1c2e86e9433bc62b3b10c71704

Updated d.ts baselines

view details

Armando Aguirre

commit sha 381dd8427a5356d8b394042e3683a9e843ce906c

Removed TextRange and added FileRangeRequestArgs

view details

Armando Aguirre

commit sha fe91f317de7adf6dd0af648505c5e06116e58214

Fixed uncomment bug

view details

Armando Aguirre

commit sha ee37d8e8d34e2c88fc32657c3a2515748bdc476d

Added comment and uncomment selection

view details

Armando Aguirre

commit sha 35a3d8547b82626de5f14525ae5fe8f846849f72

Fixed lint issues

view details

Armando Aguirre

commit sha 413a3d3eb4a1a3b21d8fb4b553b36ff27a078f96

Fixed more lint issues.

view details

Armando Aguirre

commit sha 89429ac6aaef2392265c5c30815a8df9fc2df2d7

Fixed lint errors

view details

Armando Aguirre

commit sha 40751ba89b343acab7731689d44b9f67b43bb7bf

Removed public commands

view details

Armando Aguirre

commit sha 9f03d7bad7e10a425edcc232a1e9be562f23916a

Use getFileAndLanguageServiceForSyntacticOperation

view details

Armando Aguirre

commit sha 0985afd51a90b29b5e929833f91d2544c10054a7

Fixed uncomment bug

view details

kingwl

commit sha 3b8ad5c870d63d1f3577786f412bdb1d9915155d

Add outlining spans for call expression or arrow body

view details

kingwl

commit sha 98a74ddfe8b1cc20cafdb319c93d79024ca015dc

Update baseline

view details

kingwl

commit sha 4d57d591d2a66d1e2b71ad40028a03bbc018ef04

Avoid semi

view details

push time in 7 days

starteddagster-io/dagster

started time in 7 days

startedogham/exa

started time in 9 days

startedjohnno1962/InjectionIII

started time in 14 days

startedauth0/jwt-decode

started time in 19 days

startedpastelsky/bundlephobia

started time in 21 days

startededwardtufte/tufte-css

started time in 22 days

startedlivegrep/livegrep

started time in a month

startedstephenou/fruitionsite

started time in a month

startedstatsd/statsd

started time in a month

startedhuggingface/transformers

started time in a month

push eventkeyz/TypeScript

BigAru

commit sha 4c80de907800ae366527f0c57a96b467e322906f

add multi vardecl

view details

BigAru

commit sha 367f47e75501c616626facff002fcc4aa2c274aa

fix multi decl bug

view details

BigAru

commit sha e697856a7d663118ce0895a3cd97b3cd0a81f10a

change refactor name

view details

BigAru

commit sha cc07d682105cf74682a59e4adbb14a61123f86cd

add tests for ToAnon, ToArrow and available arrow

view details

BigAru

commit sha 05c44f123e7b6cf166aef1df9041938a24f09131

add tests for ToNamed and available anon

view details

BigAru

commit sha d77186589495c770a52effee141feb0451ef93a9

add tests for ReturnType and available Arrow as FnParam

view details

BigAru

commit sha 62b9fccb981e2ed133d05dc4071da5c2c795684a

fix bug modifiers by toNamed

view details

BigAru

commit sha c25726e7649ab6b71da8bce7b97503d558d09f1e

add tests for modifiers

view details

BigAru

commit sha 7c78cd5c6f20047b0d238e9960bc67aaecb3bca1

fix for tslint error

view details

BigAru

commit sha 152e3621756f22c424508fec61316d2d6e27076a

adapt one test case

view details

BigAru

commit sha 6922f6c4cae774cdb9f3b5446600ca53be50fb95

refactor getInfo getAvailableActions

view details

BigAru

commit sha 39c3928e5d488b55fd889861f95dfe454fe9f752

refactor small progress

view details

BigAru

commit sha a9cb62379579510e1a17386be47009f07dc91c09

extract creation of block

view details

BigAru

commit sha 6bd26cd2e5c424963d4b8c03240986184f155f56

extract creation of funcDeclaration

view details

BigAru

commit sha 3e7dcad726033cc38ad3e844f52990cb29fa50c5

make guideline compliant

view details

BigAru

commit sha 649b53c8de762e09bd93caac6ec1348d1b1260fa

apply feedback from pr

view details

BigAru

commit sha 595131868f6cea6fc0db05b39ac7e76846f1662d

add testcase and apply feedback from pr

view details

BigAru

commit sha d97e07360cdcf382467cecaeba87011c776eb0eb

apply feedback from pr

view details

BigAru

commit sha 0fa2fadeca756093ea3a7824ebbd31d54718d398

add newline

view details

BigAru

commit sha 1c74d0eef402e9737ffc9532d541d1a0c51d03b1

rename testcases

view details

push time in a month

startedswitchablenorms/DeepFashion2

started time in 2 months

startedcssinjs/jss

started time in 2 months

startedbrianc/node-postgres

started time in 2 months

startedsequelize/sequelize

started time in 2 months

startedcalebmer/connect

started time in 2 months

startedintoli/user-agents

started time in 2 months

startedMarlamin/wow.tools

started time in 2 months

startedzpencerguy/fmarket

started time in 3 months

startedmoos/wordpos

started time in 3 months

push eventkeyz/dagster

Keyan Zhang

commit sha bd0791d110d4a78adabcbcb2afec4b6e3c861245

[docs] add a dead link detector (#2448) * [docs] add a dead link detector * add a sanity check for the parser

view details

Nate Kupp

commit sha bc7d2112142212ed7bb4dcb6581e42e6eb5505ef

(docs) restrict PrevNext to only work within top-level sections Test Plan: docs Reviewers: yuhan, sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2855

view details

yuhan

commit sha f1132d788a523370854b8b00b8ca9a8253134d9d

fix dead broken absolute links Summary: the new `mdxInternalLinks.test.ts` only checks links that start with "/docs". todo: we will also need to check the relative paths like "learn/guides/testing/testing" Test Plan: `yarn test` passed Reviewers: sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2857

view details

Sashank Thupukari

commit sha 881d98e64418e171b0dabefff35028d35410408f

[docs] Misc docs fixes Summary: - Fix css property warnings - Move all files inside `src/` - Fix highlight color Test Plan: yarn dev Reviewers: yuhan Reviewed By: yuhan Differential Revision: https://dagster.phacility.com/D2859

view details

yuhan

commit sha 5c2de1f220f14f9110263abdd771eb99a447b0d8

disallow relative link references Summary: force all internal links to start with '/' {F136613} Test Plan: yarn test Reviewers: sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2858

view details

prha

commit sha fdc4282126328f50f07c05b68b6e1da91be22f47

Handle unspecified assetName from URL Test Plan: Rendered assets root Reviewers: schrockn, sashank Reviewed By: schrockn Differential Revision: https://dagster.phacility.com/D2866

view details

Sashank Thupukari

commit sha 416a0aae5be6fc098af67955e7c2cd60565f620d

(dagster-api-2) Delete dagster repository cli commands Test Plan: unit Reviewers: schrockn, alangenfeld Reviewed By: schrockn, alangenfeld Differential Revision: https://dagster.phacility.com/D2800

view details

yuhan

commit sha 291789e2dd99a16eadbdbfd624c6172ca93f6f66

merge tutorial sub-sections. remove tutorial/sections/ Test Plan: yarn test yarn dev Reviewers: sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2861

view details

yuhan

commit sha f85f048930e1f2fdb2ef577e2e29f08d8790018e

doc fixs: add favicon and meta tags Summary: favicon: {F136869} meta tags preview: {F136870} following the guide here https://metatags.io/ Test Plan: yarn dev Reviewers: sashank, nate Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2865

view details

Max Gasner

commit sha af0c33c2aa46b3542df046d221885839a016bd1d

PipelineDefinition housekeeping Summary: Improve coverage Test Plan: Unit Reviewers: alangenfeld, prha Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D2836

view details

Nate Kupp

commit sha fe04cdb7b06558bd3d907facc34f64fa7dffdd11

Update documentation for release process Summary: Removing references to RTD and add step for release notes. Test Plan: docs only Reviewers: sashank, max, alangenfeld, yuhan Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D2864

view details

Nicholas Schrock

commit sha 829facf13680011af3427d4a1911f655176484b0

Fix execution plan snapshot subsetting and dagit rendering bug Summary: Execution plans are strange beasts at the moment when it comes to expressing sub plans. All the steps are there, and it is the step_keys_to_execute property that tells the engine what steps to actually execute. The snapshot layer did not account for this and never persisted that information. Interestingly, this only happened because this bug pre-existed the migration to snaphots. We were incorrectly rendering execution plans in re-execution scenarios. In this screenshot, we executed a single step but the other steps are there but in a skipped state Before -- {F136002} With this change we only render the executed subplan After -- {F136004} This was tricky to fix because we encode step_keys_to_execute in multiple locations. The invariant check in the create_run machinery ensures (hopefully) that no one screws up until we fix it properly. This may be hotfix worthy given that this information in persisted. Then again, the bug this fixes is a fairly minor display bug. However correctly persisting the snapshot ASAP would be pretty nice. Test Plan: BK Reviewers: alangenfeld, prha, max, yuhan, sashank Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D2850

view details

prha

commit sha 296d7ce74c88b17e8f9a0ee81f097eb80b9b2a1b

Add endpoint_url config for s3 compute log manager Summary: For https://github.com/dagster-io/dagster/issues/2438 Test Plan: Booted up local minio instance, configured endpoint_url to point to it, saw compute logs get written locally Reviewers: nate, schrockn Reviewed By: schrockn Differential Revision: https://dagster.phacility.com/D2867

view details

alangenfeld

commit sha 4064f5bf8e24eb8465c5d12f5b2dcfbabb7d026f

use update_wrapper on all decorators Summary: to ensure `__doc__` and other properties are transfered to definition objects Test Plan: updated test Reviewers: max, nate, sashank Reviewed By: max Differential Revision: https://dagster.phacility.com/D2844

view details

Sashank Thupukari

commit sha 17651512fef1927e03bb5ae941d3b717d66c2175

Fix external pipeline subselection bug Summary: Previously, when we called `create_execution_plan_index` with an external pipeline that was created from a solid subset, the pipeline definition that we retrieved for passing to `create_execution_plan` was the full pipeline, not the pipeline w/ subset. This is because we didn't persist the `solid_subset` information anywhere, and just used the `pipeline_name` to retrieve the pipeline definition. This diff stores the `solid_subset` information on `ExternalPipeline` so we can re-use it to retrieve the pipeline w/ subset Test Plan: 1. Load pipeline with multiple solids that require config 2. Select solid subset in Dagit 3. Delete extraneous config for solids that are not in the subset 4. Verify that there is no error Reviewers: schrockn, alangenfeld, max Reviewed By: schrockn, alangenfeld Differential Revision: https://dagster.phacility.com/D2870

view details

Max Gasner

commit sha a132dc6a10e35ff5743ce82e27533a7f521d8d40

1/ Unify execution logic Summary: Something something the hand that cuts is the hand that cures. This pulls out and improves on the refactor from D2809 and is intended to make review of that and further elements of the stack easier. Test Plan: Unit Reviewers: alangenfeld, schrockn Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D2847

view details

Max Gasner

commit sha dfd2f967aab93c0d7e7eb829199933103a3b419d

2/ Add execute_run API Summary: This brings test cases in line with, and simplifies understanding of, the dagster-graphql reexecution codepath. Depends on D2847. Test Plan: Unit Reviewers: alangenfeld, schrockn Reviewed By: schrockn Differential Revision: https://dagster.phacility.com/D2848

view details

Sashank Thupukari

commit sha 1a799cf1cd2d386c13a7bf11442001fa3d9c6484

0.7.12.pre0

view details

Sashank Thupukari

commit sha 87683389ba6e0fcc30ed49e97addcb1bbd9a309f

0.7.12

view details

Nicholas Schrock

commit sha a17c4d145e632be7972b21306692c522a8db5606

(external-config-schema-25) Use external apis in _start_pipeline_execution_for_created_run Summary: See title Depends on D2850 Test Plan: BK Reviewers: sashank, alangenfeld Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D2833

view details

push time in 3 months

startedphilipwalton/flexbugs

started time in 3 months

startedFormidableLabs/inspectpack

started time in 3 months

startedGoogleChrome/web-vitals-extension

started time in 3 months

push eventkeyz/dagster

Keyan Zhang

commit sha e7f39f57cf96dd990f6ce3408731f1ad89cf0a61

add a sanity check for the parser

view details

push time in 3 months

PR opened dagster-io/dagster

[docs] add a dead link detector

Summary: I found a few dead links on the new docs site. I think this could've been caught on the source (mdx) level before publishing, so I added a Jest test that does some basic static analysis on the mdx files.

Note: the test is not comprehensive yet. Specifically:

  1. It doesn't check the dynamic routes (apidocs/)
  2. When the link contains a target heading (e.g. "https://docs.dagster.io/docs/tutorial/advanced#reusable-solids"), it doesn't check whether the heading/slug actually exists.

Supporting these isn't hard but requires pulling out and reusing some existing logic, so I think it's probably better for someone on the team to do it. :) You can also find them as TODOs in the test file.


Test Plan: run yarn test under docs/next. The test should fail; however I didn't add the test to the CI pipeline, so it should be safe to be merged as-is.

 FAIL  src/__tests__/mdxInternalLinks.test.ts
  ✕ no dead links (659 ms)

  ● no dead links

    expect(received).toEqual(expected) // deep equality

    - Expected  -  1
    + Received  + 38

    - Array []
    + Array [
    +   Object {
    +     "deadLink": "tutorial/scheduler",
    +     "sourceFile": "deploying/airflow.mdx",
    +   },
    +   Object {
    +     "deadLink": "tutorial/modes",
    +     "sourceFile": "learn/concepts/index.mdx",
    +   },
    +   Object {
    +     "deadLink": "tutorial/hello_dag",
    +     "sourceFile": "learn/concepts/index.mdx",
    +   },
    +   Object {
    +     "deadLink": "tutorial/composite_solids",
    +     "sourceFile": "learn/concepts/index.mdx",
    +   },
    +   Object {
    +     "deadLink": "learn/guides/dagster_pandas#creating-dagster-dataframe-types",
    +     "sourceFile": "learn/guides/dagster_pandas/dagster_pandas.mdx",
    +   },
    +   Object {
    +     "deadLink": "learn/guides/dagster_pandas#dagster-dataframe-level-validation",
    +     "sourceFile": "learn/guides/dagster_pandas/dagster_pandas.mdx",
    +   },
    +   Object {
    +     "deadLink": "learn/guides/dagster_pandas#dagster-dataframe-custom-validation",
    +     "sourceFile": "learn/guides/dagster_pandas/dagster_pandas.mdx",
    +   },
    +   Object {
    +     "deadLink": "tutorial/config",
    +     "sourceFile": "learn/guides/partitioning/partition_pipeline.mdx",
    +   },
    +   Object {
    +     "deadLink": "learn//concepts#solid",
    +     "sourceFile": "tutorial/overview.mdx",
    +   },
    + ]
+1927 -45

0 comment

5 changed files

pr created time in 3 months

create barnchkeyz/dagster

branch : next-dead-link-detector

created branch time in 3 months

fork keyz/dagster

A Python library for building data applications: ETL, ML, Data Pipelines, and more.

fork in 3 months

startedpirix-gh/ts-toolbelt

started time in 3 months

more