profile
viewpoint
Kent C. Dodds kentcdodds @kentcdodds Salt Lake City, Utah, USA https://kentcdodds.com Improving the world w/ quality software · Husband, Father, Latter-day Saint, Teacher, OSS · http://TestingJavaScript.com · http://EpicReact.Dev · Be Kind

gatsbyjs/gatsby 47034

Build blazing fast, modern apps and websites with React

downshift-js/downshift 8704

🏎 A set of primitives to build simple, flexible, WAI-ARIA compliant React autocomplete, combobox or select dropdown components.

formium/tsdx 6245

Zero-config CLI for TypeScript package development

all-contributors/all-contributors 4602

✨ Recognize all contributors, not just the ones who push code ✨

istanbuljs/nyc 4346

the Istanbul command line interface

bvaughn/react-error-boundary 1716

Simple reusable React error boundary component

jaredpalmer/awesome-react-render-props 1295

Awesome list of React components with render props

c8r/kit 1200

Tools for developing, documenting, and testing React component libraries

conventional-changelog-archived-repos/validate-commit-msg 525

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard

all-contributors/all-contributors-cli 328

Tool to help automate adding contributor acknowledgements according to the all-contributors specification ✨

push eventkentcdodds/react-testing-library-examples

Kent C. Dodds

commit sha adf5eeedaf106193e3797b86a1133c1a0ff4c5e9

small improvements

view details

push time in an hour

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha f51f0a8b540109f81e655a944bcdb3b02aba2457

Update react-redux.js (#28)

view details

push time in an hour

pull request commentkentcdodds/react-testing-library-examples

Update react-redux.js

I still disagree with moving from function declarations to arrow functions :P

MichaelDeBoey

comment created time in an hour

PullRequestReviewEvent

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha ebca8852bb8f5dc9debb2d4ecde5a3a04eaa2eff

Update upload-file.js (#27)

view details

push time in an hour

PullRequestReviewEvent

pull request commenttesting-library/testing-library-docs

Update example-update-props.md

Thanks!

MichaelDeBoey

comment created time in an hour

push eventtesting-library/testing-library-docs

Michaël De Boey

commit sha 911abe8ef22aa24e89d2d79c3568af883a7d4a1e

Update example-update-props.md (#623)

view details

push time in an hour

PR merged testing-library/testing-library-docs

Update example-update-props.md

Bring in line with https://github.com/kentcdodds/react-testing-library-examples/blob/master/src/tests/update-props.js

+15 -16

0 comment

1 changed file

MichaelDeBoey

pr closed time in an hour

pull request commentkentcdodds/react-testing-library-examples

Update react-router.js

youre awesome

MichaelDeBoey

comment created time in 2 hours

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha 9310df7b35777cb53eb44674e9a4d8ba2fa59bf7

Update update-props.js (#26)

view details

push time in 2 hours

PullRequestReviewEvent

pull request commentkentcdodds/react-testing-library-examples

Update react-router.js

Thanks! It's a lot better now :)

MichaelDeBoey

comment created time in 2 hours

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha 6c09777bd7b4072320f04ebadae2e334c0313ebc

Update react-router.js (#25)

view details

push time in 2 hours

PullRequestReviewEvent

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha 588ae70762bd062113f92896e07fde15ec32cae7

Update react-router.js (#24)

view details

push time in 3 hours

PullRequestReviewEvent

Pull request review commentkentcdodds/react-testing-library-examples

Update react-router.js

 const App = () => (  // this is a handy function that I would utilize for any component // that relies on the router being in context-function renderWithRouter(ui, {route = '/'} = {}) {+const renderWithRouter = (ui, {route = '/'} = {}) => {

Haha, I don't like this change (https://kentcdodds.com/blog/function-forms), but it's no big deal.

Why don't we call this function render and alias the render that we import from @testing-library/react to rtlRender.

MichaelDeBoey

comment created time in 3 hours

PullRequestReviewEvent

pull request commentkentcdodds/react-testing-library-examples

Update react-router.js

Thanks!

MichaelDeBoey

comment created time in 4 hours

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha 1682ab28806061694c3c2828b8388343b9f416ee

Update react-router.js (#22)

view details

push time in 4 hours

PullRequestReviewEvent

push eventkentcdodds/react-testing-library-examples

Kent C. Dodds

commit sha 9ede7b5cd26c7a000c104aaa8897b40285140cd3

Update .travis.yml

view details

push time in 4 hours

push eventkentcdodds/react-testing-library-examples

Michaël De Boey

commit sha 0faa7efe0bff8a6241f049255614a28647e5d0e5

Update .travis.yml (#21)

view details

push time in 4 hours

PullRequestReviewEvent

push eventkentcdodds/kentcdodds.com

Kent C. Dodds

commit sha 2c80827f7b62fffdf918320dc6754b074c7a5292

Remove broken Russian translation link

view details

push time in 4 hours

push eventkentcdodds/kcd-discord-bot

Kent C. Dodds

commit sha 002038fd1e493fbdb72a08a4a07d3b5b33381351

Update manual-releases.md

view details

push time in 6 hours

push eventkentcdodds/kcd-discord-bot

Kent C. Dodds

commit sha 88e0d94a1d84390d911857562139bdc4791b302b

Update handle-updated-message.js

view details

push time in 13 hours

issue commentReactTraining/react-router

Sourcemaps not loading in development (v6)

No new release has taken place so I believe this is still an issue

kentcdodds

comment created time in 14 hours

issue closedkentcdodds/bookshelf

Branch exercises/11-unit-testing - api-client.exercise.js TODO

Hey Kent! In /src/utils/tests/api-client.exercise.js, you have a TODO: STOP, UPDATE THIS KENT comment in the file.

There isn't much context as to what should be updated but I wanted to let you know that that was there as it could be confusing for learners.

closed time in 20 hours

zacjones93

issue commentkentcdodds/bookshelf

Branch exercises/11-unit-testing - api-client.exercise.js TODO

Fixed! Thanks @zacjones93 :)

zacjones93

comment created time in 20 hours

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 873a65bdb34424cdb7820d54a2ab1bb1cb8e8f21

exercises/11-unit-testing

view details

push time in 20 hours

issue commenttesting-library/cypress-testing-library

[QUERY] Can multiple test-ids be configured?

Hi John,

Unfortunately I don't think this is possible. But you could make your own command for those.

And here's the CODE_OF_CONDUCT.md file: https://github.com/testing-library/cypress-testing-library/blob/master/other/CODE_OF_CONDUCT.md Thanks!

JohnJacobT

comment created time in 21 hours

issue commenttesting-library/cypress-testing-library

[QUERY] Can multiple test-ids be configured?

Whoops, wrong button 🤦‍♂️

JohnJacobT

comment created time in 21 hours

issue closedtesting-library/cypress-testing-library

[QUERY] Can multiple test-ids be configured?

Hello,

First of all, thank you for creating this.

This is not a 'issue', but a query: Can you configure more than one testid attribute?

The section Configure testId attribute shows how to change the default testId attribute to another. Is it possible to configure multiple testid attributes, if yes, how?

Cypress documentation about Selector Playground talks about different testid attributes in the order of priority. In a couple of projects, I am working on, I see different testId attributes used in different sections of a web app. With these two, I assume, it is not uncommon to encounter different test id attributes in the same web app. Hence the question.

In case, configuring multiple test id attributes are not currently supported, is there a plan to incorporate this feature in later releases?

Regards, John.

P.S - CODE_OF_CONDUCT.md, mentioned in the template that comes up while creating a new issue, is not found in this repository.

closed time in 21 hours

JohnJacobT

pull request commentbabel-utils/babel-plugin-tester

Add verbose option

I'd rather use http://npm.im/debug

It's a pretty standard tool for this kind of thing. I think our debug key could be simply babel-plugin-tester. Would you be willing to try that?

aminya

comment created time in 21 hours

issue closedkentcdodds/ama

Testing visuals with React Testing Library

I'm sold on using RTL for testing functional parts of my React app (e.g. if I click this button, make sure my list of books is updated to include another book).

How would you suggest to test the visuals? E.g. is the button visible?

Complexity that I see:

  • display: none
  • visibility: hidden
  • 0 area (width: 0 and height: 0)
  • overflow: hidden and this is positioned absolutely outside of the parent
  • another component is covering/overlapping it
  • text on the button is now the same color as the background, making it less usable to the user
  • ... <infinite more things that could go wrong>

I could use expect(...).toHaveStyle(...) from RTL.

I'm not convinced that such writing such visual tests is worth it or that I would know what specific styles to test for.

Curious if you have advice on how to test or if its not worth testing such things.

closed time in a day

pcattori

issue commentkentcdodds/ama

Testing visuals with React Testing Library

Yup! That's right :)

pcattori

comment created time in a day

push eventkentcdodds/kentcdodds.com

Peter Hozák

commit sha 89c3f45618925e4daa1a31d9c1f801f8f382e7fc

use screen and userEvent in a blog (#545)

view details

push time in a day

PR merged kentcdodds/kentcdodds.com

use screen and userEvent in a blog

is it OK to update random blogs when I notice you didn't use screen in them yet?

+10 -10

0 comment

1 changed file

Aprillion

pr closed time in a day

PullRequestReviewEvent

startedXiphe/test-real-styles

started time in a day

push eventkentcdodds/testing-react-apps

Kent C. Dodds

commit sha 988abcf1767e6883f04ea3c4dae5f2bf497b77da

email autofill

view details

Kent C. Dodds

commit sha bed4faa7fba8f2de7c495be2eef3238bd9841b17

update title

view details

push time in 2 days

delete branch kentcdodds/advanced-react-patterns

delete branch : accordion-maybe

delete time in 2 days

delete branch kentcdodds/advanced-react-patterns

delete branch : wip/major-updates

delete time in 2 days

delete branch kentcdodds/advanced-react-patterns

delete branch : create-workshop-app

delete time in 2 days

push eventkentcdodds/react-suspense

Kent C. Dodds

commit sha 269a950abe692338f41acb47337348561226fd16

update all the deps

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha b2b7b46a684d03ff20a2693df1d0efd56175d753

exercises/14-e2e-testing

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 3520e89e1121d95e2b24a6ce4ab659d6f3fbcbcb

exercises/13-integration-testing

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 1ef62bc77497b0cb44a639bc8d15c3216ac5c6c7

exercises/12-testing-hooks-and-components

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha c045bf7c834fdc41fb1e0796e83e617205764556

exercises/11-unit-testing

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha e370632c0e7d9757bcd1cbedc01df17dddb0c9f3

exercises/10-render-as-you-fetch

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha f9608ab6b3a3bdc8a9546d52ac3f34a841202bec

exercises/09-performance

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha dae401c298f43f2b2ac36d4a7b4b9030c607cf2b

exercises/08-compound-components

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 51613f9ccd4463f04bf4d27f60a90d2f6cbe3580

exercises/07-context

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 94345306e075355cebecf46bb9ef989da3e5c572

exercises/06-cache-management

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha a97135ddc48c0207afaf004fabe861bd18c6ce6f

exercises/05-routing

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 5e2656b26d395a7b322239c02eeba4761155a7d5

exercises/04-authentication

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 82183abc3d8db2795b626ede0a2ef8c8c4024fe1

exercises/03-data-fetching

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 8f338ce91695f673d19806d1978a009f42311869

exercises/02-styles

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

Kent C. Dodds

commit sha 6e5ffe299036f4c3c36919ef8b4bf306e1fb9ae0

exercises/01-bootstrap

view details

push time in 2 days

push eventkentcdodds/bookshelf

Kent C. Dodds

commit sha 209d2b69203d6c43176d0d65a807560aeae52097

update all deps

view details

push time in 2 days

push eventkentcdodds/react-performance

Kent C. Dodds

commit sha b64006859653b31911fce7ee6106ad53b578599f

update all deps

view details

push time in 2 days

push eventkentcdodds/advanced-react-patterns

Kent C. Dodds

commit sha 9c751c3e5a39318ee4be57c77ce32acde71238f3

update all deps

view details

push time in 2 days

push eventkentcdodds/advanced-react-hooks

Kent C. Dodds

commit sha 85f373092a88258bd57e56af419694613bcbf125

update all deps

view details

push time in 2 days

push eventkentcdodds/react-hooks

Kent C. Dodds

commit sha 8571ddf66f2d611eaed533a7bfb2c0dabfba4c51

master ▶️ main

view details

Kent C. Dodds

commit sha def9339fc95804321f948233d079998937f4f5d5

update all deps

view details

push time in 2 days

push eventkentcdodds/react-fundamentals

Kent C. Dodds

commit sha e603bb14188a8a647e5d9314e85f5e37eb38a651

update all deps

view details

push time in 2 days

push eventkentcdodds/testing-react-apps

Kent C. Dodds

commit sha 3758cb1e96d193f1ade523db09bc2f5aadac119a

update all deps

view details

push time in 2 days

delete branch testing-library/cypress-testing-library

delete branch : all-contributors/add-Thisen

delete time in 2 days

push eventtesting-library/cypress-testing-library

allcontributors[bot]

commit sha 80937d5fffaff9b37dca24c7baa867afc06654c7

docs: add Thisen as a contributor (#158) * docs: update README.md * docs: update .all-contributorsrc * docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

view details

push time in 2 days

PR merged testing-library/cypress-testing-library

docs: add Thisen as a contributor

Adds @Thisen as a contributor for code, test.

This was requested by kentcdodds in this comment

+11 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 2 days

PR closed testing-library/cypress-testing-library

docs: add Thisen as a contributor

Adds @Thisen as a contributor for code.

This was requested by kentcdodds in this comment

+11 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 2 days

pull request commenttesting-library/cypress-testing-library

Fix configureCypressTestingLibrary typings

@all-contributors please add @Thisen for code and tests

Thisen

comment created time in 2 days

pull request commenttesting-library/cypress-testing-library

Fix configureCypressTestingLibrary typings

@all-contributors please add @Thisen for code

Thisen

comment created time in 2 days

push eventtesting-library/cypress-testing-library

Mathis Møller

commit sha 85a80492c28dec2b4bbf271a766b5d70107d3ac4

fix(ts): configureCypressTestingLibrary typings (#156)

view details

push time in 2 days

PR merged testing-library/cypress-testing-library

Fix configureCypressTestingLibrary typings

<!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!

Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file).

Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file).

If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request

Please fill out the information below to expedite the review and (hopefully) merge of your pull request! -->

<!-- What changes are being made? (What feature/bug is being fixed here?) -->

What:

Fixes cy.configureCypressTestingLibrary(config) for TypeScript users. Fixes #143. Also, ran prettier for the changed files.

<!-- Why are these changes necessary? -->

Why:

Type safety. 🎉

<!-- How were these changes implemented? -->

How:

I've added a declaration for configureCypressTestingLibrary in the type definitions.

<!-- Have you done all of these things? -->

Checklist:

<!-- add "N/A" to the end of each line that's irrelevant to your changes -->

<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->

  • [X] Documentation
  • [X] Tests
  • [X] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->

<!-- feel free to add additional comments -->

+222 -181

0 comment

2 changed files

Thisen

pr closed time in 2 days

PullRequestReviewEvent

startedbalavishnuvj/rtl-simple-queries

started time in 2 days

delete branch kentcdodds/kentcdodds.com

delete branch : all-contributors/add-Aprillion

delete time in 2 days

push eventkentcdodds/kentcdodds.com

allcontributors[bot]

commit sha cd9b5937d031a17d4949dfe37824028d99dc8f87

docs: add Aprillion as a contributor (#544) Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

view details

push time in 2 days

PR merged kentcdodds/kentcdodds.com

docs: add Aprillion as a contributor

Adds @Aprillion as a contributor for code.

This was requested by kentcdodds in this comment

+3 -2

0 comment

2 changed files

allcontributors[bot]

pr closed time in 2 days

pull request commentkentcdodds/kentcdodds.com

enable "Add a Keyword for this Search..." context menu item in Firefo…

@all-contributors please add @Aprillion for code

Aprillion

comment created time in 2 days

push eventkentcdodds/kentcdodds.com

Peter Hozák

commit sha f6b8795ff3e8c36506013965ed82d3c4c707a7ee

enable "Add a Keyword for this Search..." context menu item in Firefox for the blog search (#543)

view details

push time in 2 days

PR merged kentcdodds/kentcdodds.com

enable "Add a Keyword for this Search..." context menu item in Firefo…

saving the bookmark and using the keyword search worked fine for me from Firefox address bar from localhost after npm run dev ...and the search works the same as before in Chrome and Safari on Mac... (manual test only, no idea how to automate browser bookmarking)

keyword search

+18 -9

1 comment

1 changed file

Aprillion

pr closed time in 2 days

PullRequestReviewEvent

delete branch kentcdodds/kentcdodds.com

delete branch : all-contributors/add-Aprillion

delete time in 2 days

push eventkentcdodds/kentcdodds.com

allcontributors[bot]

commit sha 288100f3bc805eccd8177e7b276590d4d9dc42e5

docs: add Aprillion as a contributor (#542) Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

view details

push time in 2 days

PR merged kentcdodds/kentcdodds.com

docs: add Aprillion as a contributor

Adds @Aprillion as a contributor for content.

This was requested by kentcdodds in this comment

+10 -0

0 comment

2 changed files

allcontributors[bot]

pr closed time in 2 days

pull request commentkentcdodds/kentcdodds.com

use screen in the blog suggested in live stream

@all-contributors please add @Aprillion for content

Aprillion

comment created time in 2 days

push eventkentcdodds/kentcdodds.com

Peter Hozák

commit sha bdf1d6368c90d0e0b1b2d3299bf3aea404986fee

use screen in the blog suggested in live stream (#541) Co-authored-by: Peter Hozak <peter.hozak@merck.com>

view details

push time in 2 days

more