Re-opened

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@YC Due to the long inactivity of the repo and lack of correct Typescript typing. I am currently rewriting the lib with Typescript. I will review the logic and take account into your patch 🙏🏻 Give me some time.

Resolves #351

If the cookie is updated due to rolling, I think it makes sense for session.cookie and its expiry to be updated accordingly also. https://github.com/expressjs/session/issues/33#issuecomment-42497814

@YC do you recon what I described in my original post is the correct thing?

https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/src/index.js#L350-L354

https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/test/legacy-tests.test.js#L525-L532

https://github.com/jdesboeufs/connect-mongo/blob/6c62235206dcfd6c8e1bf5b73927b6b1297b5e65/test/legacy-tests.test.js#L540-L547

The tests seem to be inconsistent as to what should be passed in the touch function.

Ping @YC

unstale

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

With the new end conditions these should be added to the API

Unified Topology as the link, how do we setup our MongoStore now?

This is still an issue.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I'm using the same code in my other application and didn't need a strategy but when using it in this one i do? What type of strategy?

sorry i didn't add (session) mb

`node_modules/connect-mongo/src/index.js:57 const Store = connect.Store || connect.session.Store ^

TypeError: Cannot read property 'Store' of undefined`

and its in the module and i dont wanna mess with it

`node_modules/connect-mongo/src/index.js:57 const Store = connect.Store || connect.session.Store ^

TypeError: Cannot read property 'Store' of undefined`

and its in the module and i dont wanna mess with it

Please fix this,

(node:20256) UnhandledPromiseRejectionWarning: MongoError: (Unauthorized) not authorized on admin to execute command { insert: "system.indexes", documents: [[{ns admin.sessions} {key [{expires 1}]} {name expires_1} {expireAfterSeconds 0} {unique false}]], ordered: true }

i have tried to provide url without srv but getting err = new MongoError(options); ^ MongoError: connection 0 to THE MONGO URL closed

Any help? Any alternatives?

Please fix this, i have tried to provide url without srv but getting err = new MongoError(options); ^ MongoError: connection 0 to THE MONGO URL closed

Any help? Any alternatives?

Some people use unified map images and leaflet tiles, this was just to provide those if you are interested.

I have tried that mentioned in @MRVDH advise, but still not working, any help? with 'mongodb+srv:// string type getting error (node:16402) UnhandledPromiseRejectionWarning: MongoError: (Unauthorized) not authorized on admin to execute command { insert: "system.indexes", documents: [[{ns admin.sessions} {key [{expires 1}]} {name expires_1} {expireAfterSeconds 0} {unique false}]], ordered: true, writeConcern: { w: "majority" } }

With string as in advise getting err = new MongoError(options); ^ MongoError: connection 0 to MONGO_ATLAS_CONNECTION_URL Any help?

When compiling my project I get the following typescript error.

node_modules/connect-mongo/src/types.d.ts:11:27 - error TS7016: Could not find a declaration file for module 'mongoose'. 

11 import * as mongoose from 'mongoose';

While I don't use mongoose, installing @types/mongoose to my dev-dependencies seems to fix this error.

These are my dependencies:

"dependencies": {
    "bcrypt": "^5.0.0",
    "body-parser": "^1.19.0",
    "chalk": "^4.1.0",
    "compression": "^1.7.4",
    "connect-mongo": "^3.2.0",
    "cors": "^2.8.5",
    "dotenv": "^8.2.0",
    "express": "^4.17.1",
    "express-session": "^1.17.1",
    "helmet": "^4.3.1",
    "jeroentvb-helper": "github:jeroentvb/jeroentvb-helper",
    "mongodb": "^3.6.3",
  },
  "devDependencies": {
    "@types/bcrypt": "^3.0.0",
    "@types/body-parser": "^1.19.0",
    "@types/compression": "^1.7.0",
    "@types/cors": "^2.8.9",
    "@types/express": "^4.17.9",
    "@types/express-session": "1.17.0",
    "@types/helmet": "^4.0.0",
    "@types/mongodb": "^3.6.3",
    "@types/node": "^14.14.20",
    "ts-node-dev": "^1.1.1",
    "tslint": "^6.1.3",
    "typescript": "^4.1.3"
  }

I am planning to rewrite the lib in typescript

Is there any progress on this? Currently getting lots of type errors related to express-session and mongoose connection.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.