<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description <!-- Provide a brief description of the issue -->

• Currently, when a user clicks a link to a PDF file, it'll be downloaded and opened in an associated app without confirming.
• For security reasons, some users want to prevent it

Steps to reproduce <!-- Please add a series of steps to reproduce the issue -->

1. On Android, click https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf

Actual result <!-- Please add screenshots if needed -->

It'll be downloaded and opened in a default PDF viewer app.

Expected result

• Allow them to prevent it as an option menu

Issue reproduces how often <!-- [Easily reproduced/Intermittent issue/No steps to reproduce] -->

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

• Can you reproduce this issue with the current Play Store version?
• Can you reproduce this issue with the current Play Store Beta version?
• Can you reproduce this issue with the current Play Store Nightly version?

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

<!-- Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue -->

@dlecan just curious / double checking through, does your implementation expect all embedded widgets to see the same storage area (or would our dual-keyed approach work for you, [fingers crossed])?

Similar, does your widget depend on DOM storage being persisted across sessions?

If the answers to the above are "no" and "no", then… have i got good news for you!

Otherwise, would be glad to get to learn more about your app's needs. I can't promise we can change Brave's policy in any particular way (we're not looking to relax privacy boundaries), but I would be useful to better understand the needs of privacy-respecting developers, to give us a better understanding of the space and tradeoffs

Thanks @anisg, just one last question:

does your extension rely on DOM storage APIs persisting their values across sessions. Or would it be sufficient to just have the values last for a session. Asking because we're getting very close to landing https://github.com/brave/brave-browser/issues/8514, and that would give all embedded frames dual-keyed storage. If your extension doesn't expect all frames to see the same storage, than we might have a fix already underworks and about to land.

If the extension / frame expects long term persisted, global (i.e., not dual keyed) storage though, our upcoming change won't solve that use case. I think at that point though, probably the best thing we can do is encourage extensions to handle long term, global, extension stored using the extension API, or in the background script in general.

Otherwise, if we allowed extension URLs to have global, non-dual-keyed, long-term storage, we'd actually allow sites to cross site track again (by injecting the extension URL frame themselves, flag it non-sandboxed, and then use that as a way of doing cross site tracking).

Anyway, thank you for being so helpful and humoring all the questions. Hope we can figure something out that both makes things easier for privacy-respecting developers like yourself, w/o harming the privacy guarantees we want in Brave!

Just verified that this was indeed what was in the Figma file 😅:

👍

eggcellent, p3 it is. Thanks @diracdeltas !

lot of webcompat issues in this thread: https://github.com/brave/brave-browser/issues/2143#issuecomment-733509235

we should figure out if we can enable it without directly going through google servers

p3 sgtm

<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description

<!--Provide a brief description of the issue--> Sometimes the in-line tip button displays "twitterTipsIconLabel" instead of "Tip" text (localized).

I haven't been able to reproduce this but it has been reported internally and externally.

Steps to Reproduce

<!--Please add a series of steps to reproduce the issue-->

TBD

Actual result:

<!--Please add screenshots if needed-->

Expected result:

Reproduces how often:

<!--[Easily reproduced/Intermittent issue/No steps to reproduce]--> unsure

Brave version (brave://version info)

<!--For installed build, please copy Brave, Revision and OS from brave://version and paste here. If building from source please mention it along with brave://version details--> unknown

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue--> cc @emerick

QA process is to log a new issue once an issue is closed with a PR, so closing this one. We can track the new issue under https://github.com/brave/brave-browser/issues/12900.

<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description

<!--Provide a brief description of the issue--> Per https://github.com/brave/brave-browser/issues/12350#issuecomment-733979030, issue reported with https://github.com/brave/brave-browser/issues/12350 is still occurring with 1.17.73.

Steps to Reproduce

<!--Please add a series of steps to reproduce the issue-->

TBD

Actual result:

<!--Please add screenshots if needed--> Content level/in-line tip text reads something like "twitterTipsIconLabel"

Expected result:

Should say "Tip"

Reproduces how often:

<!--[Easily reproduced/Intermittent issue/No steps to reproduce]--> intermittent

Brave version (brave://version info)

<!--For installed build, please copy Brave, Revision and OS from brave://version and paste here. If building from source please mention it along with brave://version details--> 1.17.73

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? unsure, probably
• Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue--> cc @emerick @cryptojennie @brave/legacy_qa

Can we remove duplication with https://github.com/brave/brave-core/pull/6933/files#diff-dc54666ac5547a38442ebd8a02187f6df83b883532bb933408fa753a3c214868R24?

nit: Let's deprecate DISALLOW_COPY_AND_ASSIGN :)

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves https://github.com/brave/brave-browser/issues/12837

Submitter Checklist:

• [x] There is a ticket for my issue.
• [ ] Used Github auto-closing keywords in the commit message.
• [ ] Wrote a good PR/commit description
• [ ] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• [ ] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• [ ] Ran git rebase master (if needed).
• [ ] Requested a security/privacy review as needed.

Reviewer Checklist:

• [ ] New files have MPL-2.0 license header.
• [ ] Adequate test coverage exists to prevent regressions
• [ ] Major classes, functions and non-trivial code blocks are well-commented
• [ ] Changes in component dependencies are properly reflected in gn
• [ ] Code follows the style guide
• [ ] Test plan is specified in PR before merging

After-merge Checklist:

• [ ] The associated issue milestone is set to the smallest version that the changes has landed on.
• [ ] All relevant documentation has been updated, for instance:
  • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
  • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
  • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

• Top tiles and stats UI should fall back to previous UI without widgets when user disables the bg images and remove all widgets from NTP.

<!-- Have you searched for similar issues on the repository? Before submitting this issue, please visit our wiki for common ones: https://github.com/brave/browser-ios/wiki For more, check out our community site: https://community.brave.com/ -->

Description:

Looks like there's a ? at the end of the reward onboarding string which doesn't make sense.

Steps to Reproduce

1. install 1.22 (20.11.25.21) via TF
2. run through onboarding till you get to rewards

Actual result: <!-- Add screenshots if needed -->

<p align="center"> <img src="https://user-images.githubusercontent.com/2602313/100298482-3d31bb00-2f5f-11eb-9e9f-03be936d57e7.jpg" width=300> </p>

Expected result:

I'm not 100% sure what it should be, but maybe using ! or a period makes more sense. CCing @jamesmudgett @anthonypkeane to decide how the string should look like.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version: <!-- Provide full details Eg: v1.4.2(17.09.08.16) -->

• 1.22 (20.11.25.21)

Device details: <!-- Model type and iOS version Eg: iPhone 6s+ (iOS 10.3.3)-->

• iPhone 11 running iOS 14.2 - Reproduced

Website problems only: N/A

• did you check with Brave Shields down? N/A
• did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @bsclifton @srirambv

It looks like translation is done for each words - Shields UP for this site Shields -> 보호 UP-> 위로, for this site -> 이 사이트를 위한 and same for Shields DOWN for this site. Translating word to word causes weird translation result because Korean and English uses different word order.

Description

Blocking facebook login does not work on Twitch.tv

Actual result:

Expected result:

facebook login button should be blocked.

Reproduces how often:

100%

Brave version (brave://version info)

Version 1.18.41 Chromium: 87.0.4280.49 (Official Build) nightly (64-bit)

Version/Channel Information:

• Can you reproduce this issue with the current release? ✔
• Can you reproduce this issue with the beta channel? ✔
• Can you reproduce this issue with the nightly channel? ✔

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? ❌
• Does the issue resolve itself when disabling Brave Rewards? ❌
• Is the issue reproducible on the latest version of Chrome? ✔

I think Brave Together would be better than Brave 함께. I think only Together is partly tranlated. For Top Sites, Top is translated to 최고의. However, its meaning is much close to highest, greatest. In our case, its meaning should be close tomost visited instead.

IMO, it's better to use Brave Together instead of translating. and 자주 방문한 사이트(which means Most visited sites) is better for for Top Sites translation. Or just using Top Sites.