profile
viewpoint

brave/brave-ios 771

Brave iOS Browser

brave/adblock-rust 367

Brave's Rust-based adblock engine

brave/ad-block 216

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.

brave/tracking-protection 61

Tracking protection engine used in the Brave browser for list like disconnectme.

brave-intl/bat-ledger 41

A BAT-based micropayments system for users and publishers

brave/adblock-rust-ffi 27

An FFI crate to expose functionality from brave/adblock-rust

brave/go-translate 13

Translation adapter / relay server for Brave

brave/tor_build_scripts 8

Build scripts for tor binary

brave/omaha-build 4

[WIP] Windows omaha client

issue openedbrave/brave-browser

Prevent auto downloading & opening a PDF file on click

<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description <!-- Provide a brief description of the issue -->

  • Currently, when a user clicks a link to a PDF file, it'll be downloaded and opened in an associated app without confirming.
  • For security reasons, some users want to prevent it

Steps to reproduce <!-- Please add a series of steps to reproduce the issue -->

  1. On Android, click https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf

Actual result <!-- Please add screenshots if needed -->

It'll be downloaded and opened in a default PDF viewer app.

Expected result

  • Allow them to prevent it as an option menu

Issue reproduces how often <!-- [Easily reproduced/Intermittent issue/No steps to reproduce] -->

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

<!-- Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue -->

created time in 10 minutes

issue commentbrave/brave-browser

Give non-eTLD+1 frames document length, ephemeral storage

@dlecan just curious / double checking through, does your implementation expect all embedded widgets to see the same storage area (or would our dual-keyed approach work for you, [fingers crossed])?

Similar, does your widget depend on DOM storage being persisted across sessions?

If the answers to the above are "no" and "no", then… have i got good news for you!

Otherwise, would be glad to get to learn more about your app's needs. I can't promise we can change Brave's policy in any particular way (we're not looking to relax privacy boundaries), but I would be useful to better understand the needs of privacy-respecting developers, to give us a better understanding of the space and tradeoffs

pes10k

comment created time in 40 minutes

created tagbrave/brave-browser

tagv1.18.63

Next generation Brave browser for macOS, Windows, Linux, Android.

created time in 43 minutes

push eventbrave/brave-browser

brave-builds

commit sha f5f15471b9dca78f7aaa9b3106bf1d805647bfb8

1.18.63

view details

push time in 43 minutes

created tagbrave/brave-core

tagv1.18.63

Core engine for the Brave browser for macOS, Windows, Linux, Android. For the issue log, please see https://github.com/brave/brave-browser

created time in 43 minutes

push eventbrave/brave-core

brave-builds

commit sha 37c7f12a5e68e5360704a593417794e24a45d4db

1.18.63

view details

push time in 43 minutes

issue commentbrave/brave-browser

Third party cookies blocked in an Chrome extension Iframe

Thanks @anisg, just one last question:

does your extension rely on DOM storage APIs persisting their values across sessions. Or would it be sufficient to just have the values last for a session. Asking because we're getting very close to landing https://github.com/brave/brave-browser/issues/8514, and that would give all embedded frames dual-keyed storage. If your extension doesn't expect all frames to see the same storage, than we might have a fix already underworks and about to land.

If the extension / frame expects long term persisted, global (i.e., not dual keyed) storage though, our upcoming change won't solve that use case. I think at that point though, probably the best thing we can do is encourage extensions to handle long term, global, extension stored using the extension API, or in the background script in general.

Otherwise, if we allowed extension URLs to have global, non-dual-keyed, long-term storage, we'd actually allow sites to cross site track again (by injecting the extension URL frame themselves, flag it non-sandboxed, and then use that as a way of doing cross site tracking).

Anyway, thank you for being so helpful and humoring all the questions. Hope we can figure something out that both makes things easier for privacy-respecting developers like yourself, w/o harming the privacy guarantees we want in Brave!

anisg

comment created time in an hour

release brave/brave-browser

v1.19.35

released time in an hour

issue commentbrave/brave-ios

Remove/Replace "?" from rewards onboarding string

Just verified that this was indeed what was in the Figma file 😅: image

kjozwiak

comment created time in an hour

create barnchbrave/brave-core

branch : yandex_implementation_android

created branch time in 2 hours

Pull request review commentbrave/brave-core

Disables several blink runtime features.

 def replace_cc_arg(args):     # Filter away out and out_x86     # Maybe this dir can be queried from env variable instead of hardcoding     OUT_DIR_NAMES = ['out', 'out_x86']-    start_dir = rel_path.split(os.sep)[0]-    if start_dir in OUT_DIR_NAMES:-        # Don't even try to substitute path for auto-generated cc-        return+    rel_path_parts = rel_path.split(os.sep, 3)+    if rel_path_parts[0] in OUT_DIR_NAMES:+        if rel_path_parts[2] == 'gen':

👍

mkarolin

comment created time in 2 hours

issue commentbrave/brave-browser

Browsing data not cleared on exit

eggcellent, p3 it is. Thanks @diracdeltas !

e962c0

comment created time in 2 hours

issue openedbrave/brave-browser

re-enable FCM

lot of webcompat issues in this thread: https://github.com/brave/brave-browser/issues/2143#issuecomment-733509235

we should figure out if we can enable it without directly going through google servers

created time in 2 hours

issue commentbrave/brave-browser

Browsing data not cleared on exit

p3 sgtm

e962c0

comment created time in 2 hours

issue closedbrave/brave-browser

[Desktop] sometimes in-line tip button shows "twitterTipsIconLabel" text instead of "Tip"

<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description

<!--Provide a brief description of the issue--> Sometimes the in-line tip button displays "twitterTipsIconLabel" instead of "Tip" text (localized).

I haven't been able to reproduce this but it has been reported internally and externally.

Steps to Reproduce

<!--Please add a series of steps to reproduce the issue-->

TBD

Actual result:

<!--Please add screenshots if needed--> twitter

Expected result:

Screen Shot 2020-10-27 at 3 21 31 PM

Reproduces how often:

<!--[Easily reproduced/Intermittent issue/No steps to reproduce]--> unsure

Brave version (brave://version info)

<!--For installed build, please copy Brave, Revision and OS from brave://version and paste here. If building from source please mention it along with brave://version details--> unknown

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue--> cc @emerick

closed time in 2 hours

LaurenWags

issue commentbrave/brave-browser

[Desktop] sometimes in-line tip button shows "twitterTipsIconLabel" text instead of "Tip"

QA process is to log a new issue once an issue is closed with a PR, so closing this one. We can track the new issue under https://github.com/brave/brave-browser/issues/12900.

LaurenWags

comment created time in 2 hours

issue openedbrave/brave-browser

[Desktop] sometimes in-line tip button shows "twitterTipsIconLabel" text instead of "Tip" - follow up to 12350

<!-- Have you searched for similar issues? Before submitting this issue, please check the open issues and add a note before logging a new issue.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description

<!--Provide a brief description of the issue--> Per https://github.com/brave/brave-browser/issues/12350#issuecomment-733979030, issue reported with https://github.com/brave/brave-browser/issues/12350 is still occurring with 1.17.73.

Steps to Reproduce

<!--Please add a series of steps to reproduce the issue-->

TBD

Actual result:

<!--Please add screenshots if needed--> Content level/in-line tip text reads something like "twitterTipsIconLabel"

Expected result:

Should say "Tip"

Reproduces how often:

<!--[Easily reproduced/Intermittent issue/No steps to reproduce]--> intermittent

Brave version (brave://version info)

<!--For installed build, please copy Brave, Revision and OS from brave://version and paste here. If building from source please mention it along with brave://version details--> 1.17.73

Version/Channel Information:

<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? unsure, probably
  • Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue--> cc @emerick @cryptojennie @brave/legacy_qa

created time in 2 hours

Pull request review commentbrave/brave-core

Disables several blink runtime features.

+/* Copyright (c) 2020 The Brave Authors. All rights reserved.+ * This Source Code Form is subject to the terms of the Mozilla Public+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,+ * You can obtain one at http://mozilla.org/MPL/2.0/. */++#include "third_party/blink/renderer/core/origin_trials/origin_trial_context.h"++#define AddFeature AddFeature_ChromiumImpl+#define AddForceEnabledTrials AddForceEnabledTrials_ChromiumImpl+#include "../../../../../../../third_party/blink/renderer/core/origin_trials/origin_trial_context.cc"+#undef AddForceEnabledTrials+#undef AddFeature++namespace blink {++// AddFeature doesn't check if origin_trials::IsTrialValid.+void OriginTrialContext::AddFeature(OriginTrialFeature feature) {+  // When updating this list also update the trials names below in+  // AddForceEnabledTrials override as well as the names in+  //  * origin_trials.cc override and+  static const std::array<OriginTrialFeature, 3> kBraveDisabledTrialFeatures = {+      // [cr88] OriginTrialFeature::kDigitalGoods,+      OriginTrialFeature::kNativeFileSystem,+      OriginTrialFeature::kSignedExchangeSubresourcePrefetch,+      OriginTrialFeature::kSubresourceWebBundles,+  };+  if (base::Contains(kBraveDisabledTrialFeatures, feature))+    return;++  AddFeature_ChromiumImpl(feature);+}++// AddForceEnabledTrials only has a DCHECK with origin_trials::IsTrialValid.+void OriginTrialContext::AddForceEnabledTrials(+    const Vector<String>& trial_names) {+  // When updating this list also update+  //  * origin_trials.cc override and+  static const char* const kBraveDisabledTrialNames[] = {+      // [cr88] "DigitalGoods",+      "NativeFileSystem2",

Can we remove duplication with https://github.com/brave/brave-core/pull/6933/files#diff-dc54666ac5547a38442ebd8a02187f6df83b883532bb933408fa753a3c214868R24?

mkarolin

comment created time in 3 hours

Pull request review commentbrave/brave-core

Disables several blink runtime features.

+/* Copyright (c) 2020 The Brave Authors. All rights reserved.+ * This Source Code Form is subject to the terms of the Mozilla Public+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,+ * You can obtain one at http://mozilla.org/MPL/2.0/. */++#include "base/path_service.h"+#include "brave/common/brave_paths.h"+#include "chrome/browser/ui/browser.h"+#include "chrome/browser/ui/tabs/tab_strip_model.h"+#include "chrome/test/base/in_process_browser_test.h"+#include "chrome/test/base/ui_test_utils.h"+#include "content/public/common/content_switches.h"+#include "content/public/browser/render_frame_host.h"+#include "content/public/browser/web_contents.h"+#include "content/public/test/browser_test.h"+#include "content/public/test/browser_test_utils.h"+#include "net/dns/mock_host_resolver.h"+#include "net/test/embedded_test_server/embedded_test_server.h"+#include "url/gurl.h"++class DigitalGoodsAPIBrowserTest+    : public InProcessBrowserTest,+      public ::testing::WithParamInterface<bool> {+ public:+  DigitalGoodsAPIBrowserTest()+      : https_server_(net::EmbeddedTestServer::TYPE_HTTPS) {+    brave::RegisterPathProvider();+    base::FilePath test_data_dir;+    base::PathService::Get(brave::DIR_TEST_DATA, &test_data_dir);+    https_server_.SetSSLConfig(net::EmbeddedTestServer::CERT_OK);+    https_server_.ServeFilesFromDirectory(test_data_dir);+  }++  ~DigitalGoodsAPIBrowserTest() override = default;++  bool IsDigitalGoodsAPIEnabled() { return GetParam(); }++  void SetUpCommandLine(base::CommandLine* command_line) override {+    InProcessBrowserTest::SetUpCommandLine(command_line);+    if (IsDigitalGoodsAPIEnabled()) {+      command_line->AppendSwitch(+          switches::kEnableExperimentalWebPlatformFeatures);+    }+  }++  void SetUpOnMainThread() override {+    InProcessBrowserTest::SetUpOnMainThread();++    EXPECT_TRUE(https_server_.Start());+    // Map all hosts to localhost.+    host_resolver()->AddRule("*", "127.0.0.1");+  }++  content::WebContents* web_contents() {+    return browser()->tab_strip_model()->GetActiveWebContents();+  }++  content::RenderFrameHost* main_frame() {+    return web_contents()->GetMainFrame();+  }++ protected:+  net::EmbeddedTestServer https_server_;++  DISALLOW_COPY_AND_ASSIGN(DigitalGoodsAPIBrowserTest);

nit: Let's deprecate DISALLOW_COPY_AND_ASSIGN :)

mkarolin

comment created time in 3 hours

push eventbrave/brave-core

Terry Mancey

commit sha 772bc2f777d1cc4030a24bb4ed84a1c763c08ee0

Add unit tests for Brave Ads refill unblinded tokens

view details

push time in 3 hours

push eventbrave/brave-core

Terry Mancey

commit sha efcb055ca9ad2688139cb36e236bab66a7442627

Add unit tests for Brave Ads refill unblinded tokens

view details

push time in 3 hours

PR opened brave/brave-core

Reviewers
Add layout for fall back UI for top tiles CI/skip-ios CI/skip-linux CI/skip-macos CI/skip-windows

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves https://github.com/brave/brave-browser/issues/12837

Submitter Checklist:

  • [x] There is a ticket for my issue.
  • [ ] Used Github auto-closing keywords in the commit message.
  • [ ] Wrote a good PR/commit description
  • [ ] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [ ] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [ ] Ran git rebase master (if needed).
  • [ ] Requested a security/privacy review as needed.

Reviewer Checklist:

  • [ ] New files have MPL-2.0 license header.
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on.
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

  • Top tiles and stats UI should fall back to previous UI without widgets when user disables the bg images and remove all widgets from NTP.
+125 -43

0 comment

6 changed files

pr created time in 3 hours

create barnchbrave/brave-core

branch : fallback_ui_for_top_tiles_android

created branch time in 3 hours

push eventbrave/brave-core

Brian R. Bondy

commit sha 29cef15a454021849b92bdfa703002495069237b

Add IPFS P3A to P3A whitelist

view details

Ivan Efremov

commit sha 7a7a8fccc37bc3f8fa506edf5b84567ba5a3afb0

12873: Fix crash in pixel perturbing routine. All users of `ImageDataBuffer::Create` do check the return value, so should we. Fixes https://github.com/brave/brave-browser/issues/12873

view details

iefremov

commit sha 75630ffdbd5f3f3b08a2edd59b8d047e38b5b962

Merge pull request #7246 from brave/ie_crash_perturb 12873: Fix crash in pixel perturbing routine.

view details

brave-builds

commit sha b912ac24882039c7ba0e95b6bbfecb713df483f4

1.19.34

view details

Brian R. Bondy

commit sha fd4f2f2f5174089dce997b9befce3ff9b6f2b499

Merge pull request #7206 from brave/ipfs-p3a-whitelist Add IPFS P3A to P3A whitelist

view details

Mihai PLESA

commit sha 45226f77f5873b4099aab36c4effd858b1af53cc

roll back to rust deps 0.1.5

view details

Mihai PLESA

commit sha db1b4f2b657c010594b3ae5221c9a99bec4dc5b2

Merge pull request #7252 from brave/mplesa-rust-deps-rollback roll back to rust deps 0.1.5

view details

brave-builds

commit sha c37ae8ab2fd0f7a886d8de9edb329ea5dcddcb70

1.19.35

view details

Terry Mancey

commit sha 8cefafd3ab29e17f9c28aa35520f9f68d3646a32

Add unit tests for Brave Ads refill unblinded tokens

view details

push time in 3 hours

issue openedbrave/brave-ios

Remove/Replace "?" from rewards onboarding string

<!-- Have you searched for similar issues on the repository? Before submitting this issue, please visit our wiki for common ones: https://github.com/brave/browser-ios/wiki For more, check out our community site: https://community.brave.com/ -->

Description:

Looks like there's a ? at the end of the reward onboarding string which doesn't make sense.

Steps to Reproduce

  1. install 1.22 (20.11.25.21) via TF
  2. run through onboarding till you get to rewards

Actual result: <!-- Add screenshots if needed -->

<p align="center"> <img src="https://user-images.githubusercontent.com/2602313/100298482-3d31bb00-2f5f-11eb-9e9f-03be936d57e7.jpg" width=300> </p>

Expected result:

I'm not 100% sure what it should be, but maybe using ! or a period makes more sense. CCing @jamesmudgett @anthonypkeane to decide how the string should look like.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version: <!-- Provide full details Eg: v1.4.2(17.09.08.16) -->

  • 1.22 (20.11.25.21)

Device details: <!-- Model type and iOS version Eg: iPhone 6s+ (iOS 10.3.3)-->

  • iPhone 11 running iOS 14.2 - Reproduced

Website problems only: N/A

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @bsclifton @srirambv

created time in 3 hours

issue openedbrave/brave-browser

Strange shields popup korean translation

It looks like translation is done for each words - Shields UP for this site Shields -> 보호 UP-> 위로, for this site -> 이 사이트를 위한 and same for Shields DOWN for this site. Translating word to word causes weird translation result because Korean and English uses different word order.

스크린샷 2020-11-26 오전 10 19 20 스크린샷 2020-11-26 오전 10 20 43

created time in 3 hours

push eventbrave/brave-core

Terry Mancey

commit sha 6a92e8da6d655d5d74cf72953291e5a731da5304

Add unit tests for Brave Ads refill unblinded tokens

view details

push time in 3 hours

issue closedbrave/brave-browser

Facebook login button on Twitch.tv

Description

Blocking facebook login does not work on Twitch.tv

Actual result:

image image

Expected result:

facebook login button should be blocked.

Reproduces how often:

100%

Brave version (brave://version info)

Version 1.18.41 Chromium: 87.0.4280.49 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? ✔
  • Can you reproduce this issue with the beta channel? ✔
  • Can you reproduce this issue with the nightly channel? ✔

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? ❌
  • Does the issue resolve itself when disabling Brave Rewards? ❌
  • Is the issue reproducible on the latest version of Chrome? ✔

closed time in 4 hours

TheAresjej

issue openedbrave/brave-browser

Strange korean translation on NTP customization widget

I think Brave Together would be better than Brave 함께. I think only Together is partly tranlated. For Top Sites, Top is translated to 최고의. However, its meaning is much close to highest, greatest. In our case, its meaning should be close tomost visited instead.

IMO, it's better to use Brave Together instead of translating. and 자주 방문한 사이트(which means Most visited sites) is better for for Top Sites translation. Or just using Top Sites.

스크린샷 2020-11-26 오전 9 48 57

created time in 4 hours

push eventbrave/brave-core

mkarolin

commit sha 060ec82934d3209603c3fcb2f31d62b110a21e46

New Tab button moved out of TabStrip. Chromium change: https://chromium.googlesource.com/chromium/src/+/f68b2ae9b9344f47741b881d1fb53a4691d60270 commit f68b2ae9b9344f47741b881d1fb53a4691d60270 Author: Taylor Bergquist <tbergquist@chromium.org> Date: Wed Nov 4 22:30:38 2020 +0000 Move NTB out of TabStrip. The NTB is instead laid out just right of the tabstrip by TabStripRegionView. Behavior is unchanged, except for: - The NTB will never hide (e.g. during drag sessions) because it's now positioned reasonably during the cases where it was previously hidden. - The NTB is positioned slightly further to the right. It was previously overlapping the rightmost tab a bit to be better aligned relative to the trailing separator. That of course doesn't make sense when the tabstrip is scrollable, but still could before that state is reached, or if the tabstrip is scrolled all the way to the end. - A few details of the NTB's movement during animations are different, e.g. when pinning the rightmost tab. Under the hood, the NTB is no longer explicitly animated; that is happening implicitly as the tabstrip's bounds change during animation. Also rewrites BrowserNonClientFrameViewTabbedTest.HitTestTabstrip because it was a) testing very different things per platform and it's now positioned reasonably during the cases where it was previously hidden. - The NTB is positioned slightly further to the right. It was previously overlapping the rightmost tab a bit to be better aligned relative to the trailing separator. That of course doesn't make sense when the tabstrip is scrollable, but still could before that state is reached, or if the tabstrip is scrolled all the way to the end. - A few details of the NTB's movement during animations are different, e.g. when pinning the rightmost tab. Under the hood, the NTB is no longer explicitly animated; that is happening implicitly as the tabstrip's bounds change during animation. Also rewrites BrowserNonClientFrameViewTabbedTest.HitTestTabstrip because it was a) testing very different things per platform and b) was very unclear about what it was expecting and why. Bug: 1093972

view details

push time in 4 hours

more