profile
viewpoint
Jason Tokoph jtokoph Blockspring San Francisco, CA http://jasontokoph.com wigglezipheartpeach

bigfive/atom-sublime-select 230

Enable 'sublime style' multiline selection boxes to Atom editor http://atom.io

jtokoph/auto-detect-indentation 29

Auto detect indentation of files in Atom

jtokoph/editr 19

Edit remote files with TextMate, Sublime Text 2, Chocolat and more!

jtokoph/ghosttext-vscode 16

GhostText support for Visual Studio Code

jtokoph/nirc 8

Node IRC Client Library

jtokoph/dotfiles 4

Every home has it's hidden beauty.

jtokoph/jtokoph.github.com 2

My Site/Blog Whatever

jtokoph/ghes 1

github enhancement suite

jtokoph/omniauth-twitch 1

OmniAuth Strategy for Twitch

jtokoph/react-boilerplate 1

My basic boilerplate: React + Redux + Webpack 3 + HMR + Jest

issue openedrubygems/rubygems

Bundler 2 does not auto-switch versions when BUNDLE_GEMFILE is set via .bundle/config

Bundler 2 is supposed to detect if a project was bundled with v1 based on the BUNDLED WITH lines in the lockfile.

This is not working correctly if:

  1. The Gemfile is in a subdirectory or with an alternate name
  2. The alternate location is specified in .bundle/config with BUNDLE_GEMFILE
  3. bundle update is run from the project root directory

Note: This is working correctly if one of the following is true:

  • bundle update is run from the subdirectory that includes the Gemfile
  • or bundle update is run with BUNDLE_GEMFILE env var set to the alternate location

Expected result

Running bundler 2.x on a project that was bundled with 1.x would be that BUNDLED_WITH would not be updated.

Observed result

BUNDLED WITH is updated to 2.x

Example repo to reproduce

A repository that demonstrates this behavior is located here: https://github.com/jtokoph/bundler2bug

The readme has steps to reproduce.

created time in 18 days

push eventjtokoph/dotfiles

Jason Tokoph

commit sha c4413a49d14b8f97f7c08f9f8a8563bfde1ecac9

Slate update among other things

view details

push time in 25 days

create barnchjtokoph/go-astar

branch : master

created branch time in a month

created repositoryjtokoph/go-astar

created time in a month

fork jtokoph/go-astar

Go implementation of the A* search algorithm

fork in a month

startedcespare/reflex

started time in a month

issue closedbundler/bundler

Bundler 2 does not auto-switch versions when BUNDLE_GEMFILE is set via .bundle/config

Bundler 2 is supposed to detect if a project was bundled with v1 based on the BUNDLED WITH lines in the lockfile.

This is not working correctly if:

  1. The Gemfile is in a subdirectory or with an alternate name
  2. The alternate location is specified in .bundle/config with BUNDLE_GEMFILE
  3. bundle update is run from the project root directory

Note: This is working correctly if one of the following is true:

  • bundle update is run from the subdirectory that includes the Gemfile
  • or bundle update is run with BUNDLE_GEMFILE env var set to the alternate location

Expected result

Running bundler 2.x on a project that was bundled with 1.x would be that BUNDLED_WITH would not be updated.

Observed result

BUNDLED WITH is updated to 2.x

Example repo to reproduce

A repository that demonstrates this behavior is located here: https://github.com/jtokoph/bundler2bug

The readme has steps to reproduce.

closed time in 4 months

jtokoph

issue commentbundler/bundler

Bundler 2 does not auto-switch versions when BUNDLE_GEMFILE is set via .bundle/config

I realized that this is actually a rubygems issue and opened an issue there: https://github.com/rubygems/rubygems/issues/2991

jtokoph

comment created time in 4 months

issue openedrubygems/rubygems

rubygems does not select correct bundler version when BUNDLE_GEMFILE is set via .bundle/config

I'm having a problem.

My current problem is: the gem command does not factor in the BUNDLE_GEMFILE option being set in .bundle/config. It only checks for the environment variable of the same name.

When running the bundle command in an environment that has both v1 and v2 of bundler installed, rubygems will always use bundler v2 when the following conditions are true:

  1. The Gemfile is in a subdirectory or has an alternate name
  2. and the alternate location is specified in .bundle/config with BUNDLE_GEMFILE
  3. and bundle update is run from the project root directory

The bundle command should choose a version of bundler based on the BUNDLED WITH lines in the lockfile.

Note: This is working correctly if one of the following is true:

  • bundle update is run from the subdirectory that includes the Gemfile
  • or bundle update is run with BUNDLE_GEMFILE env var set to the alternate location

I think I've narrowed it down to this block of code here: https://github.com/rubygems/rubygems/blame/ed6641c2f36268a89c6db150fca5768e225cf804/lib/rubygems/bundler_version_finder.rb#L83

I think it should look for a .bundle/config file with the BUNDLE_GEMFILE option, but am unsure of the best way to implement here.

Expected result

Running bundler project that was bundled with 1.x would not update BUNDLED_WITH to a different version

Observed result

BUNDLED WITH is updated to 2.x

Example repo to reproduce

A repository that demonstrates this behavior is located here: https://github.com/jtokoph/bundler2bug

The readme has steps to reproduce.

This issue is related to:

  • [ ] Network problems
  • [ ] Installing a library
  • [ ] Publishing a library
  • [x] The command line gem
  • [ ] Other

Here are my current environment details:

$ gem env version
RubyGems Environment:
  - RUBYGEMS VERSION: 3.0.3
  - RUBY VERSION: 2.6.5 (2019-10-01 patchlevel 114) [x86_64-linux]
  - INSTALLATION DIRECTORY: /usr/local/bundle
  - USER INSTALLATION DIRECTORY: /root/.gem/ruby/2.6.0
  - RUBY EXECUTABLE: /usr/local/bin/ruby
  - GIT EXECUTABLE: /usr/bin/git
  - EXECUTABLE DIRECTORY: /usr/local/bundle/bin
  - SPEC CACHE DIRECTORY: /root/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /usr/local/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /usr/local/bundle
     - /root/.gem/ruby/2.6.0
     - /usr/local/lib/ruby/gems/2.6.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
     - "install" => "--no-document"
     - "update" => "--no-document"
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /usr/local/bundle/bin
     - /usr/local/sbin
     - /usr/local/bin
     - /usr/sbin
     - /usr/bin
     - /sbin
     - /bin

I will abide by the code of conduct.

created time in 4 months

push eventjtokoph/bundler2bug

Jason Tokoph

commit sha 5fe368575ee282a78711dee18da1c2b6779ae7a1

fix readme

view details

push time in 4 months

issue openedbundler/bundler

Bundler 2 does not auto-switch versions when BUNDLE_GEMFILE is set via .bundle/config

Bundler 2 is supposed to detect if a project was bundled with v1 based on the BUNDLED WITH lines in the lockfile.

This is not working correctly if:

  1. The Gemfile is in a subdirectory or with an alternate name
  2. The alternate location is specified in .bundle/config with BUNDLE_GEMFILE
  3. bundle update is run from the project root directory

Note: This is working correctly if one of the following is true:

  • bundle update is run from the subdirectory that includes the Gemfile
  • or bundle update is run with BUNDLE_GEMFILE set to the alternate location

Expected result

Running bundler 2.x on a project that was bundled with 1.x would be that BUNDLED_WITH would not be updated.

Observed result

BUNDLED_WITH is updated to 2.x

Example repo to reproduce

A repository that demonstrates this behavior is located here: https://github.com/jtokoph/bundler2bug

The readme has steps to reproduce.

created time in 4 months

push eventjtokoph/bundler2bug

Jason Tokoph

commit sha 34a474d5c27bfb2000583eb739013856bc41e25b

Add readme

view details

push time in 4 months

create barnchjtokoph/bundler2bug

branch : master

created branch time in 4 months

created repositoryjtokoph/bundler2bug

created time in 4 months

more