cc @Chuxel

The latest Ionide plugin (5.x) requires the .NET 5 SDK. F# developers also tend to update things very quickly, so I think we can just drop the other .NET Core SDK options. Otherwise, to make this function with the other SDKs, we'd have to install specific versions of the plugin.

Pylance has some pretty impressive features which I feel is a must-have in any python dev environment. Also being developed by Microsoft, it makes sense to have it installed in the Python dev container.

This will require two changes

1. Adding "ms-python.vscode-pylance" to list of extensions installed
2. Updating settings to "python.languageServer": "Pylance"

<!-- 🚨 Please only include bugs related to Dev Container Definitions here. 🚨 Other locations: VS Code Remote Development: http://github.com/Microsoft/vscode-remote-release VS Code OSS: http://github.com/Microsoft/vscode GitHub Codespaces: https://github.community/c/codespaces-beta -->

I can't change the default shell through chsh utility.

<!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

• Name of Dev Container Definition with Issue: mcr.microsoft.com/vscode/devcontainers/base:ubuntu-20.04

Steps to Reproduce:

1. Install fish inside container
2. Run sudo chsh -s /usr/bin/fish vscode
3. Get chsh: user 'vscode' does not exist in /etc/passwd error and /etc/passwd is now empty
4. Shell is now broken and I need to clear the docker volume to fix it

Nevermind, this problem is unrelated to devcontainers. The issue is present with the ubuntu image.

<!-- 🚨 Please only include bugs related to Dev Container Definitions here. 🚨 Other locations: VS Code Remote Development: http://github.com/Microsoft/vscode-remote-release VS Code OSS: http://github.com/Microsoft/vscode GitHub Codespaces: https://github.community/c/codespaces-beta -->

I can't change the default shell through chsh utility.

<!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

• Name of Dev Container Definition with Issue: mcr.microsoft.com/vscode/devcontainers/base:ubuntu-20.04

Steps to Reproduce:

1. Install fish inside container
2. Run sudo chsh -s /usr/bin/fish vscode
3. Get chsh: user 'vscode' does not exist in /etc/passwd error and /etc/passwd is now empty
4. Shell is now broken and I need to clear the docker volume to fix it

<br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><br/>:x: ferm10n sign now<br/>_{You have signed the CLA already but the status is still pending? Let us recheck it.}

I modeled this off the docker-debian.sh script, to allow using docker-from-docker on an alpine distro, like https://github.com/microsoft/vscode-dev-containers/tree/master/containers/docker-from-docker

That link was for debian/ubuntu only, but this would allow alpine to be used as well.

And here's the Dockerfile I tested it with:

FROM alpine

# [Option] Install zsh
ARG INSTALL_ZSH="true"
# [Option] Enable non-root Docker access in container
ARG ENABLE_NONROOT_DOCKER="true"

# Install needed packages and setup non-root user. Use a separate RUN statement to add your own dependencies.
ARG USERNAME=automatic
ARG USER_UID=1000
ARG USER_GID=$USER_UID
COPY .devcontainer/*.sh /tmp/library-scripts/
RUN apk update && ash /tmp/library-scripts/common.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" \
    # Use Docker script from script library to set things up
    && /bin/bash /tmp/library-scripts/docker.sh "${ENABLE_NONROOT_DOCKER}" "/var/run/docker-host.sock" "/var/run/docker.sock" "${USERNAME}" \
    # Clean up
    && rm -rf /tmp/library-scripts /var/cache/apk/*

# Setting the ENTRYPOINT to docker-init.sh will configure non-root access to 
# the Docker socket if "overrideCommand": false is set in devcontainer.json. 
# The script will also execute CMD if you need to alter startup behaviors.
ENTRYPOINT [ "/usr/local/share/docker-init.sh" ]
CMD [ "sleep", "infinity" ]

Closes https://github.com/microsoft/vscode-dev-containers/issues/508.

What are you trying to accomplish?

In order to improve our metrics around reference violations, we would like to be able to view the actual violation count for each constant, rather than just the number of files that contain violations. A single file could conceivably contain a hundred reference violations, but that impossible to determine without parsing the file either via script or visually.

Adding a violation count per constant is a relatively unobtrusive way to get this count that should not interfere or overly complicate the core functions of packwerk. With this number included in deprecated_references.yml, the granularity of the monitoring for referential integrity of each package is improved and progress toward detangling dependencies can be better tracked.

What approach did you choose and why?

I chose to just add another key/value pair to the package violations hash. Now, in addition to "files" and "violations", we also have "violation_count". This is an additive change to the existing structure of the deprecated_dependencies.yml file that is unlikely to affect consumers' expectations for the file's structure.

On another branch I also wrote a per file violation count which does alter the structure of the deprecated_dependencies.yml but I thought I'd hold off on that for now to see if we truly need it at GitHub or if there is interest elsewhere in the community.

What should reviewers focus on?

There's just one line of production code change, so I guess just focus on ensuring this is an accurate reflection of the violation count for the constant. No new tests were added but existing tests have been adapted in a way I believe sufficiently covers the change. Maybe there are other scenarios that should be tested which I did not consider?

Type of Change

• [ ] Bugfix
• [x] New feature
• [ ] Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Checklist

• [x] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] It is safe to rollback this change.

<!-- 🚨 Please only include feature requests related to Dev Container Definitions here. 🚨 Other locations: VS Code Remote Development: http://github.com/Microsoft/vscode-remote-release VS Code OSS: http://github.com/Microsoft/vscode GitHub Codespaces: https://github.community/c/codespaces-beta -->

<!-- Describe the feature request --> Is it possible to specify an image tag in devcontainer.json when building an image from Dockerfile? I read the official reference but I could not find something like "build.tag". https://code.visualstudio.com/docs/remote/devcontainerjson-reference

I basically copied over all the new script files into my repo and re-applied our changes.

Only thing we had to Chang on top of this was to oudate the devcontainer.json to use Dockerfile instead if base.Dockerfile.

• VSCode Version:
• Local OS Version: Windowr 10
• Name of Dev Container Definition with Issue:

Very similar to: https://github.com/microsoft/vscode-dev-containers/issues/589, new version of the image seems to have re-introduced the same bug.

Create a custom image, inheriting from FROM mcr.microsoft.com/vscode/devcontainers/universal:linux

FROM mcr.microsoft.com/vscode/devcontainers/universal:linux

USER codespace

RUN npm install -g @angular/cli 
    
RUN az extension add --name azure-devops \
    && az extension add --name application-insights \
    && az extension add --name portal

ADD Microsoft.PowerShell_profile.ps1 /home/codespace/.config/powershell/Microsoft.PowerShell_profile.ps1
ADD Microsoft.PowerShell_profile.ps1 /home/codespace/.config/powershell/Microsoft.VSCode_profile.ps1

Docker complains:

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
See 'docker run --help'.

That indeed fixes it! Thanks for the quick feedback.

With everyone replicating these docker files and devcontainer.jsons in will become more of an issue in the future I guess... things breaking when you rebuild the image... Are you getting any telemetry on those kinds of things?

I open the server directory from Remote Containers: Open Folder in Container, the environment variables are not reflected in the dockerfile.

If you run docker-compose up -d from root, the variable TEST will be reflected as true.

I could not do it by specifying .env from env_file in docker-compose.

How can I get the variable TEST to output true set in .env?

run environment

OS: Windows10
  WSL2 Ubuntu 20.04.1
docker: 20.10.0

project tree

root
|- .devcontainer
|   |- docker-compose.yml
|- docker
|    |- Dockerfile
|- client (src)
|- server (src)
|   |- .devcontainer.json
|- .env
|- docker-compose.yml 

/dcoer-compose.yml

version: "3"

services:
  php:
    build:
      context: ./docker/php
      args:
        - TEST=${TEST}
    env_file:
      - .env

/.env

TEST=true

/docker/Dockerfile

FROM php:7.4-fpm

ARG TEST

# ${TEST} is empty

/server/.devcontainer.json

{
	"name": "php",
	"dockerComposeFile": [
		"../docker-compose.yml",
		"../.devcontainer/docker-compose.yml"
	],
	"service": "php",
	"workspaceFolder": "/workspace/server",
	"shutdownAction": "none",
	"settings": {
	},
	"extensions": [
	]
}

@Chuxel I found the culprit. If I am working long time on dev containers then vmmem process starts to consume 95% of the ram unnecessary. Easy fix is to reboot the computer and ram usage drops to 50%-60%. 16GB ram is enough. You just need to reboot computer often to fix the issue.

That sounds awesome. I'll run more tests tomorrow

On Wed, Jan 13, 2021, 23:02 Allison Weins [email protected] wrote:

Hi @jessehouwing https://github.com/jessehouwing, after consulting with Chuck, we think we know the issue here. If you look at 'tmp/dockerd.logyou'll likely see a permissions error. To fix this, you'll need to tweak the runArgs in your devcontainer.json to include--privilegedand--init. You'll also want to remove mounts` as we've recently updated the universal image to use docker-in-docker and bound mounts should be taken care of for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-dev-containers/issues/717#issuecomment-759766992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA724S7JS5DUAD5SKLWF533SZYKBBANCNFSM4WA7X4OA .

As apple is pushing their M1 chips, are there ARM builds planned to speed up work done inside devcontainers on the latest Macs?

Using these x86 work but it feels very slow. I recompiled the typescript-node using arm64v8/node instead of the regular node base container and it feels a lot smoother.

Hi @oberbeck.

We've already got an issue tracking this request at #558 and I encourage you to follow along there/upvote it!

As a note, this request will require a bit of work so we don't have an ETA to share for fulfilling it.

I'm going to close this issue as a duplicate but feel free to re-open if you disagree/have further comments that you don't think belong on #558.

Hi @sti0,

I'd suggest checking out the new docker-in-docker definition, since it will not have these bind mount problems. We'd love to hear feedback on how that goes!

On our side, we'll need to update our docs after we figure out the recommended/easiest way to solve the incorrectly escaped chars issue. It is indeed that colon causing you issues.

Hi @jessehouwing, after consulting with Chuck, we think we know the issue here. If you look at 'tmp/dockerd.logyou'll likely see a permissions error. To fix this, you'll need to tweak the runArgs in your devcontainer.json to include--privilegedand--init. You'll also want to removemounts` as we've recently updated the universal image to use docker-in-docker and bound mounts should be taken care of for you.

@Chuxel