profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/joohoi/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

joohoi/acme-dns 1078

Limited DNS server with RESTful HTTP API to handle ACME DNS challenges easily and securely.

joohoi/acme-dns-certbot-joohoi 105

Certbot client hook for acme-dns

joohoi/godance 11

SMB password sprayer

joohoi/focli 8

Command line interface to Föli bus stop timetables

joohoi/blight 2

Screen backlight control script for Linux

joohoi/PayloadsAllTheThings 2

A list of useful payloads and bypass for Web Application Security and Pentest/CTF

joohoi/acme-dns.io 1

ACME-DNS.io site files

joohoi/httpexpect 1

End-to-end HTTP and REST API testing for Go.

joohoi/matterbridge 1

bridge between mattermost, IRC, gitter, xmpp, slack, discord, telegram, rocket.chat, steam, twitch, ssh-chat, zulip, whatsapp and matrix with REST API (mattermost not required!)

startedjoohoi/acme-dns

started time in 6 hours

startedjoohoi/acme-dns

started time in 8 hours

create barnchcertbot/website-builds

branch : dependabot/npm_and_yarn/lodash-4.17.21

created branch time in 8 hours

create barnchcertbot/website

branch : dependabot/npm_and_yarn/lodash-4.17.21

created branch time in 8 hours

PR opened certbot/website

Bump lodash from 4.17.19 to 4.17.21

Bumps lodash from 4.17.19 to 4.17.21. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/f299b52f39486275a9e6483b60a410e06520c538"><code>f299b52</code></a> Bump to v4.17.21</li> <li><a href="https://github.com/lodash/lodash/commit/c4847ebe7d14540bb28a8b932a9ce1b9ecbfee1a"><code>c4847eb</code></a> Improve performance of <code>toNumber</code>, <code>trim</code> and <code>trimEnd</code> on large input strings</li> <li><a href="https://github.com/lodash/lodash/commit/3469357cff396a26c363f8c1b5a91dde28ba4b1c"><code>3469357</code></a> Prevent command injection through <code>_.template</code>'s <code>variable</code> option</li> <li><a href="https://github.com/lodash/lodash/commit/ded9bc66583ed0b4e3b7dc906206d40757b4a90a"><code>ded9bc6</code></a> Bump to v4.17.20.</li> <li><a href="https://github.com/lodash/lodash/commit/63150ef7645ac07961b63a86490f419f356429aa"><code>63150ef</code></a> Documentation fixes.</li> <li><a href="https://github.com/lodash/lodash/commit/00f0f62a979d2f5fa0287c06eae70cf9a62d8794"><code>00f0f62</code></a> test.js: Remove trailing comma.</li> <li><a href="https://github.com/lodash/lodash/commit/846e434c7a5b5692c55ebf5715ed677b70a32389"><code>846e434</code></a> Temporarily use a custom fork of <code>lodash-cli</code>.</li> <li><a href="https://github.com/lodash/lodash/commit/5d046f39cbd27f573914768e3b36eeefcc4f1229"><code>5d046f3</code></a> Re-enable Travis tests on <code>4.17</code> branch.</li> <li><a href="https://github.com/lodash/lodash/commit/aa816b36d402a1ad9385142ce7188f17dae514fd"><code>aa816b3</code></a> Remove <code>/npm-package</code>.</li> <li>See full diff in <a href="https://github.com/lodash/lodash/compare/4.17.19...4.17.21">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~bnjmnt4n">bnjmnt4n</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

2 changed files

pr created time in 8 hours

PR opened certbot/certbot

[Windows] Cleanup Certbot pkg dir before installing to avoid dependencies conflicts

Fixes #8824

This PR makes the installer first delete (if exist) the previous pkg directory in the Certbot installation in order to avoid dependencies conflicts when a new version of Certbot (with new versions of dependencies) is intaller other an existing one.

I took the simplest approach here, which is to delete specifically the directories known to create conflicts, instead of more complex approaches that involve to factor in some way the complete uninstaller logic. This is because the complexity added without a clear improvement does not worth it in my opinion. More specifically:

  • factorizing in some way the uninstaller section in the NSIS template make the installer use any potential new logic of a new installation of Certbot instead of the one applying for the current installation, and may create unexpected errors during installation or at runtime
  • calling the existing uninstaller.exe would be better, but I could not find a proper way to let NSIS wait for the actual end of the uninstall logic, and again may create unexpected errors during installation or at runtime
+5 -0

0 comment

1 changed file

pr created time in 12 hours

issue commentcertbot/certbot

Docker image size growing

Ouch.

The culprit seems to be /root/.cargo, presumably due to us upgrading to a version of cryptography that has a build-time dependency on Rust.

$ sudo docker run -it --rm --entrypoint /bin/sh  certbot/certbot:v1.14.0
/opt/certbot # du -hs /root/.cargo/
257.1M  /root/.cargo/

https://github.com/pyca/cryptography/issues/5991 suggests to use a multi-stage Docker build, which is what popped into my head as well, but we could also just blow it away explicitly after pip is done installing stuff; we don't have a runtime dependency on anything in there.

invidian

comment created time in 13 hours

PR opened certbot/certbot

Deprecate zope.component in favor of an internal certbot services module

This is the first PR of a serie with the goal of removing totally zope dependencies from Certbot. As discussed previously with @bmw, the steps will be the following:

  1. Removing mechanics around zope.component
  2. Creating ABC classes that will replace Zope interfaces from certbot.intefaces
  3. Rewrite plugin discovery logic to use the ABC classes instead of the Zope interfaces
  4. Removing Zope interfaces, zope.* dependencies and deprecation paths added during the previous steps

This PR is solving the first step.

zope.component is used in Certbot to provide singleton logic: global objects implementing IConfig, IReporter and IDisplay need to be available everywhere in Certbot code, and provideUtility/getUtility from zope.component are used for that purpose.

In this PR a new module certbot.services is created, and reimplement this singleton logic through the getters/setters module functions for config, reporter and display. All Certbot code is adapted to use this new logic.

The certbot.services is part of the public API.

A deprecation path is provided for provideUtility and getUtility through the init module of certbot: when these functions are called for the Certbot Zope interfaces, a warning is emitted and the call is delegated to the certbot.services module that will return the actual singletons. This way external plugins maintainers have the occasion to be warned about deprecated usage of zope.component for Certbot and the necessity to move to the new logic.

Beside obvious changes throughout the Certbot code, an extra care was needed for certbot.tests.util.patch_get_utility. Indeed despite this decorator claiming to patch only the display utility, it was actually patching any output of getUtility function, including reporter and config, even though the mock objects specs were taken from the display utility interface... To make things clear, I make patch_get_utility explicitly mock display only, and change its name appropriately. In test modules either reporter or display are mocked as needed.

+475 -315

0 comment

44 changed files

pr created time in 14 hours

issue openedcertbot/certbot

Docker image size growing

It seems over the past 7 months Docker image size grow 3 times. Is this something expected?

$ docker image ls | grep certbot
certbot/certbot      v1.15.0                        31f028392d54        3 days ago          381MB
certbot/certbot      v1.14.0                        c8eac9ed295e        4 weeks ago         357MB
certbot/certbot      v1.13.0                        67cfe9e9c63f        2 months ago        95.5MB
certbot/certbot      v1.11.0                        7e91e27a5806        4 months ago        96.1MB
certbot/certbot      v1.10.0                        c3703e180159        5 months ago        89.1MB
certbot/certbot      v1.9.0                         0091bcdbf8c6        7 months ago        92.3MB

created time in 16 hours

PR opened certbot/josepy

Python 3

Let's remove a few more remnants from the Python 2 days :)

+22 -31

0 comment

8 changed files

pr created time in 18 hours

pull request commentcertbot/certbot

Fix incompatibility with lexicon >= v3.6.0

Done, thanks. As far as I understand the local-oldest-requirements.txt serve to override requirements from oldest_constraints.txt, so I have removed the dns-lexicon lines from where it was mentioned, since none of them was specifying a newer version.

coldfix

comment created time in a day

push eventcertbot/certbot

Brad Warren

commit sha 7eae058af595f526b42031c646b1febebdcffeca

Remove OS instructions (#8833) Fixes https://github.com/certbot/certbot/issues/8832. [These instructions are creating confusion among users](https://github.com/certbot/certbot/issues/8832) and [frustration among packagers](https://pagure.io/fesco/issue/2570) for whom the warning at the top of the OS packaging section doesn't apply. Because of this, I think we should remove them in favor of our instruction generator and snap/docker/pip instructions. I also told Fedora packagers that we could probably do this in response to them continuing to improve their Certbot packages which they've done through things like the renewal timer that is now enabled by default.

view details

push time in a day

delete branch certbot/certbot

delete branch : remove-os-instructions

delete time in a day

PR merged certbot/certbot

Remove OS instructions

Fixes https://github.com/certbot/certbot/issues/8832.

These instructions are creating confusion among users and frustration among packagers for whom the warning at the top of the OS packaging section doesn't apply. Because of this, I think we should remove them in favor of our instruction generator and snap/docker/pip instructions.

I also told Fedora packagers that we could probably do this in response to them continuing to improve their Certbot packages which they've done through things like the renewal timer that is now enabled by default.

+0 -111

0 comment

1 changed file

bmw

pr closed time in a day

issue closedcertbot/certbot

Ubuntu 20.04 instructions need update. ppa is deprecated. install.html says use ppa, not snap.

After a bit of Google searching, I have learned that the published instructions for certbot at https://certbot.eff.org/docs/install.html need an update.

The instructions currently say:

Ubuntu

If you run Ubuntu, certbot can be installed using:

sudo apt-get install certbot

Optionally to install the Certbot Apache plugin, you can use:

sudo apt-get install python3-certbot-apache

Doing so under Ubuntu 20.04 says no such package is availab.e

Google searching says to add the chatbot ppa as follows:

sudo add-apt-repository ppa:certbot/certbot

That gives an errror message saying that the package is deprecated, pointing back at https://certbot.eff.org/docs/install.html which is where we came from.

Apparently, snap --classic is the right install method for Ubuntu 20.04.

My operating system is (include version):

Ubuntu 20.04

I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):

snap

I ran this command and it produced this output:

# add-apt-repository ppa:certbot/certbot
The PPA has been DEPRECATED.

To get up to date instructions on how to get certbot for your systems, please see https://certbot.eff.org/docs/install.html.
More info: https://launchpad.net/~certbot/ archive/ubuntu/certbot
Press [ENTER] to continue or Ctrl-c to cancel adding it.
^C

closed time in a day

poetnerd

pull request commentcertbot/certbot

Fix incompatibility with lexicon >= v3.6.0

Well obviously with this new version of Lexicon we break the compatibility with some old systems, but this is fine since they are unlikely to update the DNS plugins. You can move the updated constraint to the last section, Plugins constraints.

Don't forget to update the relevant local-oldest-requirements.txt files in the DNS plugins folders.

coldfix

comment created time in a day

issue commentcertbot/certbot

Ubuntu 20.04 instructions need update. ppa is deprecated. install.html says use ppa, not snap.

Thanks for describing your confusion here. I created https://github.com/certbot/certbot/pull/8833 to fix this.

poetnerd

comment created time in a day

PR opened certbot/certbot

Remove OS instructions

These instructions are creating confusion among users and frustration among packagers for whom the warning at the top of the OS packaging section doesn't apply. Because of this, I think we should remove them in favor of our instruction generator and snap/docker/pip instructions.

I also told Fedora packagers that we could probably do this in response to them continuing to improve their Certbot packages which they've done through things like the renewal time that is now enabled by default.

+0 -111

0 comment

1 changed file

pr created time in a day

create barnchcertbot/certbot

branch : remove-os-instructions

created branch time in a day

PR closed certbot/certbot

Update lexion create record rtype argument

Pull Request Checklist

  • [x] If the change being made is to a distributed component, edit the master section of certbot/CHANGELOG.md to include a description of the change being made.
  • [x] Add or update any documentation as needed to support the changes in this PR.
  • [x] Include your name in AUTHORS.md if you like.

Due to https://github.com/AnalogJ/lexicon/pull/341 lexicon change the type keyword argument to rtype.

Here make a change to LexiconClient to fix this problem:

  File "/opt/certbot/src/certbot/certbot/plugins/dns_common_lexicon.py", line 48, in add_txt_record
    self.provider.create_record(type='TXT', name=record_name, content=record_content)
TypeError: create_record() got an unexpected keyword argument 'type'
+7 -6

1 comment

4 changed files

tengattack

pr closed time in a day

pull request commentcertbot/certbot

Update lexion create record rtype argument

Thanks a lot for taking the time to write a PR @tengattack, but we already have a PR for this at https://github.com/certbot/certbot/pull/8819 which has been reviewed so I'm going to close this in favor of that one.

tengattack

comment created time in a day

issue closedcertbot/certbot

when create_record, unexpected keyword argument 'type'

My operating system is Debian GNU/Linux 10

I installed Certbot with pip (python 3.7.3)

I ran this command and it produced this output:

command:

sudo /dictial-certbot/venv/bin/certbot certonly --dns-ovh --dns-ovh-credentials /home/admin/.ovhapi -d dictial.com -d *.dictial.com --email ismael.lachheb@protonmail.com --agree-tos --noninteractive

output:

Saving debug log to /var/log/letsencrypt/letsencrypt.log
Plugins selected: Authenticator dns-ovh, Installer None
Requesting a certificate for dictial.com and *.dictial.com
Performing the following challenges:
dns-01 challenge for dictial.com
dns-01 challenge for dictial.com
Cleaning up challenges
Encountered exception during recovery: TypeError: delete_record() got an unexpected keyword argument 'type'
An unexpected error occurred:
TypeError: create_record() got an unexpected keyword argument 'type'
Please see the logfiles in /var/log/letsencrypt for more details.

Certbot's behavior differed from what I expected because:

I expected it to work, it was fonctionnal a few months ago

closed time in a day

lachhebo

issue commentcertbot/certbot

when create_record, unexpected keyword argument 'type'

Closing as a duplicate of https://github.com/certbot/certbot/issues/8826. This should be fixed in our next release.

lachhebo

comment created time in a day

issue commentcertbot/certbot

Windows ACME challenge unreadable : does not use inherited security

If you run certbot.exe certonly --webroot -d www.stavangerbilder.no --debug-challenges --dry-run, can you tell me the permissions on:

  1. C:\Sites\Stavangerbilder
  2. C:\Sites\Stavangerbilder.well-known\acme-challenge
  3. The file created by Certbot in C:\Sites\Stavangerbilder.well-known\acme-challenge
  4. Your file created in C:\Sites\Stavangerbilder.well-known\acme-challenge using notepad that is served just fine
Tarjei-stavanger

comment created time in a day

startedjoohoi/acme-dns

started time in a day

issue openedcertbot/certbot

Ubuntu 20.04 instructions need update. ppa is deprecated. install.html says use ppa, not snap.

After a bit of Google searching, I have learned that the published instructions for certbot at https://certbot.eff.org/docs/install.html need an update.

The instructions currently say:

Ubuntu

If you run Ubuntu, certbot can be installed using:

sudo apt-get install certbot

Optionally to install the Certbot Apache plugin, you can use:

sudo apt-get install python3-certbot-apache

Doing so under Ubuntu 20.04 says no such package is availab.e

Google searching says to add the chatbot ppa as follows:

sudo add-apt-repository ppa:certbot/certbot

That gives an errror message saying that the package is deprecated, pointing back at https://certbot.eff.org/docs/install.html which is where we came from.

Apparently, snap --classic is the right install method for Ubuntu 20.04.

My operating system is (include version):

Ubuntu 20.04

I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):

snap

I ran this command and it produced this output:

# add-apt-repository ppa:certbot/certbot
The PPA has been DEPRECATED.

To get up to date instructions on how to get certbot for your systems, please see https://certbot.eff.org/docs/install.html.
More info: https://launchpad.net/~certbot/ archive/ubuntu/certbot
Press [ENTER] to continue or Ctrl-c to cancel adding it.
^C

created time in a day

push eventcertbot/website-builds

Travis CI

commit sha ab11d4f7141568eb8b0c12cc33e8583e81b39d3c

Build website at f8dd585

view details

push time in 2 days

PR opened certbot/certbot

Update lexion create record rtype argument

Pull Request Checklist

  • [ ] If the change being made is to a distributed component, edit the master section of certbot/CHANGELOG.md to include a description of the change being made.
  • [ ] Add or update any documentation as needed to support the changes in this PR.
  • [ ] Include your name in AUTHORS.md if you like.

Due to https://github.com/AnalogJ/lexicon/pull/341 lexicon change the type keyword argument to rtype.

Here make a change to LexiconClient to fix this problem:

  File "/opt/certbot/src/certbot/certbot/plugins/dns_common_lexicon.py", line 48, in add_txt_record
    self.provider.create_record(type='TXT', name=record_name, content=record_content)
TypeError: create_record() got an unexpected keyword argument 'type'
+6 -5

0 comment

3 changed files

pr created time in 2 days

issue commentcertbot/certbot

when create_record, unexpected keyword argument 'type'

Thanks, it worked

lachhebo

comment created time in 2 days

issue commentcertbot/certbot

when create_record, unexpected keyword argument 'type'

looking through it seems to be a duplicate of https://github.com/certbot/certbot/issues/8826

seems for now you can downgrade the lexicon provider version to <3.1 pip install dns-lexicon==3.0.8

lachhebo

comment created time in 2 days