profile
viewpoint
Jonathan Fielding jonathan-fielding @uswitch London https://www.jonathanfielding.com/ #WebDev at @uswitch, speaker about web things, writing about cool stuff, contributor to open source & into #Anime, loving both Attack on Titan and SAO

jonathan-fielding/AppBoilerplate 96

A jquery mobile app boilerplate

jonathan-fielding/criticaljs 9

CriticalJS is a JavaScript library which enables you to improve the perceived performance of your site

jonathan-fielding/DeferJS-Example 4

A quick example of deferring the loading of main javascript

jonathan-fielding/api.browserfeatures.io 2

API for finding out what browsers support a particular feature

jonathan-fielding/browserstack-travis-integration-demo 1

A simple demo of how we would intergrate BrowserStack and TravisCI to perform unit tests

jonathan-fielding/CalcCLI 1

Command line CLI using Node

jonathan-fielding/chosen 1

Chosen is a library for making long, unwieldy select boxes more friendly.

jonathan-fielding/compass-html5-boilerplate 1

Compass version of the Html5 Boilerplate project by Paul Irish

jonathan-fielding/developer.management 1

Developer Management is my new blog focused on being a manager in the software engineering space. I will be posting about different areas of being a manager including recruitment, people management and stakeholder management.

jonathan-fielding/DigitalOceanCLI 1

A simple command line utility for working with Digital Ocean Droplets

PR closed uswitch/trustyle

Input styling money

Description

Reopening pull request because of drone issues

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+1186 -140

0 comment

27 changed files

meghaniankov

pr closed time in 5 hours

PullRequestEvent

PR closed uswitch/trustyle

Move Input styling to theme do not merge

Description

image

Updated:

  • Input
  • Frozen Input
  • Input Alert
  • All themes

This will be a major release as functionality has changed.

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [x] Component library change: storybook / webpack / etc

Definition of done:

  • [x] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [x] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [x] If introducing a new component behaviour, added a story to cover that case.
  • [x] If component change, version updated
+1186 -140

1 comment

27 changed files

meghaniankov

pr closed time in 5 hours

pull request commentuswitch/trustyle

Move Input styling to theme

@meghaniankov can you please tidy up the commit history

meghaniankov

comment created time in 7 hours

PullRequestEvent

PR closed uswitch/trustyle

Move Input styling to theme do not merge

Description

image

Updated:

  • Input
  • Frozen Input
  • Input Alert
  • All themes

This will be a major release as functionality has changed.

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [x] Component library change: storybook / webpack / etc

Definition of done:

  • [x] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [x] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [x] If introducing a new component behaviour, added a story to cover that case.
  • [x] If component change, version updated
+1186 -140

0 comment

27 changed files

meghaniankov

pr closed time in 7 hours

push eventuswitch/trustyle

meghaniankov

commit sha 7b4371994ade919091dc7962af6fc002ed8764d5

feat: add rich text block styling

view details

meghaniankov

commit sha 71eab4bc081a36ba81f5d200373d8941f92902f2

feat: add form styling

view details

meghaniankov

commit sha 897abc29fb949a9147929c97ebe2d245a934f526

feat: add rich text block and form styling to all themes

view details

meghaniankov

commit sha ef002991728c4e68fc5ee447153f2b3440674ee9

feat: change panel text color in Money

view details

meghaniankov

commit sha 139d9abc68b21ea661f83087ff38155b16ae3f10

feat: update panel label styling in Money

view details

meghaniankov

commit sha 323b6372b88e3822176aa0aec738795cafd11385

Merge branch 'master' of https://github.com/uswitch/trustyle into form-and-panel-styling

view details

Meghan Iankov

commit sha d88012753f274ca217c5bbcafed951db243e6b70

Merge branch 'master' into form-and-panel-styling

view details

meghaniankov

commit sha ee70d9b9a7613fb8857bb3bfa42383d623c4747a

feat: update panel and form styling

view details

meghaniankov

commit sha 2222b1dc85aa17b2cc0f444650d1dce12fcefcc5

feat: update form and panel styling in themes for all brands

view details

meghaniankov

commit sha f445b9a2b71a0f8d3dac8a71a4b63586132ee8e4

Merge branch 'form-and-panel-styling' of https://github.com/uswitch/trustyle into form-and-panel-styling

view details

meghaniankov

commit sha cc95c0eb922ba3f04f2644d19fc40aa82c02b48d

feat: update form label in themes for all brands

view details

meghaniankov

commit sha 0cc44c8c2ec9cfe81416171aeb443c14cfa667b6

feat: move panel-primary under variants object

view details

Jonathan Fielding

commit sha 1316dc25c1f9d57ba160c778e5bfac5e67ca3a59

Merge branch 'master' into form-and-panel-styling

view details

meghaniankov

commit sha 8eadc955b55b6522de1a393afaa0dd0d623a5278

Merge branch 'master' of https://github.com/uswitch/trustyle into form-and-panel-styling

view details

meghaniankov

commit sha b2eb3091156c04989d305a4772f9102298159e09

Merge branch 'master' of https://github.com/uswitch/trustyle into form-and-panel-styling

view details

Meghan Iankov

commit sha 08273bf239616e026360851f5228297b4319d373

Merge branch 'master' into form-and-panel-styling

view details

meghaniankov

commit sha 77f704e0e7a20313b1b2f48894d09431e8feaea0

Merge branch 'form-and-panel-styling' of https://github.com/uswitch/trustyle into form-and-panel-styling

view details

meghaniankov

commit sha 08a366570b8c779bb8a4c8e4ea92b0de14bb1bf1

Publish - @uswitch/trustyle.bankrate-theme@1.4.0 - @uswitch/trustyle.journey-theme@1.1.0 - @uswitch/trustyle.money-theme@0.19.0 - @uswitch/trustyle.save-on-energy-theme@0.4.0 - @uswitch/trustyle.uswitch-rebrand-theme@0.1.0 - @uswitch/trustyle.uswitch-theme@0.17.0

view details

Jonathan Fielding

commit sha 722736967c93e4450bdce9f13b8c26917994f57d

Merge pull request #595 from uswitch/form-and-panel-styling Form and Rich Text Block panel styling to themes

view details

push time in a day

delete branch uswitch/trustyle

delete branch : form-and-panel-styling

delete time in a day

PR merged uswitch/trustyle

Form and Rich Text Block panel styling to themes

Description

image

Add styling for the Form (label and button) and Rich Text Block (base and panel-primary variant) to the themes for all brands. Note: Input styling will be on another PR

Checklist

Pull request contains:

  • [x] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [x] Includes theme changes for both Uswitch and money
  • [x] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [x] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+205 -6

0 comment

12 changed files

meghaniankov

pr closed time in a day

push eventuswitch/trustyle

Jonathan Fielding

commit sha 1a773dd720dbab0e8e100a2a664ed465285ef864

feat: fix incorrect list spacing

view details

Jonathan Fielding

commit sha a09d67e9c091e3d2de9ffde7a93f3231269770e6

Publish - @uswitch/trustyle.list@0.3.4

view details

Jonathan Fielding

commit sha cabae32b8847b64c30f33f68d2b2475a4489a8bf

Merge pull request #600 from uswitch/feat/fix-incorrect-list-spacing feat: fix incorrect list spacing

view details

push time in a day

delete branch uswitch/trustyle

delete branch : feat/fix-incorrect-list-spacing

delete time in a day

PR merged uswitch/trustyle

feat: fix incorrect list spacing

Description

Fix issue in Eevee with p being injected in list items

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+5 -1

0 comment

2 changed files

jonathan-fielding

pr closed time in a day

created taguswitch/trustyle

tag@uswitch/trustyle.list@0.3.4

React components with style

created time in a day

push eventuswitch/trustyle

Jonathan Fielding

commit sha a09d67e9c091e3d2de9ffde7a93f3231269770e6

Publish - @uswitch/trustyle.list@0.3.4

view details

push time in a day

push eventuswitch/trustyle

Ruxandra Anghel

commit sha 47dc5420a0d7632c6d297b5f35527728704889dd

Add hero-card compound

view details

Rik Jurriaans

commit sha 9bf0861f5b4e2cec482aae0fdcfd50259a769eb8

Change height of the radio buttons for the journey theme

view details

Rik Jurriaans

commit sha ef7450c56bc74e6815cecb96137e913c3508b1a4

Publish - @uswitch/trustyle.journey-theme@1.0.10

view details

Rik Jurriaans

commit sha 470be8ad27dea9dc428b52f309d7c803561519a1

Merge branch 'master' into change-radio-height

view details

Rik Jurriaans

commit sha db5c2cc039cbbefdc7c0ea4ede0cd918ca289dbe

Publish - @uswitch/trustyle.journey-theme@1.0.11

view details

Rik Jurriaans

commit sha 8253d9d0c12fe46033cb22a22780c583bb320acf

Merge pull request #584 from uswitch/change-radio-height Change height of the radio buttons for the journey theme

view details

Rik Jurriaans

commit sha c02296cbedcd8abf16bc5df3cb2de96009ff920a

Make radio 2px smaller on journey

view details

Rik Jurriaans

commit sha 432c338255e205272a07d01e728c23cf6e02cade

Publish - @uswitch/trustyle.journey-theme@1.0.12

view details

Peter Horne

commit sha aa59b09b55c9280c50bbc1bcc4774c4ede8316b1

Add critical prop to Card (for imgix)

view details

Rik Jurriaans

commit sha cf7fcc7d9363df29b9a0d465ec17931e7f111065

Merge pull request #586 from uswitch/change-height-theme Make radio 2px smaller on journey

view details

Peter Horne

commit sha a4057e8b4eedcf0722db093565f6d2034e201a41

Merge branch 'master' into critical-cards

view details

Peter Horne

commit sha 8038a5fd02cca5fb12bce1c113ee4c6ca7070ec0

Merge pull request #587 from uswitch/critical-cards Add critical prop to Card (for imgix)

view details

Peter Horne

commit sha 8a17198d9ac21e87e15ac61f127d7c37e2df1c17

Publish - @uswitch/trustyle.card@0.7.0

view details

Peter Horne

commit sha a2418b91b672798904e986a20ca4544928e1ce92

Merge pull request #588 from uswitch/publish-8038a5fd Publish

view details

domtronn

commit sha ce0ab93ec5c0c9208a7efb0c21331519320a8920

Pull theming of the numeric/bullet elements into elements 1. Move theming into elements block 2. Add backwards compatability for theme structure 3. Pull theming of before element into theme

view details

domtronn

commit sha d90ed2cf0c4e3da5e0913a95b8850507b023056d

Bump

view details

Peter Horne

commit sha c4952ec3578afa0ec092907f9cbae872d4235846

Always render description/linkText in card

view details

Peter Horne

commit sha de7a7eb4480b9ed18dc9cb1cb0c2cbb05d3e6bf4

Publish - @uswitch/trustyle.card@0.8.0

view details

Dom Charlesworth

commit sha 91d0faefe6d06b05fba40f2f4c0442c5f94f7c9b

Merge pull request #589 from uswitch/feat/pull-list-item-styles-into-theme Feat/pull list item styles into theme

view details

Peter Horne

commit sha 0745909dd276a9ca8922bd573badc6262acd6d2b

Merge branch 'master' into horizontal-cards

view details

push time in 2 days

push eventuswitch/trustyle

Jonathan Fielding

commit sha 36f7ae7c93bc1ee9f23d6757865a424e85d42981

feat: fix incorrect list spacing

view details

push time in 2 days

push eventuswitch/trustyle

Ruxandra Anghel

commit sha 47dc5420a0d7632c6d297b5f35527728704889dd

Add hero-card compound

view details

Ruxandra Anghel

commit sha 378d25ba7d56f6ac96c09c6521f4517ce298250d

Move from grid to flex

view details

Ruxandra Anghel

commit sha 3dcdc2fc69c00f57f458bf6006f1d6063751df1f

Update margins and paddings to standard spacing

view details

Jonathan Fielding

commit sha daa38a503aa125502cb06882c41859ff20d1e9f5

Merge branch 'master' into hero-card

view details

Ruxandra Anghel

commit sha 4841c652de5c817f31bd6957eefddee0ddc56e99

Merge pull request #582 from uswitch/hero-card Add hero-card compound

view details

Ruxandra Anghel

commit sha 8f11bf343cab726475dc6650697feb90d09ef356

Publish - @uswitch/trustyle.hero-card@1.0.0 - @uswitch/trustyle.link-list@0.2.1 - @uswitch/trustyle.money-theme@0.18.0

view details

Ruxandra Anghel

commit sha bed45b5f060ef34ccae72e2385299526082ab799

Merge pull request #598 from uswitch/publish Publish

view details

Phil Helm

commit sha 99ba79e432650646ac6fa6754884edd591a83deb

update bankrate theme

view details

Phil Helm

commit sha bf8e857bdaebdb37d2b85e0dd892ea96b28c4e1b

move list in theme

view details

Phil Helm

commit sha dae2404a563721e8c39e9fc05ad47d9e3d6093bc

not shorthand in side nav

view details

Phil Helm

commit sha 48c2e61677e4baeb7347b04bc14486d8683ea9d5

fix side(top) nav

view details

Phil Helm

commit sha 94b0eaf266ed06eadafb994c6fec2225ddbaf636

Publish - @uswitch/trustyle.bankrate-theme@1.3.0

view details

Phil Helm

commit sha f0b05787f614290c0c6c658e2f369906c585856e

Merge pull request #596 from uswitch/update-bankrate-theme update bankrate theme

view details

Salomao Rodrigues

commit sha 1b5450a49927b5457e9af8b82ad13f044a3ac00d

Fix sticky hover state on iOS

view details

Salomao Rodrigues

commit sha 7f66ba41319623b0c1b7b716ef92131017654fe2

Publish - @uswitch/trustyle.button@1.0.2 - @uswitch/trustyle.journey-theme@1.0.13

view details

Salomão Rodrigues

commit sha a2d1b71dc7e4a1fb2c0ba1f4b3423c09c8e0d413

Merge pull request #599 from uswitch/fix-sticky-hover Fix sticky hover state on iOS

view details

Jonathan Fielding

commit sha 1316dc25c1f9d57ba160c778e5bfac5e67ca3a59

Merge branch 'master' into form-and-panel-styling

view details

push time in 2 days

PR opened uswitch/trustyle

feat: fix incorrect list spacing

Description

<!-- Explain the purpose of this Pull Request. -->

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+4 -0

0 comment

1 changed file

pr created time in 2 days

create barnchuswitch/trustyle

branch : feat/fix-incorrect-list-spacing

created branch time in 2 days

Pull request review commentuswitch/trustyle

Form and Rich Text Block panel styling to themes

     }   }, +  "richTextBlock": {+    "base": {+      "*:first-child": { "mt": 0 }+    },+    "panel-primary": {

should their not be a variants object

meghaniankov

comment created time in 6 days

Pull request review commentuswitch/trustyle

Form and Rich Text Block panel styling to themes

     }   }, +  "richTextBlock": {+    "base": {+      "*:first-child": { "mt": 0 }+    },+    "panel-primary": {+      "py": "lg",+      "px": ["sm", "52px"],

please avoid magic numbers, (52px), can we make sure were using numbers from theme and speak to designers if they use a value that's not in the theme tokens

meghaniankov

comment created time in 6 days

push eventuswitch/trustyle

Liam McCombes

commit sha 1ca9f5b98185fa80aa1c54d6b55cc606232e1e19

WIP bankrate theming tweaks

view details

Phil Helm

commit sha 195db5a2dbe3c72c005915e74436b7ffed3bab72

fix bankrate author image

view details

Phil Helm

commit sha 5340b6ef5e40dd427c68c15267a54a4ee477bfd7

shorthands

view details

Phil Helm

commit sha 98ffa53f98b0c7b3e4967771a41c6464afe41372

fix li numbers

view details

Phil Helm

commit sha d614162caeb5c67af8b510727f0564e20d38c3cf

shorthands

view details

Rik Jurriaans

commit sha 9bf0861f5b4e2cec482aae0fdcfd50259a769eb8

Change height of the radio buttons for the journey theme

view details

Rik Jurriaans

commit sha ef7450c56bc74e6815cecb96137e913c3508b1a4

Publish - @uswitch/trustyle.journey-theme@1.0.10

view details

Phil Helm

commit sha ba146363c44517e0648bec464b5bc203f866c242

number fix

view details

Phil Helm

commit sha 7fb52d63f962a68a5fe1021b1517af6df08a6f35

space fix

view details

Phil Helm

commit sha d3ca2a3c569e786c12ef2cf8162ed5e739fbfcec

Publish - @uswitch/trustyle.article-intro@0.3.0 - @uswitch/trustyle.author@0.4.0 - @uswitch/trustyle.list@0.3.0 - @uswitch/trustyle.read-more-card@1.3.0 - @uswitch/trustyle.bankrate-theme@1.2.2

view details

Liam McCombes

commit sha c014922ede50880c0197d5def098b2cf50fd65f2

Merge pull request #583 from uswitch/bankrate-tweaks bankrate tweaks

view details

Phil Helm

commit sha c3209650a9385e5f7fc3e43012f2f0f64c903f8b

fix list

view details

Phil Helm

commit sha c643fa615915cb3c118d25da59acd588cdf8d6b6

Publish - @uswitch/trustyle.list@0.3.1

view details

Phil Helm

commit sha 89dc740adca98360b01b3f11114d41c7b98cbbe9

Merge pull request #585 from uswitch/list-fix list fix

view details

Rik Jurriaans

commit sha 470be8ad27dea9dc428b52f309d7c803561519a1

Merge branch 'master' into change-radio-height

view details

Rik Jurriaans

commit sha db5c2cc039cbbefdc7c0ea4ede0cd918ca289dbe

Publish - @uswitch/trustyle.journey-theme@1.0.11

view details

Rik Jurriaans

commit sha 8253d9d0c12fe46033cb22a22780c583bb320acf

Merge pull request #584 from uswitch/change-radio-height Change height of the radio buttons for the journey theme

view details

Rik Jurriaans

commit sha c02296cbedcd8abf16bc5df3cb2de96009ff920a

Make radio 2px smaller on journey

view details

Rik Jurriaans

commit sha 432c338255e205272a07d01e728c23cf6e02cade

Publish - @uswitch/trustyle.journey-theme@1.0.12

view details

Peter Horne

commit sha aa59b09b55c9280c50bbc1bcc4774c4ede8316b1

Add critical prop to Card (for imgix)

view details

push time in 6 days

Pull request review commentuswitch/trustyle

Add hero-card compound

         "variant": "compounds.cookie-banner.button-with-checkbox",         "borderColor": "plum"       }+    },++    "heroCard": {+      "variants": {+        "background": "linear-gradient(161.42deg, #924A8B 22.95%, #AF4C83 77.05%)",+        "box-shadow": "0px 9px 19px rgba(92, 36, 87, 0.2)",+        "column-gap": 104,+        "paddingX":["sm","xxxl"],+        "pt": ["md", 85],

looks like some magic numbers, are we not using standard theme spacing?

ruxiang05

comment created time in 7 days

Pull request review commentuswitch/trustyle

Add hero-card compound

 export const LinkList: React.FC<ListLinkProps> = ({ }) => {   return (     <div className={className} sx={{ variant: styles(variant) }}>-      <div-        sx={{-          display: 'flex',-          alignItems: 'center',-          variant: styles(variant, 'header')-        }}-      >-        {icon}-        <Styled.h3-          as="h2"+      {(title || icon) && (+        <div

I know this isnt new but as this is the title of the link list shouldn't this be a <header> element

ruxiang05

comment created time in 7 days

Pull request review commentuswitch/trustyle

Add hero-card compound

+/** @jsx jsx */++import * as React from 'react'+import { jsx, Styled } from 'theme-ui'+import { ButtonLink } from '@uswitch/trustyle.button-link'++interface Props extends React.HTMLAttributes<HTMLDivElement> {+  title: string+  ctaText: string+  children: React.ReactNode+}++const styles = (element?: string) =>+  `compounds.heroCard.variants${element ? `.${element}` : ''}`++const HeroCard: React.FC<Props> = ({ title, ctaText, children }) => {+  return (+    <div+      sx={{+        display: 'grid',

has this been tested in IE11

ruxiang05

comment created time in 7 days

push eventuswitch/trustyle

Ruxandra Anghel

commit sha 3dbaac7645981dbac33676b09c3c584df7767b08

Add quick links as variant to link list Add filled arrow to list items

view details

Ruxandra Anghel

commit sha a0558c8fbad7b7460903b028cdc76303b68d1565

Merge branch 'master' into quick-links

view details

Ruxandra Anghel

commit sha a42590cbbb508f1a4a760c79f8a1cca8fd898249

Publish - @uswitch/trustyle.interactive-tabs@1.3.2 - @uswitch/trustyle.side-nav@0.3.2 - @uswitch/trustyle.sponsored-product-rate-table@0.1.2 - @uswitch/trustyle.sponsored-product@0.1.2 - @uswitch/trustyle.testimonial-card@0.1.2 - @uswitch/trustyle.accordion@0.5.2 - @uswitch/trustyle.author-profile@0.2.2 - @uswitch/trustyle.breadcrumbs@1.3.2 - @uswitch/trustyle.bullet-list-highlight@0.3.2 - @uswitch/trustyle.call-out@1.2.2 - @uswitch/trustyle.category@1.4.2 - @uswitch/trustyle.drop-down@2.0.7 - @uswitch/trustyle.embedded-video@0.4.2 - @uswitch/trustyle.frozen-input@2.0.5 - @uswitch/trustyle.icon@1.8.6 - @uswitch/trustyle.input@1.0.1 - @uswitch/trustyle.link-list@0.2.0 - @uswitch/trustyle.pagination@0.2.2 - @uswitch/trustyle.read-more-card@1.2.2 - @uswitch/trustyle.side-drawer@0.2.59 - @uswitch/trustyle.money-theme@0.17.0

view details

Jonathan Fielding

commit sha 48e96bc44b61ec7084ef58c890f49de2990b75a6

Merge pull request #573 from uswitch/quick-links Add quick links as variant to link list

view details

push time in 9 days

delete branch uswitch/trustyle

delete branch : quick-links

delete time in 9 days

PR merged uswitch/trustyle

Add quick links as variant to link list

Description

Add quick links as a variant to link list. Affects Money theme.

Desktop

Screenshot 2020-06-19 at 15 52 47

Mobile

Screenshot 2020-06-19 at 15 53 01

Checklist

Pull request contains:

  • [x] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [x] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [x] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+195 -52

1 comment

27 changed files

ruxiang05

pr closed time in 9 days

pull request commentuswitch/trustyle

Add quick links as variant to link list

Please rebase, squash and then do your version commit after that

ruxiang05

comment created time in 9 days

Pull request review commentuswitch/trustyle

Add quick links as variant to link list

 import * as React from 'react' import { jsx, Styled } from 'theme-ui' +export type Variant = 'base' | 'quickLinks'+ interface ListLinkProps extends React.HTMLAttributes<HTMLDivElement> {   title?: string+  icon?: React.ReactNode+  variant?: Variant   className?: string } +const styles = (variant: Variant, element?: string) =>+  `elements.linkList.variants.${variant}${element ? `.${element}` : ''}`+ export const LinkList: React.FC<ListLinkProps> = ({   children,   title,+  icon,+  variant = 'base',   className }) => {+  console.log(styles(variant))

🙀

ruxiang05

comment created time in 10 days

Pull request review commentuswitch/trustyle

Add quick links as variant to link list

 const glyphChoices: Glyph[] = [   'cross',   'edit',   'email',+  'filled-arrow',

would be good to switch over to @callumacrae's new icon component once its done

ruxiang05

comment created time in 10 days

push eventuswitch/trustyle

Callum Macrae

commit sha 768c9311674a7fbf4a3fd4f5fc24ccaa3f894a53

Update README with warning about versioning early

view details

Callum Macrae

commit sha 16e2a1f288b0148bea481f00ae56a53dacb2ac1b

Merge branch 'master' into callumacrae-patch-1

view details

Jonathan Fielding

commit sha 5d1c9a764b38cff03cb13ce3bfe69cce7ceb6a77

Merge pull request #576 from uswitch/callumacrae-patch-1 Update README with warning about versioning early

view details

push time in 10 days

delete branch uswitch/trustyle

delete branch : callumacrae-patch-1

delete time in 10 days

PR merged uswitch/trustyle

Update README with warning about versioning early

Description

Have seen a couple people get blocked by this recently, and a bunch of the bot warnings in #trustyle were from people versioning early and then having to merge in master.

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [x] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+8 -0

0 comment

1 changed file

callumacrae

pr closed time in 10 days

Pull request review commentuswitch/trustyle

Move itemsPerRow to correct position

         "borderColor": "primary",         "color": "grey-100"       }+    },++    "card": {+      "itemsPerRow": [1, 2, 3]

@ruxiang05 please can you move this to the one that @domtronn pushed

ruxiang05

comment created time in 14 days

PR opened uswitch/trustyle

Add missing itemsPerRow

Description

<!-- Explain the purpose of this Pull Request. -->

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+1 -0

0 comment

1 changed file

pr created time in 14 days

Pull request review commentuswitch/trustyle

Credit card

 const makeStyles = (variant: string) => (element?: string) =>  const Card: React.FC<Props> = ({   className = '',+  date,   description,   horizontal = false,   imageSize = 'cover',   imgAlt,   imgSizes = '768px',   imgSrc,   linkHref,-  linkText = 'Read more',+  linkText,+  tag,

as i said in my other comment, this is possibly tags as we could have articles with multiple tags maybe, lets check with rob

ruxiang05

comment created time in 16 days

Pull request review commentuswitch/trustyle

Credit card

 export const VerticalCards = () => {               description={content}               linkHref="https://www.uswitch.com"               linkText="read about cats"+              tag="Credit Card"

could this be an array, lets check with Rob

ruxiang05

comment created time in 16 days

push eventuswitch/trustyle

Rik Jurriaans

commit sha a6d2f744055c552337c72ee83899c31e0425892a

Fix button styling in journey theme

view details

Rik Jurriaans

commit sha 21a0b9ecbf7bb737fa20a85e6fe5f4b556e6a800

Publish - @uswitch/trustyle.journey-theme@1.0.1

view details

Rik Jurriaans

commit sha 0893f465bdb8730f0b736969412ec382be39182c

Bumb

view details

Flora Harvey

commit sha 2dce0c8a833bf77a2927de8124748246b42540c0

Fix tabs for SSR

view details

Flora Harvey

commit sha 6e6262740abcb9a2acbc48cd0f49f178976cfe5a

Fix carousel & interactive tabs styling

view details

Rik Jurriaans

commit sha 26a7d293eaf0d61948ec56cd1c04644196bb8f10

Merge pull request #544 from uswitch/button-fixes Fix button styling in journey theme

view details

Flora Harvey

commit sha 6233054d1bc90dd03ff3b580f13950746cd6af21

Merge branch 'master' into design-fixes

view details

Rik Jurriaans

commit sha 79b1532fb01fb289be8b2524be35246b0af34ff8

Publish - @uswitch/trustyle.journey-theme@1.0.2

view details

Rik Jurriaans

commit sha d2a9e68f476a530f3f8b1824c67a355a09e98f01

Merge pull request #550 from uswitch/wtf Publish

view details

Flora Harvey

commit sha d7a198a66d9dbbb8da36a512ef57da161be16d4d

Merge branch 'master' into design-fixes

view details

Flora Harvey

commit sha f49c9ca94ef183751ed5545fd0a00c984352db41

Publish - @uswitch/trustyle.carousel@1.0.4 - @uswitch/trustyle.interactive-tabs@1.2.0 - @uswitch/trustyle.tabs@0.1.1 - @uswitch/trustyle.testimonial-card@0.0.16 - @uswitch/trustyle.uswitch-theme@0.14.3

view details

Flora Harvey

commit sha 444c95bff48019e60662f6e489bf9fc7202c9b0a

Merge pull request #549 from uswitch/design-fixes Design fixes

view details

Peter Horne

commit sha 9114982bba9484a9951d7df82e7c65747e2b702f

Add person + telephone themed icons

view details

Peter Horne

commit sha 1ec95f360ed6bd66b5d48bc51a616ec2cea3c8e4

Publish - @uswitch/trustyle.themed-icon@1.0.6

view details

Peter Horne

commit sha 6f247b7a20405f33e1c101a367dd0b11cfc5c792

Merge pull request #551 from uswitch/uswitch-icons Add person + telephone themed icons

view details

Jonathan Fielding

commit sha 88c9fb27201a7a77fc2dea7ae5b392ba2e582a74

feat: add bundlephobia workflow

view details

Jonathan Fielding

commit sha ddccc34b946587ca1c17073855b90e8e94367d36

test

view details

push time in 17 days

push eventuswitch/trustyle

Jonathan Fielding

commit sha dc4bc8ced818b3ffaab730211adb9a8209d954cb

test

view details

push time in 17 days

PR opened uswitch/trustyle

feat: add bundlephobia workflow

Description

Add bundlephobia workflow

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+18 -0

0 comment

1 changed file

pr created time in 17 days

create barnchuswitch/trustyle

branch : feat/bundlephobia

created branch time in 17 days

push eventuswitch/trustyle

Ruxandra Anghel

commit sha 98dc8b261b643115601bcdb9763194d29d2aff13

Update icon tile text colour

view details

Ruxandra Anghel

commit sha 3a13e8d3ca49237e0d11ccf6de476b8c6c975b08

Merge branch 'master' into category-tiles

view details

Ruxandra Anghel

commit sha 8ada20b556c78b5a83c7d6852fc3115060c4a7aa

Publish - @uswitch/trustyle.money-theme@0.13.1

view details

Jonathan Fielding

commit sha 9e9d0281d83dff8d0a327ccfb511be9e0c363306

Merge pull request #543 from uswitch/category-tiles Update icon tile text colour

view details

push time in 19 days

delete branch uswitch/trustyle

delete branch : category-tiles

delete time in 19 days

PR merged uswitch/trustyle

Update icon tile text colour

Description

Part of the money homepage redesign

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+7 -1

0 comment

2 changed files

ruxiang05

pr closed time in 19 days

push eventuswitch/trustyle

Nathan Hynes

commit sha 94c364cceebf696d53a28721215dc91757179a91

Updates logo-collection to include variant for outer div.

view details

Rik Jurriaans

commit sha 7ed2361740226d9f8fda666c6a535e7e78f01519

Remove reference to open which does not exist

view details

Nathan Hynes

commit sha 2ed99f89aef8e1d7cd0d13cc8a6b7b8a67968699

Publish - @uswitch/trustyle.logo-collection@1.0.1 - @uswitch/trustyle.money-theme@0.12.12 - @uswitch/trustyle.uswitch-theme@0.14.1

view details

Rik Jurriaans

commit sha cacca844f04909061e733c8900247acf7afa67ce

Publish - @uswitch/trustyle.funnel-progress@2.0.1

view details

Nathan Hynes

commit sha 29cb9aa984fb08f8f5590ed50f229ed3301d7463

Merge pull request #537 from uswitch/add-variant-to-logo Updates logo-collection to include variant for outer div.

view details

Rik Jurriaans

commit sha a496cb84cc3a5454f7126ef5371d7df5084d8fbb

Merge branch 'master' into fix-bug

view details

Rik Jurriaans

commit sha 969faa58699a4726821061ba449330e764557e95

Merge pull request #538 from uswitch/fix-bug Remove reference to open which does not exist

view details

Jonathan Fielding

commit sha 015f67bb76e02e19e2fbd31aba99281854702e2d

Merge branch 'master' into category-tiles

view details

push time in 21 days

push eventuswitch/trustyle

meghaniankov

commit sha 8c4429aacb88b3a92063dd43c88ac6fb8a4f636d

feat: make tabs scrolling optional

view details

meghaniankov

commit sha b1699f33ed9e3dacf5a8513e2a73d22457c10040

style: began styling tabs to Money design

view details

meghaniankov

commit sha 007b60e4c9757342f031300d8d92ac1cfd07082f

style: finish tab styling

view details

meghaniankov

commit sha 6ad9e70575f1a9c419108c6f39d6dc1bdb616fda

refactor: remove optional scrolling

view details

meghaniankov

commit sha 28ff5f5532b2977058d07e7f49f23bd83ac2e175

feat: replaced scrolling library with css

view details

meghaniankov

commit sha be7a80359fedd8ad92fe9cc9fbd386d16550820a

style: styled tabs closer to design

view details

meghaniankov

commit sha 139c2b8b98181ab5e04dbfcc3b1ed225edd79dbc

feat: re-wrote scrollable login within tabs component

view details

meghaniankov

commit sha c4e151b3ab0f0ffc3e089dc33e216630542130c8

feat: add touch events to scrolling

view details

meghaniankov

commit sha 928425695e29cc51209f78a6908ad871dd8692f7

feat: add left and right edge styling

view details

meghaniankov

commit sha 88e1040d8a2d26db8c5edd808592af3e56ed8a0c

feat: added logic to render edge styling when content is overflowed

view details

meghaniankov

commit sha c773621b7f2e996ed4d2a3c01fb3a510571a9722

refactor: moved scroll overflow styling to theme.json

view details

meghaniankov

commit sha faad20e7790f7443ff2b145de2edd3d8c1385d91

fix: add fix for ie11 dragging

view details

meghaniankov

commit sha 208fda1e666c46619cf2ac67d4776dd55ddc24ee

fix: fix cut off of last item when scrolling

view details

meghaniankov

commit sha 293be55e23e7945a483971e491e051b10eec7efc

style: add edge gradient and bottom border styling

view details

Sam Egger

commit sha 22420869b5bf22d3e18e17f332b9a14eb8eae613

fix: fixed bug where scrolling wouldnt work where the edge pseudo elements were placed

view details

Sam Egger

commit sha 66bcce71e6b110bcd4c2085aa8032b0b12d2339b

style: tweak margin on edges

view details

meghaniankov

commit sha 5ac2b26842ce4a5b25f94359caeefc1b27448f93

refactor: move background styling to level above

view details

meghaniankov

commit sha 73f7543385f0cac9233a66e1502c1eb879a3cd36

style: add edge gradient and bottom border styling on uSwitch theme

view details

meghaniankov

commit sha a7c74471b8bcb72fa63ff04f1058389ebfe33dac

Merge branch 'master' of https://github.com/uswitch/trustyle into edit-tabs-component

view details

meghaniankov

commit sha 64f378c7086d49b05bf4d06f7d3e702197fc0e7b

fix: fix build error in drone for null type

view details

push time in 22 days

delete branch uswitch/trustyle

delete branch : edit-tabs-component

delete time in 22 days

Pull request review commentuswitch/trustyle

Edit tabs component

 interface TabsProps extends React.HTMLAttributes<HTMLDivElement> {  export const Tabs: React.FC<TabsProps> = ({ children }) => {   const [activeTab, setActiveTab] = useState(0)+  const [left, setLeft] = useState(0)+  const tabs: RefObject<HTMLDivElement> = React.createRef()+  const tabWrap: RefObject<HTMLDivElement> = React.createRef()+  const [padding, setPadding] = useState(0)+  const [width, setWidth] = useState(0)+  const [wrapWidth, setWrapWidth] = useState(0)+  const [isPressed, setIsPressed] = useState(false)+  const [lastX, setLastX] = useState(0)+  const [showLeftBorder, setShowLeftBorder] = useState(false)+  const [showRightBorder, setShowRightBorder] = useState(false)+  const [scrollEnd, setScrollEnd] = useState(false)++  useEffect(() => {+    setPadding(tabs?.current?.offsetHeight)+    setWidth(tabs?.current?.scrollWidth)+  }, [tabs])++  useEffect(() => {+    setWrapWidth(tabWrap?.current?.offsetWidth)++    if (width > wrapWidth && !scrollEnd) {+      setShowRightBorder(true)+    }++    if (left !== 0) {+      setShowLeftBorder(true)+    } else {+      setShowLeftBorder(false)+    }+  }, [tabWrap])++  const setRealLeft = (left: number) => {+    if (left > 0) {+      return setLeft(0)+    }++    const minLeft = -(width - wrapWidth)++    if (left <= minLeft) {+      setScrollEnd(true)+      setShowRightBorder(false)+      return setLeft(minLeft)+    } else {+      setScrollEnd(false)+      setShowRightBorder(true)+    }++    setLeft(left)+  }++  const onMouseDown = (event: any) => {+    if (wrapWidth > width) return++    setLastX(event.clientX)+    setIsPressed(true)+  }++  const onMouseUp = () => {+    setIsPressed(false)+  }++  const onMouseMove = (event: any) => {+    if (!isPressed) return++    if (lastX > event.clientX) {+      // drag left+      const diff = lastX - event.clientX+      setRealLeft(left - diff)+    } else {+      // drag right+      const diff = event.clientX - lastX++      setRealLeft(left + diff)+    }++    setLastX(event.clientX)+  }++  const onTouchStart = (event: any) => {+    if (wrapWidth > width) return+    setLastX(event.touches[0].clientX)+    setIsPressed(true)+  }++  const onTouchEnd = () => {+    setIsPressed(false)+  }++  const onTouchMove = (event: any) => {+    if (!isPressed) return++    if (lastX > event.touches[0].clientX) {+      const diff = lastX - event.touches[0].clientX+      setRealLeft(left - diff)+    } else {+      const diff = event.touches[0].clientX - lastX+      setRealLeft(left + diff)+    }++    setLastX(event.touches[0].clientX)+  }++  const onDragStart = (event: any) => {+    event.preventDefault()+  }++  window.addEventListener('mouseup', onMouseUp)

i was there when we did this fix, it was for when the mouse moves outside the container before mouse up

meghaniankov

comment created time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2

released time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha 1f6bae8792ccb57fbec36bf0a73970679694602a

feat: update readme

view details

push time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha 8bdc278829d95ef0af27cf63d7e32a79aef834cd

fix: issue with strict type

view details

push time in 23 days

push eventuswitch/trustyle

Ruxandra Anghel

commit sha 7aa58be2c2daca2d9b64dcf3910871a20b1491b6

Fix previous/next page buttons

view details

Ruxandra Anghel

commit sha 27b93be97daadddb1bae4d8e89431fca4096151e

Fix skipping

view details

Ruxandra Anghel

commit sha 71ed537354765d3f0cbc5490e59b095db977adc4

Publish - @uswitch/trustyle.pagination@0.1.30

view details

Jonathan Fielding

commit sha 679d13263089d2f866aff3a2cf1262a072aeeaeb

Merge pull request #526 from uswitch/pagination Fix previous/next pagination buttons

view details

push time in 23 days

delete branch uswitch/trustyle

delete branch : pagination

delete time in 23 days

PR merged uswitch/trustyle

Fix previous/next pagination buttons

Description

Current Behaviour: When you click on the arrow on the right you are taken to the last page When you click on the arrow on the left you are taken to the first page

Expected Behaviour: When you click on the arrow on the right you are taken to the next page When you click on the arrow on the left you are taken to the previous page

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [x] Work has been tested in multiple browsers
  • [x] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+5 -5

0 comment

2 changed files

ruxiang05

pr closed time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2-rc5

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2-rc5

released time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha 4e4b6b5120d29d9411913aa53f2aafd2850aaa93

test

view details

push time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2-rc4

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2-rc4

released time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha 7e2d7b6fadaac775ee35f31805c9df6482d920dd

test

view details

push time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2-rc3

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2-rc3

released time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha d0ae2c54605e6015cefbd8c71053f96a7f1078f6

test

view details

push time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2-rc2

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2-rc2

released time in 23 days

Pull request review commentuswitch/trustyle

Fix previous/next pagination buttons

 const Pagination: React.FC<Props> = ({           ...liStyling         }}       >+        {console.log(currentPage)}

please remove console.log

ruxiang05

comment created time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha f131f95b6f372b2dcf355ba9864c8dec43233f0b

test

view details

push time in 23 days

created tagjonathan-fielding/bundlephobia-pr-review

tag1.2.2-rc1

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/bundlephobia-pr-review

1.2.2-rc1

released time in 23 days

push eventjonathan-fielding/bundlephobia-pr-review

Jonathan Fielding

commit sha 2ea1f612fe8d71a1db5bba3fd58f3b5dc2bf3b2f

feat: rename so I can publish

view details

push time in 23 days

created tagjonathan-fielding/check-my-bundlephobia

tag1.2.1

Github action to check for new added packages size on bundlephobia

created time in 23 days

release jonathan-fielding/check-my-bundlephobia

1.2.1

released time in 23 days

push eventjonathan-fielding/check-my-bundlephobia

Jonathan Fielding

commit sha 60cc87a6e87b5fa65dd747c5febba78937d062fd

logging

view details

push time in 23 days

fork jonathan-fielding/check-my-bundlephobia

Github action to check for new added packages size on bundlephobia

fork in 23 days

Pull request review commentuswitch/trustyle

Edit tabs component

 interface TabsProps extends React.HTMLAttributes<HTMLDivElement> {  export const Tabs: React.FC<TabsProps> = ({ children }) => {   const [activeTab, setActiveTab] = useState(0)+  const [left, setLeft] = useState(0)+  const tabs: RefObject<HTMLDivElement> = React.createRef()+  const tabWrap: RefObject<HTMLDivElement> = React.createRef()+  const [padding, setPadding] = useState(0)+  const [width, setWidth] = useState(0)+  const [wrapWidth, setWrapWidth] = useState(0)+  const [isPressed, setIsPressed] = useState(false)+  const [lastX, setLastX] = useState(0)+  const [showLeftBorder, setShowLeftBorder] = useState(false)+  const [showRightBorder, setShowRightBorder] = useState(false)+  const [scrollEnd, setScrollEnd] = useState(false)++  useEffect(() => {+    setPadding(tabs?.current?.offsetHeight)+    setWidth(tabs?.current?.scrollWidth)+  }, [tabs])++  useEffect(() => {+    setWrapWidth(tabWrap?.current?.offsetWidth)++    if (width > wrapWidth && !scrollEnd) {+      setShowRightBorder(true)+    }++    if (left !== 0) {+      setShowLeftBorder(true)+    } else {+      setShowLeftBorder(false)+    }+  }, [tabWrap])++  const setRealLeft = (left: number) => {+    if (left > 0) {+      return setLeft(0)+    }++    const minLeft = -(width - wrapWidth)++    if (left <= minLeft) {+      setScrollEnd(true)+      setShowRightBorder(false)+      return setLeft(minLeft)+    } else {+      setScrollEnd(false)+      setShowRightBorder(true)+    }++    setLeft(left)+  }++  const onMouseDown = (event: any) => {+    if (wrapWidth > width) return++    setLastX(event.clientX)+    setIsPressed(true)+  }++  const onMouseUp = () => {+    setIsPressed(false)+  }++  const onMouseMove = (event: any) => {+    if (!isPressed) return++    if (lastX > event.clientX) {+      // drag left+      const diff = lastX - event.clientX+      setRealLeft(left - diff)+    } else {+      // drag right+      const diff = event.clientX - lastX++      setRealLeft(left + diff)+    }++    setLastX(event.clientX)+  }++  const onTouchStart = (event: any) => {+    if (wrapWidth > width) return+    setLastX(event.touches[0].clientX)+    setIsPressed(true)+  }++  const onTouchEnd = () => {+    setIsPressed(false)+  }++  const onTouchMove = (event: any) => {+    if (!isPressed) return++    if (lastX > event.touches[0].clientX) {+      const diff = lastX - event.touches[0].clientX+      setRealLeft(left - diff)+    } else {+      const diff = event.touches[0].clientX - lastX+      setRealLeft(left + diff)+    }++    setLastX(event.touches[0].clientX)+  }++  const onDragStart = (event: any) => {+    event.preventDefault()+  }++  window.addEventListener('mouseup', onMouseUp)

is something similar needed for on touch up?

meghaniankov

comment created time in 24 days

Pull request review commentuswitch/trustyle

Edit tabs component

 interface TabsProps extends React.HTMLAttributes<HTMLDivElement> {  export const Tabs: React.FC<TabsProps> = ({ children }) => {   const [activeTab, setActiveTab] = useState(0)+  const [left, setLeft] = useState(0)+  const tabs: RefObject<HTMLDivElement> = React.createRef()+  const tabWrap: RefObject<HTMLDivElement> = React.createRef()+  const [padding, setPadding] = useState(0)+  const [width, setWidth] = useState(0)+  const [wrapWidth, setWrapWidth] = useState(0)+  const [isPressed, setIsPressed] = useState(false)+  const [lastX, setLastX] = useState(0)+  const [showLeftBorder, setShowLeftBorder] = useState(false)+  const [showRightBorder, setShowRightBorder] = useState(false)+  const [scrollEnd, setScrollEnd] = useState(false)++  useEffect(() => {+    setPadding(tabs?.current?.offsetHeight)+    setWidth(tabs?.current?.scrollWidth)+  }, [tabs])++  useEffect(() => {+    setWrapWidth(tabWrap?.current?.offsetWidth)++    if (width > wrapWidth && !scrollEnd) {+      setShowRightBorder(true)+    }++    if (left !== 0) {+      setShowLeftBorder(true)+    } else {+      setShowLeftBorder(false)+    }+  }, [tabWrap])++  const setRealLeft = (left: number) => {+    if (left > 0) {+      return setLeft(0)+    }++    const minLeft = -(width - wrapWidth)++    if (left <= minLeft) {+      setScrollEnd(true)+      setShowRightBorder(false)+      return setLeft(minLeft)+    } else {+      setScrollEnd(false)+      setShowRightBorder(true)+    }++    setLeft(left)+  }++  const onMouseDown = (event: any) => {+    if (wrapWidth > width) return++    setLastX(event.clientX)+    setIsPressed(true)+  }++  const onMouseUp = () => {+    setIsPressed(false)+  }++  const onMouseMove = (event: any) => {+    if (!isPressed) return++    if (lastX > event.clientX) {+      // drag left+      const diff = lastX - event.clientX+      setRealLeft(left - diff)+    } else {+      // drag right+      const diff = event.clientX - lastX++      setRealLeft(left + diff)+    }++    setLastX(event.clientX)+  }++  const onTouchStart = (event: any) => {+    if (wrapWidth > width) return+    setLastX(event.touches[0].clientX)+    setIsPressed(true)+  }++  const onTouchEnd = () => {+    setIsPressed(false)+  }++  const onTouchMove = (event: any) => {

can we combine onMouseMove and onTouchMove

meghaniankov

comment created time in 24 days

Pull request review commentuswitch/trustyle

Edit tabs component

 interface TabsProps extends React.HTMLAttributes<HTMLDivElement> {  export const Tabs: React.FC<TabsProps> = ({ children }) => {   const [activeTab, setActiveTab] = useState(0)+  const [left, setLeft] = useState(0)+  const tabs: RefObject<HTMLDivElement> = React.createRef()+  const tabWrap: RefObject<HTMLDivElement> = React.createRef()+  const [padding, setPadding] = useState(0)+  const [width, setWidth] = useState(0)+  const [wrapWidth, setWrapWidth] = useState(0)+  const [isPressed, setIsPressed] = useState(false)+  const [lastX, setLastX] = useState(0)+  const [showLeftBorder, setShowLeftBorder] = useState(false)+  const [showRightBorder, setShowRightBorder] = useState(false)+  const [scrollEnd, setScrollEnd] = useState(false)++  useEffect(() => {+    setPadding(tabs?.current?.offsetHeight)+    setWidth(tabs?.current?.scrollWidth)+  }, [tabs])++  useEffect(() => {+    setWrapWidth(tabWrap?.current?.offsetWidth)++    if (width > wrapWidth && !scrollEnd) {+      setShowRightBorder(true)+    }++    if (left !== 0) {+      setShowLeftBorder(true)+    } else {+      setShowLeftBorder(false)+    }+  }, [tabWrap])++  const setRealLeft = (left: number) => {

mayby it should be something like normalizeLeft?

meghaniankov

comment created time in 24 days

push eventjonathan-fielding/manager-readme

Jonathan Fielding

commit sha 37ad619850187bb537370fb2665bc9773daff35d

feat: RVU updateS

view details

push time in 24 days

Pull request review commentuswitch/trustyle

Adds collection of tabs to trustyle

+{+  "name": "@uswitch/trustyle.tabs",+  "version": "0.0.1",+  "license": "MIT",+  "main": "lib/index.js",+  "ts:main": "src/index.tsx",+  "publishConfig": {+    "access": "public"+  },+  "scripts": {+    "--------------- BUILDING": "----------------------",+    "clean": "rm -rf lib",+    "build": "npm run clean && tsc"+  },+  "peerDependencies": {+    "@emotion/core": "^10.0.27",+    "react": "^16.7.0"+  },+  "dependencies": {+    "@uswitch/trustyle.flex-grid": "^2.2.2",+    "react-indiana-drag-scroll": "^1.6.1"

the browser will need to parse 8kb of JS for this, is there any smaller libraries

NathanHynes

comment created time in a month

Pull request review commentuswitch/trustyle

Adds collection of tabs to trustyle

+package-lock=false

why would we not have a package.lock, is this a pattern on this repo?

NathanHynes

comment created time in a month

push eventjonathan-fielding/express-debug-chrome-extension

snyk-bot

commit sha e330dcbc4935b4fc03c4a2e0074073c0d55ec047

fix: package.json & package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-570062

view details

push time in a month

push eventuswitch/trustyle

Callum Macrae

commit sha 3b673e5f2b3dd74c34f364d87189ad0f22446c66

Fix tablet breakpoint in IE11

view details

Callum Macrae

commit sha 4130ea984e8551ec414435a5fc8ad2b46d6d0298

Publish - @uswitch/trustyle.product-table@1.4.2

view details

Jonathan Fielding

commit sha b20ba3dcf9181484d46d97fc5ee27c7010bab265

Merge pull request #486 from uswitch/tablet-ie11 Fix product table tablet breakpoint in IE11

view details

push time in a month

delete branch uswitch/trustyle

delete branch : tablet-ie11

delete time in a month

PR merged uswitch/trustyle

Fix product table tablet breakpoint in IE11

Description

Was broken here when tablet product table tablet breakpoint was shown mobile layout instead of desktop, but IE11 breakpoint wasn't adjusted: https://github.com/uswitch/trustyle/pull/475/files#diff-4d553efec1d2b870ecca128c23369239

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+2 -2

0 comment

2 changed files

callumacrae

pr closed time in a month

push eventuswitch/trustyle

Daniel Whyte

commit sha 15f289d9e8cac2a4cc9d6de7b46a78691c07430e

make product table images work on ie11

view details

Daniel Whyte

commit sha 7c3d8ca63c66b8394727d4c4b5f783c9e0b216f4

Publish - @uswitch/trustyle.product-table@1.3.5

view details

Jonathan Fielding

commit sha 2ef81f997bc071ecd55fc3224c349c8fcb6cf8e8

Merge pull request #476 from uswitch/ie-table-images make product table images work on ie11

view details

push time in a month

delete branch uswitch/trustyle

delete branch : ie-table-images

delete time in a month

PR merged uswitch/trustyle

make product table images work on ie11

Description

Replaces object-fit which doesn't have support on IE11

Checklist

Pull request contains:

  • [ ] A new component
  • [x] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated

Before: Screen Shot 2020-05-21 at 16 25 16

After: Screen Shot 2020-05-21 at 16 21 29

+20 -9

0 comment

2 changed files

Danwhy

pr closed time in a month

delete branch uswitch/trustyle

delete branch : feat/callout-bold

delete time in a month

push eventuswitch/trustyle

Jonathan Fielding

commit sha c94b3fb6489f6e174cc96d01ff3837924a6baea9

feat: allow bold callout

view details

Jonathan Fielding

commit sha 6640a0212a3241007b1276f8c8ff76a07afe1a88

Publish - @uswitch/trustyle.call-out@1.1.0

view details

Jonathan Fielding

commit sha b8963effa3c257f4614e6d7c059eaa65b5f7efef

Merge pull request #472 from uswitch/feat/callout-bold feat: allow bold callout

view details

push time in a month

PR merged uswitch/trustyle

feat: allow bold callout

Description

<!-- Explain the purpose of this Pull Request. -->

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+8 -3

2 comments

3 changed files

jonathan-fielding

pr closed time in a month

pull request commentuswitch/trustyle

feat: allow bold callout

Would it not be better to just allow rich text?

me and @barneyfoxuk discussed this, yes it would but we didn't want the risk of migrating the copy at this time as this is used everywhere, also would require a bigger code change to the component

jonathan-fielding

comment created time in a month

created taguswitch/trustyle

tag@uswitch/trustyle.call-out@1.1.0

React components with style

created time in a month

push eventuswitch/trustyle

Jonathan Fielding

commit sha 6640a0212a3241007b1276f8c8ff76a07afe1a88

Publish - @uswitch/trustyle.call-out@1.1.0

view details

push time in a month

PR opened uswitch/trustyle

feat: allow bold callout

Description

<!-- Explain the purpose of this Pull Request. -->

Checklist

Pull request contains:

  • [ ] A new component
  • [ ] Component maintenance: improvement / bug fix / etc
  • [ ] Component library change: storybook / webpack / etc

Definition of done:

  • [ ] Includes theme changes for both Uswitch and money
  • [ ] Work has been tested in multiple browsers
  • [ ] PR description includes description of change
  • [ ] PR description includes screenshot of change
  • [ ] If new component, designer has approved screenshot
  • [ ] If the change will affect other teams, that team knows about this change
  • [ ] If introducing a new component behaviour, added a story to cover that case.
  • [ ] If component change, version updated
+7 -2

0 comment

2 changed files

pr created time in a month

create barnchuswitch/trustyle

branch : feat/callout-bold

created branch time in a month

push eventuswitch/trustyle

Jonathan Fielding

commit sha 386e0ce6b94c54cbcff30d033cf69d226abb9cc3

fix: issues with money styling of tables

view details

Jonathan Fielding

commit sha d690c8ef0c2495374c5dc0a78878aaecc0f3be22

Publish - @uswitch/trustyle.money-theme@0.11.12

view details

Jonathan Fielding

commit sha fcbf3e1c9b4319f2de2055673189a9ead0f63af7

Merge pull request #471 from uswitch/fix/table-bugs-money fix: issues with money styling of tables

view details

push time in a month

delete branch uswitch/trustyle

delete branch : fix/table-bugs-money

delete time in a month

more