profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jojojames/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

emacs-evil/evil-collection 732

A set of keybindings for evil-mode

jojojames/dired-sidebar 337

Sidebar for Emacs leveraging Dired

jojojames/.emacs.d 6

Emacs Configuration

jojojames/.archived_dotfiles 0

Housing some dotfiles.

jojojames/1password2pass 0

1password2pass is a tool to import passwords from 1password keychain to pass (passwordstore.org)

startedcariboulabs/cariboulite

started time in a day

push eventemacs-evil/evil-collection

Vonfry

commit sha 2849c80c79e730454410bf259981e4d31eeef9b2

Add telega keybindings for evil

view details

push time in a day

PR merged emacs-evil/evil-collection

Add telega keybindings for evil

Here is a problem about keybinds on buttons. Currently, I remove the original keybinds on these button and bind new ones which may be a reasonable solution.

+204 -0

3 comments

2 changed files

Vonfry

pr closed time in a day

pull request commentemacs-evil/evil-collection

Add telega keybindings for evil

Thanks

Vonfry

comment created time in a day

pull request commentemacs-evil/evil-collection

Add telega keybindings for evil

Thanks

Vonfry

comment created time in a day

startedjojojames/vscode-icon-emacs

started time in a day

startedjojojames/dired-sidebar

started time in a day

Pull request review commentemacs-evil/evil-collection

Add telega keybindings for evil

+;;; evil-collection-telega.el --- Evil bindings for calc -*- lexical-binding: t -*-++;; Copyright (C) 2018 Pierre Neidhardt++;; Author: Ruoyu Feng <mail@vonfry.name>+;; Maintainer: James Nguyen <james@jojojames.com>, Pierre Neidhardt <mail@ambrevar.xyz>+;; URL: https://github.com/emacs-evil/evil-collection+;; Version: 0.0.6+;; Package-Requires: ((emacs "25.1"))+;; Keywords: evil, emacs, tools, telegram, telega++;; This file is free software; you can redistribute it and/or modify+;; it under the terms of the GNU General Public License as published+;; by the Free Software Foundation; either version 3, or (at your+;; option) any later version.+;;+;; This file is distributed in the hope that it will be useful,+;; but WITHOUT ANY WARRANTY; without even the implied warranty of+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the+;; GNU General Public License for more details.+;;+;; For a full copy of the GNU General Public License+;; see <http://www.gnu.org/licenses/>.++;;; Commentary:+;; Evil bindings for calc.++;;; Code:+(require 'telega nil t)+(require 'evil-collection)++(defconst evil-collection-telega-maps '(telega-root-mode-map+                                        telega-chat-mode-map+                                        telega-image-mode-map+                                        telega-webpage-mode-map+                                        telega-user-button-map+                                        telega-msg-button-map+                                        telega-chat-button-map+                                        telega-sticker-button-map))++(dolist (map evil-collection-telega-maps)+  (eval `(defvar ,map)))

can it be omitted?

Vonfry

comment created time in 2 days

Pull request review commentemacs-evil/evil-collection

Add telega keybindings for evil

+;;; evil-collection-telega.el --- Evil bindings for calc -*- lexical-binding: t -*-++;; Copyright (C) 2018 Pierre Neidhardt

Your name

Vonfry

comment created time in 2 days

Pull request review commentemacs-evil/evil-collection

Add telega keybindings for evil

+;;; evil-collection-telega.el --- Evil bindings for calc -*- lexical-binding: t -*-++;; Copyright (C) 2018 Pierre Neidhardt++;; Author: Ruoyu Feng <mail@vonfry.name>+;; Maintainer: James Nguyen <james@jojojames.com>, Pierre Neidhardt <mail@ambrevar.xyz>+;; URL: https://github.com/emacs-evil/evil-collection+;; Version: 0.0.6+;; Package-Requires: ((emacs "25.1"))+;; Keywords: evil, emacs, tools, telegram, telega++;; This file is free software; you can redistribute it and/or modify+;; it under the terms of the GNU General Public License as published+;; by the Free Software Foundation; either version 3, or (at your+;; option) any later version.+;;+;; This file is distributed in the hope that it will be useful,+;; but WITHOUT ANY WARRANTY; without even the implied warranty of+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the+;; GNU General Public License for more details.+;;+;; For a full copy of the GNU General Public License+;; see <http://www.gnu.org/licenses/>.++;;; Commentary:+;; Evil bindings for calc.

calc -> telega

Vonfry

comment created time in 2 days

Pull request review commentemacs-evil/evil-collection

Add telega keybindings for evil

+;;; evil-collection-telega.el --- Evil bindings for calc -*- lexical-binding: t -*-

calc -> telega

Vonfry

comment created time in 2 days

pull request commentemacs-evil/evil-collection

Add telega keybindings for evil

Great work

Vonfry

comment created time in 2 days

startedBurntSushi/ripgrep

started time in 3 days

startedSvetlitski/fcp

started time in 3 days

startedSigNoz/signoz

started time in 3 days

PR opened emacs-evil/evil-collection

Add telega keybindings for evil

Here is a problem about keybinds on buttons. Currently, I remove the original keybinds on these button and bind new ones which may be a reasonable solution.

+197 -0

0 comment

2 changed files

pr created time in 3 days

pull request commentemacs-evil/evil-collection

Feature request: add an option like evil-disable-insert-state-bindings

There's something here: https://github.com/emacs-evil/evil/blob/d3cc85bf828f04256de4a36ddb7624064b0252c8/evil-maps.el#L400 that I wonder if we could leverage. I didn't look too closely at that function though.s at all.

About evil-update-insert-state-bindings: I think we can't utilize it as-is, since it was specifically designed for evil-insert-state-map only, but evil-collection revolves around various modes.

Or did you mean something like this (just a prototype, there should be definitely a better version)?

(defun evil-collection-remove-insert-state-bindings (map-sym)
  "Remove all insert-state bindings from MAP-SYM."
  (setcdr   (evil-lookup-key (eval map-sym) [insert-state])   nil))

Then we create a custom variable like evil-collection-disable-insert-state-bindings and ran this on all evil-collection-mode-list when it is turned off, and re-run evil-collection-init when turned on?

I think this may open up the question of whether or not we want a filter list similar to the black/white list we have now, but specifically for states to enable/disable. E.g. A user can set a a filter to not have insert state binds at all.

IMO this is completely feasible. But from my perspective, casually we only care about insert and normal: sometimes we want bindings in normal state but not in insert state (like evil-disable-insert-state-bindings's author has predicted), and vice versa; on the other hand, normal but not visual/motion seems a bit rare.

daanturo

comment created time in 4 days

PR opened emacs-evil/evil-collection

Feature request: add an option like evil-disable-insert-state-bindings

Can evil-collection exclude insert state bindings when evil-disable-insert-state-bindings is non-nil?

It's confusing since I have already set that variable but in some modes' insert state, evil bindings are still around.

Perhaps we can add an additional check in evil-collection-define-key?

(defun evil-collection-define-key (state map-sym &rest bindings)
  ;; ...
  (when-let ((state
              (cond
               ((not evil-disable-insert-state-bindings) state) ; Unaffected, just move on
               ((eq 'insert state) nil)
               ((and (listp state)) (remove 'insert state)))))
    (let*
        ;; ...
        )))

Or to be less disruptive, let's define a variable named evil-collection-disable-insert-state-bindings?

Edit: clarified suggestion.

+16 -1

6 comments

1 changed file

pr created time in 4 days

startedjojojames/dired-sidebar

started time in 5 days

startedjojojames/dired-sidebar

started time in 6 days

startedjojojames/dired-sidebar

started time in 7 days

startedjojojames/dired-sidebar

started time in 9 days

startedjojojames/dired-sidebar

started time in 9 days

push eventemacs-evil/evil-collection

condy

commit sha eaded9d762fd49f962eeb6b8e15d6a33f79f4f26

devdocs: add devdocs-goto-target binding

view details

push time in 9 days

startedcodyogden/killedbygoogle

started time in 9 days

push eventemacs-evil/evil-collection

condy

commit sha 86b02f84a8df0ddd6216cb85d49bedd6ee2ab747

[devdocs]: initial support

view details

push time in 11 days

startedjojojames/smart-jump

started time in 12 days

issue commentemacs-evil/evil-collection

Cannot insert the selected item in completion menu in Company mode

I'm personally against having it be the default, since TNG would no longer behave like Vim

Fair enough. Let's put a pin in it for now. Though if someone wanted to submit a PR adding this as an optional feature, welcome!

I plan to create a Vim/YCM setup with snippets and templates and LSP, study their behavior and report here how it works

Looking forward to it. :+1:

(No pressure)

linwaytin

comment created time in 13 days

issue closedemacs-evil/evil-collection

use xref functionality in go-mode

Hi, thanks for this extensive collection!

I'd like to use xref- functionality rather than godef bindings as provided by default for go-mode. What's the recommended way of doing this?

Thank you for your time!

closed time in 13 days

fgeller