profile
viewpoint

johnjesse/carbon-tutorial 0

An app for the Carbon Design System tutorial

johnjesse/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

johnjesse/downshift 0

🏎 Primitive to build simple, flexible, WAI-ARIA compliant enhanced input React components

johnjesse/glamorous 0

💄 Maintainable CSS with React

johnjesse/history 0

Manage session history with JavaScript

johnjesse/intern 0

A next-generation code testing stack for JavaScript.

johnjesse/mobx-react 0

React bindings for MobX

johnjesse/rc-dock 0

Dock Layout for React Component

johnjesse/react-day-picker 0

Flexible date picker for React

johnjesse/react-docgen-typescript 0

A simple parser for react properties defined in typescript instead of propTypes.

issue openedcarbon-design-system/carbon

Insufficient Line heights in Carbons Typography

Insufficient Line heights in Carbons Typography

Detailed description

The line-heights defined in the carbon typography page here - https://www.carbondesignsystem.com/guidelines/typography/overview struggle with text that includes large descenders and ascenders. Typically text with large ascenders or descenders are accented letters - (the case is worse when the letters are capitals) - or specical characters - for instance emoji

This can cause issues where

  • Text is overflowing the container boundary
  • lines of text overlap

Steps to reproduce the issue

See code sandbox here - https://codesandbox.io/s/carbon-typography-issues-hd924?file=/src/index.js - this is a contrived example just using letters - but it illustrates that most Carbon type styles have the issue - the only ones that don't appear to be

  • body-long-02
  • expressive-heading-02

This feels like a big issue -> surely all the line-heights should be coping with the text including long ascenders and descenders

created time in 2 months

push eventjohnjesse/ts-webpack-react-starter

dependabot[bot]

commit sha 17c1a969bd55c4e61ccd81178d2cfce1b3a05ca0

Bump websocket-extensions from 0.1.3 to 0.1.4 Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

johnjessewood

commit sha 20be2922313ccba208369b3b60ac2402e4cf0ec4

Merge pull request #1 from johnjesse/dependabot/npm_and_yarn/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4

view details

dependabot[bot]

commit sha 9549413960a0f7ea837e84b2a31c726d67639121

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha d574ddc350cba58a4b0eff7d2d28a4c2094346ce

Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

johnjessewood

commit sha f61034c0c48f4d19b0147b546d855306f68cb780

Merge pull request #3 from johnjesse/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

johnjessewood

commit sha 11c02e769892088a284d6301194e4bae7872a6a8

Merge pull request #4 from johnjesse/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3

view details

John Wood

commit sha ae5f0995c45b675316dc13886ef3cce5b87fcae1

Merge branch 'main' into gsap-fem

view details

push time in 3 months

push eventjohnjesse/ts-webpack-react-starter

dependabot[bot]

commit sha 9549413960a0f7ea837e84b2a31c726d67639121

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha d574ddc350cba58a4b0eff7d2d28a4c2094346ce

Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

johnjessewood

commit sha f61034c0c48f4d19b0147b546d855306f68cb780

Merge pull request #3 from johnjesse/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

johnjessewood

commit sha 11c02e769892088a284d6301194e4bae7872a6a8

Merge pull request #4 from johnjesse/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3

view details

John Wood

commit sha 028e8d65cec45e66fd3d48f1f440e3fb464860b7

There are lots of changes here but I'm basically just getting the blog up and going

view details

John Wood

commit sha 714cadff2f8879e0fbe1d8fb62b364c6b5d632e1

Fix filename issues and unused imports

view details

John Wood

commit sha e72d4e04d4f1a2f9f06a3efa3bb435345477bf1a

Attempt to fix mobile viewport scaling issues

view details

John Wood

commit sha 379971a3c3fd9f95eac6a3cdd5ffa06e1acb3e93

Start to add responsive links menu

view details

John Wood

commit sha 3375d3b177ee12d1f3e398dc93d4ccd68a31c283

Add some loaders

view details

John Wood

commit sha b0e1d663084aa035a557150b8c9b1446aec658d5

Creater app header image

view details

John Wood

commit sha 5d34be30258be66d801ba7b9516ced4847f365fa

Update themes

view details

John Wood

commit sha a31cef1b4054cab5f104f42ded2ff3f105339ba7

Try out react flipped toolkit

view details

John Wood

commit sha 8f1c0cb6399283010e8d67399c3a748d0a0ecf63

Put main content in header

view details

John Wood

commit sha 9b220c0b5e7f7e60d56a53a8b2731b91db1df1c5

Add title

view details

John Wood

commit sha 57e1d4fec9aade24ad329ef086e426946fd1364c

Remove bundle analyzer from prod config for deploy

view details

push time in 3 months

push eventjohnjesse/ts-webpack-react-starter

dependabot[bot]

commit sha d574ddc350cba58a4b0eff7d2d28a4c2094346ce

Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

johnjessewood

commit sha 11c02e769892088a284d6301194e4bae7872a6a8

Merge pull request #4 from johnjesse/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3

view details

push time in 3 months

PR merged johnjesse/ts-webpack-react-starter

Bump elliptic from 6.5.2 to 6.5.3 dependencies

Bumps elliptic from 6.5.2 to 6.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li>See full diff in <a href="https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventjohnjesse/ts-webpack-react-starter

dependabot[bot]

commit sha 9549413960a0f7ea837e84b2a31c726d67639121

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

johnjessewood

commit sha f61034c0c48f4d19b0147b546d855306f68cb780

Merge pull request #3 from johnjesse/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 3 months

PR merged johnjesse/ts-webpack-react-starter

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

issue commentcarbon-design-system/carbon

[Tabs] remove dropdown variant for tabs

As this is the expected behaviour for responsive tabs - could/should the current behaviour where the tab is switched out to a dropdown be marked as deprecated. We use the carbon design system but have our own component implementation and almost went ahead and implemented the current responsive tab behaviour in our own component - before luckily stumbling across this

joshblack

comment created time in 3 months

more