profile
viewpoint
Johannes Lumpe johanneslumpe @mark43 New York http://lum.pe JS at @mark43

react-native-community/react-native-video 5017

A <Video /> component for react-native

itinance/react-native-fs 3597

Native filesystem access for react-native

acdlite/flummox 1699

Minimal, isomorphic Flux.

johanneslumpe/react-native-gesture-recognizers 343

Gesture recognizer decorators for react-native

johanneslumpe/react-native-keyboardevents 248

Keyboard events for react-native

johanneslumpe/react-native-selectablesectionlistview 243

A Listview with a sidebar to jump to sections directly

johanneslumpe/redux-history-transitions 167

history transitions based on arbitrary actions

johanneslumpe/react-native-browser-polyfill 31

A collection of polyfills for the react-native JavaScript environment.

arturmuller/developing-a-redux-edge 24

Supplementary material for Developing a Redux Edge book

johanneslumpe/react-native-linkingios-example 14

An example application, showcasing the use of custom url schemes in React Native.

issue commenttypeorm/typeorm

Tree closure-table doesn't update for my code

The docs clearly state that changing an entry's parent has not yet been implemented yet when using closure tables: https://github.com/typeorm/typeorm/blob/master/docs/tree-entities.md#note

mason-meng

comment created time in a month

issue commentPhotonsters/PhotonFileValidator

.PHZ support

ah good point. It would only work for non-AA files.

Hambot3D

comment created time in 2 months

issue commentPhotonsters/PhotonFileValidator

.PHZ support

@X3msnake we could just use catibo-convert to convert from .phz to .cbddlp, make changes and then convert it back ;)

Hambot3D

comment created time in 2 months

issue commentPhotonsters/PhotonFileValidator

.PHZ support

According to Phrozen their format uses "sliced PNG files in ZIP format". That's what I was told via email. So I'm wondering if the images in this format actually a zip file embedded in this phz format. If not, then it should use normal PNG files.

Hambot3D

comment created time in 3 months

startedPhotonsters/PhotonFileValidator

started time in 3 months

issue commentPhotonsters/PhotonFileValidator

.PHZ support

@X3msnake I have not really done anything like this before, but I'd be interested to dive into it. Do you have some pointers as to how to get started here?

Hambot3D

comment created time in 3 months

issue commentPhotonsters/PhotonFileValidator

.PHZ support

@X3msnake indeed! Sadly not good news. I reached out to Phrozen and was told that their own file format is just a zip file. When asking about Chitubox I was told that they had no info on that version of the phz format. So I reached out to Chitubox directly and was told that the format is closed source and contains “NDA sources”, which really seems unlikely for a file format that is essentially some bytes concatenated with a zip of images. Regardless, they didn’t offer up any format specs.

So I’m wondering if we should try to use your plugin to intercept the output and try to get chitu to slice to a zip instead? Then we could add support for that to the validator.

Hambot3D

comment created time in 3 months

pull request commentmark43/github-actions

VUL-300 README GitHub Issues–#engineering-help integration

You should be able to copy the working message sending code from other actions and then add unit tests to this action. Given that your output matches the required api contract for the slack message action, this should just work ;)

jonbeller

comment created time in 3 months

Pull request review commentmark43/github-actions

VUL-300 README GitHub Issues–#engineering-help integration

+import * as core from '@actions/core';+import { GitHub, context } from '@actions/github';++/**+ * Gets action input and parses it as json+ * @param param+ * @param options+ */+const getParsedInput = <T>(+  param: string,+  options: core.InputOptions = {+    required: true,+  },+): T => {+  const input = core.getInput(param, options);+  try {+    const parsedInput = JSON.parse(input);+    return parsedInput as T;+  } catch (e) {+    throw new Error(`Failed parsing input for ${param}: ${e.message}`);+  }+};++// init GitHub client+const repoToken = getParsedInput<string>('repo-token');

Can this be wrapped in a function as our other actions do so it can be properly unit tested?

jonbeller

comment created time in 3 months

more