Superseded by #145.

Uses a link to an archived version of their documentation (per https://github.com/angular/angular/issues/38393#issuecomment-671522621). Supersedes #140

Hi,

My colleague let me know that == is bad style. Word is, all the best linter rules prohibit it.

I cannot say he is wrong; but it's confusing when source documents such as this proposal use this frowned-upon syntactical hackery.

/s

Whether it is bad style is a matter of opinion.

Although this repo is not supposed to serve as documentation for people that don’t necessarily know the == null trick, while writing the explainer, I have been careful enough to complement occurrences of == null with a comment saying explicitly “null or undefined”, or, more colloquially, “nullish”.

a == null is a common exception to that rule. == is bad practice because of problems caused by the loose type conversion.

a == null has a well defined and useful meaning, it is equivalent to a === null || a === undefined so it's a commonly used exception to the rule when you want to check if something is nullish.

e.g. a == null ? b : a is equivalent to a ?? b.

Hi,

My colleague let me know that == is bad style. Word is, all the best linter rules prohibit it.

I cannot say he is wrong; but it's confusing when source documents such as this proposal use this frowned-upon syntactical hackery.

/s

Tried to install this package using pip3 on Linux mint and got the following error: ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output. <br />

Version: 5.01 The current

./src/index

points to nowhere in the installed npm package ...

@HenningM it works for me now

Reverts HenningM/express-ws#146

looks like this commit created a breaking change.

Error: /path/to/project/node_modules/express-ws/index.js:4 module.exports = _require('./src/index').default /path/to/project/node_modules/express-ws/index.js:1 Error: Cannot find module './src/index'

@HenningM thank you for that. seems to be working. will close the PR to revert changes.

I've published a 5.0.2 version without the babel -> esm changes for now. Let me know if this version works better for you, @webarchymeta.

I will have another look at your changes, @OmgImAlexis.

I'm using the latest code right now I'm all of our projects.

This PR should be closed. There's no way a 3 year old commit broke this. You have an issue with the way your project is setup.

@webarchymeta @HenningM @OmgImAlexis Ive created a PR to revert the changes. seems as though this commit broke loading the /lib folder.

Not sure why you opened that PR the revert doesn't need to happen. This is an issue on your end.

Can you show me the contents of node_modules/express-ws?

@webarchymeta @HenningM @OmgImAlexis Ive created a PR to revert the changes. seems as though this commit broke loading the /lib folder.

@HenningM seems like the update included more than just the update to the ws node_modules. the removal of babel and updating to ESM is causing issues.

Reverts HenningM/express-ws#146

looks like this commit created a breaking change.

Error: /path/to/project/node_modules/express-ws/index.js:4 module.exports = _require('./src/index').default /path/to/project/node_modules/express-ws/index.js:1 Error: Cannot find module './src/index'

Version: 5.01 The current

./src/index

points to nowhere ...

See below:

Remediation Upgrade ws to version 7.4.6 or later. For example:

"dependencies": {
  "ws": ">=7.4.6"
}

or…

"devDependencies": {
  "ws": ">=7.4.6"
}

Always verify the validity and compatibility of suggestions with your codebase.

Details: GHSA-6fc8-4gx4-v693 moderate severity Vulnerable versions: >= 5.0.0, < 7.4.6 Patched version: 7.4.6 Impact A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches The vulnerability was fixed in [email protected] (websockets/ws@00c425e).

Workarounds In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

express-ws version 5.0.1 has been published, upgrading the ws dependency to v7.4.6.

Thanks to @hartmutobendorf for the PR!

https://snyk.io/test/github/henningm/express-ws