profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jeffkreeftmeijer/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jeff Kreeftmeijer jeffkreeftmeijer AppSignal Amersfoort, The Netherlands https://jeffkreeftmeijer.com /kreɪft·maɪ·ər/ Writes (about) software. Elixir & Ruby at @appsignal.

jeffkreeftmeijer/appsignal.terminal 29

ANSI color profiles for Terminal.app and iTerm2, inspired by AppSignal's color scheme

jeffkreeftmeijer/bacon 3

a small RSpec clone

jeffkreeftmeijer/almost-sinatra 2

Sinatra refactored, only eight lines now.

jeffkreeftmeijer/boilermaker 2

🥃🍺 Elixir app packaged with Distillery and installed with Homebrew

jeffkreeftmeijer/.vim 1

My ~/.vim/ and ~/.vimrc

PullRequestReviewEvent

Pull request review commentappsignal/test-setups

Make NextJS setup compatible with error helpers

 console.log("Starting KOA app"); app.on("error", (error) => {   appsignal     .tracer()-    .currentSpan()-    .addError(error)-    .close()+    .setError(error)

You’ll need to use setError here, as you’re adding the error to the existing span. The span should then be closed, as we’ve run into an error and can’t continue adding more performance measurements to this span (like we do in the Plug instrumentation). I think you still need the call to close, there.

luismiramirez

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedappsignal/appsignal-javascript

Run the integration tests against the set of browsers we support

https://github.com/appsignal/integration-guide/blob/main/roadmap.md#frontend

created time in 3 days

issue openedappsignal/appsignal-javascript

Add integration tests that use a real browser

https://github.com/appsignal/integration-guide/blob/main/roadmap.md#frontend

created time in 3 days

issue openedappsignal/appsignal-javascript

Run the unit tests for the JS libary in a build matrix against all supported libraries

https://github.com/appsignal/integration-guide/blob/main/roadmap.md#frontend

created time in 3 days

issue openedappsignal/appsignal-elixir

Switch Elixir integration projects to a monorepo

Like the Ruby and Node.js integrations, move the Elixir integration to a monorepo, while still keeping the packages (appsignal-elixir, appsignal-plug and appsignal-phoenix) separate.

This is currently blocked by https://github.com/appsignal/mono/issues/11, as mono doesn’t yet allow for releasing packages in a preset order.

created time in 3 days

issue commentappsignal/appsignal-elixir

Failure to download agent release does not fail compilation

Ah, I misread your initial comment thinking it didn’t fail on compiling the agent but then compiled when running. Thanks for clarifying.

We’re open for improvements on this, as we understand this can be a bit confusing, but we’d prefer not to break compilation when something fails on our end.

validere-ben

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentappsignal/appsignal-elixir

Failure to download agent release does not fail compilation

Hey Ben,

We no longer raise an error when we fail to download the agent to allow apps to compile even if the agent can’t be installed for some reason. The Nif then doesn’t get loaded, but AppSignal should then automatically use the fallback functions. This should then allow the app to run as normal, but without AppSignal’s instrumentation. We should also print a warning to the console when building, so anyone running into this issue knows that the extension wasn’t installed properly.

From your report, there seem to be two issues;

  1. The Nif fails to load, causing an error that prevents your app from starting. That’s a problem we should look into to be able fulfill the promise outlined above.
  2. The warning is easily missed. We should print a clear warning that shows the user what happened to avoid confusion.

We’ll look into both of these, and we’ll report back. Thanks for letting us know about this!

validere-ben

comment created time in 4 days

push eventappsignal/appsignal-elixir

Andrea Leopardi

commit sha 53a047bbffc8beec2c94a87ec8e6233af0514ef5

Speed up arity check in Appsignal.Instrumentation (#680) Checking one of the two supported arities of a function in a guard is faster than getting the whole keyword list info from :erlang.fun_info/1. We only need to support arities of 0 and 1 anyways. Plus, it's a few less lines of code!

view details

push time in 4 days

PR merged appsignal/appsignal-elixir

Reviewers
Speed up function arity check in Appsignal.Instrumentation enhancement

I haven't actually benchmarked this :sweat_smile:, but I’m fairly sure that checking one of the two supported arities of a function in a guard is faster than getting the whole keyword list of info and so on. Plus, it's a few less lines of code!

While I got you here, I was reading through the code for Appsignal.Instrumentation. Would you folks appreciate some contributions to have guards on all functions and more precise function specs?

+2 -8

3 comments

1 changed file

whatyouhide

pr closed time in 4 days

pull request commentappsignal/appsignal-elixir

Speed up function arity check in Appsignal.Instrumentation

Hey Andrea,

Thanks for the patch! This’ll be included in the next release.

More precise function specs and guards on Appsignal.Instrumentation are definitely welcome. Feel free to open pull requests for whatever you come across. :)

whatyouhide

comment created time in 4 days

push eventjeffkreeftmeijer/opentelemetry-nodejs-example

Jeff Kreeftmeijer

commit sha bc23e91b7b48ca2a8158ff796e4825f26ea0b8f4

Add README

view details

push time in 7 days

create barnchjeffkreeftmeijer/opentelemetry-nodejs-example

branch : master

created branch time in 7 days

created repositoryjeffkreeftmeijer/opentelemetry-nodejs-example

created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventjeffkreeftmeijer/updates

Jeff Kreeftmeijer

commit sha 9fcfffc0557aaafac158015b184d633021f0a255

Add 2021-08-18-im-giving-a-best-mans.md

view details

push time in a month

push eventjeffkreeftmeijer/.emacs.d

Jeff Kreeftmeijer

commit sha 4ceb04c7dfbbea4581f971a45fa134616977d431

Add emacs-general-configuration.org

view details

push time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentappsignal/appsignal-elixir

Replace decorator slashes with underscores

The CI failures aren’t caused by this patch, and are present on main. There’s a fix in #666, please merge that one first.

jeffkreeftmeijer

comment created time in a month