profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jefferysmith/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

jefferysmith/backbone-grails-cellar 1

Grails version of the backbone-jax-cellar application

jefferysmith/springdoclet 1

A javadoc Doclet that generates documentation for Spring-based applications

jefferysmith/bruteforcedefender 0

Grails plugin enables blocking user account after few attampts with incorect credentials. Preventing brute-force attacks

jefferysmith/DIM 0

Destiny Item Manager

jefferysmith/grails-doc 0

Documentation Project For The Grails Web Application Framework

issue commentDestinyItemManager/DIM

ensure all text is being searched in triumps/milestones/artifact mods/etc

followup improvements needed: https://github.com/DestinyItemManager/DIM/issues/6869

nev-r

comment created time in 37 minutes

issue openedDestinyItemManager/DIM

better presentation node string search

Proposed change searching presentation nodes should work similarly to other searches, with implicit AND (maybe support OR)

How does this fit into your workflow? i can't search for triumphs that involve "lost sector" and "flawless" unless i know the exact right string, because triumph search is naive and single-string

created time in 37 minutes

created tagDestinyItemManager/DIM

tagv6.70.0

Destiny Item Manager

created time in 8 hours

push eventDestinyItemManager/DIM

DIM Release Bot

commit sha 22651fc98a54d0bc244ace511272f6db9c86ec89

6.70.0

view details

push time in 8 hours

push eventDestinyItemManager/DIM

DIM i18n Bot

commit sha 3dc93f6669671018b12c3e5af43d959b2121c86a

i18n

view details

Ben Hollis

commit sha f92156efe3907618e14f1f99987c1154a116ae0c

Upgrades

view details

Ben Hollis

commit sha 1cfcb1076fa938c489cca06ec04f360662fe35db

Work around Safari idb bug

view details

Ben Hollis

commit sha e065d9d68cf0ab04bc6996962fb80e33765db632

Merge pull request #6856 from DestinyItemManager/safari-idb

view details

delphiactual

commit sha 156eedde857e0c29482adbcbf785a53dd371e0e8

D2AI Build Update - 62b71efe

view details

DIM Release Bot

commit sha aa565f463f32355e6b53597d2a2cb233ddeb5e25

6.69.0

view details

nev

commit sha 6db57008b1188955d5982c0b640a27b3ad73d325

include perk text in perk search

view details

Ryan Rushton

commit sha bb67cbdb2ca5b7ddd76f41e65d6663aa1f7ba4b0

Merge pull request #6857 from DestinyItemManager/d2ai-build [D2AI] Build Update

view details

nev

commit sha 1140a84e21424812a59e16ade8ff0bf8e4ab4cf7

upgrade safari fixer

view details

nev-r

commit sha 88a7d1716b2a48714355de5e9fb453c366714c6e

Update CHANGELOG.md

view details

DIM Release Bot

commit sha 46b238dc196016817a23b4572d981e60dd22d0d9

6.69.1

view details

Rob Jones

commit sha 8117dfe46de6663bc74e22b0c48c77aeb3190240

require changelog

view details

Rob Jones

commit sha 7eb5a6a74020a792824c87d446c7a3770c623e23

update changelog

view details

Rob Jones

commit sha 31794bdeed57ffe4c1bb318ef9b2429d9408452a

reorder

view details

Rob Jones

commit sha 793c1de66e7e113addb932061e50e7e7cdd3bf1c

remove unnecessary changelog

view details

Rob Jones

commit sha c8d8634bcd094754c5a670cc1c0740dfc75f6364

Merge pull request #6861 from DestinyItemManager/require-changelog require changelog

view details

Ryan Rushton

commit sha ba644167ba20d28bf8e0a65a18be4863e6cafc93

Fixed issue with general mods in the optimiser.

view details

Ryan Rushton

commit sha 53c2809efb4e4d33e2c541e2ad04a9278e603ed8

A better fix.

view details

Ryan Rushton

commit sha d10eea15a371fed2e904bc5395a852814f5844ff

Updated changelog

view details

Ryan Rushton

commit sha b13ffe7b1bdfb91bbe07729b6803492c657143b1

Merge pull request #6862 from DestinyItemManager/ryanr-lo-fix-nothing-option Fixed issue with general mods in the optimiser.

view details

push time in 11 hours

Pull request review commentDestinyItemManager/DIM

Use generated raid plug category hashes.

 export const slotSpecificPlugCategoryHashes = [   armor2PlugCategoryHashesByName.classitem, ]; -// TODO generate this somehow so we dont need to maintain it-export const raidPlugCategoryHashes = [-  PlugCategoryHashes.EnhancementsSeasonOutlaw, // last wish-  PlugCategoryHashes.EnhancementsRaidGarden, // garden of salvation-  PlugCategoryHashes.EnhancementsRaidDescent, // deep stone crypt-  PlugCategoryHashes.EnhancementsRaidV520, // vault of glass-];+export const raidPlugCategoryHashes: number[] =+  Array.isArray(raidModPlugCategoryHashes) &&+  raidModPlugCategoryHashes.every((pch) => typeof pch === 'number')

Done

ryan-rushton

comment created time in 11 hours

push eventDestinyItemManager/DIM

Ryan Rushton

commit sha b719fdb2e23f999af4b894038a0198852e911bbe

Removed checks on raid mod plug generated type and removed re-export

view details

push time in 11 hours

push eventDestinyItemManager/DIM

Ryan Rushton

commit sha a37e457cc4cd5cd442b647fb36e1936e41a9d9e2

Fixed an issue where energy types could mismatch in lo.

view details

Ryan Rushton

commit sha e93b9516e0cb11036c8da99df148f79858cab4c9

Updated changelog

view details

Ryan Rushton

commit sha 39f71361e8f5efa35b28340bbfe15c724750c0c3

Merge pull request #6868 from DestinyItemManager/ryanr-fix-issue-with-mismatching-energy-type Fixed an issue where mod types could be mismatched

view details

push time in 11 hours

delete branch DestinyItemManager/DIM

delete branch : ryanr-fix-issue-with-mismatching-energy-type

delete time in 11 hours

PR merged DestinyItemManager/DIM

Reviewers
Fixed an issue where mod types could be mismatched

Found a case where mod energy types could be mismatched.

Screen Shot 2021-06-23 at 11 12 19 pm

+147 -13

0 comment

4 changed files

ryan-rushton

pr closed time in 11 hours

PR opened DestinyItemManager/DIM

Reviewers
Fixed an issue where mod types could be mismatched

Found a case where mod energy types could be mismatched.

Screen Shot 2021-06-23 at 11 12 19 pm

+147 -13

0 comment

4 changed files

pr created time in 11 hours

push eventDestinyItemManager/DIM

nev

commit sha 6db57008b1188955d5982c0b640a27b3ad73d325

include perk text in perk search

view details

nev-r

commit sha 74ff6dfb235d662391bbfe15c02131449260f920

Merge pull request #6859 from DestinyItemManager/perk-search include perk text in perk search

view details

push time in 15 hours

delete branch DestinyItemManager/DIM

delete branch : perk-search

delete time in 15 hours

PR merged DestinyItemManager/DIM

Reviewers
include perk text in perk search

so, perk search was not actually searching through perk text. just sockets. this manifests especially on mods' "description" text

+5 -2

0 comment

2 changed files

nev-r

pr closed time in 15 hours

Pull request review commentDestinyItemManager/DIM

Use generated raid plug category hashes.

 export const slotSpecificPlugCategoryHashes = [   armor2PlugCategoryHashesByName.classitem, ]; -// TODO generate this somehow so we dont need to maintain it-export const raidPlugCategoryHashes = [-  PlugCategoryHashes.EnhancementsSeasonOutlaw, // last wish-  PlugCategoryHashes.EnhancementsRaidGarden, // garden of salvation-  PlugCategoryHashes.EnhancementsRaidDescent, // deep stone crypt-  PlugCategoryHashes.EnhancementsRaidV520, // vault of glass-];+export const raidPlugCategoryHashes: number[] =+  Array.isArray(raidModPlugCategoryHashes) &&+  raidModPlugCategoryHashes.every((pch) => typeof pch === 'number')

Yeah I am probably being overly cautious in the event something changes in an update. Feels weird importing json as an object. I will update it accordingly.

ryan-rushton

comment created time in 15 hours

Pull request review commentDestinyItemManager/DIM

Use generated raid plug category hashes.

 export const slotSpecificPlugCategoryHashes = [   armor2PlugCategoryHashesByName.classitem, ]; -// TODO generate this somehow so we dont need to maintain it-export const raidPlugCategoryHashes = [-  PlugCategoryHashes.EnhancementsSeasonOutlaw, // last wish-  PlugCategoryHashes.EnhancementsRaidGarden, // garden of salvation-  PlugCategoryHashes.EnhancementsRaidDescent, // deep stone crypt-  PlugCategoryHashes.EnhancementsRaidV520, // vault of glass-];+export const raidPlugCategoryHashes: number[] =+  Array.isArray(raidModPlugCategoryHashes) &&+  raidModPlugCategoryHashes.every((pch) => typeof pch === 'number')

image image

yeah don't think this verification is needed, as TS is already aware of this structure's types

ryan-rushton

comment created time in 16 hours

Pull request review commentDestinyItemManager/DIM

Use generated raid plug category hashes.

 export const slotSpecificPlugCategoryHashes = [   armor2PlugCategoryHashesByName.classitem, ]; -// TODO generate this somehow so we dont need to maintain it-export const raidPlugCategoryHashes = [-  PlugCategoryHashes.EnhancementsSeasonOutlaw, // last wish-  PlugCategoryHashes.EnhancementsRaidGarden, // garden of salvation-  PlugCategoryHashes.EnhancementsRaidDescent, // deep stone crypt-  PlugCategoryHashes.EnhancementsRaidV520, // vault of glass-];+export const raidPlugCategoryHashes: number[] =+  Array.isArray(raidModPlugCategoryHashes) &&+  raidModPlugCategoryHashes.every((pch) => typeof pch === 'number')

When is it not an array of numbers?

ryan-rushton

comment created time in 18 hours

issue commentvercel/hyper

bash: hyper: command not found

Hi, @LabhanshAgrawal sorry to disturb you I want some guidance on how can I start on this project contributing I tried to run this project but it's not building locally and where does the community communicate of this repository, I have a fair bit of idea of the tech stack used.. when I build it locally here is the error can u help, please this is the error -

Error #1 -------------------------------------------------------------------------------- TypeError: fs.rm is not a function at createStageDirPath (/home/vinay/Desktop/Open_source_exploration/hyper/node_modules/app-builder-lib/src/targets/targetUtil.ts:32:12) at Object.createStageDir (/home/vinay/Desktop/Open_source_exploration/hyper/node_modules/app-builder-lib/src/targets/targetUtil.ts:27:29) at AppImageTarget.build (/home/vinay/Desktop/Open_source_exploration/hyper/node_modules/app-builder-lib/src/targets/AppImageTarget.ts:48:7) at async Promise.all (index 0) at AsyncTaskManager.awaitTasks (/home/vinay/Desktop/Open_source_exploration/hyper/node_modules/builder-util/src/asyncTaskManager.ts:65:25) at /home/vinay/Desktop/Open_source_exploration/hyper/node_modules/app-builder-lib/src/platformPackager.ts:150:7

You can ask any questions on https://github.com/vercel/hyper/discussions/categories/q-a You need to use Node version greater than or equal to 14.14 for this

fyrfli

comment created time in 18 hours

issue commentvercel/hyper

arm64 builds getting auto updated to x64

I also tested this behaviour this morning and can confirm. We will likely have to take the architecture into account in: https://github.com/vercel/hyper/blob/canary/app/updater.ts.

Before updating (canary.5)

Screen Shot 2021-06-23 at 9 44 01 am

After Updating to canary.6

Screen Shot 2021-06-23 at 9 45 27 am

LabhanshAgrawal

comment created time in 19 hours

issue commentvercel/hyper

Support for multiple shells

@www-wagner Already Referenced it, but Hyper Launch Menu. Here's the official readme docs.

https://hyper.is/store/hyper-launch-menu/source?README.md

How i can use launch menu?? say import and export :c

atrauzzi

comment created time in 19 hours

pull request commentDestinyItemManager/DIM

Default to similar loadout as comparison base in Loadout Optimizer

@robojumper, sorry about all the merge conflicts. I am fixing fires I started.

robojumper

comment created time in 19 hours

push eventDestinyItemManager/DIM

Ryan Rushton

commit sha 90aa464e272355f671bb97234b5de86d6b16a34e

Fixed an issue where we were swapping energy in lo incorrectly

view details

Ryan Rushton

commit sha 44513d702f35650eaed2eda35b6a052414eb7642

Updated changelog

view details

Ryan Rushton

commit sha 7792f6cc5e88a8d29b372518b6debee79de7fa32

Fixed comments and the changelog new line

view details

Ryan Rushton

commit sha 6392265416b603fb05828b90a50f097dc2ac550a

Merge pull request #6867 from DestinyItemManager/ryanr-fix-issue-with-energy-swaps Fixed an issue where we were swapping energy in lo incorrectly

view details

push time in 19 hours

delete branch DestinyItemManager/DIM

delete branch : ryanr-fix-issue-with-energy-swaps

delete time in 19 hours

PR merged DestinyItemManager/DIM

Reviewers
Fixed an issue where we were swapping energy in lo incorrectly

I am pretty confident this fixes it once and for all. The tests helped a lot as that part of the calculation was the hardest part to get my head around.

Fixes #6866

+215 -46

1 comment

3 changed files

ryan-rushton

pr closed time in 19 hours

issue closedDestinyItemManager/DIM

Mods assigned wrong when energy conversion isn't allowed

https://twitter.com/asacre45/status/1407289987108786179

closed time in 19 hours

bhollis

pull request commentDestinyItemManager/DIM

Fixed an issue where we were swapping energy in lo incorrectly

Merging so I can ask beta to test

ryan-rushton

comment created time in 19 hours

issue closedvercel/hyper

Can't open official website hyper.is

<!-- Hi there! Thank you for discovering and submitting an issue.

Before you submit this; let's make sure of a few things. Please make sure the following boxes are ticked if they are correct. If not, please try and fulfill these first. -->

<!-- Checked checkbox should look like this: [x] -->

  • [ ] I am on the latest Hyper.app version
  • [ ] I have searched the issues of this repo and believe that this is not a duplicate

<!-- Once those are done, if you're able to fill in the following list with your information, it'd be very helpful to whoever handles the issue. -->

  • OS version and name: <!-- Replace with version + name -->
  • Hyper.app version: <!-- Replace with version -->
  • Link of a Gist with the contents of your .hyper.js: <!-- Gist Link Here -->
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): <!-- Replace with info if applicable, or N/A -->
  • The issue is reproducible in vanilla Hyper.app: <!-- Replace with info if applicable, or Is Vanilla. (Vanilla means Hyper.app without any add-ons or extras. Straight out of the box.) -->

Issue

<!-- Now feel free to write your issue, but please be descriptive! Thanks again 🙌 ❤️ -->

closed time in 19 hours

smallnine9

issue commentvercel/hyper

Can't open official website hyper.is

https://downforeveryoneorjustme.com/hyper.is

thanks,this problem is just for me, i will find the reason

smallnine9

comment created time in 19 hours