profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jeffbrown/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jeff Scott Brown jeffbrown OCI St. Louis, Missouri USA

PR opened micronaut-projects/micronaut-core

Reviewers
extract websocket upgrade method type: improvement

This PR extracts a more idiomatic private method isWebSocketUpgradeand also reuses the constant WEB_SOCKET_HEADER_VALUE

+9 -8

0 comment

1 changed file

pr created time in 2 hours

create barnchmicronaut-projects/micronaut-core

branch : http-headers-insensitive

created branch time in 2 hours

push eventmicronaut-projects/micronaut-camel

micronaut-build

commit sha 48579544a46010b5fa4aa49b6fc766a2317fcc50

Update dependencies

view details

push time in 3 hours

push eventmicronaut-projects/micronaut-r2dbc

micronaut-build

commit sha d08fb420dcb0b500cedb2de3eda544456e25c418

Update dependencies

view details

push time in 3 hours

push eventmicronaut-projects/micronaut-micrometer

dependabot[bot]

commit sha 50cfff1d076cc71e81ac24f77652f0a0bf8ea8d6

build: bump metrics-core from 4.1.20 to 4.2.0 (#260) Bumps [metrics-core](https://github.com/dropwizard/metrics) from 4.1.20 to 4.2.0. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](https://github.com/dropwizard/metrics/compare/v4.1.20...v4.2.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 1bbabc051df9ef70d843d4a7f81ca0cf624e011f

build: bump actions/cache from 2.1.5 to 2.1.6 (#264) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.5 to 2.1.6. - [Release notes](https://github.com/actions/cache/releases) - [Commits](https://github.com/actions/cache/compare/v2.1.5...v2.1.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 6c1f570f5a14811c7a263cf4d235ab0de6d8dcf4

build: bump peter-evans/create-pull-request from 3.8.2 to 3.10.0 (#265) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3.8.2 to 3.10.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](https://github.com/peter-evans/create-pull-request/compare/v3.8.2...v3.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Jouper

commit sha 593a9f44f8ca834db3067f5f598ea96434f7bf1d

Resolves micronaut-projects/micronaut-micrometer#243 (#259)

view details

micronaut-build

commit sha 36d4a301334c6ce0590140ab56b0d7a79166ae97

[micrometer] Update common files for branch master (#256) * Update common files * Do not upgrade Gradle Co-authored-by: Iván López <lopezi@objectcomputing.com>

view details

dependabot[bot]

commit sha 873d0ffcc915b8136251af94844a5ef198c40f10

build: bump metrics-core from 4.2.0 to 4.2.1 (#268) Bumps [metrics-core](https://github.com/dropwizard/metrics) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](https://github.com/dropwizard/metrics/compare/v4.2.0...v4.2.1) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

micronaut-build

commit sha 85c5bd7fd0ec5ea2602d82a9b53c79a871e9ad0b

Update dependencies

view details

push time in 3 hours

push eventmicronaut-projects/micronaut-mqtt

micronaut-build

commit sha 1fc94dbd2bb5ab3c6bdc114f0a4b51bfa636d0ce

Update dependencies

view details

push time in 4 hours

push eventmicronaut-projects/micronaut-views

micronaut-build

commit sha d4745db62c4436a60d4d99eda9755b4e08061d02

Update dependencies

view details

push time in 4 hours

push eventmicronaut-projects/micronaut-kubernetes

Pavol Gressa

commit sha 2c9cf1c66336682b54228ffb06e76a86e39fce04

fix: fix test when defaultIfEmpty in service instance providers (#318)

view details

micronaut-build

commit sha f23cf7fb704a61e62498e360156dfdd8a04f2ca0

[skip ci] Release v2.3.4

view details

micronaut-build

commit sha 1389a9e4284358f363a3fcffd194c39c29b0c7f0

Back to 2.3.5-SNAPSHOT

view details

micronaut-build

commit sha 4740ad4d4c3cf1cdd718c0635cd8705526f90652

Update dependencies

view details

push time in 4 hours

Pull request review commentmicronaut-projects/micronaut-kafka

Add KafkaPartition and KafkaPartitionKey annotations

+/*+ * Copyright 2017-2020 original authors+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ * https://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */+package io.micronaut.configuration.kafka.annotation;++import io.micronaut.core.bind.annotation.Bindable;++import java.lang.annotation.*;++/**+ * Parameter level annotation to indicate which parameter is bound to the Kafka Partition.+ * It can be used in {@link java.lang.Integer} or {@code int}.+ *+ * <p>When used in producers, indicates which partition is to be used. If the provided value is {@code null}+ * then the configured/default partitioning strategy takes place.</p>+ *+ * <p>When used in consumers, it is populated with the partition that the record was received from.</p>+ *+ * <p>Note that while using {@link KafkaPartition} in the same method as {@link KafkaPartitionKey}+ * will not throw an exception, the outcome of doing so is left unspecified.</p>

I'm not sure if this is good behaviour. I'm happy to implement a different one with some advice/guidance

bugflux

comment created time in 11 hours

Pull request review commentmicronaut-projects/micronaut-kafka

Add KafkaPartition and KafkaPartitionKey annotations

 public final Object intercept(MethodInvocationContext<Object, Object> context) {                     if (o instanceof Long) {                         timestampArgument = (Long) o;                     }+                } else if (argument.isAnnotationPresent(KafkaPartition.class)) {+                    Object o = parameterValues[i];+                    if (o != null && Integer.class.isAssignableFrom(o.getClass())) {+                        partitionSupplier = __ -> (Integer) o;+                    }+                } else if (argument.isAnnotationPresent(KafkaPartitionKey.class)) {+                    String finalTopic = topic;+                    Object partitionKey = parameterValues[i];+                    if (partitionKey != null) {+                        byte[] partitionKeyBytes = Optional.ofNullable(serdeRegistry.pickSerializer(argument))+                                .orElseGet(ByteArraySerializer::new)+                                .serialize(finalTopic, parameterValues[i]);

I'm not sure how expensive it might be to pick a serializer from the registry on every single call.

If it's deemed expensive then we can/should keep it in a map, but I'm not entirely sure what it should be keyed by. I suppose for the current implementation it would make the most sense to key by Class, but in the end that's more or less what I'd expect the registry implementations to do.

bugflux

comment created time in 11 hours

pull request commentmicronaut-projects/micronaut-kafka

Add KafkaPartition and KafkaPartitionKey annotations

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

bugflux

comment created time in 11 hours

PR opened micronaut-projects/micronaut-kafka

Add KafkaPartition and KafkaPartitionKey annotations

Hi all,

Although I haven't faced this need in micronaut projects yet, I have found if potentially useful to control partitioning separately from record keys.

This is useful when Keys have specific functional requirement (deduplication, log compaction, etc), but where partition of a topic needs to be made on a separate field (often having a one to many relationship with record keys, although that's not a requirement).

This PR brings in the ability to do just that with two new additional annotations: @KafkaPartition and @KafkaPartitionKey.

+386 -11

0 comment

6 changed files

pr created time in 11 hours

delete branch grails/grails-gradle-plugin

delete branch : fixGrailsCentralPublishPlugin

delete time in 18 hours

push eventgrails/grails-gradle-plugin

Puneet Behl

commit sha 53aa7fe0b915cf9becbb170b778e7d905593fff1

Move project publishing configuration before configuring SigninExtension

view details

Puneet Behl

commit sha 26dd60faf1ec7aaf703224c483bbdfc4f0a5ae88

Merge pull request #9 from grails/fixGrailsCentralPublishPlugin Move project publishing configuration before configuring SigninExtension

view details

push time in 18 hours

create barnchgrails/grails-gradle-plugin

branch : fixGrailsCentralPublishPlugin

created branch time in 18 hours

issue commentmicronaut-projects/micronaut-core

Allow custom HTTP response status codes

@graemerocher I'll target branch 3.0.x instead

Regarding compatibility, should custom response status codes also be possible on other Micronaut runtimes beyond Netty?

So far I've tried on tomcat and jetty using the new HttpResponse.status(int); on the former the custom reason is not being set, and on the latter the reason phrase is being set the same as the status code, which is not consistent with the generic reason I'm considering.

Similarly, should custom status codes be possible on the SimpleHttpResponseFactory? I'm not sure when is this implementation used.

About testing, I have a question about what should be the expected behavior of a currently failing test.

I have ran the tests (with my implementation now on the 3.0.x branch) and I see the following failure on InvalidStatusSpec.groovy:

Expected exception of type 'java.lang.IllegalArgumentException', but got 'io.micronaut.http.client.exceptions.HttpClientResponseException'

IllegalArgumentException is not thrown anymore because of the change in HttpStatus, but should HttpClientResponseException be thrown on custom status codes? From its JavaDoc I'm thinking it should only when the code is equal to or greater than 400.

Lastly, do I need to implement tests? For instance, to check that the generic reason phrase is being set properly

debuglevel

comment created time in 18 hours

push eventmicronaut-projects/micronaut-jms

micronaut-build

commit sha 86f92d25319309a548836a30c238d5686e016891

Update common files (#120)

view details

push time in 20 hours

delete branch micronaut-projects/micronaut-jms

delete branch : sync-files-master

delete time in 20 hours

pull request commentmicronaut-projects/micronaut-core

Include Maven configuration for javaParameters option

Yeah that is fine. Comment wasn’t directed at the change you made more a general comment that we (the Micronaut team) should fix the root cause

lelerabino

comment created time in 21 hours

push eventgrails/grails-guides

sdelamo

commit sha 6662064f6a79fc1061948ddd5395f0445ea5e5a1

Updating grails/grails-guides gh-pages branch for Github Actions run:952279884

view details

push time in 21 hours

push eventgrails/grails-static-website

sdelamo

commit sha 7f57c612d690b1c938f4e3a688ad7c298a96cf71

Updating grails/grails-static-website gh-pages branch for Github Actions run:952279884

view details

push time in 21 hours

push eventgrails/grails-guides

sdelamo

commit sha b51e63aa12d7069f1da363503318457989dbb2fd

Updating grails/grails-guides gh-pages branch for Github Actions run:952241368

view details

push time in a day

push eventgrails/grails-static-website

sdelamo

commit sha 815a65d6a6b9046f6aa2ca1c48316c1fdea1ac17

Updating grails/grails-static-website gh-pages branch for Github Actions run:952241368

view details

push time in a day

pull request commentmicronaut-projects/micronaut-core

Include Maven configuration for javaParameters option

I am quite new to this community and the overall jvm landscape, so it's totally possible that I miss some basic assumption.

Regarding pluginManagement: the decision whether to put this plugin configuration (in pluginManagement or in the actual plugin configuration) is totally out of scope here imo. The purpose of this documentation is not "teaching Maven" :)

By the way, again, I am quite green in this project, the main purpose of this PR is to push on the bad experience for people moving from gradle plugin to maven plugin working on a micronaut-data project (I'm mentioning here because it rely on keeping parameter names during compilation). Gradle plugin is automatically setting the javaParameters flag, and in any case in this documentation there is a special section about this setting for Gradle.

I just thought it should somehow be documented also for Maven.

lelerabino

comment created time in a day

push eventgrails/grails-guides

sdelamo

commit sha e893698a6dd27509a67fe98b828ff6bb6403c2ac

Updating grails/grails-guides gh-pages branch for Github Actions run:952231558

view details

push time in a day