I think it is a very good ideia. I agree that linking them to String by default seems like the most reasonable idea, and it still makes it very easy to customize into any other color if someone wants to.

The bug fix is also great :clap:

It will be ArithmeticError.

> Kebab-Case
** (ArithmeticError) bad argument in arithmetic expression: Kebab - Case
    :erlang.-(Kebab, Case)

It may be possible to declare by putting an atom directly, but it can be ignored because aliases are not available.

> defmodule :"Aaa.Bbb.Kebab-Case" do
> end
 <<70, 79, 82, 49, 0, 0, 3, 244, 66, 69, 65, 77, 65, 116, 85, 56, 0, 0, 0, 137,
   0, 0, 0, 13, 18, 65, 97, 97, 46, 66, 98, 98, 46, 75, 101, 98, 97, 98, 45, 67,
   97, 115, 101, 8, 95, 95, 105, ...>>, nil}

> alias :"Aaa.Bbb.Kebab-Case"
:"Aaa.Bbb.Kebab-Case" # expect :"Kebab-Case"
> alias Aaa.Bbb.:"Kebab-Case"
** (SyntaxError) iex:12:15: syntax error before: 'Kebab-Case'

this codes from https://github.com/tpope/vim-abolish/blob/master/plugin/abolish.vim#L120-L127

    let word = substitute(word,'\(\u\+\)\(\u\l\)','\1_\2','g')

line was duplicated.

    let word = substitute(word,'-','_','g')

elixir modules dose not allows kebab-case module name so we do not need it.

No syntax highlight, indent etc. for .sface files; set filetype? returns eelixir. Moreover, plugin works correctly for .eex and .leex files.

nvim 0.4.4, latest commit of vim-elixir.

edit: html inside sigil_H does get processed properly

Don't mind me, I can't read due to mental fatigue

No syntax highlight, indent etc. for .sface files; set filetype? returns eelixir. Moreover, plugin works correctly for .eex and .leex files.

nvim 0.4.4, latest commit of vim-elixir.

Previous implementation was buggy in several ways:

• It required :username, :password, :hostname, and :database fields while only :database is required by Ecto
• It ignored c:init/2 in the repo definition
• It ignored additional options passed to the repository
• Did not allowed for :socket_dir configuration

This fixes all these problems at once.

I'm sorry, I'm not sure what is the rule we are talking about here, but I tried to type these snippets in my vim:

defmodule Hi do
  |

defmodule Hi do
  def hello do
    "Hello"
    |

defmodule Hi do
  def hello do
    "Hello"
  end
  |

The | symbols are the position of the cursor after I pressed enter in each of those situations. It seems normal so far?

One maybe questionable decision is using Identifier here, since it is the same group of things such as self, @doc and module attributes in general: https://github.com/elixir-editors/vim-elixir/blob/a7cf8c9b1f36cea03b6889ef6e81530f8e188f53/syntax/elixir.vim#L233 https://github.com/elixir-editors/vim-elixir/blob/a7cf8c9b1f36cea03b6889ef6e81530f8e188f53/syntax/elixir.vim#L238

If we change it to String would this solve your concern? Strings and char lists would have the same color by default, but at least it would be easy for each person to customize their own.

I believe that char lists and strings could have a different syntax group, since they are very different data types. Even if both had the same color as your regular color scheme's String group, just giving different names would make it easier for someone willing to customize its own colors. Pull request #544 is a possible implementation that I came up with for this issue.

Bumps rexml from 3.2.4 to 3.2.5. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.2.5 - 2021-04-05 {#version-3-2-5}</h2> <h3>Improvements</h3> <ul> <li> <p>Add more validations to XPath parser.</p> </li> <li> <p><code>require "rexml/document"</code> by default. [GitHub#36][Patch by Koichi ITO]</p> </li> <li> <p>Don't add <code>#dcloe</code> method to core classes globally. [GitHub#37][Patch by Akira Matsuda]</p> </li> <li> <p>Add more documentations. [Patch by Burdette Lamar]</p> </li> <li> <p>Added <code>REXML::Elements#parent</code>. [GitHub#52][Patch by Burdette Lamar]</p> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a bug that <code>REXML::DocType#clone</code> doesn't copy external ID information.</p> </li> <li> <p>Fixed round-trip vulnerability bugs. See also: <a href="https://www.ruby-lang.org/en/news/2021/04/05/xml-round-trip-vulnerability-in-rexml-cve-2021-28965/">https://www.ruby-lang.org/en/news/2021/04/05/xml-round-trip-vulnerability-in-rexml-cve-2021-28965/</a> [HackerOne#1104077][CVE-2021-28965][Reported by Juho Nurminen]</p> </li> </ul> <h3>Thanks</h3> <ul> <li> <p>Koichi ITO</p> </li> <li> <p>Akira Matsuda</p> </li> <li> <p>Burdette Lamar</p> </li> <li> <p>Juho Nurminen</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/a622645e980ea5b91ad7b4d6fec32d113f15df88"><code>a622645</code></a> Add 3.2.5 entry</li> <li><a href="https://github.com/ruby/rexml/commit/3c137eb119550874b2b3e27d12b733ca67033377"><code>3c137eb</code></a> Fix a parser bug that some data may be ignored before DOCTYPE</li> <li><a href="https://github.com/ruby/rexml/commit/9b311e59ae05749e082eb6bbefa1cb620d1a786e"><code>9b311e5</code></a> Fix a bug that invalid document declaration may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/f9d88e4948b4a43294c25dc0edb16815bd9d8618"><code>f9d88e4</code></a> Fix a bug that invalid document declaration may be generated</li> <li><a href="https://github.com/ruby/rexml/commit/f7bab8937513b1403cea5aff874cbf32fd5e8551"><code>f7bab89</code></a> Fix a bug that invalid element end may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/6a250d2cd1194c2be72becbdd9c3e770aa16e752"><code>6a250d2</code></a> Fix a bug that invalid element start may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/2fe62e29094d95921d7e19abbd2e26b23d78dc5b"><code>2fe62e2</code></a> Fix a bug that invalid notation declaration may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/a659c63e37414506dfb0d4655e031bb7a2e73fc8"><code>a659c63</code></a> Fix a bug that invalid notation declaration may be generated</li> <li><a href="https://github.com/ruby/rexml/commit/790dd113ce693ce831cbbc53f2f990a317643f75"><code>790dd11</code></a> Use ruby/setup-ruby (<a href="https://github-redirect.dependabot.com/ruby/rexml/issues/66">#66</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/eda1b2007dd8751f381bf741f16c9e33c5d3e52a"><code>eda1b20</code></a> Clean up and enhance high-level RDoc (<a href="https://github-redirect.dependabot.com/ruby/rexml/issues/65">#65</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.2.4...v3.2.5">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

I believe that strings and charlists deserve different highlighting group, since those are very different data types. Even if it is defaulted to regular vim string, it would make a little easier for us to customize our own colors.

The motivation behind this is that I ran into a bug when I was pattern matching the wrong value because I didn't notice I wrote single quoted "strings" instead of double quoted strings by mistake, and different colors for them would have saved me some minutes and a couple of head scratches.

I made this change today and I'm not sure they are 100% safe and did not break anything. I do not excel in those syntax groups of vim, but it seems to be working. Comments and changes to my piece of code are more than welcome, and if this change is not what we want/need, then we can close this pull request.

Thanks for reading and providing us with this good content! (:

Thanks a lot for this plugin. I noticed that when using the :find command that sub-directories are not searched for elixir source files. If this was intentional, please disregard this PR. Otherwise, these changes will add support for finding files in a tree of sub-directories.

I enabled the undocumented option let g:elixir_use_markdown_for_docs = 1 and it looks ok for normal markdown but fails when there is a doctest

I think any string starting in this markdown as iex()> should be marked as elixir thats my example docs

  @moduledoc """
  ## Shorthand hexadecimal form
  #
  An abbreviated, three (hexadecimal)-digit form is used.
  Expanding this form to the six-digit form is as simple as doubling each digit:
  09C becomes 0099CC
  """
  @doc """
    iex> ExChroma.from_rgb({50, 50, 50, 1})
    "323232"
    iex> ExChroma.from_rgb({50, 50, 50, 0.5})
    "32323280"
  """

Edit - when I leave an empty line at the beginning then it treats it as a normal string which looks better

I enabled the undocumented option let g:elixir_use_markdown_for_docs = 1 and it looks ok for normal markdown but fails when there is a doctest I think any string starting in this markdown as iex()> should be marked as elixir thats my example docs

  @moduledoc """
  ## Shorthand hexadecimal form
  #
  An abbreviated, three (hexadecimal)-digit form is used.
  Expanding this form to the six-digit form is as simple as doubling each digit:
  09C becomes 0099CC
  """
  @doc """
    iex()> ExChroma.from_rgb({50, 50, 50, 1})
    "323232"
    iex()> ExChroma.from_rgb({50, 50, 50, 0.5})
    "32323280"
  """