jasongrout ( Jason Grout )

Thanks a lot @juhuebner, I made some comments mainly for me to understand better your changes.

juhuebner

comment created time in 2 hours

push eventjupyterlab/pull-requests

commit sha badcbf20ac044af5d295a092bf71fd58cde5a7a1

Conform to extension template

commit sha 7746f22c7f3bb6928b3f434444f14457410f3181

Fix unit tests

commit sha 962f05136cc2f2491416d66ec7705180c681ae28

Lint code

commit sha 247138056465a9b61571063250560f26fd5cb491

Fix jest

commit sha 7160050c00854ee556f3d1071d4db960fccb0501

Switch to SVG icons

commit sha 5ab43ce935cff63324fed772ea8c2ec4826d8769

Use only monaco editor

commit sha aaab29e34804d7b815b38e38f799f9f7525a3b28

Use ActionButton

commit sha 576e21a7686a33ee427fac4e3da4c069bd1a1ed6

Correct naming

commit sha 46b78784636e05bc46ca220451c71b57fb1522b4

Modernize backend

commit sha 6b290ead9cd4b84c5ac955c7ba7afde8bd61112a

Fix and update Jest

commit sha 6aadb53dd0d869f47cab60a4124438ee6b80a4bc

Fix GitLab client

commit sha 836ab31df287b9f81f02229cd166e4340efb1782

Render PR description as Markdown

commit sha 92f95cd938cdd4a1747c03a901e66c1c5b776dd4

Fix CI

commit sha adc74d8b42e953accfc64629cf362ab411e569fa

Use FilePath component

commit sha 05e731a0405a5b1f14cf5e07d1420c2e0fc7a56a

WIP Switch to codemirror

commit sha e806c6ef278ab5452552800bf136942b8e520c22

Fix gitlab assigned query

commit sha 5d4d43c35cd5d7f13f1f0e02a059e97092d1cf58

Bump version

commit sha e29ef497f16a75965132139f71db1bcb1ea1a2e2

Correct extension icon

commit sha 506625378a64cefe41ba99f0a5972d39c5fc871a

Add comment decoration

commit sha 7497fcc832b3098c587b072cd3316e1c2fa7e5ff

Change threads data structure

push time in 2 hours

PR merged jupyterlab/pull-requests

Extension reloaded

I'm working on rebooting this extension. Should this extension keep living in the jupyterlab organization? Could I be granted right to publish it on pypi (cc @blink1073 @jaipreet-s)?

TODO

[x] Add support for GitLab
- [x] Update GitHub for new discussion data structure
[x] More server configuration (base url, token, third service)
[x] Switch to codemirror for plain text (for Jupyter ecosystem coherence)
[x] Refresh the code
[ ] Extend testing
[x] Switch to GitHub workflow
[ ] UI improvements
- [ ] Use virtual tree view for PR/file list
- [x] Better file path display
- [x] Support markdown rendering
- [x] Support discussion at PR level

+16491 -3662

69 commit in fcollonval/pull-requests/tree/next jupyterlab/pull-requests/tree/master

11 comments

109 changed files

fcollonval

pr closed time in 2 hours

Pull request review commentjupyter/nbclient

 def _cleanup() -> None: # the fix for python3.7: https://github.com/python/cpython/pull/15706/files if sys.platform == 'win32':     if sys.version_info < (3, 7):-        subprocess._cleanup = _cleanup-        subprocess._active = None+        subprocess._cleanup = _cleanup  # type: ignore+        subprocess._active = None  # type:ignore

Is it needed?

juhuebner

comment created time in 2 hours

Pull request review commentjupyter/nbclient

 commands =     python -c 'import pathlib; print("documentation available under file://\{0\}".format(pathlib.Path(r"{toxworkdir}") / "docs_out" / "index.html"))'  # Distro-[testenv:dist]+[testenv:dist-{win, linux}] skip_install = true-# Have to use /bin/bash or the `*` will cause that argument to get quoted by the tox command line...+platform =+    win: win|msys+    linux: linux|darwin+allowlist_externals = +    win: powershell+    linux: bash  + commands =     python setup.py sdist --dist-dir={distdir} bdist_wheel --dist-dir={distdir}-    /bin/bash -c 'python -m pip install -U --force-reinstall {distdir}/nbclient*.whl'-    /bin/bash -c 'python -m pip install -U --force-reinstall --no-deps {distdir}/nbclient*.tar.gz'+    win: powershell Get-ChildItem -Path {distdir} -Filter nbclient*.whl | foreach \{python -m pip install -U --force-reinstall $_.FullName\}+    win: powershell Get-ChildItem -Path {distdir} -Filter nbclient*.tar.gz | foreach \{python -m pip install -U --force-reinstall --no-deps $_.FullName\}+    # Have to use /bin/bash or the `*` will cause that argument to get quoted by the tox command line...+    linux: bash -c 'python -m pip install -U --force-reinstall {distdir}/nbclient*.whl'+    linux: bash -c 'python -m pip install -U --force-reinstall --no-deps {distdir}/nbclient*.tar.gz'

We don't need to use /bin/bash anymore?

juhuebner

comment created time in 2 hours

Pull request review commentjupyter/nbclient