A MakeCode project
isidorn/electron-quick-start 0
Clone to try a simple Electron app
empty
express starter
PR closed microsoft/vscode
<!-- Thank you for submitting a Pull Request. Please:
- Read our Pull Request guidelines: https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests.
- Associate an issue with the Pull Request.
- Ensure that the code is up-to-date with the
master
branch. - Include a description of the proposed changes and how to test them. -->
The PR fixes https://github.com/microsoft/vscode/issues/114453
pr closed time in 16 minutes
issue closedmicrosoft/vscode
Possibility to move around pinned tabs with workbench.action.openEditorAtNextIndex/PrevIndex
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
I wanted to make new shortcut on Shift+j
to move on a left pinned tab and Shif+k
to move on a right one. But there are only workbench.action.openEditorAtIndex1-9 commands. I think that implementing commands that allow moving on a next/previous pinned tab could be a good idea. Such commands can be named as workbench.action.openEditorAtNextIndex
and workbench.action.openEditorAtPreviousIndex
. Implementing it will allow to move on a next/previous pinned tabs by shortcuts very easy comparing to existing Alt+1 ... Alt+9
.
closed time in 17 minutes
CIRCULARKAissue commentmicrosoft/vscode
Possibility to move around pinned tabs with workbench.action.openEditorAtNextIndex/PrevIndex
Ok.
comment created time in 17 minutes
issue openedmicrosoft/vscode
Test outline, breadcrumbs, quick pick for notebooks and text editors
Refs: https://github.com/microsoft/vscode/issues/98173
- [ ] anyOS
- [ ] anyOS
Complexity: 4
We have added support for outline, breadcrumbs, and symbol picks for notebooks. This needs testing. Since this required significant refactorings the "normal" outline & breadcrumbs must also be re-tested
created time in 18 minutes
issue commentmicrosoft/vscode
[ext-api] provide Pseudoterminal.onDidChangeName event
Makes sense, if a PR for this comes in for this I can bring it to the API sync. Seems like a good improvement so I don't see why it wouldn't be able to get merged in.
comment created time in 19 minutes
issue commentmicrosoft/vscode
Make VS Code less chatty with screen readers
Even though @leonardder has provided a workaround I think we should behave nicely out of the box.
👍🏼
I suggest that I change the role of
ACTIVITYBAR_PART
,SIDEBAR_PART
andPANEL_PART
to have arole
:none
. I plan to do this start of next milestone (so in 2 weeks in Insiders) then you can try it out and let me know what you think.
This sounds awesome, thank you!
comment created time in 21 minutes
issue commentmicrosoft/vscode
Rework working copy service participants
To verify
- use this sample extension https://github.com/jrieken/sample-file-participant (or any other extension that adds extra edits during
onWill[Create|Rename|Delete]
events - move a file
- acknowledge the prompt, follow each path and ensure it makes sense
- have a slow participate case (e.g move
samples/slow.txt
) and make sure there is progress that allows to cancel the participant
comment created time in 22 minutes
issue commentmicrosoft/vscode
Make VS Code less chatty with screen readers
@MarcoZehe Have you considered disabling NVDA's landmark reporting just for Code as a workaround?
No, since I currently work primarily on a Mac. I could try this with VoiceOver for a VS Code specific activity, but thought that this warrants a discussion for default behavior since we talk about VS Code being a desktop app and not a website. And while you can distribute this default setting in a VS Code module for NVDA, and possibly scripts for JAWS if Vispero were to include that, providing a VS Code specific activity for VoiceOver users is not possible easily.
comment created time in 23 minutes
issue commentmicrosoft/vscode
after vs code update, ng serve command doesn't work anymore in vs code terminal
it looks like we cleared the environment variable mutations made in js-debug, but narem reports the environment variable is empty after doing so.
@connor4312 not sure I'm understanding the problem here, isn't NODE_OPTIONS
meant to be empty if js-debug cleared the mutations?
comment created time in 23 minutes
issue closedmicrosoft/vscode
Extension pack dependencies are not respected when installing via the VS Code URI
Issue Type: <b>Bug</b>
- Open a VSCode window
- Open the uri vscode://shsuman.dummy-extension-main in the browser
- VSCode will prompt you to install the Dummy Extension - Main
- Install the Dummy Extension - Main (shsuman.dummy-extension-main)
This will install the Dummy Extension - Main but wouldn't install the Dummy Extension -Remote(shsuman.dummy-extension-remote) which is a part of the extension pack for the Dummy Extension - Main
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z) OS version: Windows_NT x64 10.0.19042
<details> <summary>System Info</summary>
Item | Value |
---|---|
CPUs | Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112) |
GPU Status | 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled |
Load (avg) | undefined |
Memory (System) | 15.92GB (5.42GB free) |
Process Argv | --crash-reporter-id 611024cc-5acc-4121-a31a-6d32c5099117 |
Screen Reader | no |
VM | 0% |
</details><details><summary>Extensions (21)</summary>
Extension | Author (truncated) | Version |
---|---|---|
gitlens | eam | 11.1.3 |
tsl-problem-matcher | eam | 0.3.1 |
EditorConfig | Edi | 0.16.4 |
prettier-vscode | esb | 5.8.0 |
vscode-azurestorage | ms- | 0.11.0 |
vscode-docker | ms- | 1.9.1 |
csharp | ms- | 1.23.8 |
python | ms- | 2020.12.424452561 |
vscode-pylance | ms- | 2021.1.1 |
jupyter | ms- | 2020.12.414227025 |
vscode-ai | ms- | 0.6.20-dev |
remote-ssh | ms- | 0.62.0 |
remote-ssh-edit | ms- | 0.62.0 |
remote-wsl | ms- | 0.52.0 |
azure-account | ms- | 0.9.4 |
vscode-typescript-tslint-plugin | ms- | 1.3.3 |
vsliveshare | ms- | 1.0.3484 |
java | red | 0.73.0 |
html-preview-vscode | tht | 0.2.5 |
vscode-java-debug | vsc | 0.30.0 |
vscode-java-dependency | vsc | 0.17.0 |
</details><details> <summary>A/B Experiments</summary>
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt875:30247033
</details>
<!-- generated by issue reporter -->
closed time in 36 minutes
shsumanissue commentmicrosoft/vscode
Extension pack dependencies are not respected when installing via the VS Code URI
Yes, I am seeing the right behaviour now. For some reason, it wasn't working at the time
comment created time in 36 minutes
issue commentmicrosoft/vscode
File/folder name editing - loses focus on shift + A (keybinding for creating a folder)
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.
Happy Coding!
comment created time in 39 minutes
issue closedmicrosoft/vscode
File/folder name editing - loses focus on shift + A (keybinding for creating a folder)
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.51.1
- OS Version: Linux Mint 19.3
Steps to Reproduce:
- Create a new file
- Start editing its name
- Each time I want to write an uppercase "A" with shift + A (keybinding which create a new folder) it exit editing the file name and try to create the folder.
When editing a file or folder name, keybindings shouldn't trigger.
<!-- Launch with code --disable-extensions
to check. -->
Does this issue occur when all extensions are disabled?: Yes
closed time in 39 minutes
trompxissue commentmicrosoft/vscode
Add a special type instead of using a busy error for semantic tokens
Verify that you can use vscode.CancellationError
with requiring proposed API checks. Optionally, verify that you throw this error from a semantic tokens provider without it resetting previous semantic tokens
comment created time in 44 minutes
push eventmicrosoft/vscode
commit sha 830a7589e2acce95a35eb41daf491271160d3e0f
tests - enable symlink tests for windows again via 'junction' that do not require admin privilges
push time in an hour
issue closedmicrosoft/vscode-vsce
Cannot overwrite the access token
PS C:\Users\Marko\Source\Repos\The Spiral Language\VS Code Plugin> vsce login mrakgr
Publisher 'mrakgr' is already known
Do you want to overwrite its PAT? [y/N] y
Personal Access Token for publisher 'mrakgr': ****************************************************
ERROR Failed request: (401)
Trying to do a vsce publish patch -p <token>
also fails with a 401 error. The situation on my PC is a bit unusual because a few days ago, I was on a cleaning spree and deleted the AppData
folder by hand in order to free up space on the SSD. This broke some apps, and I suspect vsce
is one of them. Right now my only choice for publishing on the VS Code marketplace is the web interface.
Can I do anything to fix this apart from reinstalling Windows?
closed time in an hour
mrakgrissue commentmicrosoft/vscode-vsce
Cannot overwrite the access token
You need to request a new access token: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#get-a-personal-access-token
comment created time in an hour
issue closedmicrosoft/vscode
Codespaces: cannot clone/fetch/push/mirror private repos on other organizations
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: GitHub Codespaces
Steps to Reproduce:
- Create a codespace from a private repository under your personal account.
- Try to add a remote pointing to a private repository under a GitHub organization.
codespace ➜ ~/workspace $ git clone --bare https://github.com/REDACTED/REDACTED.git
Cloning into bare repository 'REDACTED.git'...
remote: Repository not found.
fatal: repository 'https://github.com/REDACTED/REDACTED.git/' not found
codespace ➜ ~/workspace/ks-engine (master) $ git remote add --mirror=push REDACTED https://github.com/REDACTED/REDACTED.git
codespace ➜ ~/workspace/ks-engine (master) $ git remote -v
REDACTED https://github.com/REDACTED/REDACTED.git (fetch)
REDACTED https://github.com/REDACTED/REDACTED.git (push)
origin https://github.com/0xbkt/ks-engine (fetch)
origin https://github.com/0xbkt/ks-engine (push)
codespace ➜ ~/workspace/ks-engine (master) $ git fetch REDACTED
remote: Repository not found.
fatal: repository 'https://github.com/REDACTED/REDACTED.git/' not found
codespace ➜ ~/workspace/ks-engine (master) $
<!-- Launch with code --disable-extensions
to check. -->
Does this issue occur when all extensions are disabled?: Yes
closed time in an hour
0xbktissue commentmicrosoft/vscode
Codespaces: cannot clone/fetch/push/mirror private repos on other organizations
A Codespace's auth is locked against the repo the Codespace was created from. Discussions already happening:
https://github.community/t/cant-push-to-other-private-repos/156447
comment created time in an hour
push eventmicrosoft/vscode
commit sha 14cc5263711ea86eebf41505acf5888c70e1413b
Cannot open a remote workspace via --remote syntax. Fixes #114900
push time in an hour
issue closedmicrosoft/vscode
Cannot open a remote workspace via --remote syntax
Looking at the implementation of --remote
support, I do not think we correctly open a workspace when I provide one via command line, e.g. code-insiders --remote wsl+Ubuntu /home/ticino/workspaces/workspace.code-workspace
I would have expected that in this method we create a workspace openable if we encounter the .code-workspace
file extension:
https://github.com/microsoft/vscode/blob/c8ff3471b596a8a21e1f080f3f038e08ee148b6e/src/vs/platform/windows/electron-main/windowsMainService.ts#L922-L937
closed time in an hour
bpaseroissue commentmicrosoft/vscode
Add support for immutable context key service
https://github.com/microsoft/vscode/blob/86d96faaaf8b15a66abc2d766dc47cbdabd177f9/src/vs/workbench/browser/parts/views/treeView.ts#L1126-L1137
We often create CKS that we only use for a few static values (see above). This can then cause issues with them not being disposed of or them being alive for too long. Instead should have a dead/immutable CKS which delegates everything to its parent, esp eventing, and which only holds a few static values.
comment created time in an hour
push eventmicrosoft/vscode
commit sha 55d27525647b70239cc29bdd2acad03c48c46771
update gulp-atom-electron again
push time in an hour
issue commentmicrosoft/vscode
Cannot open a remote workspace via --remote syntax
Looks like I broke this with https://github.com/microsoft/vscode/commit/f667462a2a8a12c92dbcdd8acf92df7354063691
comment created time in an hour
issue openedmicrosoft/vscode
Add support for immutable context key service
this is a follow up from https://github.com/microsoft/vscode/issues/107903#issuecomment-765589206
created time in an hour
issue commentmicrosoft/vscode
Integrated Terminal Lags Intermittently
What fixed the issue for me was running
codesign --remove-signature /Applications/Visual\ Studio\ Code.app/Contents/Frameworks/Code\ Helper\ \(Renderer\).app
.
this helped me with lags and slow terminal open
comment created time in an hour
push eventmicrosoft/vscode
commit sha e60e0eab3529b3f31e67eea6822b34e91f3bbafb
Cleanup some file related unit tests (#114895) * wip * clean up * more test cleanup * cleanup more * more cleanup
push time in an hour
issue openedmicrosoft/vscode
Cannot open a remote workspace via --remote syntax
Looking at the implementation of --remote
support, I do not think we correctly open a workspace when I provide one via command line, e.g. code-insiders --remote wsl+Ubuntu /home/ticino/workspaces/workspace.code-workspace
I would have expected that in this method we create a workspace openable if we encounter the .code-workspace
file extension:
https://github.com/microsoft/vscode/blob/c8ff3471b596a8a21e1f080f3f038e08ee148b6e/src/vs/platform/windows/electron-main/windowsMainService.ts#L922-L937
created time in an hour