<!-- Thank you for submitting a Pull Request. Please:

• Read our Pull Request guidelines: https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests.
• Associate an issue with the Pull Request.
• Ensure that the code is up-to-date with the master branch.
• Include a description of the proposed changes and how to test them. -->

The PR fixes https://github.com/microsoft/vscode/issues/114453

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> I wanted to make new shortcut on Shift+j to move on a left pinned tab and Shif+k to move on a right one. But there are only workbench.action.openEditorAtIndex1-9 commands. I think that implementing commands that allow moving on a next/previous pinned tab could be a good idea. Such commands can be named as workbench.action.openEditorAtNextIndex and workbench.action.openEditorAtPreviousIndex. Implementing it will allow to move on a next/previous pinned tabs by shortcuts very easy comparing to existing Alt+1 ... Alt+9.

Ok.

Refs: https://github.com/microsoft/vscode/issues/98173

• [ ] anyOS
• [ ] anyOS

Complexity: 4

We have added support for outline, breadcrumbs, and symbol picks for notebooks. This needs testing. Since this required significant refactorings the "normal" outline & breadcrumbs must also be re-tested

Makes sense, if a PR for this comes in for this I can bring it to the API sync. Seems like a good improvement so I don't see why it wouldn't be able to get merged in.

Even though @leonardder has provided a workaround I think we should behave nicely out of the box.

👍🏼

I suggest that I change the role of ACTIVITYBAR_PART, SIDEBAR_PART and PANEL_PART to have a role: none. I plan to do this start of next milestone (so in 2 weeks in Insiders) then you can try it out and let me know what you think.

This sounds awesome, thank you!

To verify

• use this sample extension https://github.com/jrieken/sample-file-participant (or any other extension that adds extra edits during onWill[Create|Rename|Delete] events
• move a file
• acknowledge the prompt, follow each path and ensure it makes sense
• have a slow participate case (e.g move samples/slow.txt) and make sure there is progress that allows to cancel the participant

@MarcoZehe Have you considered disabling NVDA's landmark reporting just for Code as a workaround?

No, since I currently work primarily on a Mac. I could try this with VoiceOver for a VS Code specific activity, but thought that this warrants a discussion for default behavior since we talk about VS Code being a desktop app and not a website. And while you can distribute this default setting in a VS Code module for NVDA, and possibly scripts for JAWS if Vispero were to include that, providing a VS Code specific activity for VoiceOver users is not possible easily.

it looks like we cleared the environment variable mutations made in js-debug, but narem reports the environment variable is empty after doing so.

@connor4312 not sure I'm understanding the problem here, isn't NODE_OPTIONS meant to be empty if js-debug cleared the mutations?

Issue Type: <b>Bug</b>

1. Open a VSCode window
2. Open the uri vscode://shsuman.dummy-extension-main in the browser
3. VSCode will prompt you to install the Dummy Extension - Main
4. Install the Dummy Extension - Main (shsuman.dummy-extension-main)

This will install the Dummy Extension - Main but wouldn't install the Dummy Extension -Remote(shsuman.dummy-extension-remote) which is a part of the extension pack for the Dummy Extension - Main

VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z) OS version: Windows_NT x64 10.0.19042

<details> <summary>System Info</summary>

</details><details><summary>Extensions (21)</summary>

</details><details> <summary>A/B Experiments</summary>

vsins829:30139715
vsliv368:30146709
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt875:30247033

</details>

<!-- generated by issue reporter -->

Yes, I am seeing the right behaviour now. For some reason, it wasn't working at the time

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

• VSCode Version: 1.51.1
• OS Version: Linux Mint 19.3

Steps to Reproduce:

1. Create a new file
2. Start editing its name
3. Each time I want to write an uppercase "A" with shift + A (keybinding which create a new folder) it exit editing the file name and try to create the folder.

When editing a file or folder name, keybindings shouldn't trigger.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

Verify that you can use vscode.CancellationError with requiring proposed API checks. Optionally, verify that you throw this error from a semantic tokens provider without it resetting previous semantic tokens

PS C:\Users\Marko\Source\Repos\The Spiral Language\VS Code Plugin> vsce login mrakgr
Publisher 'mrakgr' is already known
Do you want to overwrite its PAT? [y/N] y
Personal Access Token for publisher 'mrakgr': ****************************************************

 ERROR  Failed request: (401)

Trying to do a vsce publish patch -p <token> also fails with a 401 error. The situation on my PC is a bit unusual because a few days ago, I was on a cleaning spree and deleted the AppData folder by hand in order to free up space on the SSD. This broke some apps, and I suspect vsce is one of them. Right now my only choice for publishing on the VS Code marketplace is the web interface.

Can I do anything to fix this apart from reinstalling Windows?

You need to request a new access token: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#get-a-personal-access-token

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

• VSCode Version: GitHub Codespaces

Steps to Reproduce:

1. Create a codespace from a private repository under your personal account.
2. Try to add a remote pointing to a private repository under a GitHub organization.

codespace ➜ ~/workspace $ git clone --bare https://github.com/REDACTED/REDACTED.git
Cloning into bare repository 'REDACTED.git'...
remote: Repository not found.
fatal: repository 'https://github.com/REDACTED/REDACTED.git/' not found

codespace ➜ ~/workspace/ks-engine (master) $ git remote add --mirror=push REDACTED https://github.com/REDACTED/REDACTED.git
codespace ➜ ~/workspace/ks-engine (master) $ git remote -v
REDACTED      https://github.com/REDACTED/REDACTED.git (fetch)
REDACTED      https://github.com/REDACTED/REDACTED.git (push)
origin        https://github.com/0xbkt/ks-engine (fetch)
origin        https://github.com/0xbkt/ks-engine (push)
codespace ➜ ~/workspace/ks-engine (master) $ git fetch REDACTED
remote: Repository not found.
fatal: repository 'https://github.com/REDACTED/REDACTED.git/' not found
codespace ➜ ~/workspace/ks-engine (master) $ 

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

A Codespace's auth is locked against the repo the Codespace was created from. Discussions already happening:

https://github.community/t/cant-push-to-other-private-repos/156447

Looking at the implementation of --remote support, I do not think we correctly open a workspace when I provide one via command line, e.g. code-insiders --remote wsl+Ubuntu /home/ticino/workspaces/workspace.code-workspace

I would have expected that in this method we create a workspace openable if we encounter the .code-workspace file extension:

https://github.com/microsoft/vscode/blob/c8ff3471b596a8a21e1f080f3f038e08ee148b6e/src/vs/platform/windows/electron-main/windowsMainService.ts#L922-L937

https://github.com/microsoft/vscode/blob/86d96faaaf8b15a66abc2d766dc47cbdabd177f9/src/vs/workbench/browser/parts/views/treeView.ts#L1126-L1137

We often create CKS that we only use for a few static values (see above). This can then cause issues with them not being disposed of or them being alive for too long. Instead should have a dead/immutable CKS which delegates everything to its parent, esp eventing, and which only holds a few static values.

Looks like I broke this with https://github.com/microsoft/vscode/commit/f667462a2a8a12c92dbcdd8acf92df7354063691

this is a follow up from https://github.com/microsoft/vscode/issues/107903#issuecomment-765589206

What fixed the issue for me was running codesign --remove-signature /Applications/Visual\ Studio\ Code.app/Contents/Frameworks/Code\ Helper\ \(Renderer\).app.

this helped me with lags and slow terminal open

Looking at the implementation of --remote support, I do not think we correctly open a workspace when I provide one via command line, e.g. code-insiders --remote wsl+Ubuntu /home/ticino/workspaces/workspace.code-workspace

I would have expected that in this method we create a workspace openable if we encounter the .code-workspace file extension:

https://github.com/microsoft/vscode/blob/c8ff3471b596a8a21e1f080f3f038e08ee148b6e/src/vs/platform/windows/electron-main/windowsMainService.ts#L922-L937