inxilpro ( Chris Morrell )

release awssat/tailwindo

3.0.6

released time in an hour

release usablica/intro.js

v4.1.0

released time in 4 hours

issue commentinxilpro/node-app-root-path

Path resolution in npm linked modules report module and not root app path.

I have to share an interesting bug that took a long time to figure out and is directly related to this issue:

https://medium.com/@fagnerbrack/the-story-of-a-stupid-bug-that-is-impossible-to-reproduce-6863ac526172

Basically:

NPM install on local files creates a symlink.
Zipping removes the symlink.
This can cause a bug that can only happen in prod and is impossible to reproduce locally.

MarkGriffiths

comment created time in 11 hours

Pull request review commentInterNACHI/modular

Livewire auto-discovery.

+<?php++namespace InterNACHI\Modular\Console\Commands\Make;++use Illuminate\Support\Facades\Config;+use Livewire\Commands\MakeCommand;+use Symfony\Component\Console\Input\InputOption;++class MakeLivewire extends MakeCommand+{+	use Modularize;++	protected $signature = 'livewire:make {name} {--force} {--inline} {--test} {--stub=default}';++	public function __construct()+	{+		parent::__construct();++		$this->getDefinition()->addOption(+			new InputOption(+				'--module',+				null,+				InputOption::VALUE_REQUIRED,+				'Create this resource inside an application module'+			)+		);++		Config::set('livewire.class_namespace', 'Modules\Blueprints');+		Config::set('livewire.view_path', 'app-modules/blueprints/resources/livewire');

Will check everything tomorrow, on a Europe timezone so it’s late :)

eckelarsson

comment created time in 17 hours

Pull request review commentInterNACHI/modular

Livewire auto-discovery.

 class ModularizedCommandsServiceProvider extends ServiceProvider { 	protected $overrides = [+		'command.livewire.make' => MakeLivewire::class,

Yeah me and @DanielCoulbourne was thinkering with this to make it work and we what we could find was that Livewire was hooking the make command in a not standard way so we didn’t find a solution for adding the —module argument into LW.

eckelarsson

comment created time in 17 hours

Pull request review commentInterNACHI/modular

Livewire auto-discovery.

+<?php++namespace InterNACHI\Modular\Console\Commands\Make;++use Illuminate\Support\Facades\Config;+use Livewire\Commands\MakeCommand;+use Symfony\Component\Console\Input\InputOption;++class MakeLivewire extends MakeCommand+{+	use Modularize;++	protected $signature = 'livewire:make {name} {--force} {--inline} {--test} {--stub=default}';++	public function __construct()+	{+		parent::__construct();++		$this->getDefinition()->addOption(+			new InputOption(+				'--module',+				null,+				InputOption::VALUE_REQUIRED,+				'Create this resource inside an application module'+			)+		);++		Config::set('livewire.class_namespace', 'Modules\Blueprints');+		Config::set('livewire.view_path', 'app-modules/blueprints/resources/livewire');

Oh… sorry about that was me and Daniel that was playing around with the tests and then we focus on fixing the styling issue thing so forget to delete all this.

eckelarsson

comment created time in 17 hours

pull request commentglhd/aire

Form 2 Inheriting Form 1 Attributes

@inxilpro take a look at this when you get a chance -- seems to be the solution =)

bogdankharchenko

comment created time in 19 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/ws-6.2.2

delete time in 20 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/browserslist-4.16.6

delete time in 20 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/hosted-git-info-2.8.9

delete time in 20 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/lodash-4.17.21

delete time in 20 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/glob-parent-5.1.2

delete time in 20 hours

delete branch glhd/aire

delete branch : dependabot/npm_and_yarn/normalize-url-4.5.1

delete time in 20 hours

push eventglhd/aire

Chris Morrell

commit sha 774968e55c2a538d41fa2b5ebb95199d546b1f35

Only run coverage on main branch