profile
viewpoint

inicklas/active_material 0

ActiveAdmin skin based on Google's Material Design

inicklas/aika 0

Aika - Timesheets

inicklas/arc_gcs 0

Provides an Arc backend for Google Cloud Storage

inicklas/homebrew-cask 0

A CLI workflow for the administration of Mac applications distributed as binaries

inicklas/machinery 0

State machine thin layer for structs (+ GUI for Phoenix apps)

inicklas/phonegap-plugin-push 0

Register and receive push notifications

created repositoryiacobson/phoenix_demo_app

Demo App for used as support for blog posts

created time in 8 days

startedjonklein/niex

started time in 21 days

startedash-project/ash

started time in 21 days

startedlensapp/lens

started time in a month

PR opened smartpension/smart-magic-cards

Bump ini from 1.3.5 to 1.3.8

Bumps ini from 1.3.5 to 1.3.8. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/ini/commit/a2c5da86604bc2238fe393c5ff083bf23a9910eb"><code>a2c5da8</code></a> 1.3.8</li> <li><a href="https://github.com/npm/ini/commit/af5c6bb5dca6f0248c153aa87e25bddfc515ff6e"><code>af5c6bb</code></a> Do not use Object.create(null)</li> <li><a href="https://github.com/npm/ini/commit/8b648a1ac49e1b3b7686ea957e0b95e544bc6ec1"><code>8b648a1</code></a> don't test where our devdeps don't even work</li> <li><a href="https://github.com/npm/ini/commit/c74c8af35f32b801a7e82a8309eab792a95932f6"><code>c74c8af</code></a> 1.3.7</li> <li><a href="https://github.com/npm/ini/commit/024b8b55ac1c980c6225607b007714c54eb501ba"><code>024b8b5</code></a> update deps, add linting</li> <li><a href="https://github.com/npm/ini/commit/032fbaf5f0b98fce70c8cc380e0d05177a9c9073"><code>032fbaf</code></a> Use Object.create(null) to avoid default object property hazards</li> <li><a href="https://github.com/npm/ini/commit/2da90391ef70db41d10f013e3a87f9a8c5d01a72"><code>2da9039</code></a> 1.3.6</li> <li><a href="https://github.com/npm/ini/commit/cfea636f534b5ca7550d2c28b7d1a95d936d56c6"><code>cfea636</code></a> better git push script, before publish instead of after</li> <li><a href="https://github.com/npm/ini/commit/56d2805e07ccd94e2ba0984ac9240ff02d44b6f1"><code>56d2805</code></a> do not allow invalid hazardous string as section name</li> <li>See full diff in <a href="https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~isaacs">isaacs</a>, a new releaser for ini since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

pr created time in a month

startednetwide-assembler/nasm

started time in 2 months

startedderekkraan/horde

started time in 2 months

created repositorynulty/react-tut

Just the React Tutorial

created time in 2 months

created repositorynulty/iframe-host-sample

Demonstrating communication between iframe and host window

created time in 2 months

delete branch smartpension/signable

delete branch : POL-1132-extend-default-signable-templates-limit

delete time in 3 months

push eventsmartpension/signable

Tomasz Skupinski

commit sha a889c699a6833523ab784657a5115a9fef0ced67

Change the default limit of signable templates

view details

Tomasz Skupiński

commit sha e2625b7ee1d133a4a13912a431dc87848c1cc0d4

Change gem version

view details

Tomasz Skupiński

commit sha 795906b33f85dcf54b93396278d5e9563d17a607

Adjust spec files

view details

Tomasz Skupiński

commit sha 113cb340971c4ba64ba8125fcbcdadd24edd0aad

Change Query to user keyword arguments for .all method

view details

Tomasz Skupiński

commit sha 0be9874bf9752474b14c24cebe2748e551817ba8

Merge pull request #8 from smartpension/POL-1132-extend-default-signable-templates-limit [POL-1132] Change the default limit of signable templates

view details

push time in 3 months

PR merged smartpension/signable

[POL-1132] Change the default limit of signable templates

Extend the default limit of signable templates to 30. As part of this change we will change method to use keyword arguments.

Jira: https://smartpension.atlassian.net/browse/POL-1132

+5 -5

2 comments

3 changed files

tskupinski

pr closed time in 3 months

Pull request review commentsmartpension/signable

[POL-1132] Change the default limit of signable templates

 def create       end        module ClassMethods-        def all(offset = 0, limit = 10)+        def all(offset: 0, limit: 30)

As you supposed correctly - invoking the method will be part of another PR for the api repository (together with bumping the gem version).

It should work even without this as we are only using the default values.

tskupinski

comment created time in 3 months

Pull request review commentsmartpension/signable

[POL-1132] Change the default limit of signable templates

 def create       end        module ClassMethods-        def all(offset = 0, limit = 10)+        def all(offset: 0, limit: 30)

Usually when positional arguments are switched to key word, the invocation of the method needs to be changed as well - unless only the default argument values are always used during method's invocation.

Is it the case here? ;)

Or do you plan to change it in the next PR?

tskupinski

comment created time in 3 months

push eventsmartpension/signable

Tomasz Skupiński

commit sha 113cb340971c4ba64ba8125fcbcdadd24edd0aad

Change Query to user keyword arguments for .all method

view details

push time in 3 months

push eventsmartpension/signable

Tomasz Skupiński

commit sha d63db2a0655adc4f4b3a3b013a55bde84e3d2710

Change Query to user keyword arguments for .all method

view details

push time in 3 months

pull request commentsmartpension/signable

[POL-1132] Change the default limit of signable templates

@Sphaerus as it happens there were specs for this case - I have updated those.

tskupinski

comment created time in 3 months

push eventsmartpension/signable

Tomasz Skupiński

commit sha e2625b7ee1d133a4a13912a431dc87848c1cc0d4

Change gem version

view details

Tomasz Skupiński

commit sha 795906b33f85dcf54b93396278d5e9563d17a607

Adjust spec files

view details

Tomasz Skupiński

commit sha 9b20e2a4d674e55f74ced3a477ac5c1df69bbc1a

Change Query to user keyword arguments for .all method

view details

push time in 3 months

pull request commentsmartpension/signable

[POL-1132] Change the default limit of signable templates

@Sphaerus I haven't found any for previous limit, but it might be a good idea - I will double check it with someone in my team (this is my first PR).

tskupinski

comment created time in 3 months

pull request commentsmartpension/signable

[POL-1132] Change the default limit of signable templates

shouldnt we have specs for that?

tskupinski

comment created time in 3 months

PR opened smartpension/signable

[POL-1132] Change the default limit of signable templates

Extend the default limit of signable templates to 30.

Jira: https://smartpension.atlassian.net/browse/POL-1132

+1 -1

0 comment

1 changed file

pr created time in 3 months

startedtypescript-cheatsheets/react

started time in 3 months

starteddypsilon/frontend-dev-bookmarks

started time in 3 months

startedawesome-css-group/awesome-css

started time in 3 months

more