profile
viewpoint
Ilya Grigorik igrigorik Google San Francisco, CA https://www.igvita.com Building faster, more secure, and engaging open web. Director of Developer Relations at @google.

igrigorik/ga-beacon 3381

Google Analytics collector-as-a-service (using GA measurement protocol).

igrigorik/gharchive.org 1945

GH Archive is a project to record the public GitHub timeline, archive it, and make it easily accessible for further analysis.

igrigorik/em-websocket 1669

EventMachine based WebSocket server

igrigorik/em-http-request 1202

Asynchronous HTTP Client (EventMachine + Ruby)

igrigorik/decisiontree 1181

ID3-based implementation of the ML Decision Tree algorithm

igrigorik/em-synchrony 1052

Fiber aware EventMachine clients and convenience classes

google/site-kit-wp 814

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

igrigorik/bugspots 792

Implementation of simple bug prediction hotspot heuristic

igrigorik/agent 747

Agent is an attempt at modelling Go-like concurrency, in Ruby

igrigorik/em-proxy 662

EventMachine Proxy DSL for writing high-performance transparent / intercepting proxies in Ruby

MemberEvent

push eventigrigorik/videospeed

Chad Bailey

commit sha eaf5ac47f308fb4a1fc608bc862de5e01885f128

A few small fixes #586 (#591) * Trimmed trailing whitespace * Fixed erroneous newline at beginning of blacklist * Fixed erroneous instructions for adding remote in contribution guide (Fixes #586)

view details

push time in 9 days

issue closedigrigorik/videospeed

A few small fixes

This issue is simply to give a place for discussion around a couple of very minor updates I plan to do (or give someone else the chance to do them should they so prefer - would be perfect for someone who has never contributed)

Apparently, I mis-pasted the command for adding another remote on line 82 of CONTRIBUTING.md

git push --set-upstream origin feature/578-prettier.io-formatting

Should be git remote add upstream https://github.com/igrigorik/videospeed.git

Or something very close to that (I haven't validated the exact command in this post, but before updating the guide I would certainly validate it).

Next is the erroneous blank line at the beginning of the blacklist should be removed

Found in line 15 of inject.js and line 20 of options.js

The fix is simple, just change from

blacklist: `

to

blacklist: `\

closed time in 9 days

ChadBailey

PR merged igrigorik/videospeed

A few small fixes #586

Small maintenance item for resolving #586

  • Fixed erroneous instructions for adding remote in contribution guide
  • Fixed erroneous newline at beginning of blacklist
  • Trimmed trailing whitespace
+10 -10

0 comment

4 changed files

ChadBailey

pr closed time in 9 days

Pull request review commentw3c/resource-timing

TAO-Protect nextHopProtocol

 <h3>The <dfn>PerformanceResourceTiming</dfn> Interface</h3> <li><dfn>"other"</dfn>, if none of the above conditions match.</li> </ul> <p data-dfn-for="PerformanceResourceTiming">On getting, the-attribute <dfn>nextHopProtocol</dfn> returns the network protocol-used to fetch the resource, as identified by the ALPN Protocol ID-[[RFC7301]]; resources retrieved from <a data-cite=-"HTML#relevant-application-cache">relevant application caches</a>-or local resources, return an empty string. When a proxy is-configured, if a tunnel connection is established then this-attribute MUST return the ALPN Protocol ID of the tunneled-protocol, otherwise it MUST return the ALPN Protocol ID of the-first hop to the proxy. In order to have precisely one way to-represent any ALPN protocol ID, the following additional-constraints apply: octets in the ALPN protocol MUST NOT be-percent-encoded if they are valid token characters except "%", and-when using percent-encoding, uppercase hex digits MUST be used.</p>+attribute <dfn>nextHopProtocol</dfn> returns the following:+<ul>+  <li>If the resource fails the <a>timing allow check</a> algorithm and the

Re, "and": what flow are you carving out here?

yoavweiss

comment created time in 14 days

push eventigrigorik/videospeed

Chad Bailey

commit sha 55500fc0107b2b5c7465c5e85a59724630ff3b36

Feature/578 prettier.io formatting (#585) * Reformatted codebase using prettier.io (should not change functional behavior) * Formatted README.md, added CONTRIBUTING.md, .prettierrc configuration file, and installed pre-commit hook

view details

push time in 16 days

PR merged igrigorik/videospeed

Feature/578 prettier.io formatting

We discussed in #578 adding prettier for code formatting. I investigated the suggestions of using a github bot for auto-formatting and unfortunately could not find such a thing. If I've overlooked it please let me know. I also looked into using Github Actions, but I also did not find anything for that (and of course setting that up requires special access levels to the repo).

As a compromise, I have set up a very easy to use pre-commit hook and gave instructions for setting that up as well as contributing in general. I also have formatted the entire codebase using prettier. I basically kept the default prettier formatting options.

+1294 -955

0 comment

14 changed files

ChadBailey

pr closed time in 16 days

Pull request review commentigrigorik/videospeed

Create Github Action to upload to chrome web store on version tagging

+name: Upload To Chrome Web Store+# This workflow is triggered on pushes to the repository.

When a tag is pushed. I think you're hinting that we should release the large merge? :)

deef0000dragon1

comment created time in 16 days

push eventigrigorik/videospeed

jedawson

commit sha 4ac2e458f548681976346615210cb6b1cdbe6576

Apple tv plus (#541) * add support for traversing shadowRoot's; enables apple tv support.

view details

push time in 18 days

PR merged igrigorik/videospeed

Reviewers
Apple tv plus

Fixes #540 by creating a mutationObserver on the apple-tv-plus-player element to observe changes to the aria-hidden attribute; also by creating a treeWalker for the shadow DOM's that searches for the video element.

+73 -22

7 comments

1 changed file

jedawson

pr closed time in 18 days

issue closedigrigorik/videospeed

will AppleTV+ work in the future?

can't tell if they're using HTML5, but it doesn't work currently

closed time in 18 days

sidgestion

pull request commentigrigorik/videospeed

Apple tv plus

Sounds like we're OK to merge.. let's land this. :-)

Thank you all for the patience and great work here!

jedawson

comment created time in 18 days

issue openedWPO-Foundation/wptagent

WordPress CDN -> Automattic CDN

https://github.com/WPO-Foundation/wptagent/blob/638ae7af9ba14dad25bf3cb05011fa102ad6d59d/internal/optimization_checks.py#L210

A8C powers WordPress.com, but they're one of many WP hosting platforms. I'd like to propose that we relabel this to signal "Automattic" instead of "WordPress".

Additionally, we can add the header signal to the list: https://github.com/rviscomi/ismyhostfastyet/blob/master/ttfb.sql#L5

/cc @rviscomi

created time in a month

Pull request review commentGoogleChrome/web.dev

Clarify CrUX bucketing for CLS

 Ideally, pages would not have any layout shifts, so a CLS of `0` is the goal. Realistically, in some cases it's impossible to avoid 100% of layout shifts, so minimizing what you can is best. -The Chrome Use Experience Report categorizes any page with a CLS less than 5 to-be considered "small" (i.e. good).+CrUX categorizes any page with a CLS less than `0.05` to be considered "small"

Ah. If memory serves, <5 is because that bucket covers the 0-5 range and ideally CLS is 0 — that's definitely a good place to be. That said, given that this is not our official guidance for CLS thresholds, I would probably suggest we drop this part, but keep the rest.

philipwalton

comment created time in a month

Pull request review commentGoogleChrome/web.dev

Clarify CrUX bucketing for CLS

 Ideally, pages would not have any layout shifts, so a CLS of `0` is the goal. Realistically, in some cases it's impossible to avoid 100% of layout shifts, so minimizing what you can is best. -The Chrome Use Experience Report categorizes any page with a CLS less than 5 to-be considered "small" (i.e. good).+CrUX categorizes any page with a CLS less than `0.05` to be considered "small"

What do we actually mean by this? We don't assign labels in CrUX.. =/

philipwalton

comment created time in a month

issue closedigrigorik/videospeed

Version for Safari??

Do you guys have any plans of coming up with a version for Safari, Brave Browser, and Tor Browser?

closed time in a month

no-trash

issue commentigrigorik/videospeed

Version for Safari??

In theory, it should work with Brave as it's a Chromium based browser. No plans for Safari or Tor browser extensions.

no-trash

comment created time in a month

Pull request review commentgoogle/WebFundamentals

CrUX changelog

+project_path: /web/tools/_project.yaml+book_path: /web/tools/_book.yaml++{# wf_updated_on: 2020-01-15 #}+{# wf_published_on: 2019-01-15 #}+{# wf_blink_components: N/A #}++# Chrome User Experience Report {: .page-title }++## Changelog {: #changelog }

Thanks for pulling this together! Have a bunch of small suggestions, but I think it'll be easier to provide that feedback in the draft Google doc.. I'll followup there.

rviscomi

comment created time in a month

Pull request review commentgoogle/WebFundamentals

CrUX changelog

 Defined by the [HTML specification](https://html.spec.whatwg.org/#event-load): finished loading.” -  [MDN](https://developer.mozilla.org/en-US/docs/Web/Events/load). +#### First Input Delay {: #first-input-delay }

@rviscomi to stay consistent, could we add the the "Defined by <spec>" preambles for all the new metrics? It's useful to have a direct reference to the spec that spells out the metric.

rviscomi

comment created time in a month

issue closedigrigorik/gharchive.org

BigQuery info is outdated

https://www.gharchive.org/#bigquery

When you load that link to the console it directs you to the new console and the query you suggest does not work.

closed time in a month

jongio

issue commentigrigorik/gharchive.org

BigQuery info is outdated

Thanks for reporting this! Updated the link and example query.

jongio

comment created time in a month

push eventigrigorik/gharchive.org

Ilya Grigorik

commit sha ebc8c926caa241e9c043d489bc2f1c864b44f2ed

update console link to new URL

view details

push time in a month

issue commentigrigorik/videospeed

Use prettier for code style guide

Indeed, that would be ideal, but I wouldn't consider that a blocker. We could check-in a formatter config and provide some instructions on how to install and run it.

Thanks for digging into this!

ChadBailey

comment created time in a month

issue closedigrigorik/gharchive.org

No 2019 table in bigquery.

There's no 2019 table in githubarchive.year

image

closed time in a month

rspier

issue commentigrigorik/gharchive.org

No 2019 table in bigquery.

Thanks for flagging! Should be in place now.

rspier

comment created time in a month

pull request commentigrigorik/vimgolf

Lowercase user name

Rolling out now. Hope it works this time! :)

Sakisan

comment created time in a month

push eventigrigorik/vimgolf

Antoine

commit sha b81f1dcb5fd51e6681c111172a3a57c4f477257c

Lowercase admin user name (#280)

view details

push time in a month

PR merged igrigorik/vimgolf

Lowercase user name

Thanks for https://github.com/igrigorik/vimgolf/pull/279. However it appears the lowercase username is necessary after all.

https://github.com/igrigorik/vimgolf/blob/master/app/models/user.rb#L29

+1 -1

0 comment

1 changed file

Sakisan

pr closed time in a month

pull request commentigrigorik/vimgolf

Add Sakigw to the list of moderators

Should be live! Thanks for your patience.

Sakisan

comment created time in a month

push eventigrigorik/vimgolf

dependabot[bot]

commit sha da175bf78a3ce1a555230c8f521ecaa7d6d0b2f3

Bump rack from 2.0.7 to 2.0.8 (#278) Bumps [rack](https://github.com/rack/rack) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](https://github.com/rack/rack/compare/2.0.7...2.0.8) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in a month

PR merged igrigorik/vimgolf

Bump rack from 2.0.7 to 2.0.8 dependencies

Bumps rack from 2.0.7 to 2.0.8. <details> <summary>Changelog</summary>

Sourced from rack's changelog.

Changelog

All notable changes to this project will be documented in this file. For info on how to format all future additions to this file please reference Keep A Changelog.

Unreleased

Note: There are many unreleased changes in Rack (master is around 300 commits ahead of 2-0-stable), and below is not an exhaustive list. If you would like to help out and document some of the unreleased changes, PRs are welcome.

Added

Changed

  • Use Time#httpdate format for Expires, as proposed by RFC 7231. (@​nanaya)
  • Make Utils.status_code raise an error when the status symbol is invalid instead of 500.
  • Rename Request::SCHEME_WHITELIST to Request::ALLOWED_SCHEMES.
  • Make Multipart::Parser.get_filename accept files with + in their name.
  • Add Falcon to the default handler fallbacks. (@​ioquatix)
  • Update codebase to avoid string mutations in preparation for frozen_string_literals. (@​pat)
  • Change MockRequest#env_for to rely on the input optionally responding to #size instead of #length. (@​janko)
  • Rename Rack::File -> Rack::Files and add deprecation notice. (@​postmodern).

Removed

Documentation

  • Update broken example in Session::Abstract::ID documentation. (tonytonyjan)
  • Add Padrino to the list of frameworks implmenting Rack. (@​wikimatze)
  • Remove Mongrel from the suggested server options in the help output. (@​tricknotes)
  • Replace HISTORY.md and NEWS.md with CHANGELOG.md. (@​twitnithegirl)
  • Backfill CHANGELOG.md from 2.0.1 to 2.0.7 releases. (@​drenmi) </details> <details> <summary>Commits</summary>
  • e7ee459 Bumping version
  • f1a79b2 Introduce a new base class to avoid breaking when upgrading
  • 5b1cab6 Add a version prefix to the private id to make easier to migrate old values
  • 1e96e0f Fallback to the public id when reading the session in the pool adapter
  • 3ba123d Also drop the session with the public id when destroying sessions
  • 6a04bbf Fallback to the legacy id when the new id is not found
  • dc45a06 Add the private id
  • 73a5f79 revert conditionals to master
  • 4e32262 remove NullSession
  • 1c7e3b2 remove || raise and get closer to master
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

push eventigrigorik/vimgolf

Antoine

commit sha 257577fbd79588b0cbdc4cfb3128938718f2c523

Add Sakigw to the list of moderators (#279) * Add Sakigw to the list of moderators

view details

push time in a month

PR merged igrigorik/vimgolf

Add Sakigw to the list of moderators
+2 -1

1 comment

1 changed file

Sakisan

pr closed time in a month

issue closedigrigorik/videospeed

Control Regularly Doesn't Show Up

The speed controls often don't show up on Youtube or Vimeo.

Here is the latest: https://player.vimeo.com/video/352485178?api=false&autoplay=auto&byline=false&color=%23444444&portrait=false&title=false

No matter what I do (including trying different browser with no cookies etc.) the controls do not show up on that video.

closed time in a month

NetJon

issue commentigrigorik/videospeed

Control Regularly Doesn't Show Up

Triple facepalm! Pushed the tag but did not rev the version number in the manifest.

Rolling out now: https://github.com/igrigorik/videospeed/commit/0389c61db733e86698edc1e1cd5e4298a2777c1d/checks?check_suite_id=399171106

NetJon

comment created time in a month

created tagigrigorik/videospeed

tagv0.5.9

HTML5 video speed controller (for Google Chrome)

created time in a month

push eventigrigorik/videospeed

Ilya Grigorik

commit sha 0389c61db733e86698edc1e1cd5e4298a2777c1d

bump to 0.5.9

view details

push time in a month

delete tag igrigorik/videospeed

delete tag : v0.5.9

delete time in a month

pull request commentigrigorik/videospeed

Formatted code using prettier formatter (prettier.io) #578

👍

See my comments in #578.

ChadBailey

comment created time in a month

issue commentigrigorik/videospeed

Use prettier for code style guide

I like it. Enforcing a style guide would help eliminate a bunch of unnecessary back-n-forth on nitpick style comments, and consistency is great.

I would suggest we explore two options here:

  1. Setup a PR validation step that runs a check and blocks any PR if it's not formatted correctly
  2. Or, setup a bot to autoformat on commit

Between the two, I think my preference is (1) as it results in less surprises to folks committing code, even though it requires a bit more work from them.

ChadBailey

comment created time in a month

pull request commentigrigorik/vimgolf

Add Sakigw to the list of moderators

Insert triple facepalm here.

http://www.vimgolf.com/sakigw - doesn't turn up an account. http://www.vimgolf.com/Sakigw - does.

Sorry about the noise, can you revert back to cap?

Sakisan

comment created time in a month

pull request commentigrigorik/vimgolf

Add Sakigw to the list of moderators

Sanity check: http://www.vimgolf.com/sakigw — doesn't turn up an account?

Sakisan

comment created time in a month

Pull request review commentigrigorik/vimgolf

Add Sakigw to the list of moderators

   'federicogalassi',   'timvisher',   'udioica',-  'braxler'+  'braxler',+  'Sakigw'

I don't believe it should be a problem, but for consistency can we lowercase?

Sakisan

comment created time in 2 months

issue closedigrigorik/videospeed

Controls are not showing up for vimeo videos

Controls are not showing up for vimeo videos

Tried firefox and chrome on mac.

closed time in 2 months

jakhay

issue commentigrigorik/videospeed

Controls are not showing up for vimeo videos

I believe this is a dupe of https://github.com/igrigorik/videospeed/issues/572, please reopen if this is still an issue with 0.5.9.

jakhay

comment created time in 2 months

issue closedigrigorik/videospeed

speed controller not showing on first page load

I'm using the brave browser and have noticed that the speed controls won't show when I first load a YouTube page. If I click reload they will appear immediately. Has anyone encountered this issue?

closed time in 2 months

jorda0mega

issue commentigrigorik/videospeed

speed controller not showing on first page load

Resolving, please reopen if this is still an issue with 0.5.9.

jorda0mega

comment created time in 2 months

issue commentigrigorik/videospeed

speed controller not showing on first page load

Doh! It was suppose to release (tagged as v0.5.8.1) but looks like it didn't actually hit the store. Just pushed a new v0.5.9 release.

jorda0mega

comment created time in 2 months

created tagigrigorik/videospeed

tagv0.5.9

HTML5 video speed controller (for Google Chrome)

created time in 2 months

delete tag igrigorik/videospeed

delete tag : v0.5.8.1

delete time in 2 months

pull request commentigrigorik/istlsfastyet.com

[WIP] Add HTTP/3 columns

👍

Thinking out loud: we could note the QUIC version supported by some platforms but set level to alert, to indicate that this is a transitionary state. WDYT?

LPardue

comment created time in 2 months

issue commentigrigorik/istlsfastyet.com

Condsider adding an HTTP/3 column

👍

On Mon, Jan 6, 2020, 7:48 AM Lucas Pardue notifications@github.com wrote:

It should probably be a WIP PR until such a time as HTTP/3 is finalized - then it can reflect whether an implementation has mainline support for the singular RFC version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/igrigorik/istlsfastyet.com/issues/203?email_source=notifications&email_token=AAACTHBA3VHSJRNXFLTMYVDQ4NHGVA5CNFSM4KDEXMO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIF26BA#issuecomment-571191044, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACTHEPJJQCOT4R4EEPOCLQ4NHGVANCNFSM4KDEXMOQ .

LPardue

comment created time in 2 months

issue commentigrigorik/istlsfastyet.com

Condsider adding an HTTP/3 column

Agreed, adding H/3 columns makes sense to me. Willing to pull together a PR? I guess the tricky bit here would be to (ideally) canvas and gather current state on our own, prior to publishing — not a strict blocker though.

LPardue

comment created time in 2 months

Pull request review commentigrigorik/videospeed

Apple tv plus

         // Process the DOM nodes lazily         requestIdleCallback(_ => {           mutations.forEach(function(mutation) {-            forEach.call(mutation.addedNodes, function(node) {-              if (typeof node === "function")-                return;-              checkForVideo(node, node.parentNode || mutation.target, true);-            });-            forEach.call(mutation.removedNodes, function(node) {-              if (typeof node === "function")-                return;-              checkForVideo(node, node.parentNode || mutation.target, false);-            });+            switch (mutation.type) {+              case 'childList':+                forEach.call(mutation.addedNodes, function(node) {+                  if (typeof node === "function")+                    return;+                  checkForVideo(node, node.parentNode || mutation.target, true);+                });+                forEach.call(mutation.removedNodes, function(node) {+                  if (typeof node === "function")+                    return;+                  checkForVideo(node, node.parentNode || mutation.target, false);+                });+                break;+              case 'attributes':+                if ((mutation.target.tagName == 'APPLE-TV-PLUS-PLAYER') && (mutation.target.attributes['aria-hidden'].value == "false")) {

Indeed, sorry if I'm being repetitive, but my main question here is whether we can generalize this codepath to be not Apple specific (nothing against Apple, to the contrary :)). Specifically, I was referring to this clause in the if..

mutation.target.tagName == 'APPLE-TV-PLUS-PLAYER'

I think we can drop that and everything should continue to work?

Re, modernize: definitely open to it! Want to start a separate issue with more details on what you have in mind?

jedawson

comment created time in 2 months

pull request commentigrigorik/videospeed

Bugfix/521 plural sight

Yep, makes sense, appreciate your great work on this — thanks for digging in!

I'm on the fence. On the one hand, I'd love for the controller to work in as many places as possible, but at the same time this is a special and advanced code path that we'll have to maintain and explain to users. If we had a few sites where this was necessary, I think it would be an easier call. Perhaps one option here is to sit on this for a while.. and see if we get more pluralsight requests, or find other sites where we need the same pattern? Willing to hear arguments in both directions.

ChadBailey

comment created time in 2 months

pull request commentw3c/perf-security-privacy

chore: disable markdown parsing as spec is HTML

ty @marcoscaceres!

marcoscaceres

comment created time in 2 months

push eventw3c/perf-security-privacy

Marcos Cáceres

commit sha 116fe3b1ae72ce551282ce13dc296fc43914a58a

chore: disable markdown parsing as spec is HTML

view details

Ilya Grigorik

commit sha b38b17dc7c07beb5270be5f23bfb8fc858df40c3

Merge pull request #6 from w3c/marcoscaceres-patch-1 chore: disable markdown parsing as spec is HTML

view details

push time in 2 months

pull request commentigrigorik/videospeed

Bugfix/521 plural sight

I'm glad to hear that LinkedIn updated their implementation. Are you aware of other existing sites where this feature would be useful?

I could see this being a hidden, advanced / power-user option (that would also require a lot of explanation in the menu) but it would be nice to validate that it works and is useful outside of this one instance. For example, out of the currently open bugs where VSC is not working today, would this address any of the issues?

ChadBailey

comment created time in 2 months

created tagigrigorik/videospeed

tagv0.5.8.1

HTML5 video speed controller (for Google Chrome)

created time in 2 months

pull request commentigrigorik/videospeed

Bugfix/521 plural sight

Thanks a lot for the detailed explainer! This is a tricky one..

It's unfortunate that their implementation overrides and resets playback rate, but not an unreasonable thing to do either. My intuition is that we should be disabling the controller on such implementations, instead of trying to monkey patch and override their own behavior.. Otherwise, we're entering into a never ending game of unexpected side effects and gotchas. Case in point, having to manually set rate in the controller will cause trouble when you use different built-in controls on various players.

ChadBailey

comment created time in 2 months

pull request commentigrigorik/videospeed

Create Github Action to upload dev version to chrome web store on push to master

Yep, per https://developer.chrome.com/apps/manifest/version..

  • Version: one to four dot-separated integers identifying the version of this extension
  • Version name: In addition to the version field, which is used for update purposes, version_name can be set to a descriptive version string and will be used for display purposes if present.

We could set version name to the commit hash but version has to be a numeric field. A truncated timestamp is not super helpful imo, so perhaps we could increment the last number?

deef0000dragon1

comment created time in 2 months

issue closedigrigorik/videospeed

Controller Missing w/ JWPlayer

I used Videospeed with a website (Sketchymedical.com) for school that uses JWPlayer (v8.11.10). For almost a year it worked fine. Now I can't see the controller (Flash is disabled + even tried an extension to force HTML5 = no resolution) but my preset keys still work. Only problem is that sometimes when I increase/decrease the speed, I dont know what speed I'm at.

I've tried reseting Chrome settings, uninstalling/re-installing Videoplayer, blocking Flash. It works on Youtube but not with JWPlayer. Note: JWPlayer is an HTML5 playing client

Any help would be appreciated!

closed time in 2 months

nshahzad06

issue commentigrigorik/videospeed

Controller Missing w/ JWPlayer

Should be resolved via https://github.com/igrigorik/videospeed/pull/567

nshahzad06

comment created time in 2 months

issue closedigrigorik/videospeed

extension not working

The controller isn't working.

I think that after I updated chrome yesterday the controller now longer works.

Please help - thank you.

closed time in 2 months

CodyMaldonado

issue commentigrigorik/videospeed

extension not working

Should be resolved via https://github.com/igrigorik/videospeed/pull/567

CodyMaldonado

comment created time in 2 months

push eventigrigorik/videospeed

Timothy Lim

commit sha 23591c6077414f3386b3053a251b1c6bf53b7ed0

Check for both .src and .currentSrc in mutation (#567)

view details

push time in 2 months

PR merged igrigorik/videospeed

Fix VSC not showing

Fixes: #566

The problem was introduced in https://github.com/igrigorik/videospeed/pull/529 in this line https://github.com/igrigorik/videospeed/pull/529/files#diff-e24e9eb38cffaafae22019e36f31a570R171

In testing it looks like the mutation observer can have a blank currentSrc but src is specified, so changing current code to look for both attributes and only add vsc-nosource if both are not found

image

To get extra logging shown above just apply this patch to current master via git apply patch.txt

+1 -1

0 comment

1 changed file

thewheat

pr closed time in 2 months

issue closedigrigorik/videospeed

Controller not showing up on Youtube in a certain situation.

When on a channel's "videos" page(ie https://www.youtube.com/user/LinusTechTips/videos) and I click on a video, the controller doesn't show up. Speed controls work. If I refresh, it shows up normal.

If I disable SPF(using Youtube+) it starts working normal again.

closed time in 2 months

Eisys

pull request commentigrigorik/videospeed

Create Github Action to upload dev version to chrome web store on push to master

@deef0000dragon1 couple of things on this one..

  • I think I need to create an extension first, and then we can update the name here?
  • Could you update this pull with same params as the release-on-tag PR?
  • We do need a version number when we do releases, we can't just push the same version. How would we handle it here? Auto-increment sub-version number (v.0.5.8.[x])?
deef0000dragon1

comment created time in 2 months

pull request commentigrigorik/videospeed

Update chrome-store-upload.yaml to use proper name

Success! image

Awesome work, thank you. In theory, v0.5.8 should be staged in Chrome store now.

I can also include the change that I made that edits the manifest to update the version to the tag version.

That's OK. In practice I have to do some manual updates to the manifest anyway.

deef0000dragon1

comment created time in 2 months

issue commentigrigorik/videospeed

Speed automatically sets to 1.03

Aha! Thanks for tracking this down. Do you know what logic FFZ is using to disable this behavior?

FWIW, I don't think our extension should be overriding this, more just curious how they're preventing this — guessing, by hijacking or monkey patching one of the internal functions on the player?

jwong098

comment created time in 2 months

created tagigrigorik/videospeed

tagv0.5.8

HTML5 video speed controller (for Google Chrome)

created time in 2 months

delete tag igrigorik/videospeed

delete tag : v0.5.8

delete time in 2 months

push eventigrigorik/videospeed

deef

commit sha 9b48bfa7c02869681196bdfe9c74af2cdd0e5956

Update chrome-store-upload.yaml to use proper name (#563) Also add exclude to exclude .git files.

view details

push time in 2 months

PR merged igrigorik/videospeed

Update chrome-store-upload.yaml to use proper name

Also add exclude to exclude .git files.

+2 -2

1 comment

1 changed file

deef0000dragon1

pr closed time in 2 months

IssuesEvent

issue commentigrigorik/videospeed

Speed repeatedly drops to 0.00

Hmm. Do you have any public test URLs?

Benu-Athanasia

comment created time in 2 months

issue closedigrigorik/videospeed

not working on https://pan.baidu.com

im sure the video is HTML5 and this extension runs well on any other web

closed time in 2 months

wangbuyao

issue commentigrigorik/videospeed

not working on https://pan.baidu.com

@wangbuyao @ChadBailey thanks for working on this one.

Closing due to lack of activity but please reopen if there is more to investigate.

wangbuyao

comment created time in 2 months

issue closedigrigorik/videospeed

can't control speed on v.qq.com

there is a videospeed's icon flowed on video but can't control the speed. web adress is v.qq.com

closed time in 2 months

dangerboy1986

issue closedigrigorik/videospeed

video sources skipping

sorry if support requests are not allowed here but i have video speed controller on multiple computers running chrome (all latest version, extensions are synced so ideally they are all running the same ones).

1 out of 3 experiences stuttering when playing videos at 2x from various sources (audio continues to play throughout but video skips/stutters every few seconds). i have 1gbit/1gbit symmetrical internet, am hardwired and the computer having issues is actually the most powerful of the 3 spec-wise by a large margin.

any ideas?

closed time in 2 months

xac1d

issue closedigrigorik/videospeed

No way to hide/blacklist controls on Reddit

I've tried blacklisting all reddit/v.reddit domains but the video controller appears in the middle of the video every time...

closed time in 2 months

alystair

issue closedigrigorik/videospeed

The overlay stays in place

Reproduction methods:

  1. On YouTube, move the overlay to the bottom-right corner, then resize the browser window.

  2. On YouTube, for example, if we first watch a small-width vid (when there are spacers around it in the player), then go to a wide-screen, the overlay doesn't adjust its position.

closed time in 2 months

WofWca

issue commentigrigorik/videospeed

The overlay stays in place

I believe this should be addressed now.

WofWca

comment created time in 2 months

pull request commentigrigorik/videospeed

Reset position of vsc with hotkey

WDYT of extending this to enable https://github.com/igrigorik/videospeed/issues/423? We could provide top left, bottom left as options, maybe?

jaywoozy

comment created time in 2 months

issue closedigrigorik/videospeed

Doesn't Work on Food Network

Anyone know how I can get this to work on the Food Network website?

closed time in 2 months

Benu-Athanasia

issue closedigrigorik/videospeed

Controls on vimeo embed are not accessible after rebuffer?

Example: http://eclassesbyravindra.com/mod/page/view.php?id=288

Works all good at first, but if you accelerate to the point where you cause a rebuffer, you can no longer trigger controller when hovering.

closed time in 2 months

igrigorik

issue closedigrigorik/videospeed

Doesn't work on baltimoreravens.com video player

Can't access the controller in the top left and it starts the videos without sound

closed time in 2 months

evilduck17

issue closedigrigorik/videospeed

Lost all blacklisted sites with latest update

My blacklisted sites have been reset since the extension update today. How can I recover them? I have backups of my Chrome profiles. Is there a file I can get them from?

closed time in 2 months

garyking

issue closedigrigorik/videospeed

Allow to save a default for specific sites

Please allow us to set a default speed for specific sites, so for instance, on YouTube, I'd like to default all videos to 1.50x.

closed time in 2 months

garyking

issue closedigrigorik/videospeed

Whitelist not Blacklist

A whitelist would be a great addition. If you want it only on certain sites it's impossible to do that with the blacklist, since you don't know all the sites you will ever visit. Which is why I think a whitelist makes more sense than a blacklist. I for my part only use it on youtube. Yet it's active on any page that has an embedded video ‒ this is a waste so please replace blacklist with whitelist.

closed time in 2 months

MartinLichtblau

issue commentigrigorik/videospeed

Whitelist not Blacklist

Closing, let's open a new issue to track this.. if there is interest :)

MartinLichtblau

comment created time in 2 months

issue closedigrigorik/videospeed

Javascript error: TypeError: Cannot read property 'remove' of undefined

When opening a page with an iframe, I am getting this javascript error:

TypeError: Cannot read property 'remove' of undefined

It is coming from a script called inject.js, and when I remove the videospeed from Chrome, this error goes away.

closed time in 2 months

biztechprogramming

issue commentigrigorik/videospeed

Javascript error: TypeError: Cannot read property 'remove' of undefined

Please reopen if you can provide more details.

biztechprogramming

comment created time in 2 months

issue closedigrigorik/videospeed

Feature: Add offset to Market

Due to slow human reaction time, there's delay between the user decided to set marker and time marker is actually set.

Is it possible to allow for offset other than current default which is zero? say half a second.

This prevent missing words when jumping back to marker.

Thanks.

closed time in 2 months

ndc168

issue commentigrigorik/videospeed

Feature: Add offset to Market

This is outside of scope of this extension :)

ndc168

comment created time in 2 months

more