profile
viewpoint
Ian Partridge ianpartridge IBM UK Senior cloud engineer @IBM.

apple/swift-corelibs-foundation 4097

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-docker 1116

Docker Official Image packaging for Swift

Evolution-App/iOS 213

Unofficial app for Swift Evolution

Evolution-App/Backend 123

Backend is responsible to provide data to EVOlution App - iOS

dokun1/slackin-swift 32

Invite people to your public slack instance - but in Swift!

ianpartridge/coffeeshop-demo 4

OpenLiberty, Kafka and Reactive are ordering serverless coffee with KEDA

appsody/appsody-buildah 1

A docker image with Appsody CLI installed that can be used for running Appsody with buildah in Tekton pipelines.

Pull request review commentredhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

 def create_deployment(context, app_name, image_ref):     app = App(app_name, context.namespace.name, image_ref)     if not app.is_running():         assert app.install() is True, "Failed to create deployment."+++@then(u'Secret "{secret_name}" does not have key "{secret_key}"')+def check_key_in_secret(context, secret_name, secret_key):+    time.sleep(10)+    openshift = Openshift()+    json_path = f'{{.data.{secret_key}}}'+    if not openshift.get_resource_info_by_jsonpath("secrets", secret_name, context.namespace.name, json_path):+        assert True

Updated, PTAL.

pratikjagrut

comment created time in 29 minutes

pull request commentredhat-developer/service-binding-operator

Add information for test instructions to README.md

@Avni-Sharma: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

Avni-Sharma

comment created time in an hour

pull request commentredhat-developer/service-binding-operator

Fix issue where a ServiceBinding can not be deleted if the backend service has been previously deleted

@qibobo: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

qibobo

comment created time in an hour

Pull request review commentKitura/Kitura-redis

Sorted Set Decimal Support

 branches: # by .swift-version, unless SWIFT_SNAPSHOT is specified. matrix:   include:-    - os: linux

Travis simply will not complete testing on older versions of Mac OS. They need to be removed.

scuml

comment created time in 7 hours

pull request commentKitura/Kitura-redis

Sorted Set Decimal Support

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 2 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' /> No Coverage information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' /> 0.0% Duplication

scuml

comment created time in 14 hours

pull request commentKitura/Kitura-redis

Sorted Set Decimal Support

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 2 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' /> No Coverage information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' /> 0.0% Duplication

scuml

comment created time in 14 hours

pull request commentKitura/Kitura-redis

Sorted Set Decimal Support

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 2 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' /> No Coverage information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' /> 0.0% Duplication

scuml

comment created time in 2 days

created repositorysimpleigh/spookyhash

Node bindings for SpookyHash V2

created time in 2 days

push eventredhat-developer/service-binding-operator

Pratik Jagrut

commit sha 8d2ae041a91fb8e51304277a987339ae9624f22a

Add acceptance test to verrify collection of secrets from secretRef (#809) Signed-off-by: Pratik Jagrut <26519653+pratikjagrut@users.noreply.github.com>

view details

push time in 2 days

PR merged redhat-developer/service-binding-operator

Reviewers
Add acceptance test to verify collection of secrets from secretRef approved lgtm

Motivation

https://github.com/redhat-developer/service-binding-operator/issues/808 https://issues.redhat.com/browse/APPSVC-785

+70 -0

4 comments

1 changed file

pratikjagrut

pr closed time in 2 days

pull request commentredhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

@isutton could you please confirm, that this (the acceptance scenario) is expected behavior? Thanks

pratikjagrut

comment created time in 2 days

pull request commentredhat-developer/service-binding-operator

Add acceptance test to verify collection of secrets from secretRef

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/redhat-developer/service-binding-operator/pull/809#issuecomment-761241880" title="Approved">pmacik</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

pratikjagrut

comment created time in 2 days

Pull request review commentredhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

 def create_deployment(context, app_name, image_ref):     app = App(app_name, context.namespace.name, image_ref)     if not app.is_running():         assert app.install() is True, "Failed to create deployment."+++@then(u'Secret "{secret_name}" does not have key "{secret_key}"')+def check_key_in_secret(context, secret_name, secret_key):+    time.sleep(10)+    openshift = Openshift()+    json_path = f'{{.data.{secret_key}}}'+    if not openshift.get_resource_info_by_jsonpath("secrets", secret_name, context.namespace.name, json_path):+        assert True

You don't need to assert True that is like a nop or effectively empty line... The assertion here should be only for the False case, also the failure message should explain more precisely, what went wrong - something like:

assert openshift.get_resource_info_by_jsonpath("secrets", secret_name, context.namespace.name, json_path) is None, f"Secret '{secret_name}' must not have key '{secret_key}'"
pratikjagrut

comment created time in 2 days

created repositoryweissi/fake-package

created time in 2 days

push eventapple/swift-community-hosted-continuous-integration

Ron Olson

commit sha bb77cc67362223e265c6e644d6a29c31fe5e6f14

Added Fedora Rawhide

view details

Mishal Shah

commit sha 8a1ca80a0ebb8accffe7bbe753a4a770b6cc1390

Merge pull request #36 from tachoknight/main Added Fedora Rawhide

view details

push time in 2 days

PR merged apple/swift-community-hosted-continuous-integration

Added Fedora Rawhide

Also updated the list of Fedora versions in the README.md file

+20 -1

0 comment

2 changed files

tachoknight

pr closed time in 2 days

PR opened apple/swift-community-hosted-continuous-integration

Added Fedora Rawhide

Also updated the list of Fedora versions in the README.md file

+20 -1

0 comment

2 changed files

pr created time in 2 days

issue openedredhat-developer/service-binding-operator

Respect casing in service.binding/name annotations

It seems all generated secret properties are uppercase so:

service.binding/database: path...

will result in a property named DATABASE and not database. It would be nice to respect the casing defined in the annotation or have a way to control it because some runtimes (e.g Quarkus) search for properties in a case sensitive way. Thanks!

created time in 3 days

issue openedredhat-developer/service-binding-operator

Allow constant values in service.binding/name annotations in CRD

It would be cool to allow constant values in annotations so something like

service.binding/provider: postgresql

For example, the provider and type entries are recommended and can be the same across all underlying CR which warrants them to be constants. This also facilitates ad-hoc fixes. Thanks !

created time in 3 days

pull request commentredhat-developer/service-binding-operator

Add acceptance test to verify collection of secrets from secretRef

Codecov Report

Merging #809 (d132694) into master (f40c136) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files          25       25           
  Lines        1906     1906           
=======================================
  Hits         1158     1158           
  Misses        577      577           
  Partials      171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f40c136...d132694. Read the comment docs.

pratikjagrut

comment created time in 3 days

pull request commentredhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

Codecov Report

Merging #842 (647d959) into master (42b7e92) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   60.74%   60.75%   +0.01%     
==========================================
  Files          25       25              
  Lines        1908     1906       -2     
==========================================
- Hits         1159     1158       -1     
+ Misses        578      577       -1     
  Partials      171      171              
Impacted Files Coverage Δ
pkg/controller/servicebinding/binder.go 50.00% <0.00%> (-0.16%) :arrow_down:
pkg/controller/servicebinding/common.go 17.39% <0.00%> (ø)
pkg/controller/servicebinding/reconciler.go 73.13% <0.00%> (ø)
pkg/controller/servicebinding/sbrcontroller.go 45.02% <0.00%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42b7e92...647d959. Read the comment docs.

pratikjagrut

comment created time in 3 days

pull request commentredhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign ldimaggi after the PR has been reviewed. You can assign the PR to them by writing /assign @ldimaggi in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["ldimaggi"]} -->

pratikjagrut

comment created time in 3 days

PR opened redhat-developer/service-binding-operator

Add acceptance test to verify key in a secret

Motivation

This PR is to verify the scenario in #838.

+75 -0

0 comment

2 changed files

pr created time in 3 days

push eventredhat-developer/service-binding-operator

Avni Sharma

commit sha f40c1365ee3f77487fb86ae2f786ca7d1ded1974

Remove unwanted broken links and fix annotations in the SBO User Guide (#829) Signed-off-by: Avni Sharma <16avnisharma@gmail.com>

view details

push time in 3 days

PR merged redhat-developer/service-binding-operator

Reviewers
Remove unwanted broken links and fix annotations in the SBO User Guide approved lgtm

Motivation: Broken links in SBO User Guide Rename SBO User Guide.md to SBO_User_Guide.md Fix #823

+30 -49

5 comments

2 changed files

Avni-Sharma

pr closed time in 3 days

issue closedredhat-developer/service-binding-operator

Links to user guides in README are out of date

Coming back to this after a few months to see where the project is ... the links in the README are broken:

User guide

Application Workload Author's Guide Backing Service Provider Best Practices Guide

  • https://github.com/redhat-developer/service-binding-operator/blob/master/docs/application-author.md
  • https://github.com/redhat-developer/service-binding-operator/blob/master/docs/BackingServiceBestPractices.md

Neither of these exist .. I think https://github.com/redhat-developer/service-binding-operator/blob/master/docs/SBO%20User%20Guide.md is inteded to replace both of them?

closed time in 3 days

durera

Pull request review commentredhat-developer/service-binding-operator

Bind a single app and a particular db instance with multiple sbrs

+@olm+Feature: Bind a single application to multiple SBRs++    As a user of Service Binding operator+    I want to bind a single application to multiple SBRs++    Background:+        Given Namespace [TEST_NAMESPACE] is used+        * Service Binding Operator is running+        * PostgreSQL DB operator is installed++    Scenario: Bind a single db instance by creating 2 SBRs to a single application

So, we speak about binding application to single service? Thus, this scenario should be moved to bindAppToService.feature

Also, let's describe better how this scenario is different from others we have already. From the applied steps, it looks like that we apply to the cluster two identical service bindings. Such action should be idempotent - the outcome should be equal to the scenario when just single service binding is applied.

Also, please consider replacing DB service with mocked one, and using generic test application, to make the test lighter. That would allow us to proper assert expectations, i.e. how application context looks like.

Avni-Sharma

comment created time in 3 days

Pull request review commentredhat-developer/service-binding-operator

Bind a single app and a particular db instance with multiple sbrs

+@olm+Feature: Bind a single application to multiple SBRs++    As a user of Service Binding operator+    I want to bind a single application to multiple SBRs

This is not a new feature, it is either binding application to single or multiple services.

Avni-Sharma

comment created time in 3 days

more