hzoo ( Henry Zhu )

Remove remaining `lodash` dependencies

💻

[ ] Would you like to work on a fix?

How are you using Babel?

Other (Next.js, Gatsby, vue-cli, ...)

Input code

https://babeljs.io/docs/babel-standalone 404

Configuration file name

No response

Configuration

No response

Current and expected behavior

https://babeljs.io/docs/babel-standalone 404

Environment

https://babeljs.io/docs/babel-standalone 404

Possible solution

No response

Additional context

No response

created time in 4 hours

release minbrowser/min

v1.20.0

min-1.20.0-1.x86_64.rpm 64.17MB

min-1.20.0-setup.exe 82.61MB

Min-v1.20.0-darwin-arm64.zip 83.91MB

Min-v1.20.0-darwin-x64.zip 80.15MB

Min-v1.20.0-win32-x64.zip 84.83MB

min_1.20.0_amd64.deb 57.85MB

min_1.20.0_arm64.deb 57.73MB

released time in 7 hours

pull request commentbabel/babel

The base package.json is used for internal scripts (it's not published), probably we still use lodash in them.

nicolo-ribaudo

comment created time in 9 hours

pull request commentbabel/babel

Remove remaining `lodash` dependencies

@nicolo-ribaudo Nice :) Does this mean that lodash can be removed from the base directory's package.json, or is that kept in place for stability/other reasons?

nicolo-ribaudo

comment created time in 9 hours

Pull request review commentbabel/website

 $ npm install @babel/plugin-syntax-pipeline-operator  ### With a configuration file (Recommended) +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/):+ ```json {-  "plugins": ["@babel/plugin-syntax-pipeline-operator"]+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "minimal" } ]+  ] } ``` -### Via CLI+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -```sh-$ babel --plugins @babel/plugin-syntax-pipeline-operator script.js+```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "fsharp" } ]+  ]+}+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "hack", "topicToken": "%" } ]+  ]+}+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "hack", "topicToken": "#" } ]+  ]+} ``` +### Via CLI++Because this plugin requires a configuration option, it [cannot be directly configured from the CLI](https://github.com/babel/babel/issues/4161). Use a [config file](/docs/en/config-files) instead with the CLI, to add and configure this plugin.+ ### Via Node API +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/):++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "minimal" } ],+  ],+});+```++For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/):+ ```javascript require("@babel/core").transformSync("code", {-  plugins: ["@babel/plugin-syntax-pipeline-operator"]+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "fsharp" } ],+  ], }); ``` +For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "hack": topicToken: "%" } ],

    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "hack", topicToken: "%" } ],

js-choi

comment created time in 10 hours

Pull request review commentbabel/website

 $ npm install --save-dev @babel/plugin-proposal-pipeline-operator } ``` -The Pipeline Proposal is one of three competing implementations. Which implementation the plugin should use is configured with the `"proposal"` option. This option is required and should be one of:+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -- `"minimal"` – [Minimal Pipeline](https://github.com/tc39/proposal-pipeline-operator/)-- `"smart"` - [Smart Pipeline](https://github.com/js-choi/proposal-smart-pipelines) - Added in `v7.3.0`-- `"fsharp"` - [F#-Style Pipeline](https://github.com/valtech-nyc/proposal-fsharp-pipelines) - Added in `v7.5.0`+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "fsharp" }]+  ]+}+``` -When one of the implementations is accepted, it will become the default and the `"proposal"` option will no longer be required.+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token: -### Via CLI+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack", "topicToken": "%" }]+  ]+}+``` -```sh-$ babel --plugins @babel/plugin-proposal-pipeline-operator script.js+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack": "topicToken": "#" }]+  ]+} ``` +### Via CLI++Because this plugin requires a configuration option, it [cannot be directly configured from the CLI](https://github.com/babel/babel/issues/4161). Use a [config file](/docs/en/config-files) instead with the CLI, to add and configure this plugin.+ ### Via Node API +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/)<br>`{proposal: "minimal"}`:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" } ],+  ],+});+```++For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/):++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "fsharp" } ],+  ],+});+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "hack": topicToken: "%" } ],

Oh sorry, I meant that there are more than one. Maybe I wasn't clear enough.

    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "hack", topicToken: "%" } ],

js-choi

comment created time in 10 hours

Pull request review commentbabel/website

 $ npm install --save-dev @babel/plugin-proposal-pipeline-operator } ``` -The Pipeline Proposal is one of three competing implementations. Which implementation the plugin should use is configured with the `"proposal"` option. This option is required and should be one of:+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -- `"minimal"` – [Minimal Pipeline](https://github.com/tc39/proposal-pipeline-operator/)-- `"smart"` - [Smart Pipeline](https://github.com/js-choi/proposal-smart-pipelines) - Added in `v7.3.0`-- `"fsharp"` - [F#-Style Pipeline](https://github.com/valtech-nyc/proposal-fsharp-pipelines) - Added in `v7.5.0`+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "fsharp" }]+  ]+}+``` -When one of the implementations is accepted, it will become the default and the `"proposal"` option will no longer be required.+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token: -### Via CLI+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack", "topicToken": "%" }]+  ]+}+``` -```sh-$ babel --plugins @babel/plugin-proposal-pipeline-operator script.js+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack": "topicToken": "#" }]+  ]+} ``` +### Via CLI++Because this plugin requires a configuration option, it [cannot be directly configured from the CLI](https://github.com/babel/babel/issues/4161). Use a [config file](/docs/en/config-files) instead with the CLI, to add and configure this plugin.+ ### Via Node API +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/)<br>`{proposal: "minimal"}`:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" } ],+  ],+});+```++For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/):++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "fsharp" } ],+  ],+});+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "hack": topicToken: "%" } ],+  ],+});+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:+ ```javascript require("@babel/core").transformSync("code", {   plugins: [-    [-      "@babel/plugin-proposal-pipeline-operator",-      {-        proposal: "minimal",-      },-    ],+    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "hack": topicToken: "#" } ],

    [ "@babel/plugin-proposal-pipeline-operator", { proposal: "hack", topicToken: "#" } ],

js-choi

comment created time in 10 hours

Pull request review commentbabel/website

 $ npm install --save-dev @babel/plugin-proposal-pipeline-operator } ``` -The Pipeline Proposal is one of three competing implementations. Which implementation the plugin should use is configured with the `"proposal"` option. This option is required and should be one of:+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -- `"minimal"` – [Minimal Pipeline](https://github.com/tc39/proposal-pipeline-operator/)-- `"smart"` - [Smart Pipeline](https://github.com/js-choi/proposal-smart-pipelines) - Added in `v7.3.0`-- `"fsharp"` - [F#-Style Pipeline](https://github.com/valtech-nyc/proposal-fsharp-pipelines) - Added in `v7.5.0`+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "fsharp" }]+  ]+}+``` -When one of the implementations is accepted, it will become the default and the `"proposal"` option will no longer be required.+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token: -### Via CLI+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack", "topicToken": "%" }]+  ]+}+``` -```sh-$ babel --plugins @babel/plugin-proposal-pipeline-operator script.js+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack": "topicToken": "#" }]

    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack", "topicToken": "#" }]

js-choi

comment created time in 10 hours

Pull request review commentbabel/website

 $ npm install @babel/plugin-syntax-pipeline-operator  ### With a configuration file (Recommended) +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/):+ ```json {-  "plugins": ["@babel/plugin-syntax-pipeline-operator"]+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "minimal" } ]+  ] } ``` -### Via CLI+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -```sh-$ babel --plugins @babel/plugin-syntax-pipeline-operator script.js+```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "fsharp" } ]+  ]+}+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "hack", "topicToken": "%" } ]+  ]+}+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```json+{+  "plugins": [+    [ "@babel/plugin-syntax-pipeline-operator", { "proposal": "hack", "topicToken": "#" } ]+  ]+} ``` +### Via CLI++Because this plugin requires a configuration option, it [cannot be directly configured from the CLI](https://github.com/babel/babel/issues/4161). Use a [config file](/docs/en/config-files) instead with the CLI, to add and configure this plugin.+ ### Via Node API +For [minimal F# pipes](https://github.com/tc39/proposal-pipeline-operator/):++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "minimal" } ],+  ],+});+```++For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/):+ ```javascript require("@babel/core").transformSync("code", {-  plugins: ["@babel/plugin-syntax-pipeline-operator"]+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "fsharp" } ],+  ], }); ``` +For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "hack": topicToken: "%" } ],+  ],+});+```++For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `#` topic token:++```javascript+require("@babel/core").transformSync("code", {+  plugins: [+    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "hack": topicToken: "#" } ],

    [ "@babel/plugin-syntax-pipeline-operator", { proposal: "hack", topicToken: "#" } ],

js-choi

comment created time in 10 hours

pull request commentbabel/babel

We should write a note in the docs that if someone cares about the exact number of ticks in await they need to make sure to enable transform-async-to-generator.

nicolo-ribaudo

comment created time in 15 hours

pull request commentbabel/babel

It seems like the compiled code works in Node.js >= 12 but not in Node.js 10 :thinking:

nicolo-ribaudo

comment created time in 16 hours

pull request commentbabel/babel

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e69eff745cc51cef3896b3aa7293ff1dc45f682b:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

nicolo-ribaudo

comment created time in 16 hours

pull request commentbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46995/

nicolo-ribaudo

comment created time in 16 hours

PR opened babel/babel

Fix `_step.value` acces in `for await` PR: Bug Fix :bug: Spec: Async Generators

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q	A <!--(Can use an emoji 👍) -->
Fixed Issues?	Fixes https://github.com/babel/babel/issues/13490
Patch: Bug Fix?	Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link	<!-- If only readme change, add `[skip ci]` to your commits -->
Any Dependency Changes?
License	MIT

The relevant spec tests are 6.d-6.f of 14.7.5.7 ForIn/OfBodyEvaluation.

+108 -25

1 commit in nicolo-ribaudo/babel/tree/for-await-extra-tick babel/babel/tree/main

0 comment

13 changed files

pr created time in 16 hours

issue commentbabel/babel

While working on a fix, I found another bug:

let resolve;
let promise = new Promise((r) => (resolve = r));
let iterable = {
  [Symbol.asyncIterator]() {
    return {
      next() {
        return Promise.resolve({
          get value() { throw new Error("ERR") },
          done: true
        });
      },
    };
  },
};


(async () => {
  for await (let value of iterable) {
    console.log(value);
  }
})();

When compiled, this code throws.

danieltroger

comment created time in 16 hours

issue commentbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

A slightly simplified example:

let resolve;
let promise = new Promise((r) => (resolve = r));
let iterable = {
  [Symbol.asyncIterator]() {
    return {
      next() {
        return promise;
      },
    };
  },
};

(async () => {
  for await (let value of iterable) {
    console.log(value);
  }
})();

(async function () {
  resolve({ value: 0, done: false });
  promise = new Promise((r) => (resolve = r));

  await null;
  resolve({ value: 1, done: false });
  promise = new Promise((r) => (resolve = r));

  resolve({ value: undefined, done: true });
})();

This happens even without compiling async functions (compiling for await is enough to see the bug).

repl (copy/parse the input and output in the console to see the actual and expected results)

If I replace await null with await null; await null it works, so there is an extra tick somewhere in the for await compiled code.

danieltroger

comment created time in 17 hours

issue commentbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

But you just need any configuration

For example this without any config file: babel --presets @babel/preset-env --plugins @babel/plugin-transform-runtime index.js -o dist/babel.js and then comparing node index.js and node dist/babel.js

danieltroger

comment created time in 17 hours

issue commentbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

@kdy1 SWC has the same issue FYI. But I'll wait for babel telling me whether this is a bug or actually impossible to transpile before opening an issue with SWC.

danieltroger

comment created time in 17 hours

issue commentbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

Hey @danieltroger! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

danieltroger

comment created time in 17 hours

issue openedbabel/babel

[Bug]: transpiled `for await` has different behavior than untranspiled `for await`

💻

[ ] Would you like to work on a fix?

How are you using Babel?

Other (Next.js, Gatsby, vue-cli, ...)

Input code

let resolve;
let promise = new Promise((r) => (resolve = r));
let iterable = {
  [Symbol.asyncIterator]() {
    return {
      next() {
        return promise;
      },
    };
  },
};

(async () => {
  for await (let value of iterable) {
    console.log(value);
  }

  // let iterator = iterable[Symbol.asyncIterator]();
  // while (true) {
  //   let result = await http://iterator.next();
  //   if (result.done) {
  //     break;
  //   }
  //   console.log(result.value);
  // }
})();

(async function () {
  for (let v of [0, 1]) {
    await null;
    let oldresolve = resolve;
    promise = new Promise((r) => (resolve = r));
    oldresolve({ value: v, done: false });
  }
  resolve({ value: undefined, done: true });
})();

Configuration file name

No response

Configuration

I think it's this? But you just need any configuration that correctly loads regenerator runtime and transpiles async functions. I tried to load babel-plugin-transform-runtime or something to make it load in the REPL but the REPL just showed error messages, sorry.

Please set target to ie 11.

{
  "presets": ["@babel/preset-typescript", "@parcel/babel-preset-env"],
  "plugins": [
    ["@parcel/babel-plugin-transform-runtime"],
    ["@babel/plugin-proposal-private-methods", { "loose": true }],
    ["@babel/plugin-proposal-class-properties", { "loose": true }],
  ],
};

Current and expected behavior

Running the untranspiled code yields this output:

0
1

Running the transpiled code yields this output:

Environment

Babel 7.14.5 (@babel/core 7.14.6)
Node v16.3.0
npm 7.15.1
macOS 10.15.7 (19H1217)

Possible solution

Make the transpiled code behave/output the same as the untranspiled code.

Additional context

If you replace the for await loop with the commented out while loop the transpiled code behaves as expected.

Kudos to @mischnic for simplified repro code.

created time in 17 hours

push eventbabel/babel

Terence Ng

commit sha 9cbe283bb8f0d879130db814198e7d7bca86dceb

chore: fix comment typo (#13485) * chore: fix comment typo * chore: regenerate tsconfig file Co-authored-by: terencekhwu <[email protected]>

view details

push time in 19 hours

PR merged babel/babel

chore: fix comment typo PR: Internal :house:

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q	A <!--(Can use an emoji 👍) -->
Fixed Issues?	No <!-- remove the (`) quotes and write "Fixes" before the number to link the issues -->
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	Correct a typo in comment
Tests Added + Pass?	N/A
Documentation PR Link	<!-- If only readme change, add `[skip ci]` to your commits -->
Any Dependency Changes?	No
License	MIT

+2 -2

2 commit in hyaocuk/babel/tree/main babel/babel/tree/main

4 comments

2 changed files

hyaocuk

pr closed time in 19 hours

Pull request review commentbabel/website

 $ npm install --save-dev @babel/plugin-proposal-pipeline-operator } ``` -The Pipeline Proposal is one of three competing implementations. Which implementation the plugin should use is configured with the `"proposal"` option. This option is required and should be one of:+For [F# pipes with `await`](https://github.com/valtech-nyc/proposal-fsharp-pipelines/): -- `"minimal"` – [Minimal Pipeline](https://github.com/tc39/proposal-pipeline-operator/)-- `"smart"` - [Smart Pipeline](https://github.com/js-choi/proposal-smart-pipelines) - Added in `v7.3.0`-- `"fsharp"` - [F#-Style Pipeline](https://github.com/valtech-nyc/proposal-fsharp-pipelines) - Added in `v7.5.0`+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "fsharp" }]+  ]+}+``` -When one of the implementations is accepted, it will become the default and the `"proposal"` option will no longer be required.+For [Hack pipes](https://github.com/js-choi/proposal-hack-pipes/) with `%` topic token: -### Via CLI+```json+{+  "plugins": [+    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack": "topicToken": "%" }]

    ["@babel/plugin-proposal-pipeline-operator", { "proposal": "hack", "topicToken": "%" }]

There are a few like this :)

js-choi

comment created time in 21 hours

push eventbabel/babel

Tony Gorez

commit sha 101249f3aa4b5f4326981e50c4ff7164aa4e6dd4

refactor(parser): remove refNeedsArrowPos (#13419) * fix(parser:expression): remove refNeedsArrowPos in parseExprListItem * feat: use refExpressionErrors to catch optional parameters * feat: delete useless refNeedArrowPos * fix: forgotten deletion * fix: lint and factorize * fix: delete useless comment * fix: review corrections * fix: review corrections pt2 * fix: review correction pt2 * fix: nit correction * fix: update types * Update packages/babel-parser/src/parser/util.js * fix: add invariant comment in flow and ts file Co-authored-by: Nicolò Ribaudo <[email protected]>

view details

push time in 21 hours

PR merged babel/babel

refactor(parser): remove refNeedsArrowPos PR: Internal :house: pkg: parser

Q
Fixed Issues?	⛔
Patch: Bug Fix?	⛔
Major: Breaking Change?	⛔
Minor: New Feature?	⛔
Tests Added + Pass?	👍
Documentation PR Link	⛔
Any Dependency Changes?	⛔
License	MIT

Hey @JLHwung 👋

Following your comment on my previous PR, I open this draft PR. Let me know If I'm wrong or If I misunderstand something.

🚀

+78 -79

13 commit in tony-go/babel/tree/remove-refNeedsArrowPos-in-parseExprListItem babel/babel/tree/main

13 comments

4 changed files

tony-go

pr closed time in 21 hours

issue commentbabel/babel

refactor(parser): remove refNeedsArrowPos

Where did you find that link? The correct one is https://babeljs.io/docs/en/babel-standalone

Rainmen-xia

comment created time in 21 hours

Pull request review commentbabel/babel

 export default (superClass: Class<Parser>): Class<Parser> =>           state,         ); -        if (!arrow.error && !arrow.aborted) return arrow.node;+        if (!arrow.error && !arrow.aborted && arrow.node) return arrow.node;

All these checks that I add (in ts and flow file) came from this

But during review correction I only updated what you point, I should have pass on all the code to add an invariant comment on simillary cases.

Sorry for that

tony-go

comment created time in a day

issue commentbabel/babel

Hey @Rainmen-xia! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

Rainmen-xia

comment created time in a day

issue openedbabel/babel