profile
viewpoint
Héctor Ramos hramos @facebook Bay Area, CA https://hectorramos.com React Native at @facebook.

hramos/helpscout 36

HelpScout API gem

hramos/CIStatusBoard 3

Barebones status board for tracking a given project's CI status.

hramos/parse_resource 3

A Ruby wrapper for Parse.com's REST API

hramos/AFNetworking 2

A delightful iOS networking library with NSOperations and block-based callbacks

hramos/buildevents 2

A small helper to generate Honeycomb traces from CI builds

hramos/observing_plans 2

Astronomical observing plans for use with remote observatories

hramos/octopress-www.hectorramos.com 2

Octopress is an obsessively designed framework for Jekyll blogging. It’s easy to configure and easy to deploy. Sweet huh?

hramos/.github 1

This is a sample repository that demonstrates various GitHub features.

hramos/Apollo-11 1

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.

push eventfacebook/react-native-website

Héctor Ramos

commit sha c37532703e857885c8d3d7f15f8877db1a6ec076

Add Appearance module documentation (#1600)

view details

push time in 6 minutes

pull request commentfacebook/react-native-website

⚫️ Dark Mode: Add Appearance module documentation

Hope it's ok if I merge this! I want to make sure it's documented in 0.62.

hramos

comment created time in 6 minutes

PR merged facebook/react-native-website

⚫️ Dark Mode: Add Appearance module documentation Partner RN Team p: Facebook

⬛️ Documents the Appearance module that was added back in August 2019 in https://github.com/facebook/react-native/commit/63fa3f21c5ab308def450bffb22054241a8842ef#diff-66ff56fe20c3cf9819920211fb38c9bc, and which will be part of the upcoming 0.62 release.

🌑 The Appearance API has been used by Instagram in production since October 2019 when they launched Dark theme and Dark Mode support in their Android and iOS apps.

Screen Shot 2020-02-05 at 2 50 07 PM

Screen Shot 2020-02-05 at 2 50 11 PM

🌚 Trivial: removed unnecessary space in Dimensions doc.

Test Plan:

yarn
cd website
yarn start

🖤 Prettier applied some changes as part of the pre-commit hook, which I am including in this PR.

+84 -1

2 comments

4 changed files

hramos

pr closed time in 6 minutes

push eventhramos/react-native-website

Mark Cui Pan

commit sha 95993d91be632ac4fc5d84873b407e0cea63c643

Correct mistakes in flexDirection description (#1548) The current descriptions of the behavior for 'column' and 'column-reverse' when wrapping is enabled are incorrect. They state that the next line will start to the left of the first line. This PR edits these descriptions to say that the next line will start to the _right_ of the first line.

view details

Satyajit Sahoo

commit sha 32f2608d502c4819aa53a5f0ff992a07df19bf69

Update docs for React Navigation 5 (#1578) * Update docs for React Navigation 5 * Update navigation.md tweaks Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Bartosz Kaszubowski

commit sha 1f098297db3b9a256395499ab826fc154833e10b

deprecation indicator and deprecation notes standardization (#1493) * deprecation indicator and deprecation notes standardization * update few more pages * update ProgressBarAndroid and ProgressViewIOS

view details

Dani Akash

commit sha b8916d50859de4bda60c3f611e50423a760e7848

DatePickerIOS - Added Snack Examples 🍿 (#1583) * DatePickerIOS - Added Snack Examples * Update datepickerios.md Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code * removed unused import statements Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Abraham Nnaji

commit sha 343ef6a2543c130e4c849b6043e9fc687d014af5

Added Snack example for KeyboardAvoidingView #1579 (#1606) * Added Snack example for KeyboardAvoidingView * Update keyboardavoidingview.md PRettifying the code Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Mohamed Abdel Nasser

commit sha c54779d19965d8528720ead1c8a1a85f2f2b2b6f

[DOC]: API Reference for DevSettings.addMenuItem() #1523 (#1539) * started doc addMenuItem * added API reference DevSettings * Update DevSettings API reference * Update docs/devsettings.md Co-Authored-By: Ricky <rickhanlonii@gmail.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>

view details

Kaio Duarte

commit sha 97daecbc30eb0ad4e87cc239807d1f145dab24d9

TouchableOpacity: update Snack example (#1596) * update TouchableOpacity Snack example * Update touchableopacity.md Ensuring that the old class example is still there. Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Jesse Katsumata

commit sha 3a52744042f12a18e81a88f57201d5d9b6e1a1c3

docs: add deprecation notice for clipboard (#1608) * docs: add deprecation notice for clipboard * chore: add emoji to clipboard title

view details

Pablo Espinosa

commit sha 9dbe637d81ccf9b2ba57418c1452e6e2e63dbd35

TextInput: Added new docs for PasswordRules Prop (#1615) Most of this was taken from here https://github.com/facebook/react-native/pull/25407

view details

Jesse Katsumata

commit sha e725a96b893183e1ed92bc7ca20438852d335468

docs: update url for progress bar android and progress view (#1618)

view details

Jesse Katsumata

commit sha 8d002403b9cf59ddb5bb5f7d1b580632c470f1e3

docs: consistency for optional properties (#1621)

view details

Jesse Katsumata

commit sha c6d1d2d89ba84bbe7474f8264bf31f09e25eeba7

docs: remove unused prop from TextInput docs (#1584)

view details

Ronny

commit sha 9fc1183974b6bd09def8085993159105f6031323

ActivityIndicator: add snackplayer/functional component with ho… (#1590) * added snackplayer/functional component with hooks * update docs * restore changes * PR updates * Update activityindicator.md Prettifying the code Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Damian Sznajder

commit sha 2680f59d046cea66794562a8f772606b596e78b2

Button: Update code snippet and example (#1592) * Update Button code snippet * Update button.md Prettify that code Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Kaio Duarte

commit sha 7985a601d972dfba5ed0e816c8b9ba711d40c1a5

Switch: update Snack example (#1594) * update Switch Snack example * Update switch.md Moving styles into the bottom Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Damian Sznajder

commit sha ebdf71f765e0823efd2168fb53083337dfffc262

TouchableHighlight: Update API and Snack to functional componen… (#1591) * Update TouchableHighlight example and API * Update touchablehighlight.md - Prettifying code. - Tweaking example to include toggler. * Update touchablehighlight.md Example didn't work for a stray `this`! Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Kaio Duarte

commit sha 724057f9a992c3e1bded353b6731a58ca358b37d

Picker: update Snack example (#1595) * update Picker Snack example * Update picker.md Prettifying code, shifting styles to bottom Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Dani Akash

commit sha f5e0fcab07e35eb4982d63f7966a1c1201694898

🍿 Added Snack Examples for the Alert 🚨 module (#1597) * Alert - Added Snack Examples * Update alert.md Prettifying the code! * Update alert.md Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Luis Miguel Alvarado

commit sha 823c4f8c3e271953ec3d27c8b25ceb593eee0963

[Docs][New Guide Structure] Join props.md and state.md in the b… (#1114) * remove NavigatorIOS * remove style.md and props.md * add props to Learn The Basics * explain a little better what is happening in HelloWorldApp * Update tutorial.md * add some information to the state * add state example using the player * Update tutorial.md * Update docs/tutorial.md Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * Update docs/tutorial.md Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * Apply suggestions from code review Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * update tutorial.md * Update tutorial.md * fix lint Co-authored-by: Christoph Nakazawa <cpojer@fb.com> Co-authored-by: Nicolas Charpentier <nicolas.charpentier079@gmail.com> Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>

view details

Emanuel Cepoi

commit sha 815fe1046cc429bc9a592444e53ac7eeb2058fef

Added npx prefix to react-native commands within docs (#1636)

view details

push time in 7 minutes

pull request commentfacebook/react-native

iOS: Fix dev menu sometimes not showing

This is failing a Unit Test, testViewManagerNotInitializedBeforeSetBridgeModule.

tido64

comment created time in 2 hours

pull request commentfacebook/react-native

Stamp React Native Version Into C++ Code

Oh, my bad, that file is added in this PR. In any case, we failed to apply the patch internally, usually it's either due to a file that moved or because the PR is based off an older revision and the process timed out (can happen if the base commit is over 3 months old). I'm applying the changes manually on top of HEAD and will push them out. Hold tight.

NickGerleman

comment created time in a day

pull request commentfacebook/react-native

Stamp React Native Version Into C++ Code

@NickGerleman this patch no longer applies on top of master. Looks like ReactCommon/cxxreact/ReactNativeVersion.h no longer exists.

NickGerleman

comment created time in a day

delete branch facebook/react-native

delete branch : 0.62-stable-tmp

delete time in 2 days

pull request commentfacebook/react-native

Make Vibration.vibrate compatible with TurboModules

Imported, but it ran into some issues. I'll look at this again sometime this week.

brunobar79

comment created time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-2

delete time in 2 days

PR closed facebook/react-native

Reviewers
Add simple Detox and empty suite Missing Changelog

Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.

Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!

Test Plan:

Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!

Release Notes:

Help reviewers and the release process by writing your own release notes. See below for an example.

[CATEGORY] [TYPE] [LOCATION] - Message

<!-- INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.

CATEGORY

[----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [ {Component} ] [ INTERNAL ] [ ENHANCEMENT ] [ {Filename} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------|

EXAMPLES:

[IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see -->

+66 -1

1 comment

4 changed files

rufelo

pr closed time in 2 days

delete branch facebook/react-native

delete branch : wix/detox

delete time in 2 days

delete branch facebook/react-native

delete branch : rntester-new-flipper

delete time in 2 days

delete branch facebook/react-native

delete branch : rntester-buck-fix

delete time in 2 days

delete branch facebook/react-native

delete branch : revert/regression-shadow

delete time in 2 days

delete branch facebook/react-native

delete branch : rename-to-rambundle

delete time in 2 days

delete branch facebook/react-native

delete branch : remove-deprecated-countable

delete time in 2 days

delete branch facebook/react-native

delete branch : remove-deprecated-countable-2

delete time in 2 days

delete branch facebook/react-native

delete branch : mats

delete time in 2 days

delete branch facebook/react-native

delete branch : kelset-update-detox-to-9

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-13

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-10

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-11

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-1

delete time in 2 days

delete branch facebook/react-native

delete branch : flipper-rntester-fix

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-7

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-14

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-12

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-9

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-8

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-6

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-5

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-4

delete time in 2 days

delete branch facebook/react-native

delete branch : janicduplessis-patch-3

delete time in 2 days

delete branch facebook/react-native

delete branch : ignore-fixtures-test-n-mocks

delete time in 2 days

delete branch facebook/react-native

delete branch : grabbou-patch-1

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/snapshots

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/snapshots-2

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/rn-tester

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/push-notif

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/packager-start

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/metro-preset-ver

delete time in 2 days

delete branch facebook/react-native

delete branch : fix/date-picker-e2e

delete time in 2 days

delete branch facebook/react-native

delete branch : fix-ios-unit-tests

delete time in 2 days

delete branch facebook/react-native

delete branch : fix-flow-types

delete time in 2 days

delete branch facebook/react-native

delete branch : feat/upgrade-cli

delete time in 2 days

delete branch facebook/react-native

delete branch : feat/ship-cocoapods

delete time in 2 days

delete branch facebook/react-native

delete branch : feat/better-e2e-tests

delete time in 2 days

delete branch facebook/react-native

delete branch : fbjni-fb-split

delete time in 2 days

delete branch facebook/react-native

delete branch : fbjni-fb-split-2

delete time in 2 days

delete branch facebook/react-native

delete branch : fbjni-build-test

delete time in 2 days

delete branch facebook/react-native

delete branch : fbco

delete time in 2 days

delete branch facebook/react-native

delete branch : disallow-invariant

delete time in 2 days

delete branch facebook/react-native

delete branch : bump-detox

delete time in 2 days

delete branch facebook/react-native

delete branch : template-new-flipper

delete time in 2 days

delete branch facebook/react-native

delete branch : pickfirst-removal

delete time in 2 days

delete branch facebook/react-native

delete branch : wip/detox

delete time in 2 days

pull request commentfacebook/react-native

iOS: Fix RCTDevLoadingView not showing up with UIScene

Sorry @tido64, this was reverted in 8c10147ed55ea6d48f9dc8fda24990531b30536b. Appears one of our internal apps ran into the following error:

stderr: React/DevSupport/RCTDevLoadingView.m:99:7: error: unknown type name 'UIWindowScene'; did you mean 'UIWindowLevel'?
      UIWindowScene *scene = (UIWindowScene *)RCTSharedApplication().connectedScenes.anyObject;
      ^~~~~~~~~~~~~
      UIWindowLevel

I'll have to take a look and see why this particular app has this issue.

tido64

comment created time in 2 days

pull request commentfacebook/react-native-website

⚫️ Dark Mode: Add Appearance module documentation

@rachelnabors good catch! I just updated my other PR, https://github.com/facebook/react-native-website/pull/1574, with a Snack example.

Looking at this Appearance PR, I think the Snack can be added later because this API is added in 0.62, which as of this writing has not yet reached stable and therefore it's not supported in Expo or Expo's Snack.

Do you think we can merge this as is, and I can make sure to add the Snack when it's supported? It will likely be based on https://github.com/facebook/react-native/blob/master/RNTester/js/examples/Appearance/AppearanceExample.js, which is linked to from the docs.

hramos

comment created time in 6 days

push eventhramos/react-native-website

Héctor Ramos

commit sha eb2d0877f8390da94b02b473f25a6d23cb5ece58

Add Snack and fix up iOS / Android differences;

view details

push time in 6 days

pull request commentfacebook/react-native

iOS: Fix dev menu sometimes not showing

A unit test failed while trying to land this:

	RNTesterUnitTests:
		-[RCTDevMenuTests testShowCreatingActionSheet]

I can now see that this test also failed here on Circle CI, in the test_ios job: https://circleci.com/gh/facebook/react-native/130989?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

tido64

comment created time in 7 days

delete branch facebook/react-native

delete branch : ios-link-rn-pods-improvements

delete time in 8 days

delete branch facebook/react-native

delete branch : backport-template-fix-android-instacrash

delete time in 8 days

issue commentfacebook/react-native

Push notification token getting stopped for sometimes in iOS

Can you fill out the rest of the issue template? It's not clear from the description what issue you're reporting or how to reproduce it.

nagaraju1121

comment created time in 8 days

issue closedfacebook/react-native

no error ....app crash after launching the app

Description:

Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: http://facebook.github.io/react-native/docs/upgrading.html

React Native version:

Run `react-native info` in your terminal and copy the results here.

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.
Issues without reproduction steps or code are likely to stall.

Expected Results

Describe what you expected to happen.

Snack, code example, screenshot, or link to a repository:

Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

closed time in 8 days

Ratandeep123

issue closedfacebook/react-native

How to change RefreshControl swiping down height in ScrollView

Description:

I want to change the swipe down length for RefreshControl in ScrollView, but there is no option to change swipe down length.

rsz_screenshot_2020-02-19_at_70538_pm

Currently I have to Swipe down too much.

React Native version:

System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz
    Memory: 22.70 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 8.17.0 - /usr/local/opt/node@8/bin/node
    Yarn: 1.21.1 - /usr/local/bin/yarn
    npm: 6.13.4 - /usr/local/opt/node@8/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
  IDEs:
    Android Studio: 3.1 AI-173.4697961
    Xcode: 11.3/11C29 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0 
    react-native: 0.61.4 => 0.61.4 
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-log-ios: 1.0.1

Expected Results

minimum swipe down for RefreshControl.

Snack, code example, screenshot, or link to a repository:

<ScrollView style={{scrollY: 0}} contentContainerStyle={{ flex: 1 , scrollY:30}} showsVerticalScrollIndicator={false} refreshControl={
          <RefreshControl title={'refreshing'} tintColor={'red'} onRefresh={this.onRefresh.bind(this)} refreshing={this.state.refreshing} />
        }>
</ScrollView>

closed time in 8 days

MonarthS

issue commentfacebook/react-native

How to change RefreshControl swiping down height in ScrollView

Closing as this is not a bug.

MonarthS

comment created time in 8 days

pull request commentfacebook/react-native

[NOT RFR] [CI] Add nightly build

This seems fine to me. I think it's alright to merge this, to validate that it will print the message nightly once on master. The actual job can be added on another PR.

sweggersen

comment created time in 9 days

issue closedfacebook/react-native

new Date('01/30/2020') is different on android and ios

Description: new Date('01/30/2020') is NaN for android without debug.

React Native version: npmPackages: react: 16.12.0 => 16.12.0 react-native: 0.61.5 => 0.61.5 npmGlobalPackages: create-react-native-app: 2.0.2 react-native-cli: 2.0.1 react-native-create-library: 3.1.2 react-native-git-upgrade: 0.2.7

Steps To Reproduce

Make console logs:

console.log('01/30/2020')
console.log(new Date('01/30/2020'))

Android with debug or iOS:

LOG  01/30/2020
LOG  2020-01-29T23:00:00.000Z

Android without debug:

 LOG  01/30/2020
 LOG  Date { NaN }

Expected Results

Same as iOS so: 2020-01-29T23:00:00.000Z

closed time in 9 days

Patys

issue commentfacebook/react-native

new Date('01/30/2020') is different on android and ios

React Native uses JavaScriptCore.framework on iOS. Since this is provided by the OS, the specific version is tied to the iOS version. It will differ across iOS 11, iOS 12, and iOS 13 devices. On Android, the JSC version is pinned with each React Native version (or you can use Hermes). Furthermore, when debugging is enabled, your app is using Chrome's JavaScript VM (V8) instead.

The recommendation here is to use a third party date manipulation library instead of relying on the built-in Date, due to the differences in behavior across JavaScript VMs.

Patys

comment created time in 9 days

push eventhramos/react-native-bot

Héctor Ramos

commit sha 94824b39b8882c19635dc6ee962e54e4fc784ae5

Remove no-template autocloser as templateless issues have been disabled

view details

push time in 9 days

pull request commentfacebook/react-native

[Chore] Add links to issue template

Made some tweaks and added a link. This is great!

Naturalclar

comment created time in 9 days

push eventNaturalclar/react-native

Héctor Ramos

commit sha f7ab8d16ca1d7f3fcb7a4158a49eba6d52fdb4de

Update config.yml Disable blank issues and tweak copy.

view details

push time in 9 days

pull request commentfacebook/react-native

[Chore] Add links to issue template

Configuring these as links instead of "dummy templates" is a much better fit for the intended purpose. Thank you! I hadn't heard about this feature, and I always enjoy learning something new in a PR.

Naturalclar

comment created time in 9 days

push eventhramos/react-native

Héctor Ramos

commit sha 36111700f401215e061fd23a1d6427bcad0f6224

Use LTS and LTS-1 Node versions (#28048) Summary: Previous config used Node10 and NodeLTS executors, but the naming wasn't accurate. As of today, Node 12 is LTS, Node 10 is also LTS but entering maintenance in April: https://nodejs.org/en/about/releases/ This PR switches all jobs to use Node 12 as nodelts, and renames test_js_lts to test_js_prevlts to reflect it's use of Node 10 (the previous Node LTS release). The executors are named NodeLTS and NodeLTSPrev. Later this year, we can switch these to use Node 14 and Node 12 as Node 10 goes into maintenance. ## Changelog [Internal] Pull Request resolved: https://github.com/facebook/react-native/pull/28048 Test Plan: Circle CI Reviewed By: TheSavior Differential Revision: D19887240 Pulled By: hramos fbshipit-source-id: a8d553dca0f47a5ab6132a3880830a60a1b28736

view details

radex

commit sha 33717726b9a2c84a360ca5fdd5cbd06f5fced027

Moving towards UIWindowScene support (#28058) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28058 I'm taking the first step towards supporting iOS 13 UIScene APIs and modernizing React Native not to assume an app only has a single window. See discussion here: https://github.com/facebook/react-native/issues/25181#issuecomment-505612941 The approach I'm taking is to take advantage of `RootTagContext` and passing it to NativeModules so that they can identify correctly which window they refer to. Here I'm just laying groundwork. - [x] `Alert` and `ActionSheetIOS` take an optional `rootTag` argument that will cause them to appear on the correct window - [x] `StatusBar` methods also have `rootTag` argument added, but it's not fully hooked up on the native side — this turns out to require some more work, see: https://github.com/facebook/react-native/issues/25181#issuecomment-506690818 - [x] `setNetworkActivityIndicatorVisible` is deprecated in iOS 13 - [x] `RCTPerfMonitor`, `RCTProfile` no longer assume `UIApplicationDelegate` has a `window` property (no longer the best practice) — they now just render on the key window Next steps: Add VC-based status bar management (if I get the OK on https://github.com/facebook/react-native/issues/25181#issuecomment-506690818 ), add multiple window demo to RNTester, deprecate Dimensions in favor of a layout context, consider adding hook-based APIs for native modules such as Alert that automatically know which rootTag to pass ## Changelog [Internal] [Changed] - Modernize Modal to use RootTagContext [iOS] [Changed] - `Alert`, `ActionSheetIOS`, `StatusBar` methods now take an optional `surface` argument (for future iPadOS 13 support) [Internal] [Changed] - Do not assume `UIApplicationDelegate` has a `window` property Pull Request resolved: https://github.com/facebook/react-native/pull/25425 Test Plan: - Open RNTester and: - go to Modal and check if it still works - Alert → see if works - ACtionSheetIOS → see if it works - StatusBar → see if it works - Share → see if it works Reviewed By: PeteTheHeat Differential Revision: D16957751 Pulled By: hramos fbshipit-source-id: 7bbe694c17a490a7ba7b03e5ed31e679e2777b68

view details

push time in 13 days

issue commentfacebook/react-native

Access to iOS Contact list not working

I'm honestly trying to be as courteous as I can be here. The issue you're running into is not coming from React Native. I only had to go through the error you posted above to determine that. Please look into using a dispatch queue to run any code that belongs on the main thread, on the main thread.

lutakyn

comment created time in 14 days

push eventhramos/react-native

Will Holen

commit sha ab3c184555e382b8693cbfcdfe01ba89583ee726

@allow-large-files Upgrade Hermes dependency to 0.4.0 Summary: Use the latest published release of hermes-engine. Changelog: [Android] [Changed] - Upgraded to Hermes 0.4.0 Reviewed By: mhorowitz Differential Revision: D19866355 fbshipit-source-id: be2bed957bc034d3e6107804229abc2d83e40d40

view details

Haozhun Jin

commit sha c55521aac0322f3a07ac1df5859b62f375b7e5d4

Allow non-ASCII std::string argument to detail::toValue Summary: In all other areas of JSI, std::string is treated as potentially containing UTF-8 bytes (instead of ASCII). This fixes the inconsistency. Changelog: [Internal] Reviewed By: mhorowitz Differential Revision: D19871520 fbshipit-source-id: c703f07e10bedbf2518d0bec903f85f43bbcbdf5

view details

Eli White

commit sha 6e3389c82b6899ee3a9162571f7c6f8eab830207

Partial React Sync from 241c4467...349ff315b Summary: Includes these commits: - **[349ff315b](https://github.com/facebook/react/commit/349ff315b )**: [Native] Delete NativeComponent and NativeMethodsMixin (#18036) //<Eli White>// Changelog: [General][Changed] - React Native sync for revisions 241c4467...349ff315b Reviewed By: zackargyle Differential Revision: D19893829 fbshipit-source-id: 77f35d6b7a0ddf375941c3185decf3862b6807a7

view details

Valentin Shergin

commit sha 967c9dc7b1fd5333a4abddf036ed3edff6c061c2

Fabric: `ConcreteShadowNode::getProps()` was renamed to `getConcreteProps()` and got new return type. Summary: Having the overridden function that returns a different type is apparently not a good idea (and might cause bugs and unexpected behavior), so it was renamed. The function also got a new return type (`const &` instead of `std::shared_ptr`) for simplicity, better performance, and smaller code size. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross Differential Revision: D19837694 fbshipit-source-id: b7a96424bd040409371724907b3fb3931cd8a2e8

view details

Valentin Shergin

commit sha 5703abd9535622912b4bf875faecc00d69fef0da

Fabric: Getting rid of `static_pointer_cast` in `ConcreteShadowNode` Summary: `std::static_pointer_cast` has perf overhead where as `static_cast` does not. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D19837695 fbshipit-source-id: 4a257e66813a4a3c757c8ea15ea6ae5e192d1390

view details

radex

commit sha 8ed4e4f70f207ffb5b5915d36859b0ac6c39eb82

Moving towards UIWindowScene support (#28058) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28058 I'm taking the first step towards supporting iOS 13 UIScene APIs and modernizing React Native not to assume an app only has a single window. See discussion here: https://github.com/facebook/react-native/issues/25181#issuecomment-505612941 The approach I'm taking is to take advantage of `RootTagContext` and passing it to NativeModules so that they can identify correctly which window they refer to. Here I'm just laying groundwork. - [x] `Alert` and `ActionSheetIOS` take an optional `rootTag` argument that will cause them to appear on the correct window - [x] `StatusBar` methods also have `rootTag` argument added, but it's not fully hooked up on the native side — this turns out to require some more work, see: https://github.com/facebook/react-native/issues/25181#issuecomment-506690818 - [x] `setNetworkActivityIndicatorVisible` is deprecated in iOS 13 - [x] `RCTPerfMonitor`, `RCTProfile` no longer assume `UIApplicationDelegate` has a `window` property (no longer the best practice) — they now just render on the key window Next steps: Add VC-based status bar management (if I get the OK on https://github.com/facebook/react-native/issues/25181#issuecomment-506690818 ), add multiple window demo to RNTester, deprecate Dimensions in favor of a layout context, consider adding hook-based APIs for native modules such as Alert that automatically know which rootTag to pass ## Changelog [Internal] [Changed] - Modernize Modal to use RootTagContext [iOS] [Changed] - `Alert`, `ActionSheetIOS`, `StatusBar` methods now take an optional `surface` argument (for future iPadOS 13 support) [Internal] [Changed] - Do not assume `UIApplicationDelegate` has a `window` property Pull Request resolved: https://github.com/facebook/react-native/pull/25425 Test Plan: - Open RNTester and: - go to Modal and check if it still works - Alert → see if works - ACtionSheetIOS → see if it works - StatusBar → see if it works - Share → see if it works Reviewed By: PeteTheHeat Differential Revision: D16957751 Pulled By: hramos fbshipit-source-id: 4dae1a8126822038891e3bc3e0aa9640b86dfe66

view details

push time in 14 days

pull request commentfacebook/react-native

[iOS] Moving towards UIWindowScene support

I resolved all conflicts and fixed some Flow issues. I still need to go through our internal apps and update some call sites. You can find an early copy of the internal diff with conflicts resolved in https://github.com/facebook/react-native/pull/28058. When the internal diff gets merged, it should attribute the change back to PR #25425.

radex

comment created time in 14 days

pull request commentfacebook/react-native

[iOS] Moving towards UIWindowScene support

I apologize for the huge delay here. I'm working on getting this merged.

radex

comment created time in 14 days

create barnchhramos/react-native

branch : export-D16957751

created branch time in 14 days

PR opened facebook/react-native

Reviewers
Moving towards UIWindowScene support (#25425)

Summary: I'm taking the first step towards supporting iOS 13 UIScene APIs and modernizing React Native not to assume an app only has a single window. See discussion here: https://github.com/facebook/react-native/issues/25181#issuecomment-505612941

The approach I'm taking is to take advantage of RootTagContext and passing it to NativeModules so that they can identify correctly which window they refer to. Here I'm just laying groundwork.

  • [x] Alert and ActionSheetIOS take an optional rootTag argument that will cause them to appear on the correct window
  • [x] StatusBar methods also have rootTag argument added, but it's not fully hooked up on the native side — this turns out to require some more work, see: https://github.com/facebook/react-native/issues/25181#issuecomment-506690818
  • [x] setNetworkActivityIndicatorVisible is deprecated in iOS 13
  • [x] RCTPerfMonitor, RCTProfile no longer assume UIApplicationDelegate has a window property (no longer the best practice) — they now just render on the key window

Next steps: Add VC-based status bar management (if I get the OK on https://github.com/facebook/react-native/issues/25181#issuecomment-506690818 ), add multiple window demo to RNTester, deprecate Dimensions in favor of a layout context, consider adding hook-based APIs for native modules such as Alert that automatically know which rootTag to pass

Changelog

[Internal] [Changed] - Modernize Modal to use RootTagContext [iOS] [Changed] - Alert, ActionSheetIOS, StatusBar methods now take an optional surface argument (for future iPadOS 13 support) [Internal] [Changed] - Do not assume UIApplicationDelegate has a window property Pull Request resolved: https://github.com/facebook/react-native/pull/25425

Test Plan:

  • Open RNTester and:
  • go to Modal and check if it still works
  • Alert → see if works
  • ACtionSheetIOS → see if it works
  • StatusBar → see if it works
  • Share → see if it works

Reviewed By: PeteTheHeat

Differential Revision: D16957751

Pulled By: hramos

+215 -79

0 comment

19 changed files

pr created time in 14 days

issue openedfacebook/react-native

[CI] Test failure: test_js_e2e

Tracking a test failure in Circle CI in the test_js_e2e job.

Repro Steps:

nvm install 8
yarn
node ./scripts/run-ci-e2e-tests.js --js

Error:

yarn run v1.22.0
$ /private/tmp/react-native-XsZVUnTl/template/node_modules/.bin/react-native bundle --entry-file index.js --platform android --dev true --bundle-output android-bundle.js --max-workers 1
                 Welcome to React Native!
                Learn once, write anywhere


error Cannot find module './Libraries/polyfills/console.js'
Require stack:
- /private/tmp/react-native-XsZVUnTl/template/rn-get-polyfills.js
- /private/tmp/react-native-XsZVUnTl/template/metro.config.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/import-fresh/index.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/cosmiconfig/dist/loaders.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/cosmiconfig/dist/createExplorer.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/cosmiconfig/dist/index.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/node_modules/@react-native-community/cli/build/tools/config/readConfigFromDisk.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/node_modules/@react-native-community/cli/build/tools/config/index.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/node_modules/@react-native-community/cli/build/commands/install/install.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/node_modules/@react-native-community/cli/build/commands/index.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js
- /private/tmp/react-native-XsZVUnTl/template/node_modules/react-native/cli.js. Run CLI with --verbose flag for more details.
Error: Cannot find module './Libraries/polyfills/console.js'

created time in 14 days

pull request commentfacebook/react-native

Address @octokit/rest deprecation warnings

BTW, https://github.com/facebook/react-native/pull/28048 fixes test_js, next up I need to see if the test_js_e2e failure already exists in master or not. I'm following up on this later today.

tido64

comment created time in 14 days

pull request commentfacebook/react-native

Address @octokit/rest deprecation warnings

It won’t run if test_js fails. I’m looking at that failure today.

tido64

comment created time in 14 days

PR opened facebook/react-native

[CI] Use LTS and LTS-1 Node versions

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->

Summary

Previous config used Node10 and NodeLTS executors, but the naming wasn't accurate. As of today, Node 12 is LTS, Node 10 is also LTS but entering maintenance in April.

This PR switches all jobs to use Node 12 as nodelts, and renames test_js_lts to test_js_prevlts to reflect it's use of Node 10 (the previous Node LTS release). The executors are named NodeLTS and NodeLTSPrev. Later this year, we can switch these to use Node 14 and Node 12 as Node 10 goes into maintenance.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. --> [Internal]

Test Plan

Circle CI

+11 -11

0 comment

1 changed file

pr created time in 15 days

create barnchhramos/react-native

branch : nodelts

created branch time in 15 days

pull request commentfacebook/react-native

Report size of app bundles on PRs

Merged! Yes, we should fix the deprecated warnings. I also filed https://github.com/facebook/react-native/issues/28043 as a related item that came up while testing this.

tido64

comment created time in 15 days

PR closed facebook/react-native

[RNTester] Update Podfile.lock to make CI green. Bug CLA Signed

Summary

Try to get the test_ios_frameworks CI step green again.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[Internal] [Fixed] - Make test_ios_frameworks CI step green

Test Plan

The proof is in the pudding, the step is now 💚 again.

+26 -26

1 comment

1 changed file

alloy

pr closed time in 15 days

pull request commentfacebook/react-native

[RNTester] Update Podfile.lock to make CI green.

I think this can be closed. The diff that resulted from this PR was merged, but that diff didn't have any externally visible changes (just some updates to our internal Pods mirror). The lockfile probably got updated on another PR along the way.

alloy

comment created time in 15 days

issue commentreact-native-community/discussions-and-proposals

"What do you dislike about React Native?" June 2019 Edition

We'll be posting a follow up soon and address some of the issues raised here. Locking the issue for now, as I'm in the process of compiling the response at this time.

cpojer

comment created time in 15 days

push eventhramos/react-native

Dan Abramov

commit sha aa41fd5e372c4f6ca2c35ad75bb66abbc56d9620

React Native sync for revisions 19f6fe1...241c446 Summary: This sync includes the following changes: - **[57333ca33](https://github.com/facebook/react/commit/57333ca33 )**: Show first component stack in context warning (#17922) //<Dan Abramov>// - **[cf0081263](https://github.com/facebook/react/commit/cf0081263 )**: Upgrade to jest 25 (#17896) //<Simen Bekkhus>// - **[6faf6f5eb](https://github.com/facebook/react/commit/6faf6f5eb )**: Update to flow 0.97 (#17892) //<Nicolas Gallagher>// - **[81e30c7ff](https://github.com/facebook/react/commit/81e30c7ff )**: Remove unused modules from legacy event responders (#17907) //<Nicolas Gallagher>// - **[3c713d513](https://github.com/facebook/react/commit/3c713d513 )**: chore: update to latest release of babel (#17897) //<Simen Bekkhus>// - **[3b3decf87](https://github.com/facebook/react/commit/3b3decf87 )**: add warning when owner and self are different for string refs (#17864) //<Luna Ruan>// - **[6c00c5bba](https://github.com/facebook/react/commit/6c00c5bba )**: Update to flow-bin@0.89 (#17842) //<Nicolas Gallagher>// - **[cf7a0c24d](https://github.com/facebook/react/commit/cf7a0c24d )**: Remove dynamic GKs for selective/train (#17888) //<Sebastian Markbåge>// - **[c322f5913](https://github.com/facebook/react/commit/c322f5913 )**: Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags (#17880) //<Dominic Gannaway>// - **[f2fd484af](https://github.com/facebook/react/commit/f2fd484af )**: Add React.createFactory() deprecation warning (#17878) //<Dominic Gannaway>// - **[0c04acaf8](https://github.com/facebook/react/commit/0c04acaf8 )**: Remove FB specific build (#17875) //<Sebastian Markbåge>// - **[9fd760ce7](https://github.com/facebook/react/commit/9fd760ce7 )**: Add disable <textarea/> children flag (#17874) //<Dominic Gannaway>// - **[a209a97ed](https://github.com/facebook/react/commit/a209a97ed )**: Add feature flag around React.createFactory (#17873) //<Dominic Gannaway>// - **[95bd7aad7](https://github.com/facebook/react/commit/95bd7aad7 )**: Remove renderPhaseUpdates Map (#17625) //<Andrew Clark>// - **[b43b36dd9](https://github.com/facebook/react/commit/b43b36dd9 )**: Remove ReactInstanceMap_DO_NOT_USE shim (#17861) //<Dominic Gannaway>// - **[9e075d16b](https://github.com/facebook/react/commit/9e075d16b )**: [react-interactions] Remove deprecated Scope APIs + update Focus components/docs (#17859) //<Dominic Gannaway>// - **[b6173e643](https://github.com/facebook/react/commit/b6173e643 )**: [react-interactions] Add DO_NOT_USE to Scope methods (#17835) //<Dominic Gannaway>// - **[f4ca909e0](https://github.com/facebook/react/commit/f4ca909e0 )**: react-refresh@0.7.2 //<Dan>// - **[255d9ac5f](https://github.com/facebook/react/commit/255d9ac5f )**: [Fresh] Fix edge case with early function call (#17824) //<Dan Abramov>// - **[d8570ec6e](https://github.com/facebook/react/commit/d8570ec6e )**: Create ReactFabric.stopSurface and use that for bridgeless mode binding (#16164) //<Emily>// - **[5d6129b5d](https://github.com/facebook/react/commit/5d6129b5d )**: Update ReactSuspenseList-test.internal.js (#17034) //<Ganapati V S>// - **[3ac81a57f](https://github.com/facebook/react/commit/3ac81a57f )**: Update create-react-app note for eslint-plugin-react-hooks (#16982) //<Tao>// - **[e70672149](https://github.com/facebook/react/commit/e70672149 )**: Update Flow to 0.84 (#17805) //<Dan Abramov>// - **[b979db4e7](https://github.com/facebook/react/commit/b979db4e7 )**: Bump Prettier (#17811) //<Dan Abramov>// Changelog: [General][Changed] - React Native sync for revisions 19f6fe1...241c446 Reviewed By: yungsters Differential Revision: D19623180 fbshipit-source-id: 3cdecb33aa66dfc21a2b347bf7f63a5b27fcf6ea

view details

Riley Dulin

commit sha 9b7958c2f28087f90d7e7635a20cc90ddc7c3a07

Have heap snapshots throw std::system_error instead of return a bool Summary: Instead of returning a `bool` which gives no information about the cause of the error, return `void` and throw when there's some error. Another alternative is returning `std::error_code`, but that's less flexible than throwing, and this API already supports throwing. Changelog: [Internal] Reviewed By: jbower-fb Differential Revision: D19170033 fbshipit-source-id: 870cd996a1a53c94524455f31765c1da99f57a1d

view details

Eloy Durán

commit sha 619d5d60dfa94966e7104febec08166c1b5eca49

Smoothen Flipper iOS integration (#28044) Summary: Addresses my feedback [here](https://github.com/facebook/react-native/issues/27565#issuecomment-580950480), [here](https://github.com/facebook/react-native/issues/27565#issuecomment-582490074), and [here](https://github.com/facebook/react-native/issues/27565#issuecomment-585456768). ## Changelog [iOS] [Changed] - Updated Flipper iOS integration to be included by default in the `Debug` configuration Pull Request resolved: https://github.com/facebook/react-native/pull/28044 Test Plan: Manually tested that a new application from this template still works and that the Flipper integration works. <img width="912" alt="Screenshot 2020-02-13 at 02 09 42" src="https://user-images.githubusercontent.com/2320/74391951-eb6fd800-4e05-11ea-9fde-7e0eb42c1ec4.png"> Differential Revision: D19871482 Pulled By: TheSavior fbshipit-source-id: a805808fdd0c2dfdfe47dd59ffee02c81f3fdfa7

view details

Tommy Nguyen

commit sha 667ccfdbba6bbc2f27b1930b508c3338db249bb3

Report size of app bundles on PRs (#28041) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28041 Report size of app bundles on PRs. See [React Native Benchmark Suite](https://github.com/react-native-community/discussions-and-proposals/issues/186) for further discussion. ## Changelog [Internal] [Added] - Report size of app bundles on PRs Pull Request resolved: https://github.com/facebook/react-native/pull/28019 Test Plan: PRs should start seeing comments from a bot with app bundle sizes, given that they got built successfully. Reviewed By: cpojer Differential Revision: D19859187 Pulled By: hramos fbshipit-source-id: 0eb510287ba2001895d66d038fc1e7b8a722d9a8

view details

push time in 15 days

issue closedfacebook/react-native

Access to iOS Contact list not working

Description:

I am trying to access contacts on native iOS device because react-native-contacts didn't work well as expected. I managed to access contacts on native iOS devices using NativeModules. However trying to send a callback when a contact is picked is giving errors Thread 1: EXC_BAD_ACCESS (code=1, address=0x10). I need help to make one of the functions a callback when contact is selected so that I can get contact in react native. React Native version:

System: OS: macOS 10.14.6 CPU: (4) x64 Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz Memory: 215.89 MB / 8.00 GB Shell: 3.2.57 - /bin/bash Binaries:

SDKs: iOS SDK: Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2 Atom, android-24 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom

Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild npmPackages: react: 16.12.0 => 16.12.0 react-native: 0.61.5 => 0.61.5 npmGlobalPackages: create-react-native-app: 2.0.2 react-native-git-upgrade: 0.2.7

Steps To Reproduce Created ContactPicker.m objective-C file Called NativeModule.callbackmethod in react native Expected Results Contact selected should be seen in react native console.log Snack, code example, screenshot, or link to a repository:

#import <UIKit/UIKit.h>
  #import <Foundation/Foundation.h>
  #import "React/RCTBridgeModule.h"
 @import Contacts;
   @import ContactsUI;

  @interface ContactPicker : UIViewController
  @end

//@end

  @interface ContactPicker () <CNContactPickerDelegate, RCTBridgeModule>
  @property(nonatomic,retain) NSString *contact;
  @property (copy) RCTResponseSenderBlock callbackstored;
  @end
 @implementation ContactPicker

 @synthesize contact;
 @synthesize callbackstored;

  RCT_EXPORT_MODULE();
 RCT_EXTERN_METHOD(getContacts: (RCTResponseSenderBlock)callback);
 //RCT_EXTERN_METHOD(getContactDetails: (RCTResponseSenderBlock)callback)
   RCT_EXTERN_METHOD(getContactDetails: (NSString)
  - (void)viewDidLoad {
  [super viewDidLoad];
  // Do any additional setup after loading the view, typically from a nib
   }
   - (void)getContacts: (RCTResponseSenderBlock)callback {
 CNContactPickerViewController *contactPicker = [CNContactPickerViewController new];
   self.callbackstored = callbackstored;

  contactPicker.delegate = self;
 presentViewController:contactPicker animated:YES completion:nil];
 [[[[[UIApplication sharedApplication] delegate] window] rootViewController] 
 presentViewController: contactPicker animated:YES completion:nil]; 
  }

   - (void) contactPicker:(CNContactPickerViewController *)picker
    didSelectContact:(CNContact *)contact {
   [self getContactDetails:contact];

  }

   -(NSString *)getContactDetails:(CNContact *)contactObject{

    NSString * phone = @"";

    for(CNLabeledValue * phonelabel in contactObject.phoneNumbers) {
   CNPhoneNumber * phoneNo = phonelabel.value;
   phone = [phoneNo stringValue];
   if (phone) {
  self.contact = phone;
  }}
 self.callbackstored(@[[NSNull null], phone]);
 NSLog(@"PHONE NO :: %@",self.contact);
return self.contact;
}
 @end

The error i'm getting in XCode is Thread 1: EXC_BAD_ACCESS (code=1, address=0x10)

Main Thread Checker: UI API called on a background thread: -[UIWindow rootViewController]
PID: 12998, TID: 446725, Thread name: (none), Queue name: 
com.facebook.react.ContactPickerQueue, QoS: 0
Backtrace:
4   AppTracker                       0x0000000106673071 -[ContactPicker getContacts:] + 241
5   CoreFoundation                      0x000000010fabc4cc __invoking___ + 140
6   CoreFoundation                      0x000000010fab9a45 -[NSInvocation invoke] + 325
7   CoreFoundation                      0x000000010fab9e96 -[NSInvocation invokeWithTarget:] + 54
8   AppTracker                       0x00000001069dbb6a -[RCTModuleMethod 
invokeWithBridge:module:arguments:] + 2810
9   AppTracker                       0x00000001069dfe16 
_ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 
790
10  AppTracker                       0x00000001069df923 _ 
ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 131
11  AppTracker                       0x00000001069df899 
___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 25
12  libdispatch.dylib                   0x0000000111611d7f _dispatch_call_block_and_release + 12
13  libdispatch.dylib                   0x0000000111612db5 _dispatch_client_callout + 8
14  libdispatch.dylib                   0x000000011161a225 _dispatch_lane_serial_drain + 778
15  libdispatch.dylib                   0x000000011161ae9c _dispatch_lane_invoke + 425
16  libdispatch.dylib                   0x0000000111624ea3 _dispatch_workloop_worker_thread + 733
17  libsystem_pthread.dylib             0x00000001119a1611 _pthread_wqthread + 421
 18  libsystem_pthread.dylib             0x00000001119a13fd start_wqthread + 13
 2020-02-11 11:03:12.810923+0000 AppTracker[12998:446725] [reports] Main Thread Checker: 
 UI API called on a background thread: -[UIWindow rootViewController]
 PID: 12998, TID: 446725, Thread name: (none), Queue name: 
 com.facebook.react.ContactPickerQueue, QoS: 0
 Backtrace:
 4   AppTracker                       0x0000000106673071 -[ContactPicker getContacts:] + 241
 5   CoreFoundation                      0x000000010fabc4cc __invoking___ + 140
6   CoreFoundation                      0x000000010fab9a45 -[NSInvocation invoke] + 325
7   CoreFoundation                      0x000000010fab9e96 -[NSInvocation invokeWithTarget:] + 54
 8   AppTracker                       0x00000001069dbb6a -[RCTModuleMethod 
  invokeWithBridge:module:arguments:] + 2810
  9   AppTracker                       0x00000001069dfe16 
_ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 
 790
  10  AppTracker                       0x00000001069df923 
 _ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 131
  11  AppTracker                       0x00000001069df899 
  ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 25
   12  libdispatch.dylib                   0x0000000111611d7f _dispatch_call_block_and_release + 12
   13  libdispatch.dylib                   0x0000000111612db5 _dispatch_client_callout + 8
  14  libdispatch.dylib                   0x000000011161a225 _dispatch_lane_serial_drain + 778
  15  libdispatch.dylib                   0x000000011161ae9c _dispatch_lane_invoke + 425
   16  libdispatch.dylib                   0x0000000111624ea3 _dispatch_workloop_worker_thread + 
   733
  17  libsystem_pthread.dylib             0x00000001119a1611 _pthread_wqthread + 421
   18  libsystem_pthread.dylib             0x00000001119a13fd start_wqthread + 13
     2020-02-11 11:03:12.914246+0000 AppTracker[12998:446725] [Assert] Cannot be called 
  with asCopy = NO on non-main thread.
  2020-02-11 11:03:13.652149+0000 AppTracker[12998:446680] [MC] System group container      
2020-02-11 11:03:13.652636+0000 AppTracker[12998:446680] [MC] Reading from private 
effective user settings.
(lldb)

closed time in 15 days

lutakyn

issue commentfacebook/react-native

Access to iOS Contact list not working

The error you're running into is UI API called on a background thread. Helping out with this is a bit out of scope for this repository. One of the methods you're calling from your native module is being called on a background thread; you need to do so on the main thread. You'll find examples of how to do this by googling or searching Stack Overflow on how to run code on the main thread in iOS apps.

lutakyn

comment created time in 15 days

issue commentfacebook/react-native

Access to iOS Contact list not working

Do you think you can distill this into a smaller repro case? There's bits of code that has been commented out, and the formatting is off. It's certainly not a blocker, but with some effort this issue might be able to get more eyes on it.

lutakyn

comment created time in 15 days

issue closedfacebook/react-native

Native Contacts on iOS generating errors

Description:

I am trying to access contacts on native iOS device because react-native-contacts didn't work well as expected. I managed to access contacts on native iOS devices using NativeModules. However trying to send a callback when a contact is picked is giving errors **Thread 1: EXC_BAD_ACCESS (code=1, address=0x10)**. I need help to make one of the functions a callback when contact is selected so that I can get contact in react native. 

React Native version:

System: OS: macOS 10.14.6 CPU: (4) x64 Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz Memory: 215.89 MB / 8.00 GB Shell: 3.2.57 - /bin/bash Binaries:

SDKs: iOS SDK: Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2 Atom, android-24 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom

Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild

npmPackages: react: 16.12.0 => 16.12.0 react-native: 0.61.5 => 0.61.5 npmGlobalPackages: create-react-native-app: 2.0.2 react-native-git-upgrade: 0.2.7

Steps To Reproduce

  1. Created ContactPicker.m objective-C file
  2. Called NativeModule.callbackmethod in react native

Expected Results

Contact selected should be seen in react native console.log

Snack, code example, screenshot, or link to a repository:

 `#import <UIKit/UIKit.h>
  #import <Foundation/Foundation.h>
  #import "React/RCTBridgeModule.h"
 @import Contacts;
   @import ContactsUI;

  @interface ContactPicker : UIViewController
  @end

//@end

  @interface ContactPicker () <CNContactPickerDelegate, RCTBridgeModule>
  @property(nonatomic,retain) NSString *contact;
  @property (copy) RCTResponseSenderBlock callbackstored;
  @end
 @implementation ContactPicker

 @synthesize contact;
 @synthesize callbackstored;

  RCT_EXPORT_MODULE();
 RCT_EXTERN_METHOD(getContacts: (RCTResponseSenderBlock)callback);
 //RCT_EXTERN_METHOD(getContactDetails: (RCTResponseSenderBlock)callback)
   RCT_EXTERN_METHOD(getContactDetails: (NSString)
  - (void)viewDidLoad {
  [super viewDidLoad];
  // Do any additional setup after loading the view, typically from a nib
   }
   - (void)getContacts: (RCTResponseSenderBlock)callback {
 CNContactPickerViewController *contactPicker = [CNContactPickerViewController new];
   self.callbackstored = callbackstored;

  contactPicker.delegate = self;
 presentViewController:contactPicker animated:YES completion:nil];
 [[[[[UIApplication sharedApplication] delegate] window] rootViewController] 
 presentViewController: contactPicker animated:YES completion:nil]; 
  }

   - (void) contactPicker:(CNContactPickerViewController *)picker
    didSelectContact:(CNContact *)contact {
   [self getContactDetails:contact];

  }

   -(NSString *)getContactDetails:(CNContact *)contactObject{

    NSString * phone = @"";

    for(CNLabeledValue * phonelabel in contactObject.phoneNumbers) {
   CNPhoneNumber * phoneNo = phonelabel.value;
   phone = [phoneNo stringValue];
   if (phone) {
  self.contact = phone;
  }}
 self.callbackstored(@[[NSNull null], phone]);
 NSLog(@"PHONE NO :: %@",self.contact);
return self.contact;
}
 @end`

The error i'm getting in XCode is Thread 1: EXC_BAD_ACCESS (code=1, address=0x10)

 `Main Thread Checker: UI API called on a background thread: -[UIWindow rootViewController]
 PID: 12998, TID: 446725, Thread name: (none), Queue name: 
 com.facebook.react.ContactPickerQueue, QoS: 0
 Backtrace:
 4   AppTracker                       0x0000000106673071 -[ContactPicker getContacts:] + 241
 5   CoreFoundation                      0x000000010fabc4cc __invoking___ + 140
6   CoreFoundation                      0x000000010fab9a45 -[NSInvocation invoke] + 325
7   CoreFoundation                      0x000000010fab9e96 -[NSInvocation invokeWithTarget:] + 54
8   AppTracker                       0x00000001069dbb6a -[RCTModuleMethod 
 invokeWithBridge:module:arguments:] + 2810
9   AppTracker                       0x00000001069dfe16 
_ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 
 790
 10  AppTracker                       0x00000001069df923 _ 
ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 131
11  AppTracker                       0x00000001069df899 
 ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 25
12  libdispatch.dylib                   0x0000000111611d7f _dispatch_call_block_and_release + 12
 13  libdispatch.dylib                   0x0000000111612db5 _dispatch_client_callout + 8
14  libdispatch.dylib                   0x000000011161a225 _dispatch_lane_serial_drain + 778
15  libdispatch.dylib                   0x000000011161ae9c _dispatch_lane_invoke + 425
16  libdispatch.dylib                   0x0000000111624ea3 _dispatch_workloop_worker_thread + 733
17  libsystem_pthread.dylib             0x00000001119a1611 _pthread_wqthread + 421
  18  libsystem_pthread.dylib             0x00000001119a13fd start_wqthread + 13
  2020-02-11 11:03:12.810923+0000 AppTracker[12998:446725] [reports] Main Thread Checker: 
  UI API called on a background thread: -[UIWindow rootViewController]
  PID: 12998, TID: 446725, Thread name: (none), Queue name: 
  com.facebook.react.ContactPickerQueue, QoS: 0
  Backtrace:
  4   AppTracker                       0x0000000106673071 -[ContactPicker getContacts:] + 241
  5   CoreFoundation                      0x000000010fabc4cc __invoking___ + 140
 6   CoreFoundation                      0x000000010fab9a45 -[NSInvocation invoke] + 325
 7   CoreFoundation                      0x000000010fab9e96 -[NSInvocation invokeWithTarget:] + 54
  8   AppTracker                       0x00000001069dbb6a -[RCTModuleMethod 
   invokeWithBridge:module:arguments:] + 2810
   9   AppTracker                       0x00000001069dfe16 
 _ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 
  790
   10  AppTracker                       0x00000001069df923 
  _ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 131
   11  AppTracker                       0x00000001069df899 
   ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 25
    12  libdispatch.dylib                   0x0000000111611d7f _dispatch_call_block_and_release + 12
    13  libdispatch.dylib                   0x0000000111612db5 _dispatch_client_callout + 8
   14  libdispatch.dylib                   0x000000011161a225 _dispatch_lane_serial_drain + 778
   15  libdispatch.dylib                   0x000000011161ae9c _dispatch_lane_invoke + 425
    16  libdispatch.dylib                   0x0000000111624ea3 _dispatch_workloop_worker_thread + 
    733
   17  libsystem_pthread.dylib             0x00000001119a1611 _pthread_wqthread + 421
    18  libsystem_pthread.dylib             0x00000001119a13fd start_wqthread + 13
      2020-02-11 11:03:12.914246+0000 AppTracker[12998:446725] [Assert] Cannot be called 
   with asCopy = NO on non-main thread.
   2020-02-11 11:03:13.652149+0000 AppTracker[12998:446680] [MC] System group container      
 2020-02-11 11:03:13.652636+0000 AppTracker[12998:446680] [MC] Reading from private 
 effective user settings.
 (lldb) `

closed time in 15 days

lutakyn

issue commentfacebook/react-native

Native Contacts on iOS generating errors

Going to close as duplicate of #28033, since that one has more information.

lutakyn

comment created time in 15 days

issue closedfacebook/react-native

_dele

Description:

Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: http://facebook.github.io/react-native/docs/upgrading.html

React Native version:

Run `react-native info` in your terminal and copy the results here.

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.
Issues without reproduction steps or code are likely to stall.

Expected Results

Describe what you expected to happen.

Snack, code example, screenshot, or link to a repository:

Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

closed time in 15 days

mafdele20

issue openedfacebook/react-native

[CI] Migrate bots to use Authorization HTTP Header

Tracking issue raised by GitHub's API regarding our CI bots script (bots/code-analysis-bot.js):

On February 12th, 2020 at 21:09 (UTC) your personal access token (public_repo) using octokit.js/16.43.1 Node.js/12.15.0 (Linux 4.15; x64) was used as part of a query parameter to access an endpoint through the GitHub API.

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf. Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

The access token is publicly available in .circleci/config.yml.

created time in 15 days

Pull request review commentfacebook/react-native

mention RNTester app in contributor guide

 We recommend referring to the [CONTRIBUTING](https://github.com/facebook/react-n  ## Contributing Code -Code-level contributions to React Native generally come in the form of [pull requests](https://help.github.com/en/articles/about-pull-requests). The process of proposing a change to React Native can be summarized as follows:+Code-level contributions to React Native generally come in the form of [pull requests](https://help.github.com/en/articles/about-pull-requests). These are done by forking the repo and making changes locally. Directly in the repo, there is the [`RNTester` app](/RNTester) that you can install on your device (or simulators) and use to test the changes you're making to React Native sources.++The process of proposing a change to React Native can be summarized as follows:  1. Fork the React Native repository and create your branch from `master`.-2. If you've added code that should be tested, add tests.-3. If you've changed APIs, update the documentation.-4. Ensure the test suite passes, either locally or on CI once you opened a pull request.-5. Make sure your code lints (for example via `yarn lint --fix`).-6. Push the changes to your fork.-7. Create a pull request to the React Native repository.-8. Review and address comments on your pull request.+2. Make the desired changes to React Native sources. Use the RNTester app to test them out.+3. If you've added code that should be tested, add tests.+4. If you've changed APIs, update the documentation, which lives in [another repo](https://github.com/facebook/react-native-website/pull/1469).

I think this should be a link to the repo root, and not a specific PR

vonovak

comment created time in 15 days

create barnchhramos/react-native

branch : export-D19859187

created branch time in 15 days

more