profile
viewpoint
Héctor Ramos hramos @facebook Bay Area, CA https://hectorramos.com React Native at @facebook.

hramos/helpscout 36

HelpScout API gem

hramos/needs-attention 8

A GitHub Action for managing issues that require attention.

hramos/label-actions 4

A GitHub Action to Trigger Actions on Issues Based on Labels

hramos/CIStatusBoard 3

Barebones status board for tracking a given project's CI status.

hramos/AFNetworking 2

A delightful iOS networking library with NSOperations and block-based callbacks

hramos/buildevents 2

A small helper to generate Honeycomb traces from CI builds

hramos/observing_plans 2

Astronomical observing plans for use with remote observatories

hramos/octopress-www.hectorramos.com 2

Octopress is an obsessively designed framework for Jekyll blogging. It’s easy to configure and easy to deploy. Sweet huh?

hramos/.github 1

This is a sample repository that demonstrates various GitHub features.

issue closedfacebook/react-native

Connection refused when running android project

Connection refused when running android project

closed time in 25 days

PurpleSsteelToes

issue closedfacebook/react-native

ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:132:1: Property with 'retain (or strong)' attribute must be of object type

I am using this RCTBridgeModule to create my own custom bridge module for one of my application. Recently i migrated the app to latest react-native version 0.61.5. Now the iOS xcode build and react-native run ios command build gives me the error "ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:132:1: Property with 'retain (or strong)' attribute must be of object type". The build works fine when i removed the strong keyword from this line below. The strong or retain keyword is not required here as i see the variable methodQueue here is not an object. Could you please fix this issue ASAP.

https://github.com/facebook/react-native/blob/75a617827963fd53f5f36987677a992e137eaebf/React/Base/RCTBridgeModule.h#L146

Thanks Jencir C J

closed time in 25 days

JencirJamal

issue closedfacebook/react-native

Error react-native run-android

info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag. Jetifier found 967 file(s) to forward-jetify. Using 4 workers... info JS server already running. 'adb' n�o � reconhecido como um comando interno ou externo, um programa oper�vel ou um arquivo em lotes. info Launching emulator... error Failed to launch emulator. Reason: No emulators found as an output of emulator -list-avds. warn Please launch an emulator manually or connect a device. Otherwise app may fail to launch. info Installing the app...

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.0.1/userguide/command_line_interface.html#sec:command_line_warnings

FAILURE: Build failed with an exception.

  • What went wrong: Task 'installDebug' not found in project ':app'.

  • Try: Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

  • Get more help at https://help.gradle.org

BUILD FAILED in 7s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details. Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

  • What went wrong: Task 'installDebug' not found in project ':app'.

  • Try: Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

  • Get more help at https://help.gradle.org

BUILD FAILED in 7s

at makeError (C:\Users\LENOVO\Desktop\PROJETOS.ANO.2020\PROJETOS 02.2020\APLICATIVOS.REACT.NATIVE\app\app\node_modules\execa\index.js:174:9)
at C:\Users\LENOVO\Desktop\PROJETOS.ANO.2020\PROJETOS 02.2020\APLICATIVOS.REACT.NATIVE\app\app\node_modules\execa\index.js:278:16
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async runOnAllDevices (C:\Users\LENOVO\Desktop\PROJETOS.ANO.2020\PROJETOS 02.2020\APLICATIVOS.REACT.NATIVE\app\app\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:94:5)
at async Command.handleAction (C:\Users\LENOVO\Desktop\PROJETOS.ANO.2020\PROJETOS 02.2020\APLICATIVOS.REACT.NATIVE\app\app\node_modules\react-native\node_modules\@react-native-community\cli\build\index.js:186:9)

closed time in 25 days

edmirsobrinho123

issue closedfacebook/react-native

browserified bip39 crashed the app if set to any languages others english and italian

package.json

"react": "16.9.0",
"react-native": "0.61.5",

Downloaded bip39 from https://github.com/bitcoinjs/bip39, and then

browserify -s bip39 src/index.js > bip39.dev.js

In my RN app, I first require the module then set the default wordlist

const bip39 = require('./bip39.dev')
bip39.setDefaultWordlist('french')   //<-- this crashes the app, only "english" and "italian" work

If I debug the app so that the code runs on Chrome's js engine, everything works fine, all languages can be loaded and set. Not sure what caused the crash, and bip39 function setDefaultWordlist is straightforward:

function setDefaultWordlist(language) {
    const result = _wordlists_1.wordlists[language];
    if (result)
        DEFAULT_WORDLIST = result;
    else
        throw new Error('Could not find wordlist for language "' + language + '"');
}

Please take a look and any help is appreciated!

closed time in 25 days

Ajkcki

issue closedfacebook/react-native

Calling normalize('NFKD') on unicode strings crashes the js engine

As stated in the title, here is an example

let x ='的 一 是 在 不 了 有 和 人 这 中 大'
x.normalize('NFKD')  //<---------------crash the js engine

Calling with params NFC and NFD are OK, neither NFKC nor NFKD works

My environement "react": "16.9.0", "react-native": "0.61.5",

closed time in 25 days

Ajkcki

issue closedfacebook/react-native

passing static image to react native community slider with @2x suffix

so how to you apply that (https://i.stack.imgur.com/vFws6.png) to the react native community slider? how do you pass the image to the thumb image ?

closed time in 25 days

AbouzinaLamis

issue closedfacebook/react-native

Unsupported node type: param

After yarn start on the console , my React native app's home page does not appear rather it shows a page with message unsupported node type:param. Though no error logs are printed on console. Please find screenshot of the error. IMG_20200502_113922

closed time in 25 days

RitikaSrivastava11oct

issue closedfacebook/react-native

Animated component - attach/detach native views on each render

I just noticed, that each re-render of my animated component, it will detach and attach native events for the same view. I believe the root cause is the check in componentDidUpdate, which uses this._prevComponent to do equality check.

https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/createAnimatedComponent.js#L197-L205

The issue is that this._prevComponent will always be undefined, since we only set it inside setRef method, which being invoked only once per component instance.

https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/createAnimatedComponent.js#L143-L145

Currently not sure, what is intended behaviour in componentDidUpdate method. So just raising issue without PR.

Another concern is related to UNSAFE_componentWillReceiveProps. This will invoke __detach on every parent re render, even if props are same.

closed time in 25 days

usrbowe

issue closedfacebook/react-native

Websocket do not support protocols parameters

I am implementing SIP in my react native application , while creating a websocket connection websocket constructor needs to have "sip" as a protocol but it do not support this or any other protocol parameter

closed time in 25 days

Sahil5963

issue closedfacebook/react-native

How add .aar file into React Native project and how to call lib methods

I hava created the folder 'libs' into /android/app/.

Then, on app/build.gradlew I added: implementation fileTree(dir: "libs", include: ["*.aar"])

The compilation works fine. I have no errors on it.

My Question is: How do I call the methods from the lib I put on folder 'libs'.

I have tried to use NativeModules. But it did not work.

Do I have to do someting else?

closed time in 25 days

pedroenrre

issue closedfacebook/react-native

LayoutAnimation + Keyboard bug?

Hi, I am having a little bug with my app using LayoutAnimation on Android (Samsung Galaxy S8).

Another user reported this error a while ago... (It is exactly the same) https://github.com/facebook/react-native/issues/26551

Is this an incompatibility with react navigation 5? Any solution?

It works good on my iOS (iPhone 6)

This is my react native version:

react-native-cli: 2.0.1 react-native: 0.61.4

Here I explain more widely the problem: https://stackoverflow.com/questions/62244339/react-native-layoutanimation-bug-with-react-navigation

closed time in 25 days

VictorioMolina

issue closedfacebook/react-native

TypeError: undefined is not an object (evaluating 'process.version.split')

After upgrading the RN to 0.62.2 then it failed and then shows the above evaluating 'process.version.split'.

TypeError: undefined is not an object (evaluating 'process.version.split')

Simulator Screen Shot - iPhone 8 - 2020-06-09 at 10 51 42

closed time in 25 days

nihp

issue closedfacebook/react-native

ESLint no-unused-expressions is off by default

https://github.com/facebook/react-native/blob/92630856c6270bb48d2b640d87afce9f405ed424/packages/eslint-config-react-native-community/index.js#L189

I am curious why eslint-plugin-react-native allows unused-expressions by default. Today in my project, I found a bug related to this and think this should be prevented from lint stage.

closed time in 25 days

dev-xu

issue closedfacebook/react-native

release apk com.facebook.react.common.javascriptexception:null is not an object (evaluating t(r(d[1])).default.direction react native

Release build crashes on iOS and Android. Fatal Exeption.

Error: release apk com.facebook.react.common.javascriptexception:null is not an object (evaluating t(r(d[1])).default.direction react native

package.json "dependencies": { "appcenter": "^3.0.3", "appcenter-analytics": "^3.0.3", "appcenter-crashes": "^3.0.3", "expo": "^33.0.0", "hermesvm": "^0.1.1", "jsc-android": "^241213.1.0", "react": "16.8.3", "react-dom": "~16.9.0", "react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz", "react-native-device-info": "^5.6.1", "react-native-elements": "^2.0.0", "react-native-snap-carousel": "^3.9.0", "react-native-web": "~0.11.7", "react-navigation": "^3.11.0" },

closed time in 25 days

sathyab18

issue closedfacebook/react-native

bundle ./index.js

✋ To keep the backlog clean and actionable, issues will be 🚫 closed if they do not follow one of the issue templates: 👉 https://github.com/facebook/react-native/issues/new/choose

closed time in 25 days

samar989

issue closedfacebook/react-native

error while installing react native on ubuntu 19.01 .

error Failed to install the app. Make sure you have the Android development environment set up: https://facebook.github.io/react-native/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details. Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

  • What went wrong: A problem occurred configuring project ':app'.

SDK location not found. Define location with an ANDROID_SDK_ROOT environment variable or by setting the sdk.dir path in your project's local properties file at '/home/jet/AwesomeProject/android/local.properties'.

closed time in 25 days

jet2018

issue closedfacebook/react-native

scrollView 滚动的自定义动画

希望能提供方式(function),能实现用户滚动scrollView 后的衰减动画,而不是scrollTo 货值 scrolloffset 那样的动画

closed time in 25 days

gyfgyf

PR closed facebook/react-native

Disable Detox tests CLA Signed

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->

Summary

The test_ios_detox* tests have been broken for a while. Disabling to improve signal from other tests.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog -->

[Internal]

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

Circle CI

+16 -16

2 comments

1 changed file

hramos

pr closed time in 25 days

issue closedfacebook/react-native

how i can't fixed with this error for debugger-ui, please help me

✋ To keep the backlog clean and actionable, issues will be 🚫 closed if they do not follow one of the issue templates: 👉 https://github.com/facebook/react-native/issues/new/choose

image

closed time in 25 days

dh4nil0ver5

push eventhramos/react-native

Joshua Gross

commit sha 3503d722a18dc6c0781232e164c82b8097786082

Fix race between teardown and PreAllocateView/CreateView MountItem creation Summary: Commits can happen during navigation/teardown which creates mount items. If we throw an exception during teardown because we expect the Context to still be around, we crash too often. Instead, I will rely on logic in FabricUIManager to ignore queued MountItems if we try to execute them after the surface has been torn down; and we move the IllegalStateException to actual execution of the mount item in case there's an edge-case we're missing. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D22470102 fbshipit-source-id: ad98c03994969a3c3f300d6551e90b6516ed2d8b

view details

David Vacca

commit sha d5bc0a7bff36f6ed4a7b4a71b9e4bcef6bccdf01

Fix inconsistency on AndroidTextInput view configs Summary: BubblingEventTypes are inconsistent between AndroidTextInputViewConfig.js and ReactTextInputManager.java, this diff fixes this inconsistency changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D22470096 fbshipit-source-id: 3940dcc0ae67a42ac070c06ec2d54bc365eab6b7

view details

Samuel Susla

commit sha 34ff9b7259e77f271c156bd75b837d4890ba9c81

Add view hierarchy drawings to tests Summary: Changelog: [Internal] Add view hierachy drawings to tests to make it easier to picture view hierarchy. The sketches do not reflect sizing but relationship among the views. I removed unnecessary reset of transform value to identity matrix. Reviewed By: JoshuaGross, shergin Differential Revision: D22456267 fbshipit-source-id: 480d0b938ffd0281fc94148570c412b0fcc22f42

view details

Héctor Ramos

commit sha 120ff7ccdebebdf814e478259ba1e4a8ef6f513e

Disable Detox tests on Circle CI (#29329) Summary: Disabling Detox tests on Circle CI as the `test_ios_detox*` tests have been broken for a while. Changelog: [Internal] Test Plan: Verified these no longer trigger on Circle CI Reviewed By: cpojer Differential Revision: D22476861 Pulled By: hramos fbshipit-source-id: 3d46786cd7d088d363409e4d35a327e3e997a227

view details

Dan Abramov

commit sha ac87e90fa517676440c1adf9575cb48f90de8069

Update React Hooks rule Summary: Includes better support for optional chaining. Changelog: [General][Changed] - Updated the React Hooks ESLint Plugin Reviewed By: rickhanlonii, trueadm Differential Revision: D22479305 fbshipit-source-id: 08740449ea797ce0971ccae358eb7de1ae102d7d

view details

Rick Hanlon

commit sha 8e6e83be0cf232aa299e64367fb223e4ce28d512

Switch to react-shallow-renderer Summary: Replace react-test-renderer/shallow with react-shallow-renderer. We should follow up with teams to remove these tests because they will no longer be supported. I would have just removed them but test like `BillingReauthorizeCreditCardContainer-test` seem important. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D22225642 fbshipit-source-id: a6bd559311422cb14576a574165ed7dc0279919d

view details

Héctor Ramos

commit sha f71d7f1556dcd2259d2748ebbb19112bcacc2b86

Use Xcode 11.5.0 and CocoaPods 1.9.1 (#28837) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28837 CocoaPods 1.9.1 is the latest version, as well as the one distributed by Circle CI to macOS machines alongside Xcode 11.5.0. The upgrade to CocoaPods and Xcode is therefore tightly coupled due to our dependency on Circle for our open source CI. With the upgrade to Xcode 11.5.0, we also bump our target OS to ensure iOS tests use an iOS Simulator that is part of the image. Reference: * Circle CI macOS Xcode 11.5.0 image manifest (new version): https://circle-macos-docs.s3.amazonaws.com/image-manifest/v2960/index.html * Circle CI macOS Xcode 11.3.1 image manifest (previous version): https://circle-macos-docs.s3.amazonaws.com/image-manifest/v2244/index.html > Source: https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions Changelog: [Internal] Bump Xcode version used for iOS tests. Reviewed By: fkgozali Differential Revision: D21415049 fbshipit-source-id: 86e281100eb2f382a3450abf34a8c1e5148a8279

view details

push time in 25 days

push eventhramos/react-native

Héctor Ramos

commit sha e4832999d65282086c7ff655d5471f10b7bb5f0d

Disable detox tests

view details

push time in a month

PR opened facebook/react-native

Disable Detox tests

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->

Summary

The test_ios_detox* tests have been broken for a while. Disabling to improve signal from other tests.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog -->

[Internal]

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

Circle CI

+147 -16

0 comment

3 changed files

pr created time in a month

push eventhramos/react-native

Héctor Ramos

commit sha bab1b12e8e2c8b12906edfe40d282111acb8b076

Disable detox tests

view details

push time in a month

create barnchhramos/react-native

branch : disable-detox

created branch time in a month

push eventhramos/react-native

Christoph Nakazawa

commit sha 530dffa342ee56e80cf8aa2d41a195b49c992b91

Cleanup unused dependencies Reviewed By: kassens Differential Revision: D21281288 fbshipit-source-id: cf566ad0628dc179b3753f2f25a11637c33dee24

view details

Paige Sun

commit sha b0d0e51a7724dcefe3ce1c2dfb334a731b2a385c

iOS: Animated image should animate at the same speed regardless of framerate Summary: In iOS 11, [CADisplayLink](https://developer.apple.com/documentation/quartzcore/cadisplaylink)'s frameInterval was deprecated in favor of preferredFramesPerSecond, but these two properties have different underlying assumptions. - set frameInterval to 2 for 30fps - set preferredFramesPerSecond to 30 for 30fps. When you use preferredFramesPerSecond, assume frameInterval is 1. This fix ensures gifs in <Image> component will animate at same speed regardless of framerate. Reviewed By: shergin Differential Revision: D21414014 fbshipit-source-id: 40ab23bab1990cf65d2802830b6835f350999537

view details

Rick Hanlon

commit sha 5066b662f2f0cc4d43575777a47c77fcc97a979c

LogBox - Always display the first fatal error Summary: This diff fixes an off-by-one error probably caused by my font ligatures where when exactly two exceptions are thrown at the same time we would show the second exception instead of the first. If three or more were thrown, we would show the second. I also fixed some tests that had the wrong descriptions and wrong behavior enforced. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D21413186 fbshipit-source-id: 8e2940c89251dc042b10c6a2a2186089b6e7b53d

view details

Rick Hanlon

commit sha 41f0d9ba8f46e08e5e01b7834bdb4a58e0c29dcf

Rename error titles Summary: Based on feedback we're updating these titles to be more clear for their source. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D21413486 fbshipit-source-id: c144e7f759a4ff263b7ec80fa643eeb8ffac741b

view details

Kevin Gozali

commit sha de667fffa4589766b5b4cb3dcf148c7f10267a5d

Moved some NativeModule JS specs to OSS Summary: For some reason the specs were internal, but the native impl is still in github. So let's move these to github for consistency. Changelog: [Internal] Reviewed By: hramos Differential Revision: D21419934 fbshipit-source-id: f2c4486edca43c4348f3a3c6ce98f76a322bab0b

view details

Nat Mote

commit sha 0c2c4bf33c1425fe1b64cc7d731a1eff065714e0

Deploy Flow v0.124.0 to xplat/js Summary: Changelog: [Internal] allow-large-files Reviewed By: samwgoldman, cpojer Differential Revision: D21413059 fbshipit-source-id: f3d111b40bfb88c182eab022925f7ae2dc47bc6b

view details

Tim Yung

commit sha d14b89bd8ad971a7a7cdaa92633a78b7ca1004c5

RN: Workaround Fabric + Virtual Text Press Bug Summary: Workaround for a bug with Fabric when pressing on virtual text. Changelog: [Internal] (Note: this ignores all push blocking failures!) Reviewed By: JoshuaGross Differential Revision: D21432793 fbshipit-source-id: fe20eeadd5365707fb71edae7a76d374e26b4c86

view details

Valentin Shergin

commit sha fa5b4c9e0cb609594336c6537bbcd53a867dbb32

Fabric: Backward-compatible behaviour of `measureInWindow` and `measure` Summary: Before this change, in case of incorrect measurements, Fabric's implementation of `measure` and `measureInWindow` incorrectly returned negative height and width. Now it returns zeros (as classic React Native does). Fabric: This does not fix `measureLayout` called for virtual nodes. This is not so trivially to fix and it will be done separately. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross, yungsters, mdvacca Differential Revision: D21433239 fbshipit-source-id: fbaf5ee35c690506822c634daac4426542c2cdcf

view details

Christoph Nakazawa

commit sha 21d7a357f66d277a6168bab009c99932c9a20cd6

Upgrade to Yargs 15 Summary: Only breaking changes appear to be dropped Node 6 support: https://github.com/yargs/yargs/blob/master/CHANGELOG.md. Deduplicates quite a few copies of Yargs, yay! Changelog: [Internal] (Note: this ignores all push blocking failures!) Reviewed By: motiz88 Differential Revision: D21426137 fbshipit-source-id: b091e29ac2d9464d6ce9a716a99f7ae156a91a01

view details

David Vacca

commit sha ff0c62504b35ffc753a11aa586779fbc4b2adc4d

Ez Extend logging of Fabric Summary: Quick diff to log of content of UpdateState mount item. This is useful for debugging. Note this will ONLY be logged when the constant FabricUIManager.IS_DEVELOPMENT_ENVIRONMENT is set to true changelog: [Internal][Android] internal log for fabric android Reviewed By: JoshuaGross Differential Revision: D21428345 fbshipit-source-id: d000eb6dbdd39d15935fa2102072790e17372682

view details

David Vacca

commit sha 5c48c94f8c0441bc78a007f0ea0c5b2763ff6875

Fix measureLayout function for Virtual Nodes Summary: This diff fixes a NullPointerException thrown when calling measureLayout function on a virtual node. changelog: [Android] Fix measureLayout function for VirtualTexts Reviewed By: JoshuaGross Differential Revision: D21435030 fbshipit-source-id: aba6d81f333464e49d2d769b111842e7ae8ce769

view details

Emily Janzer

commit sha ca105f8b069e42a62b7d212e1d94c9fa8123d69a

Update cocoapods (#28833) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28833 The checked-in RNTester podfile was generated using Cocoapods version 1.9.1. This doesn't match the version currently used in CircleCI, which is 1.8.4. In order to update the offline mirrors and land them without breaking CircleCI, it seems we need to switch back to 1.8.4. This diff updates the podfile back to 1.8.4 and updates the offline mirrors. Reviewed By: fkgozali Differential Revision: D21392989 fbshipit-source-id: b14aa6e2798175534e9416410ba9d6877fb718c0

view details

Valentin Shergin

commit sha d76e03f85a78fb4be30714ea11e96ab1f204a53d

Fabric: Introducing `RunLoopObserver` Summary: `RunLoopObserver` is one of the core interfaces that bridge intrinsically platform-specific functionality to cross-platform React Native core. `RunLoopObserver` allows subscribing for notifications about changes in a run loop life cycle. Primarily it supposed to be used for observing UI (aka main) and JavaScript execution thread/run-loop. Having a `RunLoopObserver` implemented in a platform-specific manner allows building these components in a cross-platform manner: * Sync and async UI event delivery pipeline; * Timing for some animation engine; * Timers (probably additional features are required). Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D21341997 fbshipit-source-id: 7ef61fb51f550dd0f2e89c64af657e0f0de029aa

view details

Valentin Shergin

commit sha 025b6a74c8bcdb2c71222a370aa6281e342b0862

Fabric: Cross-platform implementation of `SynchronousEventBeat` and `AsynchronousEventBeat` Summary: `SynchronousEventBeat` and `AsynchronousEventBeat` are a cross-platform re-implementation of run loop related parts of `MainRunLoopEventBeat` and `RuntimeEventBeat` (iOS specific classes for now). In the future, they will replace iOS- and Android-specifc event beat classes. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D21341996 fbshipit-source-id: 8eda9a5df537cd666b7728e32212a8bb5ddb3ab7

view details

Nikita Lutsenko

commit sha f4815fbad3da368bead34c3b1c1391a83c983aae

third-party | Move glog from xplat/third-party to third-party and create temporary redirect. Summary: Move and create an empty rule that redirects as well, to handle //arvr rules Need to do this way, since ovrsource sync rules are in different repo. allow_many_files allow-large-files Steps: - [X] Move glog from xplat/third-party to /third-party - [ ] Update references in ovrsource to translate to //third-party instead of //xplat/third-party - [ ] Get rid of temporary rule - [ ] Update fbsource/third-party/glog to 0.3.5 (what we have in ovrsource) Changelog: [Internal] Update reference for glog from xplat/third-party to /third-party. Reviewed By: yfeldblum Differential Revision: D21363584 fbshipit-source-id: c1ffe2dd615077170b03d98dcfb77121537793c9

view details

Yuanzhe Bian

commit sha 851644cfc23728f72fe638b57f03c596803fef7c

Fix Animated type Summary: - Fixed typing of Animated and fixed the callsites Changelog: [Internal] Reviewed By: kacieb Differential Revision: D21311870 fbshipit-source-id: 386fb496ab00ef7917273dc3eb65e1ed76a8dd33

view details

Pieter De Baets

commit sha e566c7ec7b0015e4e5e6ad92247a6357eb861d4f

Add virtual destructor to JSError Summary: We consume Hermes through multiple .so's, which means we have multiple (weak) typeinfo definitions of facebook::jsi::JSError. Previously we were using gnustl, which would strcmp typeinfo to decide whether a certain exception handler applies, which meant this didn't cause any major issues. However since this is deprecated, we recently switched to libc++, which does not have this by behaviour (or it does, but behind a flag I'm not sure how to enable). This causes any JS exceptions to fall through from our exception handlers and fatal the app. This problem is actually documented in the common Android NDK problems page: https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md#rtti_exceptions-not-working-across-library-boundaries The suggested solution is to ensure that any exception types have a key function defined (a non-pure, out-of-line virtual function). The simplest one to add is a virtual destructor. This makes the object file that holds the implementation of the destructor export a non-weak typeinfo definition which will at load time override the other weak versions. I'm not sure why we're the first to hit this. RN's JSIExecutor doesn't explicitly reference JSError which probably helps (https://github.com/facebook/react-native/blob/master/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp#L256-L258) and they also don't use unguarded callbacks like we do. Changelog: [Internal] Reviewed By: mhorowitz Differential Revision: D21426524 fbshipit-source-id: 474284ada1ca2810045dc4402c420879447f9308

view details

Rubén Norte

commit sha 26c120c6329d45e27318d82aaf5a50338bd6fa7d

Handle initialProps as optional in renderApplication Summary: Pass a default empty object to `AppContainer` if no `initialProps` were passed to `renderApplication`. This prevents issues on Android, where we do not pass a default empty `initialProps` from native, as we do on iOS. Changelog: [General] [Fixed] - Handle nullish `initialProps` correctly in `renderApplication` Reviewed By: motiz88 Differential Revision: D21448692 fbshipit-source-id: 9630bdc2414532999abf3bf9da25047f0482fcab

view details

Eloy Durán

commit sha 7bb1c4e1b8715a5c9cb6f9e4e77a6df783481d3d

Enable with CocoaPods `:configuration` (#28796) Summary: ~~⚠️ Depends on https://github.com/facebook/flipper/pull/1086 and a new Flipper release.~~ Fixes https://github.com/facebook/react-native/commit/17f025bc26da13da795845a3f7daee65563420c0#commitcomment-38831234 Currently user’s are being told to add a definition of the `FB_SONARKIT_ENABLED` macro and examples, including those in stock React Native templates, set this for the user by making use of a `post_install` hook in the user’s `Podfile`. This leads to confusion, fragile code [when a user’s project dir structure deviates from vanilla], and is ultimately not necessary as CocoaPods already has dedicated mechanisms to: * specify build settings (through the `xcconfig` property); * and selectively include certain pods only in certain build configurations (e.g. debug). ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Changed] - Entirely control Flipper being enabled through inclusion in Podfile and optionally limiting to certain build configurations using the `:configuration` directive. Pull Request resolved: https://github.com/facebook/react-native/pull/28796 Test Plan: Tested using the changes of https://github.com/facebook/flipper/pull/1086 in a new app that uses RN `master`. Reviewed By: priteshrnandgaonkar Differential Revision: D21449754 Pulled By: passy fbshipit-source-id: 9ff7c7f4ffc32b364b1edd82b94e0b80c3997625

view details

João Vieira

commit sha 16ea9ba8133a5340ed6751ec7d49bf03a0d4c5ea

Support excluding multiple platforms. Summary: Currently the schema only allows to exclude a single platform (iOS OR Android). There are cases where we need to exclude multiple. This change converts the previous `excludePlatform` string property into an `excludePlatforms` array. Changelog: [Internal][Changed] - Added support to exclude multiple platforms in Codegen. Reviewed By: sammy-SC Differential Revision: D21426950 fbshipit-source-id: eff36ffa207109274794b4b300bf6313f8286161

view details

push time in a month

PR closed facebook/react-native

Reviewers
Fix Xcode 11 build Bug CLA Signed Platform: iOS

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->

Summary

Fixes build in Xcode 11 beta, the signature for __unused was changed. This adds a new check for the new style.

In my project, react-native version 0.49.5 was used. I met this issue and found a solution, but I need to modify the code in node_moduels/reac-native by myself. It is not convenient for me to migrate the project.

I was hoping you guys would release react-native 0.49.6.

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog -->

[iOS] [Fixed] - Xcode 11 beta build

Test Plan

Build & run RNTester <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

+3 -2

6 comments

1 changed file

hileix

pr closed time in a month

push eventhramos/react-native

Héctor Ramos

commit sha 2e2deedeb4f8527b20032ef0053598e8a3c4d7b8

Update .tests.env

view details

push time in a month

push eventhramos/react-native

Héctor Ramos

commit sha d2c25e27ed5e951471c39e05ce681dff53b2835d

Update config.yml

view details

push time in a month

pull request commentfacebook/react-native

Upgrade flow-remove-types version to 2.122.0

Do we still need this change, now that the codegen package uses Babel and a build script to work around the need for flow-remove-types?

empyrical

comment created time in a month

push eventhramos/react-native

Héctor Ramos

commit sha 2d0bbb087a61a3920db7c098c0a0b38e77ae5631

Update .tests.env

view details

push time in 3 months

pull request commentfacebook/react-native

Codegen: Add prepublish script to build Flow files

Yes, sorry about that! Christoph has been working on reducing the size of our node_modules directory, so there was some work that landed while you were working on the updates to the PR. Thanks for bearing with us!

empyrical

comment created time in 3 months

create barnchhramos/react-native

branch : export-D21415049

created branch time in 3 months

PR opened facebook/react-native

Use Xcode 11.4.1 and CocoaPods 1.9.1

Summary: CocoaPods 1.9.1 is the latest version, as well as the one distributed by Circle CI to macOS machines alongside Xcode 11.4.1.

The upgrade to CocoaPods and Xcode is therefore tightly coupled due to our dependency on Circle for our open source CI.

With the upgrade to Xcode 11.4.1, we also bump our target OS to ensure iOS tests use an iOS Simulator that is part of the image.

Reference:

  • Circle CI macOS Xcode 11.4.1 image manifest (new version): https://circle-macos-docs.s3.amazonaws.com/image-manifest/v2750/index.html
  • Circle CI macOS Xcode 11.3.1 image manifest (previous version): https://circle-macos-docs.s3.amazonaws.com/image-manifest/v2244/index.html

Changelog: [Internal] Bump Xcode version used for iOS tests.

Differential Revision: D21415049

+7 -7

0 comment

3 changed files

pr created time in 3 months

Pull request review commentfacebook/react-native

Codegen: Add prepublish script to build Flow files

     "type": "git",     "url": "git@github.com:facebook/react-native.git"   },+  "scripts": {+    "build": "yarn clean && node scripts/build.js --verbose",+    "clean": "rm -rf lib",+    "prepublish": "yarn run build"+  },   "license": "MIT",   "files": [-    "src"+    "lib"   ],   "dependencies": {     "flow-parser": "^0.121.0",     "jscodeshift": "^0.9.0",     "nullthrows": "^1.1.1"+  },+  "devDependencies": {+    "@babel/core": "^7.2.0",+    "@babel/preset-env": "^7.2.0",+    "@babel/preset-flow": "^7.2.0",+    "chalk": "^2.4.1",+    "glob": "^7.1.1",+    "micromatch": "^2.3.11",+    "mkdirp": "^0.5.1",+    "prettier": "1.19.1"

Can you use these versions for the following packages? They would match what we are using internally, and help us avoid pulling multiple copies of the same library.

    "@babel/core": "^7.0.0",
    "@babel/preset-flow": "^7.0.0",
    "chalk": "^4.0.0",
    "micromatch": "^3.0.4",
    "mkdirp": "^0.5.1",
empyrical

comment created time in 3 months

more