profile
viewpoint

holgermetschulat/gosec 0

Golang security checker

holgermetschulat/radius 0

a Go (golang) RADIUS client and server implementation

PR opened securego/gosec

Update README.md

Typo ?!? v2 doesn't exist as a path in go get...

+2 -2

0 comment

1 changed file

pr created time in a month

push eventholgermetschulat/gosec

holgermetschulat

commit sha c4ad0383bfa7581462549e449a2394fd48df78f3

Update README.md Typo ?!? v2 doesn't exist as a path in go get...

view details

push time in a month

create barnchholgermetschulat/gosec

branch : readme-typo

created branch time in a month

PullRequestReviewEvent

Pull request review commentlayeh/radius

support for encrypted ints + ipaddresses / use null crypto authentic…

 func Parse(b, secret []byte) (*Packet, error) { 		return nil, errors.New("radius: invalid packet length") 	} +	if len(cryptoAuthenticator) != 0 && len(cryptoAuthenticator) != 16 {

Sorry... ignore.

dirkm

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentlayeh/radius

support for encrypted ints + ipaddresses / use null crypto authentic…

 func Parse(b, secret []byte) (*Packet, error) { 		return nil, errors.New("radius: invalid packet length") 	} +	if len(cryptoAuthenticator) != 0 && len(cryptoAuthenticator) != 16 {

Sorry misread the line... statement is okay.

dirkm

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentlayeh/radius

support for encrypted ints + ipaddresses / use null crypto authentic…

 func Parse(b, secret []byte) (*Packet, error) { 		return nil, errors.New("radius: invalid packet length") 	} +	if len(cryptoAuthenticator) != 0 && len(cryptoAuthenticator) != 16 {

cryptoAuthenticator from the function call is not used anywhere ...?

dirkm

comment created time in 2 months

Pull request review commentlayeh/radius

support for encrypted ints + ipaddresses / use null crypto authentic…

 func (p *Packet) Response(code Code) *Packet { 		Identifier: p.Identifier, 		Secret:     p.Secret, 	}-	copy(q.Authenticator[:], p.Authenticator[:])+	q.Authenticator = p.Authenticator+	q.CryptoAuthenticator = p.Authenticator

Check if deep copy is necessary here (copy the slice or copy the array)?

dirkm

comment created time in 2 months

Pull request review commentlayeh/radius

support for encrypted ints + ipaddresses / use null crypto authentic…

 func Parse(b, secret []byte) (*Packet, error) { 		return nil, errors.New("radius: invalid packet length") 	} +	if len(cryptoAuthenticator) != 0 && len(cryptoAuthenticator) != 16 {

!=0 comparision is redundant here.

dirkm

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventholgermetschulat/radius

holgermetschulat

commit sha f987725ed250e1868c2569229ffd97167e079d52

Update go.mod

view details

push time in 2 months

push eventholgermetschulat/radius

holgermetschulat

commit sha 3b2eb521f36df935622489c8fd4a008fcfa908d0

Update go.mod

view details

push time in 2 months

push eventholgermetschulat/radius

holgermetschulat

commit sha 5d9f9970d286af16a9b2f399b3a109c43403b8d5

Update go.mod

view details

push time in 2 months

MemberEvent
MemberEvent
more