profile
viewpoint

hassanbabaie/awsServiceTerms 0

Change tracking for AWS Service Terms

hassanbabaie/mc 0

MinIO Client is a replacement for ls, cp, mkdir, diff and rsync commands for filesystems and object storage.

hassanbabaie/minio 0

MinIO is a high performance object storage server compatible with Amazon S3 APIs

hassanbabaie/scalr 0

Cloud Management Software

hassanbabaie/scalr-ctl 0

Command Line Tools for Scalr

hassanbabaie/traccar 0

Traccar GPS Tracking System

hassanbabaie/webhook 0

webhook is a lightweight configurable incoming webhook server which can execute shell commands

PR closed adnanh/webhook

Add support to ppc64le

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date. For more info tag @gerrith3

+6 -0

2 comments

1 changed file

gururajrkatti

pr closed time in 15 hours

pull request commentadnanh/webhook

Add support to ppc64le

Thanks for the response. We are still working on the Github actions support for the ppc64le. will get back to you when we have that support added.

gururajrkatti

comment created time in 15 hours

issue closedadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

I tried to set up a webhook rule to be triggered when the payload signature is verified with any one of multiple secrets, but I found that any unsatisfied payload signature sub-rule that appears before other sub-rules in the or rule will cause the parent rule be evaluated to false.

example config:

"trigger-rule": {
      "or": [
        {
          "match": {
            "type": "payload-hash-sha512",
            "secret": "secret-1",
            "parameter": {
              "source": "header",
              "name": "X-Signature"
            }
          }
        },
        {
          "match": {
            "type": "payload-hash-sha512",
            "secret": "secret-2",
            "parameter": {
              "source": "header",
              "name": "X-Signature"
            }
          }
        }
      ]
    },

requests signed by "secret-2" will never trigger the hook because an error will occurred:

error evaluating hook: invalid payload signatures [...]

closed time in a day

zry98

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

Closing as a duplicate of #234.

zry98

comment created time in a day

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

Ok. I don't think this is a duplicate of #471 then.

I think this is, instead, a duplicate of #234. It's been a while since I've looked at #234. @zry98, what are you thoughts on that issue, especially my last comment?

That sounds great.

zry98

comment created time in a day

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

Ok. I don't think this is a duplicate of #471 then.

I think this is, instead, a duplicate of #234. It's been a while since I've looked at #234. @zry98, what are you thoughts on that issue, especially my last comment?

zry98

comment created time in a day

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

What version of webhook are you using? If 2.7.0, I suspect this is a duplicate of #471.

Yes, I'm using 2.7.0, please check my reply, if Evaluate returned error will immediately evaluate the parent rule to false.

zry98

comment created time in a day

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

I've located the reason: https://github.com/adnanh/webhook/blob/9c7f8c1ac4993c56658c4afacda5f3d40630d11e/internal/hook/hook.go#L797-L800

zry98

comment created time in a day

issue commentadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

What version of webhook are you using? If 2.7.0, I suspect this is a duplicate of #471.

zry98

comment created time in a day

issue openedadnanh/webhook

unsatisfied payload signature sub-rule in OR rule

I tried to set up a webhook rule to be triggered when the payload signature is verified with any one of multiple secrets, but I found that any unsatisfied payload signature sub-rule that appears before other sub-rules in the or rule will cause the parent rule be evaluated to false.

example config:

"trigger-rule": {
      "or": [
        {
          "match": {
            "type": "payload-hash-sha512",
            "secret": "secret-1",
            "parameter": {
              "source": "header",
              "name": "X-Signature"
            }
          }
        },
        {
          "match": {
            "type": "payload-hash-sha512",
            "secret": "secret-2",
            "parameter": {
              "source": "header",
              "name": "X-Signature"
            }
          }
        }
      ]
    },

requests signed by "secret-2" will never trigger the hook because an error will occurred:

error evaluating hook: invalid payload signatures [...]

created time in a day

issue closedadnanh/webhook

How to response json output?

Hi, I'm trying to receive docker hub webhook using the tool. It looks like docker hub is expecting some json response to determine request should considered successful or not. How can I send response as json?

Example json response would look like:

{
  "state": "success",
  "description": "387 tests PASSED",
  "context": "Continuous integration by Acme CI",
  "target_url": "https://ci.acme.com/results/afd339c1c3d27"
}

closed time in 3 days

shinebayar-g

issue commentadnanh/webhook

How to response json output?

Nevermind .. Turns out Docker hub webhook doesn't even check webhook response. It's always success.. I didn't have to send any response at all..

shinebayar-g

comment created time in 3 days

issue openedadnanh/webhook

How to response json output?

Hi, I'm trying to receive docker hub webhook using the tool. It looks like docker hub is expecting some json response to determine request should considered successful or not. How can I send response as json?

Example json response would look like:

{
  "state": "success",
  "description": "387 tests PASSED",
  "context": "Continuous integration by Acme CI",
  "target_url": "https://ci.acme.com/results/afd339c1c3d27"
}

created time in 3 days

pull request commentadnanh/webhook

Add service package

@adnanh, This PR is a preview of something I've been slowly whittling on. It all started by wanting to fix #393. I needed to be able to access the http.Server from the signal handlers.

This PR doesn't fix #393, but it does lay the groundwork to make that rather easy (see the KPR in the security package). However, there's a lot of changes here which may mean that I need to split this up into smaller steps so that it's easier to review, but I wanted to let you see where I'm headed.

It looks like adding the TLS Curves is a problem in Go 1.14 since the CurveID type didn't support the Stringer interface until Go 1.15. Instead of trying to work around that will build tags, I'll probably wait until Go 1.16 ships, and we can drop Go 1.14. 😃

No rush, but comments are welcome.

moorereason

comment created time in 3 days

PR opened adnanh/webhook

Add service package

To help facilitate new features, begin moving the main webhook service properties to a Service struct.

+370 -127

0 comment

6 changed files

pr created time in 3 days

push eventadnanh/webhook

Cameron Moore

commit sha 346c761ef6f504362bb0869eae5a894ad39f2f1f

Add request source Add "request" source with support for "method" and "remote-addr" parameters. Both values are taken from the raw http.Request object. Fixes #312

view details

Cameron Moore

commit sha 6f5962f8f2592b75ccf55900eb7d27512f99c74a

Use strings.ToLower on source name parameters

view details

Adnan Hajdarević

commit sha 3e18a060ae290e7fdd35d080aab5af4b3ecd7f35

Merge pull request #479 from moorereason/iss312-http-request Add request source

view details

push time in 3 days

PR merged adnanh/webhook

Add request source

Add "request" source with support for "method" and "remote-addr" parameters. Both values are taken from the raw http.Request object.

Fixes #312

+136 -28

0 comment

6 changed files

moorereason

pr closed time in 3 days

Pull request review commentadnanh/webhook

Add request source

 func (ha *Argument) Get(r *Request) (string, error) { 	case SourceHeader: 		source = &r.Headers 		key = textproto.CanonicalMIMEHeaderKey(ha.Name)+ 	case SourceQuery, SourceQueryAlias: 		source = &r.Query+ 	case SourcePayload: 		source = &r.Payload+ 	case SourceString: 		return ha.Name, nil++	case SourceRequest:+		if r == nil || r.RawRequest == nil {+			return "", errors.New("request is nil")+		}++		switch ha.Name {

Fixed

moorereason

comment created time in 3 days

Pull request review commentadnanh/webhook

Add request source

 func (ha *Argument) Get(r *Request) (string, error) { 	case SourceHeader: 		source = &r.Headers 		key = textproto.CanonicalMIMEHeaderKey(ha.Name)+ 	case SourceQuery, SourceQueryAlias: 		source = &r.Query+ 	case SourcePayload: 		source = &r.Payload+ 	case SourceString: 		return ha.Name, nil++	case SourceRequest:+		if r == nil || r.RawRequest == nil {+			return "", errors.New("request is nil")+		}++		switch ha.Name {

Let's do strings.ToLower(ha.Name) so that we avoid issues with "Method" not being matched :-)

moorereason

comment created time in 3 days

PR opened adnanh/webhook

Reviewers
Add request source

Add "request" source with support for "method" and "remote-addr" parameters. Both values are taken from the raw http.Request object.

Fixes #312

+136 -28

0 comment

6 changed files

pr created time in 4 days

pull request commentadnanh/webhook

Add support to ppc64le

We've actually moved to GitHub Actions in the development branch even though we haven't deleted the Travis config file. It's not clear to me in the GitHub Actions docs if it supports multiple architectures. Any advice?

gururajrkatti

comment created time in 4 days

PR opened adnanh/webhook

Add support to ppc64le

This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date. For more info tag @gerrith3

+6 -0

0 comment

1 changed file

pr created time in 4 days

pull request commentadnanh/webhook

Dockerfile

+1 to what @moorereason said, you can create a separate repo for this and I can link from the README if you want?

nvanheuverzwijn

comment created time in 5 days

push eventadnanh/webhook

Adnan Hajdarevic

commit sha 794a16ee1375ebda97dfecf478b3d006445c2857

wip

view details

push time in 5 days

push eventadnanh/webhook

Adnan Hajdarevic

commit sha 8431357269dd6972aef5d1364e8efa23beb25554

wip

view details

push time in 5 days

issue commentadnanh/webhook

Proposal: introduce context provider command support

Added some docs and an example to get the request IP :-)

adnanh

comment created time in 5 days

push eventadnanh/webhook

Adnan Hajdarevic

commit sha 528805584d36d33f20774a5c4498cba335b0f4fe

wip

view details

push time in 5 days

issue commentadnanh/webhook

Proposal: introduce context provider command support

Merged latest development changes, and imeplemented early abort if prehook command fails for any reason. Also renamed Context to PreHook where applicable.

Need docs & examples.

adnanh

comment created time in 5 days

push eventadnanh/webhook

Adnan Hajdarevic

commit sha 369cb0d3b665dd1d98d3842dd02f922660709f30

wip

view details

push time in 5 days

push eventadnanh/webhook

Adnan Hajdarevic

commit sha 4f1089495dbda946cc83748a0585b9e7a7cb3650

wip

view details

push time in 5 days

more