profile
viewpoint

graue/gentest 409

Generative testing for JavaScript. Save time and catch more bugs by letting the computer write test cases for you. WIP

graue/luasynth 63

Audio framework in Lua

graue/esofiles 43

The Esoteric File Archive

graue/immutable-vector 13

Immutable array for JavaScript supporting fast "modification" via structural sharing

graue/cljs-hex 9

The board game Hex, on the web

graue/intp 7

Tiny concatenative programming language

graue/burtleprng 4

JS pseudorandom number generator with repeatability, better randomness

graue/luabundle 3

Bundle Lua files together

graue/moon-noise 3

Noise generator

graue/mutatone 3

Evolves melodies (Automatic Music Hackathon project)

issue commentredux-saga/redux-saga

Call doesn't return if yields takeEvery inside.

This was surprising.

My intuition is that these two code snippets are equivalent:

// 1
function start() {
  window.addEventListener('resize', resizeHandler);
  console.log('done');
}
// 2
function installHandlers() {
  window.addEventListener('resize', resizeHandler);
}

function start() {
  installHandlers();
  console.log('done');
}

So it was unexpected to learn that yield call, which seemed to be the Saga equivalent of such a function call, changes the execution order.

mariuszdev

comment created time in 2 months

issue commenttwilio/twilio-webrtc.js

firefox: unsafe RTCSessionDescription shim

There's a similar problem with a reference to RTCPeerConnection

fippo

comment created time in 3 months

issue openedtwilio/twilio-video.js

Importing Twilio-Video breaks page in Firefox 70+ with RTC disabled

  • [x] I have verified that the issue occurs with the latest twilio-video.js release and is not marked as a known issue in the CHANGELOG.md.
  • [x] I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • [x] I verified that the Quickstart application works in my environment.
  • [x] I am not sharing any Personally Identifiable Information (PII) or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Code to reproduce the issue:

import TwilioVideo from 'twilio-video'

...in Firefox 70+ with media.peerconnection.enabled set to false in about:config.

Expected behavior:

Twilio SDK should see that WebRTC is not available and still allow other functions on the page to work.

Actual behavior:

Entire page is brought down at import time by undefined reference to global mozRTCSessionDescription (https://github.com/twilio/twilio-webrtc.js/issues/106).

When I tried patching around this, I hit another undefined reference to RTCPeerConnection.

These references both need to be fixed to ensure importing Twilio-Video, even when WebRTC is disabled, doesn't break non-call related functions on the page. The simplest fix would seem to be accessing both via window.

Software versions:

  • Browser(s): Firefox 70+
  • Operating System: Linux, but likely all
  • twilio-video.js: 2.0.0-beta15
  • Third-party libraries (e.g., Angular, React, etc.): not relevant

created time in 3 months

issue openedtwilio/twilio-video.js

Docs for LocalAudioTrack, LocalVideoTrack disappeared in 2.0.0-beta15

2.0.0-beta14 has documentation for these two classes:

https://media.twiliocdn.com/sdk/js/video/releases/2.0.0-beta14/docs/LocalAudioTrack.html https://media.twiliocdn.com/sdk/js/video/releases/2.0.0-beta14/docs/LocalVideoTrack.html

For 2.0.0-beta15 these are 404s:

https://media.twiliocdn.com/sdk/js/video/releases/2.0.0-beta15/docs/LocalAudioTrack.html https://media.twiliocdn.com/sdk/js/video/releases/2.0.0-beta15/docs/LocalVideoTrack.html

created time in 3 months

pull request commentJedWatson/react-input-autosize

Warning: componentWillReceiveProps has been renamed

Because the incompatibility with React 15.0 - 16.2 would be a breaking change, semantic versioning would require incrementing the major version of this package.

Libraries that depend on this one, like react-select, would then not get the upgrade by default, and would have to also bump their major versions if they manually took the upgrade.

It's preferable to let everyone get the immediate benefit of the console spam going away without having to go through all that.

ranneyd

comment created time in 3 months

issue openedxtermjs/xterm.js

Horizontal scrolling

We'd like to be able to scroll a terminal horizontally. It looks like this might be possible by generalizing somewhat the code that was added in #218. This has come up in the context of an accessibility concern where a user uses large fonts due to vision impairment.

created time in 4 months

pull request commentwestonganger/input-autogrow

Fix initializing on input with value " "

@westonganger 1.1.0 is still the latest on npm: https://www.npmjs.com/package/input-autogrow

graue

comment created time in 4 months

pull request commentwestonganger/input-autogrow

Fix initializing on input with value " "

Thanks for merging, @westonganger! When do you expect to cut a release with this?

graue

comment created time in 5 months

delete branch graue/input-autogrow

delete branch : patch-1

delete time in 5 months

PR opened westonganger/input-autogrow

Fix initializing on input with value " "

Fixes #9

+2 -2

0 comment

1 changed file

pr created time in 5 months

push eventgraue/input-autogrow

Scott Feeney

commit sha 5663490ed0f32098ac8ab4929fd4c16444c4f3fc

Fix initializing on input with value " " Fixes #9

view details

push time in 5 months

fork graue/input-autogrow

jQuery plugin for autogrowing inputs

fork in 5 months

issue openedwestonganger/input-autogrow

Breaks when initial value is single space

When $(...).inputAutogrow() is called on an input whose value is a single space, the code throws because it tries to read e.type in check, which has been called initially with no argument.

created time in 5 months

startedjonathantneal/closest

started time in 5 months

pull request commentJedWatson/react-input-autosize

Warning: componentWillReceiveProps has been renamed

This will make the lib incompatible with React 15.0 - 16.2. Better to just rename to UNSAFE_componentWillReceiveProps for now.

ranneyd

comment created time in 5 months

issue openedcyclejs-community/redux-cycles

What are the $s in variable names?

As a n00b to this library and observables, it's not clear why a lot of the variables in the README's examples have dollar signs at the end of their names.

Explaining the convention would make your project more accessible.

(Following the links to other libraries cited is not helpful either: the first code examples given in the docs for both Cycle.js and redux-observable also introduce dollar-sign variables with no explanation.)

created time in 5 months

startedmonicahq/monica

started time in 5 months

issue commentJedWatson/react-select

Deprecated lifecycle method warnings with React 16.9

Thanks @gwyneplaine for merging #3716. Would you mind cutting a release with the change?

Also, is there any chance you're in touch with Jed and could help us get a similar fix for his other project, https://github.com/JedWatson/react-input-autosize/issues/163?

GreenGremlin

comment created time in 6 months

more