profile
viewpoint
Graham Burgsma grahamburgsma @MindSea London, Canada

grahamburgsma/Meeting-Manager 1

Meeting scheduler Android app

grahamburgsma/Rave-Rush 1

Small game created for COSC 4P98 at Brock University

grahamburgsma/Alamofire 0

Elegant HTTP Networking in Swift

grahamburgsma/AlamofireImage 0

AlamofireImage is an image component library for Alamofire

grahamburgsma/BulletinBoard 0

General-purpose contextual cards for iOS

grahamburgsma/Chess 0

Chess with artificial intelligence using Minimax game tree and alpha beta pruning

grahamburgsma/DotMatrixPrinter 0

Dot matrix printer created with LEGO Mindstorm

grahamburgsma/edu-papers 0

Various papers written by me during my undergraduate degree at Brock University

grahamburgsma/FCM 0

⚡️ PushNotifications through FireBase for Vapor 3.

startedswift-aws/aws-sdk-swift

started time in 6 days

startedpryomoax/SwiftSSDP

started time in 11 days

issue openedpryomoax/SwiftSSDP

Update on new version?

Saw in the README you're working on a new version that uses Networking Framework and without any dependencies. I am very interested in the progress of that. Could you push your progress in a branch?

created time in 11 days

startedanupamchugh/iowncode

started time in 12 days

PR opened vapor-community/wkhtmltopdf

Version 4

I tested this one more thoroughly and fixed the README example.

@mcdappdev please review and test when you can!

+42 -24

0 comment

5 changed files

pr created time in 14 days

push eventgrahamburgsma/wkhtmltopdf-community

Graham Burgsma

commit sha fc9cba3dab069c749ebec56005ff4d40c5eabc78

Updated and tested README example

view details

push time in 14 days

push eventgrahamburgsma/wkhtmltopdf-community

Graham Burgsma

commit sha aa18c380c79fcfa3a1655e73ee746125f742e354

Removed threadPool default argument

view details

Graham Burgsma

commit sha fa155d2ffa678d78145af5e69bfff0a0cab48be2

Updated Document initializers with defaults instead of optionals

view details

Graham Burgsma

commit sha 5fb95da8d9967fa6843ec816a9f704afe57ec499

Updated and tested README example

view details

push time in 14 days

created taggrahamburgsma/wkhtmltopdf-community

tag3.0.1

Generate and return PDFs from Vapor views

created time in 14 days

push eventgrahamburgsma/wkhtmltopdf-community

Graham Burgsma

commit sha 9d2ed0eee02dee62b93049a2032e8c7a8d893f7f

Start thread pool before using

view details

Graham Burgsma

commit sha 77d66d3bbcec9305a432721367e98294699c6b15

Update README with 3.0.0 changes

view details

Jimmy McDermott

commit sha 48b481906636c33f6b369e6e254478aa53f86c86

Merge pull request #10 from grahamburgsma/fix-threadpool Fix threadpool usage and update README

view details

push time in 14 days

startedvapor-community/wkhtmltopdf

started time in 15 days

pull request commentvapor-community/wkhtmltopdf

Fix threadpool usage and update README

@mcdappdev could you please review?

grahamburgsma

comment created time in 15 days

PR opened vapor-community/wkhtmltopdf

Fix threadpool usage and update README

Realized a mistake in my previous PR, the thread pool must be started before using.

Also updated the README with the changes for 3.0.0.

+13 -12

0 comment

3 changed files

pr created time in 15 days

create barnchgrahamburgsma/wkhtmltopdf-community

branch : fix-threadpool

created branch time in 15 days

created taggrahamburgsma/wkhtmltopdf-community

tag3.0.0

Generate and return PDFs from Vapor views

created time in 15 days

delete branch grahamburgsma/wkhtmltopdf-community

delete branch : vapor-4

delete time in 15 days

push eventgrahamburgsma/wkhtmltopdf-community

Graham Burgsma

commit sha 3f516490d7040a970c72aaf7a66f93fbf9f674ac

Upgrade to Vapor 4

view details

Graham Burgsma

commit sha 909a4e06067f4d8af4a6274f6bdd9475f7f68bfa

Added option to specify threadpool on generatePDF.

view details

Jimmy McDermott

commit sha bc8fc2acf8ca4f07355d12db03803475339c82e3

Merge pull request #9 from grahamburgsma/vapor-4 Upgrade to NIO 2

view details

push time in 15 days

push eventgrahamburgsma/wkhtmltopdf-community

Graham Burgsma

commit sha 909a4e06067f4d8af4a6274f6bdd9475f7f68bfa

Added option to specify threadpool on generatePDF.

view details

push time in 15 days

Pull request review commentvapor-community/wkhtmltopdf

Upgrade to NIO 2

 import Foundation-import Service+import NIO  extension Document { -    public func generatePDF(on container: Container) throws -> Future<Data> {-        let sharedThreadPool = try container.make(BlockingIOThreadPool.self)--        return sharedThreadPool.runIfActive(eventLoop: container.eventLoop) { () -> Data in+    public func generatePDF(on eventLoop: EventLoop) throws -> EventLoopFuture<Data> {+        return NIOThreadPool(numberOfThreads: 1).runIfActive(eventLoop: eventLoop) {

Thanks @mcdappdev! Does it make sense to have a default argument in that case?

func generatePDF(on threadPool: NIOThreadPool = NIOThreadPool(numberOfThreads: 1), eventLoop: EventLoop)
grahamburgsma

comment created time in 15 days

startedMindSea/ShakyTweaksAndroid

started time in a month

PR opened vapor-community/wkhtmltopdf

Upgrade to NIO 2

Was going to update this package to Vapor 4, then realized the Vapor dependency isn't really necessary. So this now just depends on NIO 2.

However I haven't worked directly with NIO before so I'm looking for feedback.

  • Is NIOThreadPool(numberOfThreads: 1).runIfActive(eventLoop: eventLoop) the right way to replace what was there?
  • Also the unit test is failing with caught error: "ioOnClosedChannel" and I'm not sure wether my change to the library or tests is what's causing that.
+28 -17

0 comment

4 changed files

pr created time in 2 months

create barnchgrahamburgsma/wkhtmltopdf-community

branch : vapor-4

created branch time in 2 months

fork grahamburgsma/wkhtmltopdf-1

Generate and return PDFs from Vapor views

fork in 2 months

startedMihaelIsaev/wkhtmltopdf

started time in 2 months

startedxmartlabs/Eureka

started time in 2 months

startedOpenKitten/MongoKitten

started time in 2 months

startedfabianfett/pure-swift-json

started time in 2 months

issue commentjakob/Postico

Crash in Postico 1.5.11

It's working now, thanks!

jakob

comment created time in 2 months

issue commentjakob/Postico

Crash in Postico 1.5.11

Thanks for the quick fix! But I'm getting a 403 from the download link https://s3-eu-west-1.amazonaws.com/eggerapps-downloads/postico-1.5.12.zip

jakob

comment created time in 2 months

startedFlight-School/Money

started time in 2 months

fork grahamburgsma/wkhtmltopdf

📖 PDF render for Swift and Vapor 3.

fork in 2 months

startedpeek-travel/swift-currency

started time in 3 months

push eventgrahamburgsma/multipart-kit

Graham Burgsma

commit sha 0aab7475720aaecda8710e5c43f932153d14c457

Added test for failing Twilio response

view details

push time in 3 months

PR opened vapor/multipart-kit

Fix required bytes check

Fixes #43. I attempted writing a test for it but couldn't find a good way to get around the unprintable ASCII characters. Plus, Vapor 4 uses a C library so likely doesn't have this issue.

Would really appreciate if this could be merged and tagged. Thanks!

+1 -1

0 comment

1 changed file

pr created time in 3 months

issue openedvapor/multipart-kit

Parsing error

When parsing a response from Twilio it throws Invalid multipart formatting at this line https://github.com/vapor/multipart-kit/blob/f063180d0b84832accd33194e06ed3c41f8609ac/Sources/Multipart/MultipartParser.swift#L236 unless I change the < to <=.

Here's a debugPrint of the request content to test with. TwilioFaxTest.txt

created time in 3 months

create barnchgrahamburgsma/multipart-kit

branch : fix-multipart-formatting

created branch time in 3 months

fork grahamburgsma/multipart-kit

🏞 Parses and serializes multipart-encoded data with Codable support.

fork in 3 months

issue commentAlamofire/AlamofireImage

SPM support not working with 4.0.2

Thanks, it's working on master now 🎉

grahamburgsma

comment created time in 3 months

issue openedAlamofire/AlamofireImage

SPM support not working with 4.0.2

What did you do?

Add https://github.com/Alamofire/AlamofireImage.git as an SPM dependency.

What did you expect to happen?

Package would be added without errors.

What happened instead?

I get this error from Xcode. I tried resetting the SPM cache, but same error.

Package Resolution Failed
.../SourcePackages/checkouts/AlamofireImage submodule update --init --recursive output:
    fatal: No url found for submodule path 'Carthage/Checkouts/Alamofire' in .gitmodules

Looks like 4.0.2 meant to solve this but still has some issues.

created time in 3 months

issue commentalin23/Lunar

Ability to adjust brightness curve without affecting max brightness

@alin23 It's happening again, but I figured out the cause. The system brightness setting Automatically adjust brightness seems to affect the max brightness of the monitor. Even though the system brightness slider is at max. Not sure if that's fixable or a weird side effect of something Apple is doing.

Screen Shot 2020-03-02 at 7 22 36 AM Screen Shot 2020-03-02 at 7 22 55 AM

grahamburgsma

comment created time in 3 months

startedalin23/Lunar

started time in 3 months

issue closedalin23/Lunar

Ability to adjust brightness curve without affecting max brightness

Name of the feature

Ability to adjust brightness curve without affecting max brightness

What problem does this feature solve?

I'd like the ability to change the brightness curve to better match the brightness of my Mac (In adaptive mode). However changing the brightness offset also changes the max brightness. For example, -50 brightness offset makes my monitor brightness curve best match my Mac's brightness. However the max brightness is then 80 for the monitor. (Tested by setting Mac screen to full brightness, Lunar then shows 80 in the menu bar hover window.)

Interestingly a brightness offset of 0 makes the max brightness 96, which is odd. It's possible this is more of a bug than a new feature.

Love the app, let me know if you need more details!

closed time in 3 months

grahamburgsma

issue commentalin23/Lunar

Ability to adjust brightness curve without affecting max brightness

Min is 0, max is 100. However I reinstalled and restarted my computer and monitor, now it seems to be working as it should! I don't think I changed any settings, but oh well, it's working great now. Thanks for the support, closing this issue.

grahamburgsma

comment created time in 3 months

issue openedalin23/Lunar

Ability to adjust brightness curve without affecting max brightness

Name of the feature

Ability to adjust brightness curve without affecting max brightness

What problem does this feature solve?

I'd like the ability to change the brightness curve to better match the brightness of my Mac (In adaptive mode). However changing the brightness offset also changes the max brightness. For example, -50 brightness offset makes my monitor brightness curve best match my Mac's brightness. However the max brightness is then 80 for the monitor. (Tested by setting Mac screen to full brightness, Lunar then shows 80 in the menu bar hover window.)

Interestingly a brightness offset of 0 makes the max brightness 96, which is odd. It's possible this is more of a bug than a new feature.

Love the app, let me know if you need more details!

created time in 3 months

fork grahamburgsma/Alamofire

Elegant HTTP Networking in Swift

fork in 3 months

startedmxcl/PromiseKit

started time in 3 months

startedapple/swift-argument-parser

started time in 3 months

more