profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/gilbertw1/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Bryan Gilbert gilbertw1 Charleston, SC

dash-docs-el/helm-dash 464

Browse Dash docsets inside emacs

gilbertw1/akka-http-stream-example 60

An example program that uses the akka-http stream api

gilbertw1/cljs-asynchronize 60

Asynchronizes Yo Code

dash-docs-el/counsel-dash 56

Browse Dash docsets using Ivy

gilbertw1/better-jumper 51

A configurable jump list implementation for Emacs

gilbertw1/bmacs 37

Bryan's Emacs Configuration

dash-docs-el/dash-docs 32

A elisp library that exposes functionality to work with and search dash docsets.

gilbertw1/clipbot 5

A simple extensible irc/hipchat/slack bot written in clojure

gilbertw1/blog-gen 3

A hand rolled static (blog) site generator in clojure

issue commentgilbertw1/better-jumper

basic example use with evil

Hey,

You want to set better-jumper-use-evil-jump-advice to t. This will instruct better-jumper at attach advice to the evil add jump function that will make better-jumper track jumps from evil.

See more here: https://github.com/gilbertw1/better-jumper#use-evil-jump-advice-better-jumper-use-evil-jump-advice

jstaursky

comment created time in 9 days

issue commentgilbertw1/better-jumper

Use better-jump--last-jump-pos to detect duplicate calls of better-jumper-set-jump cause unexpected behavior (when use evil-mode)

Thanks for pointer, I believe your suggestion was definitely the correct approach here. I've pushed an update incorporating those changes.

Regarding your followup comment, I'm a bit torn. I think that having evil set a jump when find-file is invoked is definitely desirable. However, I'm not sure that better-jumper should be altering the behavior of evil whenever it's enabled versus leaving stock behavior alone and letting a user configure it themselves. I'll have to think on that one a bit more.

CloseToZero

comment created time in 2 months

issue closedgilbertw1/better-jumper

Use better-jump--last-jump-pos to detect duplicate calls of better-jumper-set-jump cause unexpected behavior (when use evil-mode)

better-jump--last-jump-pos is added at 7ae4011 to resolve #5, but it causes unexpected behavior (when use evil-mode).

Steps to reproduce:

Insert text:

abc-123
abc-456
abc-789

Search abc three times starting from the top of text by press / once and press n twice in normal state (NOTE: I use evil-search search module). After searching, the cursor position should at the third abc. Press C-o to go back to the second abc and then press / to search 456. Finally, press C-o again, I expect the cursor should go back to the second abc, but it goes to the first abc.

The reason is that better-jump--last-jump-pos is the same as (point) when I search 456 thus ignored by the advice of evil-set-jump.

Maybe we should use evil--jumps-jumping-backward to resolve #5 instead? The following workaround seems work fine:

(with-eval-after-load 'better-jumper
  (define-advice better-jumper--jump (:after (&rest _))
    "Don't use `better-jump--last-jump-pos' to detect duplicate calls of `better-jumper-set-jump'."
    (setq better-jump--last-jump-pos nil))
  
  ;; Instead, set `evil--jumps-jumping-backward' to non-nil to let
  ;; evil-mode know that we just jumped backward. It will be cleared
  ;; by evil-mode automatically.
  (add-hook 'better-jumper-post-jump-hook
            (lambda () (setq evil--jumps-jumping-backward t))))

closed time in 2 months

CloseToZero

push eventgilbertw1/better-jumper

Bryan Gilbert

commit sha 7f328a886ba4dd01993d269eee01c8ee3d0ddf52

Utilize evil jump var to avoid redundant jumps Set `evil--jumps-jumping-backward` when evil integration is enabled to prevent redundant jumps from being added. Fixes #15

view details

push time in 2 months

startedgpanders/ijq

started time in 2 months

issue commentgilbertw1/better-jumper

Use better-jump--last-jump-pos to detect duplicate calls of better-jumper-set-jump cause unexpected behavior (when use evil-mode)

Hey, thanks for taking the time to report this issue and research a workaround. I'll look into this shortly and test your suggestion.

CloseToZero

comment created time in 2 months

push eventgilbertw1/metaswitch-server

Bryan Gilbert

commit sha 5934c08405a95c393006f657e013eaff42304f8e

Update library versions and fix metacritic regex

view details

push time in 2 months

issue commentgilbertw1/drop

[FYI] warnings emitted when building AUR package

Thanks for the heads up! I'll be making a code cleanup pass soon

glitsj16

comment created time in 2 months

release gilbertw1/drop

0.3.3

released time in 2 months

created taggilbertw1/drop

tag0.3.3

A simple screenshot, screencast, and file upload tool with S3 support written in rust.

created time in 2 months

push eventgilbertw1/drop

Bryan Gilbert

commit sha ec0ab1d35dda55642fc40c077fc26fe2fd328cc3

Remove keybinder; Doc updates

view details

push time in 2 months

issue commentgilbertw1/better-jumper

better-jumper-forward/backward not working with `lsp-find-references`

Hi,

Sorry for taking so long to respond. Better jumper doesn't actually capture jumps, moreso it exposes functions to add, track, and navigate between jumps. It's possible that doom-emacs has changed or removed some hooks around this functionality, however you can create a function that adds a jump then performs the definition lookup like this:

(defun jump-to-def ()
    (interactive)
    (better-jumper-set-jump)
    (lsp-find-definition))

The above function should work the way you expect.

SreenivasVRao

comment created time in 3 months

startedgilbertw1/better-jumper

started time in 3 months