garrison ( Jim Garrison )

Your PRs are quite comprehensive and touch many aspects of the project. As such, can you tag a new version before and after each PR? I think there is no harm is tagging lots of versions, and would let us easily roll back if an issue arrises.
Could you described in the PRs not just what you are doing, but why. It only needs to be a single line of text. But for this example, what is clang? why would we switch to it? what's the benifit? what's the negative? and most importantly for me as a reviewer, what's the potential complications this issue may raise that I should look for (e.g. is it likely to complicate things in different operating systems? is it likely to add latency to the audio? is it likely to add clicks at audio onset etc).

I appreciate all the love you've been giving this package recently. Awesome stuff.

bramtayl

comment created time in 2 days

startedaheissenberger/vlang-aws-lambda

started time in 2 days

pull request commentJuliaAudio/PortAudio.jl

use Clang wrappers

Note: I'm guessing this will tank coverage because of all the new automatically generated and unused wrappers

bramtayl

comment created time in 3 days

pull request commentJuliaAudio/PortAudio.jl

use Clang wrappers

Ok, so, I figured as long as I'm doing a rewrite for #63, might as well implement it as well. This could probably use an extra set of eyes.

bramtayl

comment created time in 3 days

startedgarrison/ietl

started time in 4 days

issue commentJutho/WignerSymbols.jl

Thread-safety

Any Mac or Linux experiences, in particular with respect to performance, are certainly also welcome :-)

jagot

comment created time in 4 days

issue commentJutho/WignerSymbols.jl

Thread-safety

Sadly (or maybe not?) I'm not using Windows either, only Mac and Linux. I will see if I know someone who can test running my code which is dependent on WignerSymbols.jl on a real Windows machine.

jagot

comment created time in 4 days

issue commentJutho/WignerSymbols.jl

Thread-safety

Ok, I am in particular interested to know your impressions if you are working on a Windows. CI was giving some unexpected failures on Windows, but I don't have a Windows machine to test it locally. So I disabled the use of multiple threads on Windows for the CI.

I've made several reasoning mistakes about thread safety during the developments, but I don't see what could still go wrong now, and on Linux and Mac everything seems to be working fine.

jagot

comment created time in 4 days

pull request commentJutho/WignerSymbols.jl

local caching

Dear @xzackli , I finally updated WignerSymbols.jl to be thread safe. While I ended up with a different implementation than yours, your early PR was very useful, so thanks again.

xzackli

comment created time in 4 days

issue commentJutho/WignerSymbols.jl

Thread-safety

Wohoo, thanks! Will check it out pronto.

jagot

comment created time in 4 days

issue closedJutho/WignerSymbols.jl

Thread-safety

Related to #12 & #13.

I got bitten by this today, when I noticed that rotation matrices built from Clebsch--Gordan coefficients were no longer unitary, and a little later Julia crashed because of undefined reference when trying to access the factorial table out-of-bounds.

I appreciate that making WignerSymbols.jl fully thread-safe, while desirable, is a major undertaking. As a stop-gap solution, can I "warm start" by computing a large factorial once, populating the cache to cover all cases I will later need in the threaded section? I rarely need larger angular momenta than a few hundred.

closed time in 4 days

jagot

issue commentJutho/WignerSymbols.jl

Thread-safety

I've just released v2.0 which is thread safe. It was a major undertaking indeed, but I believe it was a necessary one.

jagot

comment created time in 4 days

created tagJutho/WignerSymbols.jl

tagv2.0.0

A Julia package for computing Wigner symbols and related quantities

created time in 4 days

issue commentJutho/WignerSymbols.jl

TagBot trigger issue

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/38926

JuliaTagBot

comment created time in 4 days

issue closedJutho/WignerSymbols.jl

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers. Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue. I'll open a PR within a few hours, please be patient!

closed time in 4 days

JuliaTagBot

issue openedJutho/WignerSymbols.jl

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers. Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue. I'll open a PR within a few hours, please be patient!

created time in 4 days

CommitCommentEvent

push eventJutho/WignerSymbols.jl

Jutho Haegeman

commit sha c12478f6f051ac6fdb31bb8a208cfde9b208bcbc

fix compat

view details

push time in 4 days

CommitCommentEvent

push eventJutho/WignerSymbols.jl

Jutho Haegeman