💉 An "/etc/hosts" injection tool to resolve names of local Docker containers on the host. Now rewritten in bash!
Composer container with Prestissimo preinstalled to download dependencies in parallel
Scaffold out common pieces of laravel projects
Client side encrypted pastebin
Limited DNS server with RESTful HTTP API to handle ACME DNS challenges easily and securely.
🎄 Advent of Code 2015 solutions in Node.js with Mocha unit tests
🎄 Advent of Code 2017 solutions in Node.js with Mocha unit tests
issue closedHypfer/Valetudo
Disabling homeassistant breaks mqtt commands on 2021.04
<!-- Text between these tags doesn't get displayed so you don't have to remove it -->
Describe the bug
<!-- A clear and concise description of what the bug is. --> I tried controlling my s5 max with valetudo via mqtt (node red). When sending START / HOME via mqtt i noticed that nothing happened and after that the valetudo ui was unavailable. After some fiddling and starting valetudo in the foreground i noticed this stack trace:
[2021-05-16T14:34:08.761Z] [INFO] exiting with code 1...
[2021-05-16T14:34:08.765Z] [ERROR] Stacktrace that lead to the process exiting: Error
at process.<anonymous> (/snapshot/Valetudo/index.js:35:70)
at process.emit (events.js:315:20)
at process._fatalException (internal/process/execution.js:170:19)
/snapshot/Valetudo/lib/mqtt/MqttController.js:322
if (topic.startsWith(this.hassController.autoconfPrefix + "/") && message.toString().length > 0) {
^
TypeError: Cannot read property 'autoconfPrefix' of null
at MqttClient.<anonymous> (/snapshot/Valetudo/lib/mqtt/MqttController.js:322:58)
at MqttClient.emit (events.js:315:20)
at MqttClient._handlePublish (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:1277:12)
at MqttClient._handlePacket (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:410:12)
at work (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:321:12)
at Writable.writable._write (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:335:5)
at doWrite (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:409:139)
at writeOrBuffer (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:398:5)
at Writable.write (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:307:11)
at Socket.ondata (internal/streams/readable.js:719:22)
So i started looking for something like "autoconf" in the mqtt settings, then i remembered that i disabled the home assistant stuff. After enabling that again, all worked.
To Reproduce
- Disable home assistant
- Send start/home/stop via mqtt (mosquitto_pub -h localhost -m "HOME" -t "valetudo/robot/BasicControlCapability/operation/set")
- See that UI is broken and valetudo is not running anymore on the ui.
- Validate the stacktrace via
VALETUDO_CONFIG_PATH=/mnt/data/valetudo_config.json /mnt/data/valetudo
Vacuum Model
Roborock S5 Max
Valetudo Version
2021.04
Expected behavior
Well either everything working or at least a note when disabling home assistant. Everything but crashing would be great :)
closed time in a day
jweiherissue commentHypfer/Valetudo
Disabling homeassistant breaks mqtt commands on 2021.04
Fixed with #912
comment created time in a day
issue openedHypfer/Valetudo
Disabling homeassistant breaks mqtt commands on 2021.04
<!-- Text between these tags doesn't get displayed so you don't have to remove it -->
Describe the bug
<!-- A clear and concise description of what the bug is. --> I tried controlling my s5 max with valetudo via mqtt (node red). When sending START / HOME via mqtt i noticed that nothing happened and after that the valetudo ui was unavailable. After some fiddling and starting valetudo in the foreground i noticed this stack trace:
[2021-05-16T14:34:08.761Z] [INFO] exiting with code 1...
[2021-05-16T14:34:08.765Z] [ERROR] Stacktrace that lead to the process exiting: Error
at process.<anonymous> (/snapshot/Valetudo/index.js:35:70)
at process.emit (events.js:315:20)
at process._fatalException (internal/process/execution.js:170:19)
/snapshot/Valetudo/lib/mqtt/MqttController.js:322
if (topic.startsWith(this.hassController.autoconfPrefix + "/") && message.toString().length > 0) {
^
TypeError: Cannot read property 'autoconfPrefix' of null
at MqttClient.<anonymous> (/snapshot/Valetudo/lib/mqtt/MqttController.js:322:58)
at MqttClient.emit (events.js:315:20)
at MqttClient._handlePublish (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:1277:12)
at MqttClient._handlePacket (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:410:12)
at work (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:321:12)
at Writable.writable._write (/snapshot/Valetudo/node_modules/mqtt/lib/client.js:335:5)
at doWrite (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:409:139)
at writeOrBuffer (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:398:5)
at Writable.write (/snapshot/Valetudo/node_modules/readable-stream/lib/_stream_writable.js:307:11)
at Socket.ondata (internal/streams/readable.js:719:22)
So i started looking for something like "autoconf" in the mqtt settings, then i remembered that i disabled the home assistant stuff. After enabling that again, all worked.
To Reproduce
- Disable home assistant
- Send start/home/stop via mqtt (mosquitto_pub -h localhost -m "HOME" -t "valetudo/robot/BasicControlCapability/operation/set")
- See that UI is broken and valetudo is not running anymore on the ui.
- Validate the stacktrace via
VALETUDO_CONFIG_PATH=/mnt/data/valetudo_config.json /mnt/data/valetudo
Vacuum Model
Roborock S5 Max
Valetudo Version
2021.04
Expected behavior
Well either everything working or at least a note when disabling home assistant. Everything but crashing would be great :)
created time in a day
push eventHypfer/Valetudo
commit sha e331eda332e12a138cd1d7e8b8994208f714833a
fix(timers): Copy-paste antipattern
push time in a day
push eventHypfer/Valetudo
commit sha 7b8c37ad1006aec62e1f19e5aec83d54da94189d
feat: Timers
push time in a day
push eventHypfer/Valetudo
commit sha fd79163c3e9328562346a789ad5cec6e73bfe52d
fix(ui): DND should be rendered as localtime but stored as UTC
push time in 2 days
push eventHypfer/Valetudo
commit sha 8fc9ea88d81505259f53e0dad5be3ed0e05d5d6f
fix(vendor.roborock): Handle DND as UTC
push time in 2 days
issue closedHypfer/Valetudo
MQTT doesn't work sometimes after Valetudo start
<!-- Text between these tags doesn't get displayed so you don't have to remove it -->
Describe the bug
<!--
A clear and concise description of what the bug is.
-->
Vacuum can be unavailable or only one topic is published regulary (last time - vacuum_sensor_WifiConfigurationCapability) after Valetudo start.
To Reproduce
<!-- Steps to reproduce the behavior: -->
- Wait until vacuum reboot (my vacuum reboots every night) or reboot it manually.
- If MQTT works - try again.
Screenshots
<!--If applicable, add screenshots to help explain your problem.-->
Vacuum Model
<!-- e.g. Roborock S5/Dreame D9/etc --> Gen 1
Valetudo Version
<!-- e.g. 2021.1.1 --> 2021.04.0
Additional context
<!-- Add any other context about the problem here. --> <details> <summary>Log</summary>
[2021-05-11T00:52:52.792Z] [INFO] Loading configuration file: /mnt/data/valetudo/valetudo_config.json
[2021-05-11T00:52:52.824Z] [INFO] Set Logfile to /tmp/valetudo.log
[2021-05-11T00:52:52.835Z] [INFO] Autodetected RoborockV1ValetudoRobot
[2021-05-11T00:52:53.069Z] [INFO] Starting Valetudo 2021.04.0
[2021-05-11T00:52:53.071Z] [INFO] Commit ID: 7d28ac85cea7a4081f49fe199f19adf678778f78
[2021-05-11T00:52:53.072Z] [INFO] Configuration file: /mnt/data/valetudo/valetudo_config.json
[2021-05-11T00:52:53.074Z] [INFO] Logfile: /tmp/valetudo.log
[2021-05-11T00:52:53.075Z] [INFO] Robot: Beijing Roborock Technology Co., Ltd. Xiaomi Mi Robot Vacuum (RoborockV1ValetudoRobot)
[2021-05-11T00:52:53.076Z] [INFO] JS Runtime Version: v14.16.1
[2021-05-11T00:52:53.077Z] [INFO] Arch: arm
[2021-05-11T00:52:53.079Z] [INFO] Max Heap Size: 34 MiB
[2021-05-11T00:52:53.080Z] [INFO] Node Flags: --expose-gc --max-heap-size=34
[2021-05-11T00:52:53.092Z] [INFO] DeviceId 259770451
[2021-05-11T00:52:53.093Z] [INFO] IP 127.0.0.1
[2021-05-11T00:52:53.094Z] [INFO] CloudSecret xxx
[2021-05-11T00:52:53.096Z] [INFO] LocalSecret xxx
[2021-05-11T00:52:53.636Z] [INFO] Dummycloud is spoofing 127.0.0.1:8053 on 127.0.0.1:8053
[2021-05-11T00:52:53.646Z] [INFO] Webserver running on port [33m80[39m
[2021-05-11T00:52:53.666Z] [INFO] Map Upload Server running on port 8079
[2021-05-11T00:52:58.655Z] [WARN] Error during time sync: Error: getaddrinfo EAI_AGAIN time.lan
[90m at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:67:26)[39m {
errno: [33m-3001[39m,
code: [32m'EAI_AGAIN'[39m,
syscall: [32m'getaddrinfo'[39m,
hostname: [32m'time.lan'[39m
}
[2021-05-11T00:52:59.819Z] [INFO] Connected successfully to MQTT broker
[2021-05-11T00:53:00.550Z] [INFO] Cloud connected
[2021-05-11T00:53:00.915Z] [INFO] MQTT configured
[2021-05-11T00:53:00.984Z] [WARN] MQTT handle home/vacuum/MapData failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at MapNodeMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:00.993Z] [WARN] MQTT handle home/vacuum/FanSpeedControlCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at IntensityPresetCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at IntensityPresetCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:00.997Z] [WARN] MQTT handle home/vacuum/BasicControlCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at BasicControlCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at BasicControlCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.001Z] [WARN] MQTT handle home/vacuum/ConsumableMonitoringCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at ConsumableMonitoringCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at ConsumableMonitoringCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.005Z] [WARN] MQTT handle home/vacuum/ZoneCleaningCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at ZoneCleaningCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at ZoneCleaningCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.009Z] [WARN] MQTT handle home/vacuum/GoToLocationCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at GoToLocationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at GoToLocationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.013Z] [WARN] MQTT handle home/vacuum/WifiConfigurationCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at WifiConfigurationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at WifiConfigurationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.017Z] [WARN] MQTT handle home/vacuum/LocateCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at LocateCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at LocateCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.021Z] [WARN] MQTT handle home/vacuum/StatusStateAttribute failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at StatusStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at StatusStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.024Z] [WARN] MQTT handle home/vacuum/BatteryStateAttribute failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at BatteryStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at BatteryStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.036Z] [WARN] MQTT handle home/vacuum/MapData failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at MapNodeMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.039Z] [WARN] MQTT handle home/vacuum/FanSpeedControlCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at IntensityPresetCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at IntensityPresetCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.042Z] [WARN] MQTT handle home/vacuum/BasicControlCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at BasicControlCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at BasicControlCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.045Z] [WARN] MQTT handle home/vacuum/ConsumableMonitoringCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at ConsumableMonitoringCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at ConsumableMonitoringCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.049Z] [WARN] MQTT handle home/vacuum/ZoneCleaningCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at ZoneCleaningCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at ZoneCleaningCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.052Z] [WARN] MQTT handle home/vacuum/GoToLocationCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at GoToLocationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at GoToLocationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.055Z] [WARN] MQTT handle home/vacuum/WifiConfigurationCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at WifiConfigurationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at WifiConfigurationCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.058Z] [WARN] MQTT handle home/vacuum/LocateCapability failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at LocateCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at LocateCapabilityMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.061Z] [WARN] MQTT handle home/vacuum/StatusStateAttribute failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at StatusStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at StatusStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:01.064Z] [WARN] MQTT handle home/vacuum/BatteryStateAttribute failed to configure Error: Handle may only be configured while the MQTT controller is not initialized
at BatteryStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:160:19)
at BatteryStateMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/RobotStateNodeMqttHandle.js:30:21)
at RobotMqttHandle.configure (/snapshot/Valetudo/lib/mqtt/handles/MqttHandle.js:167:29)
[90m at processTicksAndRejections (internal/process/task_queues.js:93:5)[39m
at async /snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:110:13
at async MqttController.reconfigure (/snapshot/Valetudo/lib/mqtt/MqttController.js:497:13)
at async RobotMqttHandle.onStatusAttributeEvent (/snapshot/Valetudo/lib/mqtt/handles/RobotMqttHandle.js:97:9)
[2021-05-11T00:53:59.004Z] [INFO] Successfully set the robot time via NTP to [35m2021-05-11T00:53:59.891Z[39m
[2021-05-11T08:00:02.791Z] [WARN] Failed to parse uploaded map
[2021-05-11T08:00:04.790Z] [WARN] Failed to parse uploaded map
[2021-05-11T08:06:23.972Z] [INFO] Cloud message timed out. Assuming that we're not connected anymore
[2021-05-11T08:06:41.749Z] [INFO] Cloud connected
[2021-05-11T08:13:23.975Z] [INFO] Cloud message timed out. Assuming that we're not connected anymore
[2021-05-11T08:13:42.476Z] [INFO] Cloud connected
[2021-05-11T08:15:05.791Z] [INFO] Cloud message timed out. Assuming that we're not connected anymore
[2021-05-11T08:15:23.176Z] [INFO] Cloud connected
[2021-05-11T08:24:45.515Z] [INFO] Cloud message timed out. Assuming that we're not connected anymore
[2021-05-11T08:25:03.951Z] [INFO] Cloud connected
[2021-05-11T08:25:04.402Z] [INFO] Cloud message timed out. Assuming that we're not connected anymore
[2021-05-11T08:25:04.773Z] [INFO] Cloud connected
</details>
closed time in 2 days
definitiopush eventHypfer/Valetudo
commit sha e350eba43ab36076d406c02f933c7be108cc8e99
feat(ntpClient): Keep track of the current state and enable configuration via REST
push time in 2 days
issue commentHypfer/Valetudo
MQTT doesn't work sometimes after Valetudo start
Latest works for 4 days without issues.
comment created time in 2 days
issue commentHypfer/Valetudo
MQTT doesn't work sometimes after Valetudo start
I may be hitting this same issue. If not, i am more than happy to open a dedicated thread.
I can delete my vac from HA and reboot the device. After several seconds, I'll see a flurry of activity on the
homeassistant/#andvaletudo/#topics. HA will then show 11 entities for my vac on the device registry, but each entity will beUnavailable.I think this is due to the
availability_topicthat is being configured in the discovery messages.For example:
topic:
homeassistant/sensor/rosie/rosie_sensor_error/config{"state_topic":"valetudo/rosie/StatusStateAttribute/error","icon":"mdi:alert","name":"Error description","unique_id":"rosie_sensor_error","availability_topic":"valetudo/rosie/$state","payload_available":"ready","payload_not_available":"lost","availability_mode":"latest","device":{"manufacturer":"Beijing Roborock Technology Co., Ltd.","model":"S6","name":"rosie","identifiers":["rosie"],"sw_version":"2021.04.0 (Valetudo)"}}I do not see any messages on my MQTT broker under the
valetudo/rosie/$statetopic, though.Is this the same issue that @definitio can no longer reproduce or should I open a new ticket?
IDK, you haven't shown any logs.
Both of you should try building from latest master and see if it still happens.
comment created time in 2 days
issue commentHypfer/Valetudo
MQTT doesn't work sometimes after Valetudo start
I may be hitting this same issue. If not, i am more than happy to open a dedicated thread.
I can delete my vac from HA and reboot the device. After several seconds, I'll see a flurry of activity on the homeassistant/# and valetudo/# topics. HA will then show 11 entities for my vac on the device registry, but each entity will be Unavailable.
I think this is due to the availability_topic that is being configured in the discovery messages.
For example:
topic: homeassistant/sensor/rosie/rosie_sensor_error/config
{"state_topic":"valetudo/rosie/StatusStateAttribute/error","icon":"mdi:alert","name":"Error description","unique_id":"rosie_sensor_error","availability_topic":"valetudo/rosie/$state","payload_available":"ready","payload_not_available":"lost","availability_mode":"latest","device":{"manufacturer":"Beijing Roborock Technology Co., Ltd.","model":"S6","name":"rosie","identifiers":["rosie"],"sw_version":"2021.04.0 (Valetudo)"}}
I do not see any messages on my MQTT broker under the valetudo/rosie/$state topic, though.
Is this the same issue that @definitio can no longer reproduce or should I open a new ticket?
comment created time in 2 days
issue commentHypfer/Valetudo
Error during time sync with disabled ntp
Thanks for the fix!
comment created time in 2 days
push eventHypfer/Valetudo
commit sha 949d8e306b5de34c3a3755532f269f009eb50c51
fix(ntpClient): Support disabling the ntpClient this fixes #925
push time in 2 days
issue closedHypfer/Valetudo
Error during time sync with disabled ntp
<!-- Text between these tags doesn't get displayed so you don't have to remove it -->
Describe the bug
Even after setting ntp to false in the config file, I get [2021-05-15T16:16:51.347Z] [WARN] Error during time sync: Error: Timeout waiting for NTP response in the logs.
Vacuum Model
Roborock S5
Valetudo Version
2021.04.0
closed time in 2 days
xoxysissue commentHypfer/Valetudo
Error during time sync with disabled ntp
Uhm. Uh
Apparently that was never implemented
Nice find!
comment created time in 2 days
issue openedHypfer/Valetudo
Error during time sync with disabled ntp
<!-- Text between these tags doesn't get displayed so you don't have to remove it -->
Describe the bug
Even after setting ntp to false in the config file, I get [2021-05-15T16:16:51.347Z] [WARN] Error during time sync: Error: Timeout waiting for NTP response in the logs.
Vacuum Model
Roborock S5
Valetudo Version
2021.04.0
created time in 2 days
startedlucent-sea/Remotely
started time in 4 days
push eventHypfer/Valetudo
commit sha 25411138688454d43026d07c12e46b5eab5e9269
feat(vendor.roborock): Add support for ordered segment cleanup with multiple iterations
push time in 4 days
push eventclevyr/homebrew-tap
commit sha 038de77c5cd0e5e1d36f6d8026131f19c450ceb2
Brew formula update for scaffold version v0.4.9
push time in 5 days
push eventclevyr/homebrew-tap
commit sha 3fcf06597b3b185bbee36ca15ba83da0fbbe0455
Brew formula update for scaffold version v0.4.8
push time in 5 days
PR closed Hypfer/Valetudo
Type of change
Type A:
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Refactor/Code Cleanup
- [ ] Docs
- [ ] Capability implementation for existing core capability
- [ ] New robot implementation
Type B:
- [ ] New capability
- [ ] New core feature
Description
It's not necessary to resend not changed data because messages have a retain flag.
pr closed time in 6 days
pull request commentHypfer/Valetudo
Publish only changed data to MQTT
While of course appreciated, I have to reject this one, because caching not only introduces a multitude of possible issues but also permanently rests in RAM which may be quite limited.
Since there is no real issue arising from republishing the same data, we can avoid those downsides
comment created time in 6 days
PR opened Hypfer/Valetudo
Type of change
Type A:
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Refactor/Code Cleanup
- [ ] Docs
- [ ] Capability implementation for existing core capability
- [ ] New robot implementation
Type B:
- [ ] New capability
- [ ] New core feature
Description
It's not necessary to resend not changed data because messages have a retain flag.
pr created time in 6 days
push eventHypfer/Valetudo
commit sha 835befab88a5531d6de14437a96ece08c5a03347
test(vendor.roborock): Add S6 testcase with no-mop-zones and active segments
push time in 6 days