profile
viewpoint
Flarnie Marchan flarnie Oakland, CA http://www.flarnie.com Software Engineer at Chegg Former React Core Team & Co-maintainer of Draft.js

bvaughn/react 11

A declarative, efficient, and flexible JavaScript library for building user interfaces.

flarnie/dotvim 3

Configurations for Vim

flarnie/CIsForCoding 2

A playground for learning C

flarnie/diffux 1

A tool to diff website snapshots

flarnie/dotfiles2 1

General dotfile configurations (excluding Vim configs)

flarnie/draft-js 1

A React framework for building text editors.

flarnie/accio 0

Configurable generator creation tool for node.js. Write JS faster; `accio GENERATOR NAME ARGS`

flarnie/bistro 0

Bistro is a flexible distributed scheduler, a high-performance framework supporting multiple paradigms while retaining ease of configuration, management, and monitoring.

flarnie/BridgeIC 0

Firmware for BridgeIC functionality for 1S servers for Yosemite Platform

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 843aa28838baeaea21fb05e08a64e4bafaf1adea

Finish **what is the change?:** everything **why make this change?:** - **test plan:** manual testing **issue:** none

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 4685f3cedfa5585cafc253af65a7ae4f935fde57

Delete style.css

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha ecba4c8f8dc2071bddbcbd923c8ee8998534fd97

checking if styling h1 will work

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 5704095697750b37d95fbb259a846b29f0c27e59

add inline style tag to test

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 963466a770ca1b34f66e4895ebd8442da2ce6d41

add test style

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 8d4b887386fb86cfb6fd5de3a98617d54c30ad0f

add link to style file

view details

push time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha 9ec30e7ba449a4954c7b00c9d4ba4d1a7ab4bb7e

Create index.html

view details

push time in 2 months

create barnchflarnie/foodie_dice

branch : master

created branch time in 2 months

created repositoryflarnie/foodie_dice

What's for dinner???

created time in 2 months

push eventflarnie/foodie_dice

Flarnie Marchan

commit sha b028f1edc0693b100593bfef722b0799791d629c

Set theme jekyll-theme-slate

view details

push time in 2 months

create barnchflarnie/foodie_dice

branch : master

created branch time in 2 months

created repositoryflarnie/foodie_dice

what's for dinner???

created time in 2 months

push eventflarnie/react

Ivan Babak

commit sha bfbde71657dacd2e418bd1868320da41bc1ecbac

Fix Flow failure on CircleCI due to the number of workers https://github.com/flowtype/flow-bin/issues/138#issuecomment-448416874 https://github.com/flowtype/flow-bin/issues/138#issuecomment-450367472 > This will stop flow from trying to consume too many virtual CPUs (which CircleCI doesn't actually provide), letting it run to completion without first running out of memory and killing its sub processes. The log output in CircleCI was: https://circleci.com/gh/bvaughn/react-devtools-experimental/201 ``` #!/bin/bash -eo pipefail yarn flow yarn run v1.10.1 $ /home/circleci/repo/node_modules/.bin/flow Launching Flow server for /home/circleci/repo Spawned flow server (pid=259) Logs will go to /tmp/flow/zShomezScirclecizSrepo.log Monitor logs will go to /tmp/flow/zShomezScirclecizSrepo.monitor_log Launching Flow server for /home/circleci/repo Spawned flow server (pid=361) Logs will go to /tmp/flow/zShomezScirclecizSrepo.log Monitor logs will go to /tmp/flow/zShomezScirclecizSrepo.monitor_log Launching Flow server for /home/circleci/repo Spawned flow server (pid=464) Logs will go to /tmp/flow/zShomezScirclecizSrepo.log Monitor logs will go to /tmp/flow/zShomezScirclecizSrepo.monitor_log Launching Flow server for /home/circleci/repo Spawned flow server (pid=567) Logs will go to /tmp/flow/zShomezScirclecizSrepo.log Monitor logs will go to /tmp/flow/zShomezScirclecizSrepo.monitor_log Lost connection to the flow server (0 retries remaining): -Out of retries, exiting! error Command failed with exit code 7. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. Exited with code 1 ```

view details

Brian Vaughn

commit sha 44205f16d9924f0f053c2ff3e103e1bb40a1d4c7

Merge pull request #247 from sompylasar/fix-flow-on-circleci Fix Flow failure on CircleCI due to the number of workers

view details

Brian Vaughn

commit sha da951ec9bb9f7cf4835f8c1a1d30170cafedce84

Merge pull request #243 from sompylasar/rename-profiler-types-to-frontend-backend-to-disambiguate Rename Profiler types to disambiguate which is Frontend and Backend

view details

Brian Vaughn

commit sha 9e1b1e8c91bd7e7bab4760afffa695d139f3bc07

Merge pull request #233 from gaearon/preset-env Start using @babel/preset-env

view details

Brian Vaughn

commit sha b24216a7b1d27402a7f9937dc9eefe18f5372005

Merge pull request #234 from gaearon/nested-suspense-test Add test coverage for nested Suspense

view details

Brian Vaughn

commit sha 5204ae87bcd013aa1fa1fded6be8dea5ac99c13d

Merge pull request #229 from sompylasar/217-workaround-disconnected-port-error Fix for 'Attempting to use a disconnected port object'

view details

Brian Vaughn

commit sha abcb613223c132dcd0e09a6941c628a0177a1d7a

Minor Bridge code tweaks: 1. Renamed a variable 2. Coerced undefined to null 3. Added a couple of console.warn() for unexpected paths

view details

Ivan Babak

commit sha d1f6e762e483b134449d458b28dedab432bb264d

Improve Flow coverage by reducing typecasts through `any` There are many unnecessary typecasts through `any` which break the Flow of types across the program. It's more bulletproof to avoid lying to ourselves about types. Also fixed sketchy null check where zero ID would be skipped: ```diff - } else if (selectedElementID) { + } else if (selectedElementID !== null) { ```

view details

Ivan Babak

commit sha c6c71ef8f900341bfd2778c8dd60a45f34ec0273

Fix profiling screenshots data structure to map rootID to commitIndex Propagate `rootID` throughout the code for `captureScreenshot`. Rename private profiling maps of `store` to make relations more clear. Fix missing cleanup for screenshots data in `set importedProfilingData` of `store`.

view details

Ivan Babak

commit sha cd89c0d75f6e323a3e3fc16ef9e2d09dc93675ed

Clear profiling data for root when the root is unmounted Fixes https://github.com/bvaughn/react-devtools-experimental/issues/232

view details

Dan Abramov

commit sha b9ae9393b9000bc43c8039ad80faa84c96469e6c

Use WebpackDevServer for local testing

view details

Brian Vaughn

commit sha a9aa9f210637c6b74fab768e63f899b6a4216e0f

Merge pull request #251 from gaearon/devserver Use WebpackDevServer for local testing

view details

Brian Vaughn

commit sha 18b34b49268ab9256e5408b1746da4a45eec5ca1

Rearranged Settings UI in prep for custom filter controls

view details

Brian Vaughn

commit sha 17c5feb66a625be8c6a3b223dedca29333de77db

Reorganized types shared between backend and frontend slightly.

view details

Brian Vaughn

commit sha 9db209ee64b6eb12cbfb9cae8c74027fb2317d1f

Initial pass at adding filter-by-type Flow types and support to renderer

view details

Brian Vaughn

commit sha ee1b38e4dbfdf674ecdb17d3a07a1375ed01979a

Added filter preference types and plugged into renderer partly. Lots of work to do still.

view details

Brian Vaughn

commit sha 27a182003913e80771cbe0d4f44a026bdc7a15f3

Refactored filter preferences a bit more to be stored in the Store

view details

Brian Vaughn

commit sha a241780dc249bc959c6b7e663dbe2e6deec1ab42

Filter changes are applied to the renderer without reloading

view details

Brian Vaughn

commit sha eb9705abc87d6b9a03eaec55cdf8465e69e9ab14

Removed FilterList UI for now (collapsed into Settings component)

view details

Brian Vaughn

commit sha c4c51c0821d6ac37513da12d9174d0fe47a1390e

Prevent filter preference changes while profiling is active

view details

push time in 3 months

PR opened andreypopp/react-textarea-autosize

Fix issue 251 add a11y ignore to hidden text area

what is the change?: Make the hidden text area non-tabbable and hidden from screen readers.

why make this change?: It violates some AA WCAG2 guidelines, as per this output from Pa11y:

      {
        "code": "WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Textarea.Name",
        "context": "<textarea style=\"min-height: 0px !important; max-height: none !important; height: 0px !important; visibility: hidden !important; overflow: hidden !important; position: absolute !important; z-index: -1000 !important; top: 0px !important; right: 0px !i...",
        "message": "This textarea element does not have a name available to an accessibility API. Valid names are: label element, title undefined, aria-label undefined, aria-labelledby undefined.",
        "type": "error",
        "typeCode": 1,
        "selector": "...(omitted)"
      },
      {
        "code": "WCAG2AA.Principle1.Guideline1_3.1_3_1.F68",
        "context": "<textarea style=\"min-height: 0px !important; max-height: none !important; height: 0px !important; visibility: hidden !important; overflow: hidden !important; position: absolute !important; z-index: -1000 !important; top: 0px !important; right: 0px !i...",
        "message": "This form field should be labelled in some way. Use the label element (either with a \"for\" attribute or wrapped around the form field), or \"title\", \"aria-label\" or \"aria-labelledby\" attributes as appropriate.",
        "type": "error",
        "typeCode": 1,
        "selector": "...(omitted)"
      }

test plan: We tested this change in our own product and Pa11y stopped flagging the violation.

issue: https://github.com/andreypopp/react-textarea-autosize/issues/251

+4 -1

0 comment

2 changed files

pr created time in 4 months

create barnchflarnie/react-textarea-autosize

branch : fix_issue_251

created branch time in 4 months

issue openedandreypopp/react-textarea-autosize

Accessibility violation due to unlabeled visually hidden text area

Running a Pa11y scan of a page which uses react-textarea-autosize triggers two WCAG2 AA violations:

      {
        "code": "WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Textarea.Name",
        "context": "<textarea style=\"min-height: 0px !important; max-height: none !important; height: 0px !important; visibility: hidden !important; overflow: hidden !important; position: absolute !important; z-index: -1000 !important; top: 0px !important; right: 0px !i...",
        "message": "This textarea element does not have a name available to an accessibility API. Valid names are: label element, title undefined, aria-label undefined, aria-labelledby undefined.",
        "type": "error",
        "typeCode": 1,
        "selector": "...(omitted)"
      },
      {
        "code": "WCAG2AA.Principle1.Guideline1_3.1_3_1.F68",
        "context": "<textarea style=\"min-height: 0px !important; max-height: none !important; height: 0px !important; visibility: hidden !important; overflow: hidden !important; position: absolute !important; z-index: -1000 !important; top: 0px !important; right: 0px !i...",
        "message": "This form field should be labelled in some way. Use the label element (either with a \"for\" attribute or wrapped around the form field), or \"title\", \"aria-label\" or \"aria-labelledby\" attributes as appropriate.",
        "type": "error",
        "typeCode": 1,
        "selector": "...(omitted)"
      }

To fix it we just need to add the following changes here:

hiddenTextarea.setAttribute('tab-index', '-1');
hiddenTextarea.setAttribute('aria-hidden', 'true');

I will open a PR shortly. Hope this is helpful!

created time in 4 months

fork flarnie/next.js

The React Framework

https://nextjs.org

fork in 4 months

more