Beautifier for javascript
evocateur/coldfusion-tmbundle 3
ColdFusion 8 TextMate Bundle
A proof-of-concept script loader for caching/loading scripts with localStorage
evocateur/butterscotch-pudding 2
Create figgy-pudding instances with yargs options config
A modified Sunburst theme, with better ES6 support.
Converts acorn tokens to esprima tokens
The hassle-free way to integrate analytics into any web application.
A rediculously light-weight function argument validator
:snake: A tool for managing JavaScript projects with multiple packages.
evocateur/atom-api-blueprint-preview 0
Live preview API Blueprint in Atom
startedmswjs/msw
started time in 9 days
push eventzillow/javascript
commit sha bde4d1e786217f2267c5184dcc30d20d4e292561
fix(plugin): Turn off no-import-assign for test files
push time in 15 days
delete branch evocateur/plugins
delete branch : fix-babel-output-plugin-filename
delete time in 16 days
startedegoist/rollup-plugin-esbuild
started time in 17 days
push eventzillow/javascript
commit sha 0121df05ca213ccd82022ebd673b080b3e513753
feat: Drop support for Node v8.x BREAKING CHANGE: The minimum supported version of Node is now v10.17.0 (v10 LTS).
commit sha 64ed70992d63764eff1e2501b87686ea259fefb3
feat(peer): Drop support for prettier@1 BREAKING CHANGE: The minimum peer range for prettier is now ^2.1.2.
commit sha c05f01c3a478ac16a1d49830e3a2622356a954f4
test(shims): Convert forEach() to it.each()
commit sha cfff1766796a08d68f4c676f26c603fa55145662
feat: Add module eslint-config-zillow-typescript
commit sha 9c28678b18afbc94972698211655478c1dbd6027
chore(deps): Update typescript in root to v4
commit sha eaf9bf0b00a7171382685a37054d4725950663a6
feat(deps): Upgrade typescript-eslint dependencies to ^4.2.0
commit sha 7d1865263d74ad7fefc63d9e7dc8adf989a151f5
feat(plugin): Switch typescript target to eslint-config-zillow-typescript
commit sha 284dcdd3507e63081435dabd0754a698c01ad6b0
feat: Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha 016257b963172c37ffe31dab178f506e80ef751d
feat: Upgrade eslint-plugin-react-hooks to ^4.1.2 BREAKING CHANGE: The version of eslint-plugin-react-hooks has been bumped two majors (2 -> 4), there are many new validations that may expose new lint errors. See https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md for details.
commit sha b998ea9fe36482d7226b47fd79ac9d0a89600c11
feat(deps): eslint-plugin-react@^7.21.2
commit sha dd3462b21570f3d4caf426e61de18c0267991482
feat: Upgrade eslint-plugin-jest to ^24.0.2 BREAKING CHANGE: The version of eslint-plugin-jest has been bumped two majors (22 -> 24), there are very likely new errors exposed. See https://github.com/jest-community/eslint-plugin-jest/releases/tag/v23.0.0 and https://github.com/jest-community/eslint-plugin-jest/releases/tag/v24.0.0 for details.
commit sha 127d63672740d923feec13a3e41765fff9875f4e
feat: Upgrade eslint-plugin-mocha to ^8.0.0 BREAKING CHANGE: The version of eslint-plugin-mocha has been bumped two majors (6 -> 8), there are very likely new errors exposed. See https://github.com/lo1tuma/eslint-plugin-mocha/releases for details.
commit sha 6f3e7655bb1dbaae345a19dcb2b6addf2f90cee9
feat: Support eslint v7 BREAKING CHANGE: eslint v7 is now the minimum peer. Please upgrade.
commit sha 12a9f405ce3bcab67420d8069e9a89c00e5bf85f
fix(plugin): Ensure rendered configs do not contain context-dependent paths
commit sha 906b63a16faa60bc73e31f2ef4895723fe058c8c
refactor: Render configs asynchronously without side-effects
commit sha fc05b1304edb7c2d2abb393f0b8a1ab5e09e3a9f
chore(jest): Use jest-circus as test runner
commit sha fd658bbbb78e0f9ee8f23e8324896e7b9cff941d
test(plugin): Snapshot all rendered configs
commit sha e8c14e34dd9c4b58c940449b4e9752fcba73b541
feat(plugin): Migrate deprecated CLIEngine -> ESLint constructor
commit sha bd97258659860d194ec8e6193c871e205829b518
feat(deps): Remove TypeScript 3 from dependency version range BREAKING CHANGE: TypeScript 3 is no longer supported, please upgrade.
commit sha 4dd1ae48172983462f1403f43b0731f0ff2554fa
feat(peer): Update minimum version ranges BREAKING CHANGE: The minimum version range of all peerDependencies have been bumped to their latest versions. Technically a breaking change, you only need re-install the peers to receive compatible updates.
push time in a month
push eventzillow/javascript
commit sha c676979e97e9bdf5397ba40de323d79bdbac67ab
fix(plugin): Target .ts(x) files for Jest & Mocha, too
commit sha 06d4337227a754dc636a6b38100b9691c89c5848
fix(typescript): Restore no-shadow builtinGlobals default
commit sha da2306e9f25bd00c4326d562f7a866264be8f514
fix(typescript): Turn off prefer-readonly-parameter-types, too many bugs for too little benefit
commit sha b18789b89a782deaa33c446a86f79b71e390b4aa
fix(plugin): Turn off react/prop-types in test files It merely hampers ad hoc test component definitions where prop-types are irrelevant.
commit sha 265b856ec01293e41cea4a4ea2f7d936ec23d804
chore(release): Publish - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha 828ce5a7fa03d72e84976f679d8c582a77a4b987
feat(peer): eslint >= 7.4.0 BREAKING CHANGE: The minimum peer version of eslint is now 7.4.0.
commit sha abb23464c22aeb83236775501629c3f7dd2a5d36
fix(errors): Turn off require-atomic-updates, it is very buggy
commit sha b9845de293732b01d8c9c6221deccbcdd700fd42
fix(errors): Move no-restricted-exports to es6 rules, enable
commit sha 1ce5bbe58430024b999d026484eed1a03bd6e2ad
chore: Remove TODOs that will never be done
commit sha 6249318bdc5b0250161d7a34070b4a104b7657c5
fix(typescript): Turn off react/prop-types in TSX files
commit sha 1d9438acdef5e61dee9c78c16a7690654ab8668a
fix(typescript): Flesh out no-empty-function allow list
commit sha 5e4013e9697f2d28229bf964894941903f003d28
fix(typescript): Extend no-shadow allow list to accommodate common patterns
commit sha 4ee891425c18f29782aaa3afa1ce77a5e6b3d838
refactor(plugin): Prepare for plugin-specific overrides in Jest config
commit sha 91fb3bae4b79443820370730474bad9e27961206
fix(jest): Turn off TypeScript no-invalid-void-type rule in tests This makes jest.fn<void, [args]>() impossible to use.
commit sha 4e1ac62d1219b7380f984d429385e5e6134996b8
fix(typescript): Turn off no-implicit-any-catch, too much noise
commit sha 25ac226ffc2af781089f78f12fabb47255b0f308
fix(typescript): Turn off explicit-module-boundary-types, too much noise
commit sha c05d872f553c368b571f9babd82764a21189019a
fix(rules): Turn off default-param-last until it is configurable
commit sha bb70eb9d014a6c276e0446f6b09055023dc065e3
fix(typescript): Enable auto-fix for ban-types 'object' case
commit sha 7a9d63832a13cd3050f74b76d122aaa83ec1cb48
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha 99708d0df097e455897583a9a17a907e8671a0d9
feat(prettier): Add embeddedLanguageFormatting default to config
commit sha 10542c71deb66ab6702ea8bf6d2c3307069a2c13
fix(react): Revert silly workaround, it didn't work
commit sha 3ba39d5204fe7bee86780cda342d687da295fe30
fix(react): Turn off react/prop-types until upstream bug is fixed
commit sha 0514e70ef859e455518997244d88d70e9ede711f
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha 069f822da44bc867e1a8c9a1994a1d3ce9339eb3
fix(peer): Loosen eslint-plugin-react range to allow for silly workaround
commit sha e32ab94cbeb59e472c19f86218845b33e79eaac7
chore(release): Publish - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha c6bd7ff283bed6f526f576d118d536d5c00bf805
feat(deps): eslint-plugin-import@^2.22.1
commit sha 032d5b49fa6a06f3856a6c69c36af02cc713bf0f
chore(deps): Bump eslint & eslint-config-prettier
commit sha 1d7c00275d39f88f0e50e5245de8ff34e7081e6b
fix(deps): Hard-pin [email protected] to workaround destructured prop-types bug
commit sha 60ff0aa99e15fb61807a9d30533fa947d0141953
chore(release): Publish - [email protected]
push time in a month
push eventzillow/javascript
commit sha ebdc70fcc42d0207972cbad3f142fbb94c5ddf16
fix: Prefix nested plugin env configs, make proxied environments work
commit sha 4b194205dba79e74fdb9c9725d46fbec71097a3a
refactor(plugin): Move JSON config generation back into package Changes to the generated JSON wouldn't automatically trigger a release, otherwise.
commit sha 4699e1675a6aac57ce2fac144dd206ccfeb79628
chore(release): Publish - [email protected]
push time in a month
push eventzillow/javascript
commit sha 238383a3cc71671e378b5326d4d301e11992385d
chore(release): Replace release script with preversion that triggers build + test
push time in a month
push eventzillow/javascript
commit sha 9f18491cb52f0dc388b2d9cfff0fdfb56e964bd9
chore(release): Publish - [email protected]
push time in a month
push eventzillow/javascript
commit sha f0a3c9aff700eb4967d6bab5e423f985cd40bd23
refactor(plugin): Move JSON config generation to root script
commit sha 8f02325cb99fa3797bd14cfb94cba3a6bbe2e8e9
fix(plugin): Validate config during generation
commit sha ca160992910afaf7250628d0c712fd3b76091998
fix(plugin): Expose environments from nested plugins
push time in a month
startedlukeed/escalade
started time in a month
push eventzillow/javascript
commit sha bb0619f11b053cb6a8df0aebfdff4c67748400fc
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha 6d5b2f4ad27f5fa0b4c54831fe1f1dd535f978a1
chore(lerna): Use correct command namespace
commit sha 2b5cf19e0958d83f700a33570be18ee1d0f9aabf
chore(lerna): Use exact versions between siblings
push time in a month
push eventzillow/javascript
commit sha 64ed70992d63764eff1e2501b87686ea259fefb3
feat(peer): Drop support for prettier@1 BREAKING CHANGE: The minimum peer range for prettier is now ^2.1.2.
commit sha c05f01c3a478ac16a1d49830e3a2622356a954f4
test(shims): Convert forEach() to it.each()
commit sha cfff1766796a08d68f4c676f26c603fa55145662
feat: Add module eslint-config-zillow-typescript
commit sha 9c28678b18afbc94972698211655478c1dbd6027
chore(deps): Update typescript in root to v4
commit sha eaf9bf0b00a7171382685a37054d4725950663a6
feat(deps): Upgrade typescript-eslint dependencies to ^4.2.0
commit sha 7d1865263d74ad7fefc63d9e7dc8adf989a151f5
feat(plugin): Switch typescript target to eslint-config-zillow-typescript
commit sha 284dcdd3507e63081435dabd0754a698c01ad6b0
feat: Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha 016257b963172c37ffe31dab178f506e80ef751d
feat: Upgrade eslint-plugin-react-hooks to ^4.1.2 BREAKING CHANGE: The version of eslint-plugin-react-hooks has been bumped two majors (2 -> 4), there are many new validations that may expose new lint errors. See https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md for details.
commit sha b998ea9fe36482d7226b47fd79ac9d0a89600c11
feat(deps): eslint-plugin-react@^7.21.2
commit sha dd3462b21570f3d4caf426e61de18c0267991482
feat: Upgrade eslint-plugin-jest to ^24.0.2 BREAKING CHANGE: The version of eslint-plugin-jest has been bumped two majors (22 -> 24), there are very likely new errors exposed. See https://github.com/jest-community/eslint-plugin-jest/releases/tag/v23.0.0 and https://github.com/jest-community/eslint-plugin-jest/releases/tag/v24.0.0 for details.
commit sha 127d63672740d923feec13a3e41765fff9875f4e
feat: Upgrade eslint-plugin-mocha to ^8.0.0 BREAKING CHANGE: The version of eslint-plugin-mocha has been bumped two majors (6 -> 8), there are very likely new errors exposed. See https://github.com/lo1tuma/eslint-plugin-mocha/releases for details.
commit sha 6f3e7655bb1dbaae345a19dcb2b6addf2f90cee9
feat: Support eslint v7 BREAKING CHANGE: eslint v7 is now the minimum peer. Please upgrade.
commit sha 12a9f405ce3bcab67420d8069e9a89c00e5bf85f
fix(plugin): Ensure rendered configs do not contain context-dependent paths
commit sha 906b63a16faa60bc73e31f2ef4895723fe058c8c
refactor: Render configs asynchronously without side-effects
commit sha fc05b1304edb7c2d2abb393f0b8a1ab5e09e3a9f
chore(jest): Use jest-circus as test runner
commit sha fd658bbbb78e0f9ee8f23e8324896e7b9cff941d
test(plugin): Snapshot all rendered configs
commit sha e8c14e34dd9c4b58c940449b4e9752fcba73b541
feat(plugin): Migrate deprecated CLIEngine -> ESLint constructor
commit sha bd97258659860d194ec8e6193c871e205829b518
feat(deps): Remove TypeScript 3 from dependency version range BREAKING CHANGE: TypeScript 3 is no longer supported, please upgrade.
commit sha 4dd1ae48172983462f1403f43b0731f0ff2554fa
feat(peer): Update minimum version ranges BREAKING CHANGE: The minimum version range of all peerDependencies have been bumped to their latest versions. Technically a breaking change, you only need re-install the peers to receive compatible updates.
push time in a month
push eventzillow/javascript
commit sha ef34d35abadcc2e995d51252e78104a4f4333af7
feat(plugin): Remove typescript 3 from dependency version range BREAKING CHANGE: TypeScript 3 is no longer supported, please upgrade.
commit sha e1060e3301d98383f4c7044a56790f07facfba6d
feat(peer): Update minimum version ranges BREAKING CHANGE: The minimum version range of all peerDependencies have been bumped to their latest versions. Technically a breaking change, you only need re-install the peers to receive compatible updates.
push time in a month
push eventzillow/javascript
commit sha 166802a7cc07ea2e3a3b217263afd12f04e4e55a
fix(plugin): Ensure rendered configs do not contain context-dependent paths
commit sha c40c19d1be2bbd54c0703a5fdfd814740217b3cc
refactor(plugin): Render configs asynchronously without side-effects
commit sha 60cc585a70363e0893654d44ac30bd8a8637a514
chore(jest): Use jest-circus as test runner
commit sha 81b3741dae33179e9249160c5d6ce73284207f1c
test(plugin): Snapshot all rendered configs
commit sha 9b60be4848337eec5b2a19e69176d6d6fa056e84
feat(plugin): Migrate deprecated CLIEngine -> ESLint constructor
push time in a month
push eventzillow/javascript
commit sha 7f343cd3d9907169a250144b6f121eba6b570982
test(shims): Convert forEach() to it.each()
commit sha f8a7b7c42209f9306f60684d784c7d00d5ac59cf
feat: Add module eslint-config-zillow-typescript
commit sha 0aacd9fd408b9f652cb8ce7399fcce1ee7964f39
chore(deps): Update typescript in root to v4
commit sha 269fbea79e6636157bae3e3d656f1371bc8a3e70
feat(plugin): Upgrade @typescript-eslint dependencies to ^4.2.0
commit sha 86b6b5a993428d99a894f2eea626dc841eb68607
feat(plugin): Switch typescript target to eslint-config-zillow-typescript
commit sha f961fdbf034da0dae741cf8975ced873aa7f36de
feat(config): Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha c7dea0f48d8e682f83d50495a0a5ada5aae3ed0f
feat(base): Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha 210234f14f874b2f531e6881e41828c30c447fd8
feat: Upgrade eslint-plugin-react-hooks to ^4.1.2 BREAKING CHANGE: The version of eslint-plugin-react-hooks has been bumped two majors (2 -> 4), there are many new validations that may expose new lint errors. See https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md for details.
commit sha bef7f0bbcc85078e9a56e2215cea2900e71616f6
feat(plugin): eslint-plugin-react@^7.21.2
commit sha 11415414a3512e930a81751955715adc07644fdb
feat: Upgrade eslint-plugin-jest to ^24.0.2 BREAKING CHANGE: The version of eslint-plugin-jest has been bumped two majors (22 -> 24), there are very likely new errors exposed. See https://github.com/jest-community/eslint-plugin-jest/releases/tag/v23.0.0 and https://github.com/jest-community/eslint-plugin-jest/releases/tag/v24.0.0 for details.
commit sha 7c85af532c0651cd660a922dd0b968d3de6358f0
feat: Upgrade eslint-plugin-mocha to ^8.0.0 BREAKING CHANGE: The version of eslint-plugin-mocha has been bumped two majors (6 -> 8), there are very likely new errors exposed. See https://github.com/lo1tuma/eslint-plugin-mocha/releases for details.
commit sha 93c3c6ace1193cea1067f5fc18133a2a4839c126
feat: Support eslint v7 BREAKING CHANGE: eslint v7 is now the minimum peer. Please upgrade.
push time in a month
push eventzillow/javascript
commit sha 4fc79fee8ec78e0387768facb5f00dbdf9ec8af3
feat: Support eslint v7 BREAKING CHANGE: eslint v7 is now the minimum peer. Please upgrade.
push time in a month
push eventzillow/javascript
commit sha 277f45326a6cf8858ad2ffc102c14f283e760320
feat: Add module eslint-config-zillow-typescript
commit sha 744216ca99b91d921ff95bc01bc558dad8917d61
chore(deps): Update typescript in root to v4
commit sha c323759e5ee1a87519614e26aa1e83e21a75e7a2
feat(plugin): Upgrade @typescript-eslint dependencies to ^4.2.0
commit sha 7e4eb3c78544746da52d3958b16bf4f49a88711b
feat(plugin): Switch typescript target to eslint-config-zillow-typescript
commit sha f93b9e46912e63eafefdb3f0631576af2a519b9d
feat(config): Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha 0ab3ca853fedb30dec40273d4bf089cdada41ab3
feat(base): Remove typescript re-export & peer BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
commit sha c8281cbeab6087e724a7587d1b8f66469a78fb45
feat(plugin): eslint-plugin-react-hooks@^4.1.2 BREAKING CHANGE: The version of eslint-plugin-react-hooks has been bumped two majors (2 -> 4), there are many new validations that may expose new lint errors. See https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md for details.
commit sha a78d7114e408f83dfe6205031cb30e82f04ba08f
feat(plugin): eslint-plugin-react@^7.21.2
commit sha bb470b25fdcc07d7ce2cb94e140d7c5739189a66
feat(plugin): eslint-plugin-jest@^24.0.2 BREAKING CHANGE: The version of eslint-plugin-jest has been bumped two majors (22 -> 24), there are very likely new errors exposed. See https://github.com/jest-community/eslint-plugin-jest/releases/tag/v23.0.0 and https://github.com/jest-community/eslint-plugin-jest/releases/tag/v24.0.0 for details.
commit sha 133c982b67335d425fb5bfdb7f4452114face3e2
test(shims): Convert forEach() to it.each()
commit sha 9ba4f61fa364bd2ebe1ac14fc1a1bf7c250aa7d4
feat(plugin): eslint-plugin-mocha@^8.0.0 BREAKING CHANGE: The version of eslint-plugin-mocha has been bumped two majors (6 -> 8), there are very likely new errors exposed. See https://github.com/lo1tuma/eslint-plugin-mocha/releases for details.
push time in a month
push eventzillow/javascript
commit sha 9901243080b8f52e8a66a89412dcee401984a0d2
chore(deps): Upgrade markdownlint to v0.23.2
commit sha 914da4479630a6799c21df3e206d610d4e051c08
chore(lint): Auto-fix markdownlint errors
commit sha 1bb9030c79bc6b5f58a192acca261106339341d4
feat(preset): Update dependencies
commit sha a41af7db49c7917f0da939c4ea79d2ce18428e73
fix(preset): Do not transform lodash during tests https://github.com/istanbuljs/babel-plugin-istanbul/issues/116
commit sha eb8958ee7994f9df49c91b96562cced116b5b83c
chore(release): Publish - [email protected]
push time in a month
push eventzillow/javascript
commit sha 5be352822d1e437534164936e0d31a44b7af3242
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
push time in a month
push eventzillow/javascript
commit sha 5fc1a7c6f901e38f74bebb5d74187322a1ea904a
chore: Bump root dependencies, reset lockfile
commit sha cc8cb03868739b0e850e04764b5b9dde31248432
chore: Hard-pin various root deps to avoid es-abstract@next leakage
commit sha e5ab699519311c57073cb34a418ff6c3270357e3
feat(zillow-js-shims): string.prototype.matchall@^4.0.2
commit sha 2b1f25a7d5610db5525e68b63010b3779ef665bb
feat(base): Add new Jest rules
commit sha 5ab97fc8953c92937f2ed075260fa4f1cea199be
feat(base): Add new TypeScript rules
commit sha a20ca4520c17a802fcf256b6040420face2069dc
feat(config): Add new React A11y rules
commit sha 3b038ca8ca8ec293f5ba90c254e8bed73618b8c3
feat(config): Add new React rules
commit sha f2992b7b8b1ec3a5cbbd5c29c6b78b87cb5b5e88
feat(plugin): Bump dependencies
commit sha 973291e163cade39e14a51f7225f193c6c0ee744
chore: Upgrade Jest
commit sha dd291aa3117e51581ac54b5306725134e4d8ec3c
chore: Remove babel-core@bridge
commit sha bf56011530042f5527bd005dd8f2ae55182df051
feat(plugin): Expand dependency range of TypeScript to encompass ^4.0.2
push time in a month
issue commentnpm/map-workspaces
globs that share files cause error `must not have multiple workspaces with the same name`
This is why globstars (**) are a bad choice for configuring package layout. Especially nested globstars.
comment created time in a month
Pull request review commentpreconstruct/preconstruct
+---+"@preconstruct/cli": patch
This strikes me as a minor release, at a minimum. It's really hard to judge the potential risk of a dependency update when the only thing that ever changes is the patch version.
(Excited for the Rollup v2 upgrade, don't get me wrong!)
comment created time in 2 months
startedagkozak/zsh-z
started time in 2 months
Pull request review commentzillow/drywall
import { stringToPath } from './stringToPath'; +// Use a separate cache for each theme object+const caches = new Map();
Would a WeakMap work better here?
comment created time in 2 months
startedstorybookjs/storybook
started time in 2 months
startedniksy/babel-plugin-native-error-extend
started time in 2 months
startedorogene/orogene
started time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
+import { tokenizeArgString } from './tokenize-arg-string.js'+import type {+ ArgsInput,+ Arguments,+ ArrayFlagsKey,+ ArrayOption,+ CoerceCallback,+ Configuration,+ DefaultValuesForType,+ DefaultValuesForTypeKey,+ DetailedArguments,+ Flag,+ Flags,+ FlagsKey,+ StringFlag,+ BooleanFlag,+ NumberFlag,+ ConfigsFlag,+ CoercionsFlag,+ Options,+ OptionsDefault,+ YargsParserMixin+} from './yargs-parser-types.js'+import type { Dictionary, ValueOf } from './common-types.js'+import { camelCase, decamelize } from './string-utils.js'++let mixin: YargsParserMixin+export class YargsParser {
It's super weird that git doesn't recognize this as a file moved from ../index.ts.
Also, shouldn't it be named lib/yargs-parser.ts, since it's only named export is YargsParser?
comment created time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
+import { tokenizeArgString } from './tokenize-arg-string.js'+import type {+ ArgsInput,+ Arguments,+ ArrayFlagsKey,+ ArrayOption,+ CoerceCallback,+ Configuration,+ DefaultValuesForType,+ DefaultValuesForTypeKey,+ DetailedArguments,+ Flag,+ Flags,+ FlagsKey,+ StringFlag,+ BooleanFlag,+ NumberFlag,+ ConfigsFlag,+ CoercionsFlag,+ Options,+ OptionsDefault,+ YargsParserMixin+} from './yargs-parser-types.js'+import type { Dictionary, ValueOf } from './common-types.js'
Wow, TIL.
comment created time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
+import ts from '@wessberg/rollup-plugin-ts'++export default {+ plugins: [
I think you might be missing @rollup/plugin-node-resolve, configured with extensions: ['js', 'ts']?
comment created time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
+import { tokenizeArgString } from './tokenize-arg-string.js'+import type {+ ArgsInput,+ Arguments,+ ArrayFlagsKey,+ ArrayOption,+ CoerceCallback,+ Configuration,+ DefaultValuesForType,+ DefaultValuesForTypeKey,+ DetailedArguments,+ Flag,+ Flags,+ FlagsKey,+ StringFlag,+ BooleanFlag,+ NumberFlag,+ ConfigsFlag,+ CoercionsFlag,+ Options,+ OptionsDefault,+ YargsParserMixin+} from './yargs-parser-types.js'+import type { Dictionary, ValueOf } from './common-types.js'
Aren't these files .ts? I'm confused by the explicit .js extensions.
comment created time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
"name": "yargs-parser", "version": "18.1.3", "description": "the mighty option parser used by yargs",- "main": "build/index.js",+ "main": "build/index.cjs",+ "exports": {+ "import": "./build/index-node.js",+ "require": "./build/index.cjs"+ },+ "type": "module",+ "types": "./build/index.cjs.d.ts", "scripts": {- "fix": "standardx --fix ./*.ts && standardx --fix **/*.ts",- "pretest": "npm run compile -- -p tsconfig.test.json",+ "check": "standardx && standardx ./*.ts && standardx **/*.ts && standardx test/deno/yargs-test.ts",+ "fix": "standardx --fix && standardx --fix ./*.ts && standardx --fix **/*.ts && standardx --fix test/deno/yargs-test.ts",+ "pretest": "rimraf build && tsc -p tsconfig.test.json && npm run build:cjs", "test": "c8 --reporter=text --reporter=html mocha test/*.js", "posttest": "npm run check", "coverage": "c8 report --check-coverage",- "check": "standardx ./*.ts && standardx **/*.ts",- "compile": "rimraf build && tsc",+ "precompile": "rimraf build",+ "compile": "tsc",+ "postcompile": "npm run build:cjs",+ "build:cjs": "rollup --exports=default --config=rollup.config.js ./index-node.ts --format cjs --file build/index.cjs",
A lot of these arguments could be configured more expressively in ./rollup.config.js?
"build:cjs": "rollup -c",
export default {
input: './index-node.ts',
output: {
format: 'cjs',
file: './build/index.cjs',
exports: 'default',
},
plugins: [
ts({ /* options */ })
],
}
comment created time in 3 months
Pull request review commentyargs/yargs-parser
feat!: adds support for ESM and Deno
+#!/usr/bin/env node+'use strict'++const { readFileSync, writeFileSync } = require('fs')++// Cleanup the export statement in CJS typings file generated by rollup:+const legacyTypings = 'build/index.cjs.d.ts'
I'm very leery of implicit path locations, silently dependent on "where" one executes the code from.
const legacyTypings = require('path').resolve(__dirname, '../build/index.cjs.d.ts')
comment created time in 3 months